From: Krzysztof Kozlowski <krzk@kernel.org> To: "Alice Guo (OSS)" <alice.guo@oss.nxp.com> Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Date: Fri, 18 Dec 2020 09:52:23 +0100 [thread overview] Message-ID: <20201218085223.GA17306@kozik-lap> (raw) In-Reply-To: <20201218083726.16427-1-alice.guo@oss.nxp.com> On Fri, Dec 18, 2020 at 04:37:23PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo <alice.guo@nxp.com> > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo <alice.guo@nxp.com> > --- > > Changes for v8: > - match soc node with regular expression > Changes for v7: > - change to a separate schema file > Changes for v6: > - none > Changes for v5: > - correct the error of using allOf > Changes for v4: > - use allOf to limit new version DTS files for i.MX8M to include > "fsl,imx8m*-soc", nvmem-cells and nvmem-cells-names > Changes for v3: > - put it into Documentation/devicetree/bindings/arm/fsl.yaml > - modify the description of nvmem-cells > - use "make ARCH=arm64 dtbs_check" to make sure it is right > Changes for v2: > - remove the subject prefix "LF-2571-1" > > .../bindings/soc/imx/imx8m-soc.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > > diff --git a/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > new file mode 100644 > index 000000000000..f0b0fc7b3ac6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/imx/imx8m-soc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8M Series SoC > + > +maintainers: > + - Alice Guo <alice.guo@nxp.com> > + > +description: | > + NXP i.MX8M series SoCs contain fuse entries from which SoC Unique ID can be > + obtained. > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mm > + - fsl,imx8mn > + - fsl,imx8mp > + - fsl,imx8mq > + required: > + - compatible > + > +patternProperties: > + "^soc@[0-9a-f]+$": Thanks, now it works. > + type: object > + properties: > + compatible: > + items: > + - enum: > + - fsl,imx8mm-soc > + - fsl,imx8mn-soc > + - fsl,imx8mp-soc > + - fsl,imx8mq-soc > + - const: simple-bus > + > + nvmem-cells: > + maxItems: 1 > + description: Phandle to the SOC Unique ID provided by a nvmem node > + > + nvmem-cells-names: > + const: soc_unique_id > + > + required: > + - compatible > + - nvmem-cells > + - nvmem-cell-names > + > +additionalProperties: true Don't leave comments unresolved (or resolve them against review without discussion). Rob asked for changing it. The same as with all schemas - you need to describe the missing properties. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org> To: "Alice Guo (OSS)" <alice.guo@oss.nxp.com> Cc: devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Date: Fri, 18 Dec 2020 09:52:23 +0100 [thread overview] Message-ID: <20201218085223.GA17306@kozik-lap> (raw) In-Reply-To: <20201218083726.16427-1-alice.guo@oss.nxp.com> On Fri, Dec 18, 2020 at 04:37:23PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo <alice.guo@nxp.com> > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo <alice.guo@nxp.com> > --- > > Changes for v8: > - match soc node with regular expression > Changes for v7: > - change to a separate schema file > Changes for v6: > - none > Changes for v5: > - correct the error of using allOf > Changes for v4: > - use allOf to limit new version DTS files for i.MX8M to include > "fsl,imx8m*-soc", nvmem-cells and nvmem-cells-names > Changes for v3: > - put it into Documentation/devicetree/bindings/arm/fsl.yaml > - modify the description of nvmem-cells > - use "make ARCH=arm64 dtbs_check" to make sure it is right > Changes for v2: > - remove the subject prefix "LF-2571-1" > > .../bindings/soc/imx/imx8m-soc.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > > diff --git a/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > new file mode 100644 > index 000000000000..f0b0fc7b3ac6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/imx/imx8m-soc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8M Series SoC > + > +maintainers: > + - Alice Guo <alice.guo@nxp.com> > + > +description: | > + NXP i.MX8M series SoCs contain fuse entries from which SoC Unique ID can be > + obtained. > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mm > + - fsl,imx8mn > + - fsl,imx8mp > + - fsl,imx8mq > + required: > + - compatible > + > +patternProperties: > + "^soc@[0-9a-f]+$": Thanks, now it works. > + type: object > + properties: > + compatible: > + items: > + - enum: > + - fsl,imx8mm-soc > + - fsl,imx8mn-soc > + - fsl,imx8mp-soc > + - fsl,imx8mq-soc > + - const: simple-bus > + > + nvmem-cells: > + maxItems: 1 > + description: Phandle to the SOC Unique ID provided by a nvmem node > + > + nvmem-cells-names: > + const: soc_unique_id > + > + required: > + - compatible > + - nvmem-cells > + - nvmem-cell-names > + > +additionalProperties: true Don't leave comments unresolved (or resolve them against review without discussion). Rob asked for changing it. The same as with all schemas - you need to describe the missing properties. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-18 8:53 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-18 8:37 [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Alice Guo (OSS) 2020-12-18 8:37 ` Alice Guo (OSS) 2020-12-18 8:37 ` [PATCH v8 2/4] arm64: dts: imx8m: add SoC ID compatible Alice Guo (OSS) 2020-12-18 8:37 ` Alice Guo (OSS) 2020-12-18 8:37 ` [PATCH v8 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID Alice Guo (OSS) 2020-12-18 8:37 ` Alice Guo (OSS) 2020-12-19 12:16 ` Krzysztof Kozlowski 2020-12-19 12:16 ` Krzysztof Kozlowski 2020-12-21 3:10 ` Alice Guo (OSS) 2020-12-21 3:10 ` Alice Guo (OSS) 2020-12-21 7:56 ` Krzysztof Kozlowski 2020-12-21 7:56 ` Krzysztof Kozlowski 2020-12-18 8:37 ` [PATCH v8 4/4] soc: imx8m: change to use platform driver Alice Guo (OSS) 2020-12-18 8:37 ` Alice Guo (OSS) 2020-12-19 12:18 ` Krzysztof Kozlowski 2020-12-19 12:18 ` Krzysztof Kozlowski 2020-12-21 2:36 ` Alice Guo (OSS) 2020-12-21 2:36 ` Alice Guo (OSS) 2020-12-18 8:52 ` Krzysztof Kozlowski [this message] 2020-12-18 8:52 ` [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Krzysztof Kozlowski 2020-12-18 9:05 ` Alice Guo (OSS) 2020-12-18 9:05 ` Alice Guo (OSS) 2020-12-18 9:36 ` Krzysztof Kozlowski 2020-12-18 9:36 ` Krzysztof Kozlowski 2020-12-18 10:14 ` Alice Guo (OSS) 2020-12-18 10:14 ` Alice Guo (OSS) 2020-12-18 13:59 ` Rob Herring 2020-12-18 13:59 ` Rob Herring 2020-12-21 9:20 ` Alice Guo (OSS) 2020-12-21 9:20 ` Alice Guo (OSS) 2020-12-21 20:29 ` Rob Herring 2020-12-21 20:29 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201218085223.GA17306@kozik-lap \ --to=krzk@kernel.org \ --cc=alice.guo@oss.nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.