[dm-devel] [PATCH] libmultipath: fix format warning with clang

[dm-devel] [PATCH] libmultipath: fix format warning with clang

[mwilck]

From: Martin Wilck <mwilck@suse.com>

Reported-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/log.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libmultipath/log.c b/libmultipath/log.c
index 6498c88..10fa32c 100644
--- a/libmultipath/log.c
+++ b/libmultipath/log.c
@@ -125,6 +125,7 @@ void log_reset (char *program_name)
 	pthread_cleanup_pop(1);
 }
 
+__attribute__((format(printf, 2, 0)))
 static int _log_enqueue(int prio, const char * fmt, va_list ap)
 {
 	int len, fwd;
-- 
2.29.0


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] libmultipath: fix format warning with clang

[Xose Vazquez Perez]

On 12/18/20 11:37 PM, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
> 
> Reported-by: Xose Vazquez Perez <xose.vazquez@gmail.com>

Tested-by: Xose Vazquez Perez <xose.vazquez@gmail.com>

> ---
>   libmultipath/log.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libmultipath/log.c b/libmultipath/log.c
> index 6498c88..10fa32c 100644
> --- a/libmultipath/log.c
> +++ b/libmultipath/log.c
> @@ -125,6 +125,7 @@ void log_reset (char *program_name)
>   	pthread_cleanup_pop(1);
>   }
>   
> +__attribute__((format(printf, 2, 0)))
>   static int _log_enqueue(int prio, const char * fmt, va_list ap)
>   {
>   	int len, fwd;
> 

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] libmultipath: fix format warning with clang

[Benjamin Marzinski]

On Fri, Dec 18, 2020 at 11:37:53PM +0100, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
> 
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> Reported-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libmultipath/log.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libmultipath/log.c b/libmultipath/log.c
> index 6498c88..10fa32c 100644
> --- a/libmultipath/log.c
> +++ b/libmultipath/log.c
> @@ -125,6 +125,7 @@ void log_reset (char *program_name)
>  	pthread_cleanup_pop(1);
>  }
>  
> +__attribute__((format(printf, 2, 0)))
>  static int _log_enqueue(int prio, const char * fmt, va_list ap)
>  {
>  	int len, fwd;
> -- 
> 2.29.0

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel