* [dm-devel] [PATCH] libmultipath: fix format warning with clang
@ 2020-12-18 22:37 mwilck
2020-12-18 22:43 ` Xose Vazquez Perez
2020-12-18 23:20 ` Benjamin Marzinski
0 siblings, 2 replies; 3+ messages in thread
From: mwilck @ 2020-12-18 22:37 UTC (permalink / raw)
To: Christophe Varoqui, Xose Vazquez Perez, Benjamin Marzinski
Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
Reported-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/log.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libmultipath/log.c b/libmultipath/log.c
index 6498c88..10fa32c 100644
--- a/libmultipath/log.c
+++ b/libmultipath/log.c
@@ -125,6 +125,7 @@ void log_reset (char *program_name)
pthread_cleanup_pop(1);
}
+__attribute__((format(printf, 2, 0)))
static int _log_enqueue(int prio, const char * fmt, va_list ap)
{
int len, fwd;
--
2.29.0
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [dm-devel] [PATCH] libmultipath: fix format warning with clang
2020-12-18 22:37 [dm-devel] [PATCH] libmultipath: fix format warning with clang mwilck
@ 2020-12-18 22:43 ` Xose Vazquez Perez
2020-12-18 23:20 ` Benjamin Marzinski
1 sibling, 0 replies; 3+ messages in thread
From: Xose Vazquez Perez @ 2020-12-18 22:43 UTC (permalink / raw)
To: mwilck, Christophe Varoqui, Benjamin Marzinski; +Cc: dm-devel
On 12/18/20 11:37 PM, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> Reported-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
Tested-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> libmultipath/log.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libmultipath/log.c b/libmultipath/log.c
> index 6498c88..10fa32c 100644
> --- a/libmultipath/log.c
> +++ b/libmultipath/log.c
> @@ -125,6 +125,7 @@ void log_reset (char *program_name)
> pthread_cleanup_pop(1);
> }
>
> +__attribute__((format(printf, 2, 0)))
> static int _log_enqueue(int prio, const char * fmt, va_list ap)
> {
> int len, fwd;
>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dm-devel] [PATCH] libmultipath: fix format warning with clang
2020-12-18 22:37 [dm-devel] [PATCH] libmultipath: fix format warning with clang mwilck
2020-12-18 22:43 ` Xose Vazquez Perez
@ 2020-12-18 23:20 ` Benjamin Marzinski
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Marzinski @ 2020-12-18 23:20 UTC (permalink / raw)
To: mwilck; +Cc: dm-devel, Xose Vazquez Perez
On Fri, Dec 18, 2020 at 11:37:53PM +0100, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> Reported-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> libmultipath/log.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libmultipath/log.c b/libmultipath/log.c
> index 6498c88..10fa32c 100644
> --- a/libmultipath/log.c
> +++ b/libmultipath/log.c
> @@ -125,6 +125,7 @@ void log_reset (char *program_name)
> pthread_cleanup_pop(1);
> }
>
> +__attribute__((format(printf, 2, 0)))
> static int _log_enqueue(int prio, const char * fmt, va_list ap)
> {
> int len, fwd;
> --
> 2.29.0
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-18 23:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-18 22:37 [dm-devel] [PATCH] libmultipath: fix format warning with clang mwilck
2020-12-18 22:43 ` Xose Vazquez Perez
2020-12-18 23:20 ` Benjamin Marzinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.