From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org,
"Andreas Kemnade" <andreas@kemnade.info>,
kernel@pyra-handheld.com, stable@vger.kernel.org
Subject: Re: [PATCH] DTS: ARM: gta04: SPI panel chip select is active low
Date: Wed, 30 Dec 2020 10:48:30 +0200 [thread overview]
Message-ID: <20201230084830.GG26857@atomide.com> (raw)
In-Reply-To: <a539758e798631b54a85df102a1c6635e1f70b37.1608719420.git.hns@goldelico.com>
* H. Nikolaus Schaller <hns@goldelico.com> [201223 12:33]:
> With the arrival of
>
> commit 2fee9583198eb9 ("spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors")
>
> it was clarified what the proper state for cs-gpios should be, even if the
> flag is ignored. The driver code is doing the right thing since
>
> 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
>
> The chip-select of the td028ttec1 panel is active-low, so we must omit spi-cs-high;
> attribute (already removed by separate patch) and should now use GPIO_ACTIVE_LOW for
> the client device description to be fully consistent.
Applying into fixes thanks.
Tony
prev parent reply other threads:[~2020-12-30 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 10:30 [PATCH] DTS: ARM: gta04: SPI panel chip select is active low H. Nikolaus Schaller
2020-12-30 8:48 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201230084830.GG26857@atomide.com \
--to=tony@atomide.com \
--cc=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.