* [PATCH] DTS: ARM: gta04: SPI panel chip select is active low
@ 2020-12-23 10:30 H. Nikolaus Schaller
2020-12-30 8:48 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: H. Nikolaus Schaller @ 2020-12-23 10:30 UTC (permalink / raw)
To: Benoît Cousson, Tony Lindgren, Rob Herring
Cc: linux-omap, devicetree, linux-kernel, letux-kernel,
Andreas Kemnade, kernel, H. Nikolaus Schaller, stable
With the arrival of
commit 2fee9583198eb9 ("spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors")
it was clarified what the proper state for cs-gpios should be, even if the
flag is ignored. The driver code is doing the right thing since
766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
The chip-select of the td028ttec1 panel is active-low, so we must omit spi-cs-high;
attribute (already removed by separate patch) and should now use GPIO_ACTIVE_LOW for
the client device description to be fully consistent.
Fixes: 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
CC: stable@vger.kernel.org
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
arch/arm/boot/dts/omap3-gta04.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 003202d129907b..7b8c18e6605e40 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -114,7 +114,7 @@ spi_lcd: spi_lcd {
gpio-sck = <&gpio1 12 GPIO_ACTIVE_HIGH>;
gpio-miso = <&gpio1 18 GPIO_ACTIVE_HIGH>;
gpio-mosi = <&gpio1 20 GPIO_ACTIVE_HIGH>;
- cs-gpios = <&gpio1 19 GPIO_ACTIVE_HIGH>;
+ cs-gpios = <&gpio1 19 GPIO_ACTIVE_LOW>;
num-chipselects = <1>;
/* lcd panel */
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] DTS: ARM: gta04: SPI panel chip select is active low
2020-12-23 10:30 [PATCH] DTS: ARM: gta04: SPI panel chip select is active low H. Nikolaus Schaller
@ 2020-12-30 8:48 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2020-12-30 8:48 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: Benoît Cousson, Rob Herring, linux-omap, devicetree,
linux-kernel, letux-kernel, Andreas Kemnade, kernel, stable
* H. Nikolaus Schaller <hns@goldelico.com> [201223 12:33]:
> With the arrival of
>
> commit 2fee9583198eb9 ("spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors")
>
> it was clarified what the proper state for cs-gpios should be, even if the
> flag is ignored. The driver code is doing the right thing since
>
> 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
>
> The chip-select of the td028ttec1 panel is active-low, so we must omit spi-cs-high;
> attribute (already removed by separate patch) and should now use GPIO_ACTIVE_LOW for
> the client device description to be fully consistent.
Applying into fixes thanks.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-30 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23 10:30 [PATCH] DTS: ARM: gta04: SPI panel chip select is active low H. Nikolaus Schaller
2020-12-30 8:48 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.