From: Mark Brown <broonie@kernel.org> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: Timon Baetz <timon.baetz@protonmail.com>, Marek Szyprowski <m.szyprowski@samsung.com>, Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>, MyungJoo Ham <myungjoo.ham@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Lee Jones <lee.jones@linaro.org>, Sebastian Reichel <sre@kernel.org>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes Date: Wed, 6 Jan 2021 14:59:31 +0000 [thread overview] Message-ID: <20210106145931.GE4752@sirena.org.uk> (raw) In-Reply-To: <20210105165529.GB20401@kozik-lap> [-- Attachment #1: Type: text/plain, Size: 1656 bytes --] On Tue, Jan 05, 2021 at 05:55:29PM +0100, Krzysztof Kozlowski wrote: > On Mon, Jan 04, 2021 at 09:24:49PM +0000, Mark Brown wrote: > > I'm not sure I follow, sorry? Either the core driver can parse the > > bindings enough to know what children it has or (probably better) it can > > instantiate the children unconditionally and then the function drivers > > can figure out if they need to do anything. > Currently the MFD parent/core driver will instantiate children > unconditionally. It would have to be adapted. With proposed bindings - > nothing to change. MFD core already does the thing. We're not talking massive amounts of code here, but we are talking ABI for a DT update. > The point is that function drivers should not be even bound, should not > start to probe. Otherwise if they probe and fail, they will pollute the > dmesg/probe log with failure. With the failure coming from looking for > missing of_node or any other condition from parent/core driver. There will only be an error message if one is printed, if we can do a definitive -ENODEV there should be no need to print an error. > > > Another point, is that this reflects the real hardware. The same as we > > > model entire SoC as multiple children of soc node (with their own > > > properties), here we represent smaller chip which also has > > > sub-components. > > Components we're calling things like "extcon"... > I am rather thinking about charger, but yes, extcon as well. Either you > have USB socket (and want to use associated logic) or not. Right, I'm just saying we don't need to add new device nodes reflecting implementation details into the DT to do that. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>, Timon Baetz <timon.baetz@protonmail.com>, Chanwoo Choi <cw00.choi@samsung.com>, MyungJoo Ham <myungjoo.ham@samsung.com>, ~postmarketos/upstreaming@lists.sr.ht, Sebastian Reichel <sre@kernel.org>, Lee Jones <lee.jones@linaro.org>, linux-arm-kernel@lists.infradead.org, Marek Szyprowski <m.szyprowski@samsung.com> Subject: Re: [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes Date: Wed, 6 Jan 2021 14:59:31 +0000 [thread overview] Message-ID: <20210106145931.GE4752@sirena.org.uk> (raw) In-Reply-To: <20210105165529.GB20401@kozik-lap> [-- Attachment #1.1: Type: text/plain, Size: 1656 bytes --] On Tue, Jan 05, 2021 at 05:55:29PM +0100, Krzysztof Kozlowski wrote: > On Mon, Jan 04, 2021 at 09:24:49PM +0000, Mark Brown wrote: > > I'm not sure I follow, sorry? Either the core driver can parse the > > bindings enough to know what children it has or (probably better) it can > > instantiate the children unconditionally and then the function drivers > > can figure out if they need to do anything. > Currently the MFD parent/core driver will instantiate children > unconditionally. It would have to be adapted. With proposed bindings - > nothing to change. MFD core already does the thing. We're not talking massive amounts of code here, but we are talking ABI for a DT update. > The point is that function drivers should not be even bound, should not > start to probe. Otherwise if they probe and fail, they will pollute the > dmesg/probe log with failure. With the failure coming from looking for > missing of_node or any other condition from parent/core driver. There will only be an error message if one is printed, if we can do a definitive -ENODEV there should be no need to print an error. > > > Another point, is that this reflects the real hardware. The same as we > > > model entire SoC as multiple children of soc node (with their own > > > properties), here we represent smaller chip which also has > > > sub-components. > > Components we're calling things like "extcon"... > I am rather thinking about charger, but yes, extcon as well. Either you > have USB socket (and want to use associated logic) or not. Right, I'm just saying we don't need to add new device nodes reflecting implementation details into the DT to do that. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-06 15:01 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-30 20:51 [PATCH v6 1/8] extcon: max8997: Add CHGINS and CHGRM interrupt handling Timon Baetz 2020-12-30 20:51 ` Timon Baetz 2020-12-30 20:52 ` [PATCH v6 2/8] regulator: dt-bindings: Document max8997-pmic nodes Timon Baetz 2020-12-30 20:52 ` Timon Baetz 2021-01-04 13:51 ` Mark Brown 2021-01-04 13:51 ` Mark Brown 2021-01-04 18:18 ` Krzysztof Kozlowski 2021-01-04 18:18 ` Krzysztof Kozlowski 2021-01-04 18:27 ` Mark Brown 2021-01-04 18:27 ` Mark Brown 2021-01-04 18:38 ` Krzysztof Kozlowski 2021-01-04 18:38 ` Krzysztof Kozlowski 2021-01-04 21:24 ` Mark Brown 2021-01-04 21:24 ` Mark Brown 2021-01-05 16:55 ` Krzysztof Kozlowski 2021-01-05 16:55 ` Krzysztof Kozlowski 2021-01-06 14:59 ` Mark Brown [this message] 2021-01-06 14:59 ` Mark Brown 2021-01-08 15:16 ` Timon Baetz 2021-01-08 15:16 ` Timon Baetz 2021-01-08 16:16 ` Mark Brown 2021-01-08 16:16 ` Mark Brown 2021-01-15 6:19 ` Timon Baetz 2021-01-15 6:19 ` Timon Baetz 2021-01-15 13:42 ` Mark Brown 2021-01-15 13:42 ` Mark Brown 2021-01-16 8:03 ` Timon Baetz 2021-01-16 8:03 ` Timon Baetz 2021-01-18 12:45 ` Mark Brown 2021-01-18 12:45 ` Mark Brown 2021-01-11 21:50 ` Rob Herring 2021-01-11 21:50 ` Rob Herring 2020-12-30 20:52 ` [PATCH v6 3/8] power: supply: max8997_charger: Set CHARGER current limit Timon Baetz 2020-12-30 20:52 ` Timon Baetz 2020-12-30 23:22 ` kernel test robot 2020-12-30 23:22 ` kernel test robot 2020-12-31 7:19 ` Timon Baetz 2020-12-31 8:23 ` Krzysztof Kozlowski 2020-12-31 8:23 ` Krzysztof Kozlowski 2020-12-31 8:55 ` Krzysztof Kozlowski 2020-12-31 8:55 ` Krzysztof Kozlowski 2021-01-03 1:53 ` Sebastian Reichel 2021-01-03 1:53 ` Sebastian Reichel 2020-12-30 20:52 ` [PATCH v6 4/8] ARM: dts: exynos: Add muic and charger nodes for I9100 Timon Baetz 2020-12-30 20:52 ` Timon Baetz 2020-12-30 20:52 ` [PATCH v6 5/8] ARM: dts: exynos: Add muic and charger nodes for Origen Timon Baetz 2020-12-30 20:52 ` Timon Baetz 2020-12-30 20:52 ` [PATCH v6 6/8] ARM: dts: exynos: Add muic and charger nodes for Trats Timon Baetz 2020-12-30 20:52 ` Timon Baetz 2020-12-30 20:53 ` [PATCH v6 7/8] ARM: dts: exynos: Fix charging regulator voltage and current for I9100 Timon Baetz 2020-12-30 20:53 ` Timon Baetz 2020-12-30 20:53 ` [PATCH v6 8/8] ARM: dts: exynos: Add top-off charging regulator node " Timon Baetz 2020-12-30 20:53 ` Timon Baetz 2021-01-03 16:32 ` (subset) [PATCH v6 1/8] extcon: max8997: Add CHGINS and CHGRM interrupt handling Krzysztof Kozlowski 2021-01-03 16:32 ` Krzysztof Kozlowski 2021-01-03 16:34 ` Krzysztof Kozlowski 2021-01-03 16:34 ` Krzysztof Kozlowski 2021-01-04 10:26 ` Chanwoo Choi 2021-01-04 10:26 ` Chanwoo Choi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210106145931.GE4752@sirena.org.uk \ --to=broonie@kernel.org \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=krzk@kernel.org \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=myungjoo.ham@samsung.com \ --cc=robh+dt@kernel.org \ --cc=sre@kernel.org \ --cc=timon.baetz@protonmail.com \ --cc=~postmarketos/upstreaming@lists.sr.ht \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.