* [folded-merged] ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix.patch removed from -mm tree
@ 2021-01-07 0:34 akpm
2021-01-07 21:09 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: akpm @ 2021-01-07 0:34 UTC (permalink / raw)
To: akpm, arnd, elver, georgepope, keescook, mm-commits,
natechancellor, ndesaulniers, sfr
The patch titled
Subject: ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix
has been removed from the -mm tree. Its filename was
ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix.patch
This patch was dropped because it was folded into ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang.patch
------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix
fix comment typo, per Nathan
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: George Popescu <georgepope@android.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Marco Elver <elver@google.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/Kconfig.ubsan | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/lib/Kconfig.ubsan~ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix
+++ a/lib/Kconfig.ubsan
@@ -122,7 +122,7 @@ config UBSAN_SIGNED_OVERFLOW
config UBSAN_UNSIGNED_OVERFLOW
bool "Perform checking for unsigned arithmetic overflow"
- # clang hugely expands stack usage with -fsanitize=object-size
+ # clang hugely expands stack usage with -fsanitize=unsigned-integer-overflow
depends on !CC_IS_CLANG
depends on $(cc-option,-fsanitize=unsigned-integer-overflow)
help
_
Patches currently in -mm which might be from akpm@linux-foundation.org are
mm-page_alloc-add-a-missing-mm_page_alloc_zone_locked-tracepoint-fix.patch
ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang.patch
mm.patch
mm-memcg-slab-pre-allocate-obj_cgroups-for-slab-caches-with-slab_account-fix.patch
mm-memcontrol-optimize-per-lruvec-stats-counter-memory-usage-checkpatch-fixes.patch
kasan-fix-bug-detection-via-ksize-for-hw_tags-mode-fix.patch
mm-cma-allocate-cma-areas-bottom-up-fix-3-fix.patch
mm-vmstat-fix-proc-sys-vm-stat_refresh-generating-false-warnings-fix-2.patch
kfence-kasan-make-kfence-compatible-with-kasan-fix.patch
set_memory-allow-set_direct_map__noflush-for-multiple-pages-fix.patch
arch-mm-wire-up-memfd_secret-system-call-were-relevant-fix.patch
kernel-forkc-export-kernel_thread-to-modules.patch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [folded-merged] ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix.patch removed from -mm tree
2021-01-07 0:34 [folded-merged] ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix.patch removed from -mm tree akpm
@ 2021-01-07 21:09 ` Kees Cook
2021-01-07 23:06 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Kees Cook @ 2021-01-07 21:09 UTC (permalink / raw)
To: akpm
Cc: arnd, elver, georgepope, mm-commits, natechancellor, ndesaulniers, sfr
On Wed, Jan 06, 2021 at 04:34:26PM -0800, akpm@linux-foundation.org wrote:
>
> The patch titled
> Subject: ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix
> has been removed from the -mm tree. Its filename was
> ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix.patch
>
> This patch was dropped because it was folded into ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang.patch
>
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix
>
> fix comment typo, per Nathan
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: George Popescu <georgepope@android.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Marco Elver <elver@google.com>
> Cc: Nathan Chancellor <natechancellor@gmail.com>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> lib/Kconfig.ubsan | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/lib/Kconfig.ubsan~ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix
> +++ a/lib/Kconfig.ubsan
> @@ -122,7 +122,7 @@ config UBSAN_SIGNED_OVERFLOW
>
> config UBSAN_UNSIGNED_OVERFLOW
> bool "Perform checking for unsigned arithmetic overflow"
> - # clang hugely expands stack usage with -fsanitize=object-size
> + # clang hugely expands stack usage with -fsanitize=unsigned-integer-overflow
> depends on !CC_IS_CLANG
The above "!CC_IS_CLANG" needs to be dropped. I makes it impossible to use at
all (unsigned UBSAN overflow is only implemented for Clang).
-Kees
> depends on $(cc-option,-fsanitize=unsigned-integer-overflow)
> help
> _
>
> Patches currently in -mm which might be from akpm@linux-foundation.org are
>
> mm-page_alloc-add-a-missing-mm_page_alloc_zone_locked-tracepoint-fix.patch
> ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang.patch
> mm.patch
> mm-memcg-slab-pre-allocate-obj_cgroups-for-slab-caches-with-slab_account-fix.patch
> mm-memcontrol-optimize-per-lruvec-stats-counter-memory-usage-checkpatch-fixes.patch
> kasan-fix-bug-detection-via-ksize-for-hw_tags-mode-fix.patch
> mm-cma-allocate-cma-areas-bottom-up-fix-3-fix.patch
> mm-vmstat-fix-proc-sys-vm-stat_refresh-generating-false-warnings-fix-2.patch
> kfence-kasan-make-kfence-compatible-with-kasan-fix.patch
> set_memory-allow-set_direct_map__noflush-for-multiple-pages-fix.patch
> arch-mm-wire-up-memfd_secret-system-call-were-relevant-fix.patch
> kernel-forkc-export-kernel_thread-to-modules.patch
>
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [folded-merged] ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix.patch removed from -mm tree
2021-01-07 21:09 ` Kees Cook
@ 2021-01-07 23:06 ` Andrew Morton
2021-01-08 3:56 ` Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2021-01-07 23:06 UTC (permalink / raw)
To: Kees Cook
Cc: arnd, elver, georgepope, mm-commits, natechancellor, ndesaulniers, sfr
On Thu, 7 Jan 2021 13:09:29 -0800 Kees Cook <keescook@chromium.org> wrote:
> > --- a/lib/Kconfig.ubsan~ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix
> > +++ a/lib/Kconfig.ubsan
> > @@ -122,7 +122,7 @@ config UBSAN_SIGNED_OVERFLOW
> >
> > config UBSAN_UNSIGNED_OVERFLOW
> > bool "Perform checking for unsigned arithmetic overflow"
> > - # clang hugely expands stack usage with -fsanitize=object-size
> > + # clang hugely expands stack usage with -fsanitize=unsigned-integer-overflow
> > depends on !CC_IS_CLANG
>
> The above "!CC_IS_CLANG" needs to be dropped. I makes it impossible to use at
> all (unsigned UBSAN overflow is only implemented for Clang).
It isn't clear to me that this patch remains valid anyway - I'll drop
it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [folded-merged] ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix.patch removed from -mm tree
2021-01-07 23:06 ` Andrew Morton
@ 2021-01-08 3:56 ` Stephen Rothwell
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2021-01-08 3:56 UTC (permalink / raw)
To: Andrew Morton
Cc: Kees Cook, arnd, elver, georgepope, mm-commits, natechancellor,
ndesaulniers
[-- Attachment #1: Type: text/plain, Size: 994 bytes --]
Hi Andrew,
On Thu, 7 Jan 2021 15:06:37 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Thu, 7 Jan 2021 13:09:29 -0800 Kees Cook <keescook@chromium.org> wrote:
>
> > > --- a/lib/Kconfig.ubsan~ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix
> > > +++ a/lib/Kconfig.ubsan
> > > @@ -122,7 +122,7 @@ config UBSAN_SIGNED_OVERFLOW
> > >
> > > config UBSAN_UNSIGNED_OVERFLOW
> > > bool "Perform checking for unsigned arithmetic overflow"
> > > - # clang hugely expands stack usage with -fsanitize=object-size
> > > + # clang hugely expands stack usage with -fsanitize=unsigned-integer-overflow
> > > depends on !CC_IS_CLANG
> >
> > The above "!CC_IS_CLANG" needs to be dropped. I makes it impossible to use at
> > all (unsigned UBSAN overflow is only implemented for Clang).
>
> It isn't clear to me that this patch remains valid anyway - I'll drop
> it.
I have dropped it from linux-next as well.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-08 3:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 0:34 [folded-merged] ubsan-disable-unsigned-integer-overflow-sanitizer-with-clang-fix.patch removed from -mm tree akpm
2021-01-07 21:09 ` Kees Cook
2021-01-07 23:06 ` Andrew Morton
2021-01-08 3:56 ` Stephen Rothwell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.