All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, festevam@gmail.com, catalin.marinas@arm.com,
	will@kernel.org, georgi.djakov@linaro.org, cdleonard@gmail.com,
	kernel@pengutronix.de, linux-imx@nxp.com, kernel@puri.sm,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Leonard Crestez <leonard.crestez@nxp.com>
Subject: Re: [PATCH v3 1/6] arm64: dts: imx8mq: Add NOC node
Date: Thu, 7 Jan 2021 13:12:50 +0800	[thread overview]
Message-ID: <20210107051250.GD28365@dragon> (raw)
In-Reply-To: <20201210100906.18205-2-martin.kepplinger@puri.sm>

On Thu, Dec 10, 2020 at 11:09:01AM +0100, Martin Kepplinger wrote:
> From: Leonard Crestez <leonard.crestez@nxp.com>
> 
> Add initial support for dynamic frequency scaling of the main NOC
> on imx8mq.
> 
> Make DDRC the parent of the NOC (using passive governor) so that the
> main NOC is automatically scaled together with DDRC by default.
> 
> Support for proactive scaling via interconnect will come on top.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index a841a023e8e0..9c9d68a14e69 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -1158,6 +1158,28 @@
>  			};
>  		};
>  
> +		noc: interconnect@32700000 {
> +			compatible = "fsl,imx8mq-noc", "fsl,imx8m-noc";
> +			reg = <0x32700000 0x100000>;
> +			clocks = <&clk IMX8MQ_CLK_NOC>;
> +			fsl,ddrc = <&ddrc>;
> +			operating-points-v2 = <&noc_opp_table>;
> +
> +			noc_opp_table: opp-table {
> +				compatible = "operating-points-v2";
> +
> +				opp-133M {
> +					opp-hz = /bits/ 64 <133333333>;
> +				};

Please have a newline between nodes.

Shawn

> +				opp-400M {
> +					opp-hz = /bits/ 64 <400000000>;
> +				};
> +				opp-800M {
> +					opp-hz = /bits/ 64 <800000000>;
> +				};
> +			};
> +		};
> +
>  		bus@32c00000 { /* AIPS4 */
>  			compatible = "fsl,aips-bus", "simple-bus";
>  			reg = <0x32c00000 0x400000>;
> -- 
> 2.20.1
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: kernel@puri.sm, cdleonard@gmail.com, devicetree@vger.kernel.org,
	will@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-imx@nxp.com,
	kernel@pengutronix.de, catalin.marinas@arm.com,
	Leonard Crestez <leonard.crestez@nxp.com>,
	festevam@gmail.com, georgi.djakov@linaro.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/6] arm64: dts: imx8mq: Add NOC node
Date: Thu, 7 Jan 2021 13:12:50 +0800	[thread overview]
Message-ID: <20210107051250.GD28365@dragon> (raw)
In-Reply-To: <20201210100906.18205-2-martin.kepplinger@puri.sm>

On Thu, Dec 10, 2020 at 11:09:01AM +0100, Martin Kepplinger wrote:
> From: Leonard Crestez <leonard.crestez@nxp.com>
> 
> Add initial support for dynamic frequency scaling of the main NOC
> on imx8mq.
> 
> Make DDRC the parent of the NOC (using passive governor) so that the
> main NOC is automatically scaled together with DDRC by default.
> 
> Support for proactive scaling via interconnect will come on top.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index a841a023e8e0..9c9d68a14e69 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -1158,6 +1158,28 @@
>  			};
>  		};
>  
> +		noc: interconnect@32700000 {
> +			compatible = "fsl,imx8mq-noc", "fsl,imx8m-noc";
> +			reg = <0x32700000 0x100000>;
> +			clocks = <&clk IMX8MQ_CLK_NOC>;
> +			fsl,ddrc = <&ddrc>;
> +			operating-points-v2 = <&noc_opp_table>;
> +
> +			noc_opp_table: opp-table {
> +				compatible = "operating-points-v2";
> +
> +				opp-133M {
> +					opp-hz = /bits/ 64 <133333333>;
> +				};

Please have a newline between nodes.

Shawn

> +				opp-400M {
> +					opp-hz = /bits/ 64 <400000000>;
> +				};
> +				opp-800M {
> +					opp-hz = /bits/ 64 <800000000>;
> +				};
> +			};
> +		};
> +
>  		bus@32c00000 { /* AIPS4 */
>  			compatible = "fsl,aips-bus", "simple-bus";
>  			reg = <0x32c00000 0x400000>;
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-01-07  5:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 10:09 [PATCH v3 0/6] imx8mq: updates for the interconnect fabric Martin Kepplinger
2020-12-10 10:09 ` Martin Kepplinger
2020-12-10 10:09 ` [PATCH v3 1/6] arm64: dts: imx8mq: Add NOC node Martin Kepplinger
2020-12-10 10:09   ` Martin Kepplinger
2021-01-04 14:53   ` Georgi Djakov
2021-01-04 14:53     ` Georgi Djakov
2021-01-07  5:12   ` Shawn Guo [this message]
2021-01-07  5:12     ` Shawn Guo
2020-12-10 10:09 ` [PATCH v3 2/6] arm64: dts: imx8mq: Add interconnect provider property Martin Kepplinger
2020-12-10 10:09   ` Martin Kepplinger
2021-01-04 14:53   ` Georgi Djakov
2021-01-04 14:53     ` Georgi Djakov
2020-12-10 10:09 ` [PATCH v3 3/6] arm64: dts: imx8mq: Add interconnect for lcdif Martin Kepplinger
2020-12-10 10:09   ` Martin Kepplinger
2021-01-04 14:54   ` Georgi Djakov
2021-01-04 14:54     ` Georgi Djakov
2020-12-10 10:09 ` [PATCH v3 4/6] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path Martin Kepplinger
2020-12-10 10:09   ` Martin Kepplinger
2020-12-10 10:09 ` [PATCH v3 5/6] interconnect: imx8mq: Use icc_sync_state Martin Kepplinger
2020-12-10 10:09   ` Martin Kepplinger
2020-12-10 10:09 ` [PATCH v3 6/6] arm64: defconfig: Enable interconnect for imx8mq Martin Kepplinger
2020-12-10 10:09   ` Martin Kepplinger
2021-01-04 14:55   ` Georgi Djakov
2021-01-04 14:55     ` Georgi Djakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210107051250.GD28365@dragon \
    --to=shawnguo@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=cdleonard@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=georgi.djakov@linaro.org \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=robh@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.