All of lore.kernel.org
 help / color / mirror / Atom feed
From: Georgi Djakov <georgi.djakov@linaro.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>,
	robh@kernel.org, shawnguo@kernel.org, festevam@gmail.com,
	catalin.marinas@arm.com, will@kernel.org, cdleonard@gmail.com
Cc: kernel@pengutronix.de, linux-imx@nxp.com, kernel@puri.sm,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 3/6] arm64: dts: imx8mq: Add interconnect for lcdif
Date: Mon, 4 Jan 2021 16:54:52 +0200	[thread overview]
Message-ID: <89be6e92-dcc7-7796-9258-fa3a480a193d@linaro.org> (raw)
In-Reply-To: <20201210100906.18205-4-martin.kepplinger@puri.sm>

On 12/10/20 12:09, Martin Kepplinger wrote:
> Add interconnect ports for lcdif to set bus capabilities.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>   arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 3617b7238952..7c4b68bda6fa 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -11,6 +11,7 @@
>   #include "dt-bindings/input/input.h"
>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>   #include <dt-bindings/thermal/thermal.h>
> +#include <dt-bindings/interconnect/imx8mq.h>
>   #include "imx8mq-pinfunc.h"
>   
>   / {
> @@ -522,6 +523,8 @@
>   						  <&clk IMX8MQ_VIDEO_PLL1>,
>   						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>   				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
> +				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> +				interconnect-names = "dram";
>   				status = "disabled";
>   
>   				port@0 {
> 

Nit: IMO, the dt-bindings patch (4/6) should come before this one - first
document the DT properties and then use them. Otherwise looks good to me.

Thanks,
Georgi

WARNING: multiple messages have this Message-ID (diff)
From: Georgi Djakov <georgi.djakov@linaro.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>,
	robh@kernel.org, shawnguo@kernel.org, festevam@gmail.com,
	catalin.marinas@arm.com, will@kernel.org, cdleonard@gmail.com
Cc: devicetree@vger.kernel.org, kernel@puri.sm,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/6] arm64: dts: imx8mq: Add interconnect for lcdif
Date: Mon, 4 Jan 2021 16:54:52 +0200	[thread overview]
Message-ID: <89be6e92-dcc7-7796-9258-fa3a480a193d@linaro.org> (raw)
In-Reply-To: <20201210100906.18205-4-martin.kepplinger@puri.sm>

On 12/10/20 12:09, Martin Kepplinger wrote:
> Add interconnect ports for lcdif to set bus capabilities.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>   arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 3617b7238952..7c4b68bda6fa 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -11,6 +11,7 @@
>   #include "dt-bindings/input/input.h"
>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>   #include <dt-bindings/thermal/thermal.h>
> +#include <dt-bindings/interconnect/imx8mq.h>
>   #include "imx8mq-pinfunc.h"
>   
>   / {
> @@ -522,6 +523,8 @@
>   						  <&clk IMX8MQ_VIDEO_PLL1>,
>   						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>   				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
> +				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> +				interconnect-names = "dram";
>   				status = "disabled";
>   
>   				port@0 {
> 

Nit: IMO, the dt-bindings patch (4/6) should come before this one - first
document the DT properties and then use them. Otherwise looks good to me.

Thanks,
Georgi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-04 14:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 10:09 [PATCH v3 0/6] imx8mq: updates for the interconnect fabric Martin Kepplinger
2020-12-10 10:09 ` Martin Kepplinger
2020-12-10 10:09 ` [PATCH v3 1/6] arm64: dts: imx8mq: Add NOC node Martin Kepplinger
2020-12-10 10:09   ` Martin Kepplinger
2021-01-04 14:53   ` Georgi Djakov
2021-01-04 14:53     ` Georgi Djakov
2021-01-07  5:12   ` Shawn Guo
2021-01-07  5:12     ` Shawn Guo
2020-12-10 10:09 ` [PATCH v3 2/6] arm64: dts: imx8mq: Add interconnect provider property Martin Kepplinger
2020-12-10 10:09   ` Martin Kepplinger
2021-01-04 14:53   ` Georgi Djakov
2021-01-04 14:53     ` Georgi Djakov
2020-12-10 10:09 ` [PATCH v3 3/6] arm64: dts: imx8mq: Add interconnect for lcdif Martin Kepplinger
2020-12-10 10:09   ` Martin Kepplinger
2021-01-04 14:54   ` Georgi Djakov [this message]
2021-01-04 14:54     ` Georgi Djakov
2020-12-10 10:09 ` [PATCH v3 4/6] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path Martin Kepplinger
2020-12-10 10:09   ` Martin Kepplinger
2020-12-10 10:09 ` [PATCH v3 5/6] interconnect: imx8mq: Use icc_sync_state Martin Kepplinger
2020-12-10 10:09   ` Martin Kepplinger
2020-12-10 10:09 ` [PATCH v3 6/6] arm64: defconfig: Enable interconnect for imx8mq Martin Kepplinger
2020-12-10 10:09   ` Martin Kepplinger
2021-01-04 14:55   ` Georgi Djakov
2021-01-04 14:55     ` Georgi Djakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89be6e92-dcc7-7796-9258-fa3a480a193d@linaro.org \
    --to=georgi.djakov@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=cdleonard@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.