From: Yu-Hsuan Hsu <yuhsuan@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Cheng-Yi Chiang <cychiang@chromium.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Prashant Malani <pmalani@chromium.org>,
Pi-Hsun Shih <pihsun@chromium.org>,
Yu-Hsuan Hsu <yuhsuan@chromium.org>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
alsa-devel@alsa-project.org
Subject: [PATCH 2/2] ASoC: cros_ec_codec: Reset I2S RX when probing
Date: Thu, 7 Jan 2021 16:59:42 +0800 [thread overview]
Message-ID: <20210107085942.2891525-2-yuhsuan@chromium.org> (raw)
In-Reply-To: <20210107085942.2891525-1-yuhsuan@chromium.org>
It is not guaranteed that I2S RX is disabled when the kernel booting.
For example, if the kernel crashes while it is enabled, it will keep
enabled until the next time EC reboots. Reset I2S RX when probing to
fix this issue.
Signed-off-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
---
sound/soc/codecs/cros_ec_codec.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
index f33a2a9654e7..28b3e2c48c86 100644
--- a/sound/soc/codecs/cros_ec_codec.c
+++ b/sound/soc/codecs/cros_ec_codec.c
@@ -1011,6 +1011,13 @@ static int cros_ec_codec_platform_probe(struct platform_device *pdev)
}
priv->ec_capabilities = r.capabilities;
+ /* Reset EC codec i2s rx. */
+ p.cmd = EC_CODEC_I2S_RX_RESET;
+ ret = send_ec_host_command(priv->ec_device, EC_CMD_EC_CODEC_I2S_RX,
+ (uint8_t *)&p, sizeof(p), NULL, 0);
+ if (ret)
+ dev_warn(dev, "failed to EC_CODEC_I2S_RESET: %d\n", ret);
+
platform_set_drvdata(pdev, priv);
ret = devm_snd_soc_register_component(dev, &i2s_rx_component_driver,
--
2.29.2.729.g45daf8777d-goog
WARNING: multiple messages have this Message-ID (diff)
From: Yu-Hsuan Hsu <yuhsuan@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: alsa-devel@alsa-project.org,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Guenter Roeck <groeck@chromium.org>,
Mark Brown <broonie@kernel.org>,
Prashant Malani <pmalani@chromium.org>,
Pi-Hsun Shih <pihsun@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
Yu-Hsuan Hsu <yuhsuan@chromium.org>,
Cheng-Yi Chiang <cychiang@chromium.org>
Subject: [PATCH 2/2] ASoC: cros_ec_codec: Reset I2S RX when probing
Date: Thu, 7 Jan 2021 16:59:42 +0800 [thread overview]
Message-ID: <20210107085942.2891525-2-yuhsuan@chromium.org> (raw)
In-Reply-To: <20210107085942.2891525-1-yuhsuan@chromium.org>
It is not guaranteed that I2S RX is disabled when the kernel booting.
For example, if the kernel crashes while it is enabled, it will keep
enabled until the next time EC reboots. Reset I2S RX when probing to
fix this issue.
Signed-off-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
---
sound/soc/codecs/cros_ec_codec.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
index f33a2a9654e7..28b3e2c48c86 100644
--- a/sound/soc/codecs/cros_ec_codec.c
+++ b/sound/soc/codecs/cros_ec_codec.c
@@ -1011,6 +1011,13 @@ static int cros_ec_codec_platform_probe(struct platform_device *pdev)
}
priv->ec_capabilities = r.capabilities;
+ /* Reset EC codec i2s rx. */
+ p.cmd = EC_CODEC_I2S_RX_RESET;
+ ret = send_ec_host_command(priv->ec_device, EC_CMD_EC_CODEC_I2S_RX,
+ (uint8_t *)&p, sizeof(p), NULL, 0);
+ if (ret)
+ dev_warn(dev, "failed to EC_CODEC_I2S_RESET: %d\n", ret);
+
platform_set_drvdata(pdev, priv);
ret = devm_snd_soc_register_component(dev, &i2s_rx_component_driver,
--
2.29.2.729.g45daf8777d-goog
next prev parent reply other threads:[~2021-01-07 9:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 8:59 [PATCH 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET Yu-Hsuan Hsu
2021-01-07 8:59 ` Yu-Hsuan Hsu
2021-01-07 8:59 ` Yu-Hsuan Hsu [this message]
2021-01-07 8:59 ` [PATCH 2/2] ASoC: cros_ec_codec: Reset I2S RX when probing Yu-Hsuan Hsu
2021-01-12 16:34 ` Enric Balletbo i Serra
2021-01-12 16:34 ` Enric Balletbo i Serra
2021-01-13 6:58 ` Yu-Hsuan Hsu
2021-01-13 6:58 ` Yu-Hsuan Hsu
2021-01-07 13:54 ` [PATCH 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET Mark Brown
2021-01-07 13:54 ` Mark Brown
2021-01-08 4:57 ` Yu-Hsuan Hsu
2021-01-08 4:57 ` Yu-Hsuan Hsu
2021-01-12 0:42 ` Mark Brown
2021-01-12 0:42 ` Mark Brown
2021-01-12 1:52 ` Guenter Roeck
2021-01-12 14:10 ` Mark Brown
2021-01-12 14:10 ` Mark Brown
2021-01-12 16:40 ` Enric Balletbo i Serra
2021-01-12 16:40 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107085942.2891525-2-yuhsuan@chromium.org \
--to=yuhsuan@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pihsun@chromium.org \
--cc=pmalani@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.