All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yu-Hsuan Hsu <yuhsuan@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Benson Leung <bleung@chromium.org>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Guenter Roeck <groeck@chromium.org>,
	Cheng-Yi Chiang <cychiang@chromium.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Prashant Malani <pmalani@chromium.org>,
	Pi-Hsun Shih <pihsun@chromium.org>,
	"Gustavo A . R . Silva" <gustavoars@kernel.org>,
	ALSA development <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET
Date: Fri, 8 Jan 2021 12:57:51 +0800	[thread overview]
Message-ID: <CAGvk5PqMCEib8Yr=V4SxT0BBMoC1+yGXm0y+52+LwC5dPQUVnA@mail.gmail.com> (raw)
In-Reply-To: <20210107135459.GB4726@sirena.org.uk>

Mark Brown <broonie@kernel.org> 於 2021年1月7日 週四 下午9:55寫道：
>
> On Thu, Jan 07, 2021 at 04:59:41PM +0800, Yu-Hsuan Hsu wrote:
> > Add the new command EC_CODEC_I2S_RX_RESET in ec_codec_i2s_rx_subcmd,
> > which is used for resetting the EC codec.
>
> I think the request was to sync over all the commands that are supported
> in the EC rather than just split this one addition into a separate
> patch.
Got it. However, after running make_linux_ec_commands_h.sh to create
the new cros_ec_commands.h, I found there are lots of difference (1092
insertions(+), 66 deletions(-)). In addition, there are also some
redefined variables(most are in ./include/linux/usb/pd.h) causing the
compile error.

It seems not easy to sync cros_ec_commands.h. I'm afraid of breaking
something. Does anyone have any suggestion? Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Yu-Hsuan Hsu <yuhsuan@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: ALSA development <alsa-devel@alsa-project.org>,
	"Gustavo A . R . Silva" <gustavoars@kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Guenter Roeck <groeck@chromium.org>,
	Prashant Malani <pmalani@chromium.org>,
	Pi-Hsun Shih <pihsun@chromium.org>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Benson Leung <bleung@chromium.org>,
	Cheng-Yi Chiang <cychiang@chromium.org>
Subject: Re: [PATCH 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET
Date: Fri, 8 Jan 2021 12:57:51 +0800	[thread overview]
Message-ID: <CAGvk5PqMCEib8Yr=V4SxT0BBMoC1+yGXm0y+52+LwC5dPQUVnA@mail.gmail.com> (raw)
In-Reply-To: <20210107135459.GB4726@sirena.org.uk>

Mark Brown <broonie@kernel.org> 於 2021年1月7日 週四 下午9:55寫道：
>
> On Thu, Jan 07, 2021 at 04:59:41PM +0800, Yu-Hsuan Hsu wrote:
> > Add the new command EC_CODEC_I2S_RX_RESET in ec_codec_i2s_rx_subcmd,
> > which is used for resetting the EC codec.
>
> I think the request was to sync over all the commands that are supported
> in the EC rather than just split this one addition into a separate
> patch.
Got it. However, after running make_linux_ec_commands_h.sh to create
the new cros_ec_commands.h, I found there are lots of difference (1092
insertions(+), 66 deletions(-)). In addition, there are also some
redefined variables(most are in ./include/linux/usb/pd.h) causing the
compile error.

It seems not easy to sync cros_ec_commands.h. I'm afraid of breaking
something. Does anyone have any suggestion? Thanks.

  reply	other threads:[~2021-01-08  4:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07  8:59 [PATCH 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET Yu-Hsuan Hsu
2021-01-07  8:59 ` Yu-Hsuan Hsu
2021-01-07  8:59 ` [PATCH 2/2] ASoC: cros_ec_codec: Reset I2S RX when probing Yu-Hsuan Hsu
2021-01-07  8:59   ` Yu-Hsuan Hsu
2021-01-12 16:34   ` Enric Balletbo i Serra
2021-01-12 16:34     ` Enric Balletbo i Serra
2021-01-13  6:58     ` Yu-Hsuan Hsu
2021-01-13  6:58       ` Yu-Hsuan Hsu
2021-01-07 13:54 ` [PATCH 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET Mark Brown
2021-01-07 13:54   ` Mark Brown
2021-01-08  4:57   ` Yu-Hsuan Hsu [this message]
2021-01-08  4:57     ` Yu-Hsuan Hsu
2021-01-12  0:42     ` Mark Brown
2021-01-12  0:42       ` Mark Brown
2021-01-12  1:52       ` Guenter Roeck
2021-01-12 14:10         ` Mark Brown
2021-01-12 14:10           ` Mark Brown
2021-01-12 16:40           ` Enric Balletbo i Serra
2021-01-12 16:40             ` Enric Balletbo i Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGvk5PqMCEib8Yr=V4SxT0BBMoC1+yGXm0y+52+LwC5dPQUVnA@mail.gmail.com' \
    --to=yuhsuan@chromium.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bleung@chromium.org \
    --cc=broonie@kernel.org \
    --cc=cychiang@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=gustavoars@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pihsun@chromium.org \
    --cc=pmalani@chromium.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.