All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Shreyas Joshi <shreyas.joshi@biamp.com>,
	shreyasjoshi15@gmail.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Vineet Gupta <vgupta@synopsys.com>,
	Thomas Meyer <thomas@m3y3r.de>, David Gow <davidgow@google.com>,
	Brendan Higgins <brendanhiggins@google.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>
Subject: [PATCH 0/1] console: Blank console - userspace regression
Date: Thu,  7 Jan 2021 17:43:59 +0100	[thread overview]
Message-ID: <20210107164400.17904-1-pmladek@suse.com> (raw)

The commit 757055ae8dedf5333af17b3b ("init/console: Use ttynull as a fallback when
there is no console") caused several regressions. The ttynull console has been
selected by default when no console was configured on the command line and
ttynull_init() was the first initcall calling register_console().

There were few possible workarounds but I was not happy with them.
I worked on a proper solution but it became too complicated to
be used at this stage.

The console registration code is a sad story. There are many hidden catches.
The ordering of registered consoles is not well defined. Any change
in the code tends to break some particular system.

The good news is that I become more and more familiar with it.
I hope that I will be able to clean it up step by step in
the future. But it is definitely not a good idea to do any big
refactoring in rc phase.

Hence I propose to revert the problematic commit as the least
risky solution.

Petr Mladek (1):
  Revert "init/console: Use ttynull as a fallback when there is no
    console"

 drivers/tty/Kconfig     | 14 ++++++++++++++
 drivers/tty/Makefile    |  3 ++-
 drivers/tty/ttynull.c   | 18 ------------------
 include/linux/console.h |  3 ---
 init/main.c             | 10 ++--------
 5 files changed, 18 insertions(+), 30 deletions(-)

-- 
2.26.2


             reply	other threads:[~2021-01-07 16:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 16:43 Petr Mladek [this message]
2021-01-07 16:44 ` [PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console" Petr Mladek
2021-01-07 17:46   ` Andy Shevchenko
2021-01-07 17:48     ` Linus Torvalds
2021-01-07 19:16   ` Greg Kroah-Hartman
2021-01-07 19:38     ` Linus Torvalds
2021-01-08 17:45       ` Petr Mladek
2021-01-08 18:49         ` Vineet Gupta
2021-01-08 19:03         ` Linus Torvalds
2021-01-08  3:41   ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210107164400.17904-1-pmladek@suse.com \
    --to=pmladek@suse.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=gerg@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=shreyas.joshi@biamp.com \
    --cc=shreyasjoshi15@gmail.com \
    --cc=skhan@linuxfoundation.org \
    --cc=thomas@m3y3r.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vgupta@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.