From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Guenter Roeck <linux@roeck-us.net>,
Shreyas Joshi <shreyas.joshi@biamp.com>,
shreyasjoshi15@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Greg Ungerer <gerg@linux-m68k.org>,
Vineet Gupta <vgupta@synopsys.com>,
Thomas Meyer <thomas@m3y3r.de>, David Gow <davidgow@google.com>,
Brendan Higgins <brendanhiggins@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console"
Date: Thu, 7 Jan 2021 09:48:12 -0800 [thread overview]
Message-ID: <CAHk-=wjKt0Xec69iMK18h6-BNZ+3vWR-zswQtip=Y0unK0K56g@mail.gmail.com> (raw)
In-Reply-To: <20210107174638.GH4077@smile.fi.intel.com>
On Thu, Jan 7, 2021 at 9:45 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>>
> Shouldn't it have Fixes tag along with Reported-by ones and explanation what
> was the actual problem reported?
No need for a "Fixes" tag for a revert - the commit it reverts _is_
the thing it fixes, so that's implicitly there.
But yes, a reported-by with an explanation of the actual case that
broke would be a very good idea, so that the revert documents the
particular case that caused it, not just the "big picture" case.
Linus
next prev parent reply other threads:[~2021-01-07 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 16:43 [PATCH 0/1] console: Blank console - userspace regression Petr Mladek
2021-01-07 16:44 ` [PATCH 1/1] Revert "init/console: Use ttynull as a fallback when there is no console" Petr Mladek
2021-01-07 17:46 ` Andy Shevchenko
2021-01-07 17:48 ` Linus Torvalds [this message]
2021-01-07 19:16 ` Greg Kroah-Hartman
2021-01-07 19:38 ` Linus Torvalds
2021-01-08 17:45 ` Petr Mladek
2021-01-08 18:49 ` Vineet Gupta
2021-01-08 19:03 ` Linus Torvalds
2021-01-08 3:41 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjKt0Xec69iMK18h6-BNZ+3vWR-zswQtip=Y0unK0K56g@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=gerg@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=shreyas.joshi@biamp.com \
--cc=shreyasjoshi15@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=thomas@m3y3r.de \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.