* Re: [RFC] drm/connector: Set the default callback function for drm_connector_funcs
2021-01-08 7:54 [RFC] drm/connector: Set the default callback function for drm_connector_funcs Tian Tao
@ 2021-01-08 8:12 ` Thomas Zimmermann
2021-01-08 8:58 ` Daniel Vetter
2021-01-08 13:07 ` Jani Nikula
2021-01-08 15:16 ` kernel test robot
` (2 subsequent siblings)
3 siblings, 2 replies; 7+ messages in thread
From: Thomas Zimmermann @ 2021-01-08 8:12 UTC (permalink / raw)
To: Tian Tao, airlied, daniel, kraxel, alexander.deucher, tglx,
dri-devel, xinliang.liu
[-- Attachment #1.1.1: Type: text/plain, Size: 3541 bytes --]
Hi
Am 08.01.21 um 08:54 schrieb Tian Tao:
> The member functions of drm_connector_funcs are not specific to each
> manufacturer's driver, so drm_connector_funcs is allowed to use default
> values, which prevents all drivers from setting the same member
> functions for drm_connector_funcs.
I don't think that's a good idea.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/gpu/drm/drm_connector.c | 7 ++++++-
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 1 -
> include/drm/drm_connector.h | 2 +-
> 3 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index 98b6ec4..356d8a3 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -25,6 +25,7 @@
> #include <drm/drm_encoder.h>
> #include <drm/drm_utils.h>
> #include <drm/drm_print.h>
> +#include <drm/drm_probe_helper.h>
> #include <drm/drm_drv.h>
> #include <drm/drm_file.h>
> #include <drm/drm_sysfs.h>
> @@ -216,7 +217,7 @@ void drm_connector_free_work_fn(struct work_struct *work)
> */
> int drm_connector_init(struct drm_device *dev,
> struct drm_connector *connector,
> - const struct drm_connector_funcs *funcs,
> + struct drm_connector_funcs *funcs,
Drivers cannot legally declare the funcs instance as static const.
Having static const allows for write protected pages.
> int connector_type)
> {
> struct drm_mode_config *config = &dev->mode_config;
> @@ -228,6 +229,10 @@ int drm_connector_init(struct drm_device *dev,
> (!funcs->atomic_destroy_state ||
> !funcs->atomic_duplicate_state));
>
> + if (!funcs->fill_modes)
> + funcs->fill_modes = &drm_helper_probe_single_connector_modes;
It's not clear that this is really the correct function for this driver.
Best regards
Thomas
> +
> +
> ret = __drm_mode_object_add(dev, &connector->base,
> DRM_MODE_OBJECT_CONNECTOR,
> false, drm_connector_free);
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> index c76f996..7d3b662 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> @@ -64,7 +64,6 @@ static const struct drm_connector_helper_funcs
> };
>
> static const struct drm_connector_funcs hibmc_connector_funcs = {
> - .fill_modes = drm_helper_probe_single_connector_modes,
> .destroy = hibmc_connector_destroy,
> .reset = drm_atomic_helper_connector_reset,
> .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index 1922b27..4810583 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -1561,7 +1561,7 @@ struct drm_connector {
>
> int drm_connector_init(struct drm_device *dev,
> struct drm_connector *connector,
> - const struct drm_connector_funcs *funcs,
> + struct drm_connector_funcs *funcs,
> int connector_type);
> int drm_connector_init_with_ddc(struct drm_device *dev,
> struct drm_connector *connector,
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC] drm/connector: Set the default callback function for drm_connector_funcs
2021-01-08 8:12 ` Thomas Zimmermann
@ 2021-01-08 8:58 ` Daniel Vetter
2021-01-08 13:07 ` Jani Nikula
1 sibling, 0 replies; 7+ messages in thread
From: Daniel Vetter @ 2021-01-08 8:58 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: Dave Airlie, dri-devel, Xinliang Liu, Gerd Hoffmann,
Alex Deucher, Tian Tao, Thomas Gleixner
On Fri, Jan 8, 2021 at 9:12 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> Hi
>
> Am 08.01.21 um 08:54 schrieb Tian Tao:
> > The member functions of drm_connector_funcs are not specific to each
> > manufacturer's driver, so drm_connector_funcs is allowed to use default
> > values, which prevents all drivers from setting the same member
> > functions for drm_connector_funcs.
>
> I don't think that's a good idea.
Yeah this breaks the helper/core separation. We have occasionally move
functionality across that border, but this is the one place where
we're ok with a pile of duplication, since it helps in making sure
that the helper library (like the probe function you want to make the
default here) really stays an optional helper library and doesn't
become some kind of midlayer spaghetti mess.
-Daniel
>
> >
> > Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> > ---
> > drivers/gpu/drm/drm_connector.c | 7 ++++++-
> > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 1 -
> > include/drm/drm_connector.h | 2 +-
> > 3 files changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> > index 98b6ec4..356d8a3 100644
> > --- a/drivers/gpu/drm/drm_connector.c
> > +++ b/drivers/gpu/drm/drm_connector.c
> > @@ -25,6 +25,7 @@
> > #include <drm/drm_encoder.h>
> > #include <drm/drm_utils.h>
> > #include <drm/drm_print.h>
> > +#include <drm/drm_probe_helper.h>
> > #include <drm/drm_drv.h>
> > #include <drm/drm_file.h>
> > #include <drm/drm_sysfs.h>
> > @@ -216,7 +217,7 @@ void drm_connector_free_work_fn(struct work_struct *work)
> > */
> > int drm_connector_init(struct drm_device *dev,
> > struct drm_connector *connector,
> > - const struct drm_connector_funcs *funcs,
> > + struct drm_connector_funcs *funcs,
>
> Drivers cannot legally declare the funcs instance as static const.
> Having static const allows for write protected pages.
>
> > int connector_type)
> > {
> > struct drm_mode_config *config = &dev->mode_config;
> > @@ -228,6 +229,10 @@ int drm_connector_init(struct drm_device *dev,
> > (!funcs->atomic_destroy_state ||
> > !funcs->atomic_duplicate_state));
> >
> > + if (!funcs->fill_modes)
> > + funcs->fill_modes = &drm_helper_probe_single_connector_modes;
>
> It's not clear that this is really the correct function for this driver.
>
> Best regards
> Thomas
>
> > +
> > +
> > ret = __drm_mode_object_add(dev, &connector->base,
> > DRM_MODE_OBJECT_CONNECTOR,
> > false, drm_connector_free);
> > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> > index c76f996..7d3b662 100644
> > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> > @@ -64,7 +64,6 @@ static const struct drm_connector_helper_funcs
> > };
> >
> > static const struct drm_connector_funcs hibmc_connector_funcs = {
> > - .fill_modes = drm_helper_probe_single_connector_modes,
> > .destroy = hibmc_connector_destroy,
> > .reset = drm_atomic_helper_connector_reset,
> > .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
> > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> > index 1922b27..4810583 100644
> > --- a/include/drm/drm_connector.h
> > +++ b/include/drm/drm_connector.h
> > @@ -1561,7 +1561,7 @@ struct drm_connector {
> >
> > int drm_connector_init(struct drm_device *dev,
> > struct drm_connector *connector,
> > - const struct drm_connector_funcs *funcs,
> > + struct drm_connector_funcs *funcs,
> > int connector_type);
> > int drm_connector_init_with_ddc(struct drm_device *dev,
> > struct drm_connector *connector,
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC] drm/connector: Set the default callback function for drm_connector_funcs
2021-01-08 8:12 ` Thomas Zimmermann
2021-01-08 8:58 ` Daniel Vetter
@ 2021-01-08 13:07 ` Jani Nikula
1 sibling, 0 replies; 7+ messages in thread
From: Jani Nikula @ 2021-01-08 13:07 UTC (permalink / raw)
To: Thomas Zimmermann, Tian Tao, airlied, daniel, kraxel,
alexander.deucher, tglx, dri-devel, xinliang.liu
On Fri, 08 Jan 2021, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Drivers cannot legally declare the funcs instance as static const.
> Having static const allows for write protected pages.
This. I've done quite a bit of refactoring all over the place to be
ablet to move to the complete opposite direction. We want to keep all
callback structs static const.
If the idea here was good (on which I'm inclined to side with Thomas and
Daniel that it isn't), the way to go would be to add a small wrapper for
calling ->fill_modes(), with a different path for when it's NULL.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC] drm/connector: Set the default callback function for drm_connector_funcs
2021-01-08 7:54 [RFC] drm/connector: Set the default callback function for drm_connector_funcs Tian Tao
2021-01-08 8:12 ` Thomas Zimmermann
@ 2021-01-08 15:16 ` kernel test robot
2021-01-08 15:17 ` kernel test robot
2021-01-08 23:32 ` kernel test robot
3 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2021-01-08 15:16 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 16185 bytes --]
Hi Tian,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linus/master]
[also build test WARNING on v5.11-rc2 next-20210108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Tian-Tao/drm-connector-Set-the-default-callback-function-for-drm_connector_funcs/20210108-165753
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f5e6c330254ae691f6d7befe61c786eb5056007e
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/37e7ae0ccb8825f7718028991d1635d60323f9dc
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tian-Tao/drm-connector-Set-the-default-callback-function-for-drm_connector_funcs/20210108-165753
git checkout 37e7ae0ccb8825f7718028991d1635d60323f9dc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/err.h:5,
from include/linux/regulator/consumer.h:34,
from drivers/gpu/drm/exynos/exynos_drm_dpi.c:11:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/exynos/exynos_drm_dpi.c: In function 'exynos_dpi_create_connector':
>> drivers/gpu/drm/exynos/exynos_drm_dpi.c:102:6: warning: passing argument 3 of 'drm_connector_init' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
102 | &exynos_dpi_connector_funcs,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/drm/drm_modes.h:33,
from include/drm/drm_crtc.h:40,
from include/drm/drm_atomic_helper.h:31,
from drivers/gpu/drm/exynos/exynos_drm_dpi.c:13:
include/drm/drm_connector.h:1515:38: note: expected 'struct drm_connector_funcs *' but argument is of type 'const struct drm_connector_funcs *'
1515 | struct drm_connector_funcs *funcs,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
--
In file included from include/linux/err.h:5,
from include/linux/clk.h:12,
from drivers/gpu/drm/exynos/exynos_drm_dsi.c:10:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/exynos/exynos_drm_dsi.c: In function 'exynos_dsi_create_connector':
>> drivers/gpu/drm/exynos/exynos_drm_dsi.c:1502:43: warning: passing argument 3 of 'drm_connector_init' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
1502 | ret = drm_connector_init(drm, connector, &exynos_dsi_connector_funcs,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/drm/drm_modes.h:33,
from include/drm/drm_crtc.h:40,
from include/drm/drm_atomic_helper.h:31,
from drivers/gpu/drm/exynos/exynos_drm_dsi.c:26:
include/drm/drm_connector.h:1515:38: note: expected 'struct drm_connector_funcs *' but argument is of type 'const struct drm_connector_funcs *'
1515 | struct drm_connector_funcs *funcs,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
--
In file included from include/linux/kernel.h:10,
from drivers/gpu/drm/exynos/exynos_drm_vidi.c:10:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/exynos/exynos_drm_vidi.c: In function 'vidi_create_connector':
>> drivers/gpu/drm/exynos/exynos_drm_vidi.c:346:4: warning: passing argument 3 of 'drm_connector_init' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
346 | &vidi_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL);
| ^~~~~~~~~~~~~~~~~~~~~
In file included from include/drm/drm_modes.h:33,
from include/drm/drm_crtc.h:40,
from include/drm/drm_atomic_helper.h:31,
from drivers/gpu/drm/exynos/exynos_drm_vidi.c:14:
include/drm/drm_connector.h:1515:38: note: expected 'struct drm_connector_funcs *' but argument is of type 'const struct drm_connector_funcs *'
1515 | struct drm_connector_funcs *funcs,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
--
drivers/gpu/drm/imx/parallel-display.c: In function 'imx_pd_register':
>> drivers/gpu/drm/imx/parallel-display.c:282:8: warning: passing argument 3 of 'drm_connector_init' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
282 | &imx_pd_connector_funcs,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from include/drm/drm_modes.h:33,
from include/drm/drm_crtc.h:40,
from include/drm/drm_atomic_helper.h:31,
from drivers/gpu/drm/imx/parallel-display.c:15:
include/drm/drm_connector.h:1515:38: note: expected 'struct drm_connector_funcs *' but argument is of type 'const struct drm_connector_funcs *'
1515 | struct drm_connector_funcs *funcs,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
--
In file included from include/linux/err.h:5,
from include/linux/clk.h:12,
from drivers/gpu/drm/rockchip/cdn-dp-core.c:7:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/rockchip/cdn-dp-core.c: In function 'cdn_dp_bind':
>> drivers/gpu/drm/rockchip/cdn-dp-core.c:1045:6: warning: passing argument 3 of 'drm_connector_init' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
1045 | &cdn_dp_atomic_connector_funcs,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/drm/drm_modes.h:33,
from include/drm/drm_crtc.h:40,
from include/drm/drm_atomic_helper.h:31,
from drivers/gpu/drm/rockchip/cdn-dp-core.c:18:
include/drm/drm_connector.h:1515:38: note: expected 'struct drm_connector_funcs *' but argument is of type 'const struct drm_connector_funcs *'
1515 | struct drm_connector_funcs *funcs,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
At top level:
drivers/gpu/drm/rockchip/cdn-dp-core.c:1124:12: warning: 'cdn_dp_resume' defined but not used [-Wunused-function]
1124 | static int cdn_dp_resume(struct device *dev)
| ^~~~~~~~~~~~~
--
In file included from include/linux/err.h:5,
from include/linux/clk.h:12,
from drivers/gpu/drm/rockchip/rockchip_lvds.c:9:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_bind':
>> drivers/gpu/drm/rockchip/rockchip_lvds.c:620:7: warning: passing argument 3 of 'drm_connector_init' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
620 | &rockchip_lvds_connector_funcs,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/drm/drm_modes.h:33,
from include/drm/drm_crtc.h:40,
from include/drm/drm_atomic_helper.h:31,
from drivers/gpu/drm/rockchip/rockchip_lvds.c:20:
include/drm/drm_connector.h:1515:38: note: expected 'struct drm_connector_funcs *' but argument is of type 'const struct drm_connector_funcs *'
1515 | struct drm_connector_funcs *funcs,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
--
In file included from include/linux/build_bug.h:5,
from include/linux/bits.h:22,
from include/linux/ioport.h:13,
from include/linux/acpi.h:12,
from include/linux/i2c.h:13,
from include/drm/drm_crtc.h:28,
from include/drm/drm_atomic_helper.h:31,
from drivers/gpu/drm/vc4/vc4_vec.c:16:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
137 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/vc4/vc4_vec.c: In function 'vc4_vec_connector_init':
>> drivers/gpu/drm/vc4/vc4_vec.c:364:37: warning: passing argument 3 of 'drm_connector_init' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
364 | drm_connector_init(dev, connector, &vc4_vec_connector_funcs,
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/drm/drm_modes.h:33,
from include/drm/drm_crtc.h:40,
from include/drm/drm_atomic_helper.h:31,
from drivers/gpu/drm/vc4/vc4_vec.c:16:
include/drm/drm_connector.h:1515:38: note: expected 'struct drm_connector_funcs *' but argument is of type 'const struct drm_connector_funcs *'
1515 | struct drm_connector_funcs *funcs,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
vim +102 drivers/gpu/drm/exynos/exynos_drm_dpi.c
14b6873a01981b2 Andrzej Hajda 2014-03-17 92
2b8376c803c4c1c Gustavo Padovan 2015-08-15 93 static int exynos_dpi_create_connector(struct drm_encoder *encoder)
14b6873a01981b2 Andrzej Hajda 2014-03-17 94 {
2b8376c803c4c1c Gustavo Padovan 2015-08-15 95 struct exynos_dpi *ctx = encoder_to_dpi(encoder);
14b6873a01981b2 Andrzej Hajda 2014-03-17 96 struct drm_connector *connector = &ctx->connector;
14b6873a01981b2 Andrzej Hajda 2014-03-17 97 int ret;
14b6873a01981b2 Andrzej Hajda 2014-03-17 98
14b6873a01981b2 Andrzej Hajda 2014-03-17 99 connector->polled = DRM_CONNECTOR_POLL_HPD;
14b6873a01981b2 Andrzej Hajda 2014-03-17 100
14b6873a01981b2 Andrzej Hajda 2014-03-17 101 ret = drm_connector_init(encoder->dev, connector,
14b6873a01981b2 Andrzej Hajda 2014-03-17 @102 &exynos_dpi_connector_funcs,
14b6873a01981b2 Andrzej Hajda 2014-03-17 103 DRM_MODE_CONNECTOR_VGA);
14b6873a01981b2 Andrzej Hajda 2014-03-17 104 if (ret) {
6f83d20838c0993 Inki Dae 2019-04-15 105 DRM_DEV_ERROR(ctx->dev,
6f83d20838c0993 Inki Dae 2019-04-15 106 "failed to initialize connector with drm\n");
14b6873a01981b2 Andrzej Hajda 2014-03-17 107 return ret;
14b6873a01981b2 Andrzej Hajda 2014-03-17 108 }
14b6873a01981b2 Andrzej Hajda 2014-03-17 109
14b6873a01981b2 Andrzej Hajda 2014-03-17 110 drm_connector_helper_add(connector, &exynos_dpi_connector_helper_funcs);
cde4c44d8769c1b Daniel Vetter 2018-07-09 111 drm_connector_attach_encoder(connector, encoder);
14b6873a01981b2 Andrzej Hajda 2014-03-17 112
14b6873a01981b2 Andrzej Hajda 2014-03-17 113 return 0;
14b6873a01981b2 Andrzej Hajda 2014-03-17 114 }
14b6873a01981b2 Andrzej Hajda 2014-03-17 115
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 59574 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC] drm/connector: Set the default callback function for drm_connector_funcs
2021-01-08 7:54 [RFC] drm/connector: Set the default callback function for drm_connector_funcs Tian Tao
2021-01-08 8:12 ` Thomas Zimmermann
2021-01-08 15:16 ` kernel test robot
@ 2021-01-08 15:17 ` kernel test robot
2021-01-08 23:32 ` kernel test robot
3 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2021-01-08 15:17 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4347 bytes --]
Hi Tian,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linus/master]
[also build test WARNING on v5.11-rc2 next-20210108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Tian-Tao/drm-connector-Set-the-default-callback-function-for-drm_connector_funcs/20210108-165753
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f5e6c330254ae691f6d7befe61c786eb5056007e
config: powerpc64-randconfig-r004-20210108 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/37e7ae0ccb8825f7718028991d1635d60323f9dc
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tian-Tao/drm-connector-Set-the-default-callback-function-for-drm_connector_funcs/20210108-165753
git checkout 37e7ae0ccb8825f7718028991d1635d60323f9dc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/aspeed/aspeed_gfx_out.c: In function 'aspeed_gfx_create_output':
>> drivers/gpu/drm/aspeed/aspeed_gfx_out.c:39:6: warning: passing argument 3 of 'drm_connector_init' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
39 | &aspeed_gfx_connector_funcs,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/drm/drm_modes.h:33,
from include/drm/drm_crtc.h:40,
from include/drm/drm_atomic_helper.h:31,
from drivers/gpu/drm/aspeed/aspeed_gfx_out.c:4:
include/drm/drm_connector.h:1515:38: note: expected 'struct drm_connector_funcs *' but argument is of type 'const struct drm_connector_funcs *'
1515 | struct drm_connector_funcs *funcs,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
--
drivers/gpu/drm/xlnx/zynqmp_dp.c: In function 'zynqmp_dp_drm_init':
>> drivers/gpu/drm/xlnx/zynqmp_dp.c:1623:6: warning: passing argument 3 of 'drm_connector_init' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
1623 | &zynqmp_dp_connector_funcs,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/drm/drm_modes.h:33,
from include/drm/drm_crtc.h:40,
from include/drm/drm_atomic_helper.h:31,
from drivers/gpu/drm/xlnx/zynqmp_dp.c:12:
include/drm/drm_connector.h:1515:38: note: expected 'struct drm_connector_funcs *' but argument is of type 'const struct drm_connector_funcs *'
1515 | struct drm_connector_funcs *funcs,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
vim +39 drivers/gpu/drm/aspeed/aspeed_gfx_out.c
4f2a8f5898ecd80 Joel Stanley 2019-04-03 28
4f2a8f5898ecd80 Joel Stanley 2019-04-03 29 int aspeed_gfx_create_output(struct drm_device *drm)
4f2a8f5898ecd80 Joel Stanley 2019-04-03 30 {
cd8294540776f79 Daniel Vetter 2020-04-15 31 struct aspeed_gfx *priv = to_aspeed_gfx(drm);
4f2a8f5898ecd80 Joel Stanley 2019-04-03 32 int ret;
4f2a8f5898ecd80 Joel Stanley 2019-04-03 33
4f2a8f5898ecd80 Joel Stanley 2019-04-03 34 priv->connector.dpms = DRM_MODE_DPMS_OFF;
4f2a8f5898ecd80 Joel Stanley 2019-04-03 35 priv->connector.polled = 0;
4f2a8f5898ecd80 Joel Stanley 2019-04-03 36 drm_connector_helper_add(&priv->connector,
4f2a8f5898ecd80 Joel Stanley 2019-04-03 37 &aspeed_gfx_connector_helper_funcs);
4f2a8f5898ecd80 Joel Stanley 2019-04-03 38 ret = drm_connector_init(drm, &priv->connector,
4f2a8f5898ecd80 Joel Stanley 2019-04-03 @39 &aspeed_gfx_connector_funcs,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33949 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RFC] drm/connector: Set the default callback function for drm_connector_funcs
2021-01-08 7:54 [RFC] drm/connector: Set the default callback function for drm_connector_funcs Tian Tao
` (2 preceding siblings ...)
2021-01-08 15:17 ` kernel test robot
@ 2021-01-08 23:32 ` kernel test robot
3 siblings, 0 replies; 7+ messages in thread
From: kernel test robot @ 2021-01-08 23:32 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 6018 bytes --]
Hi Tian,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linus/master]
[also build test WARNING on v5.11-rc2 next-20210108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Tian-Tao/drm-connector-Set-the-default-callback-function-for-drm_connector_funcs/20210108-165753
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f5e6c330254ae691f6d7befe61c786eb5056007e
config: riscv-randconfig-s031-20210108 (attached as .config)
compiler: riscv32-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-208-g46a52ca4-dirty
# https://github.com/0day-ci/linux/commit/37e7ae0ccb8825f7718028991d1635d60323f9dc
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tian-Tao/drm-connector-Set-the-default-callback-function-for-drm_connector_funcs/20210108-165753
git checkout 37e7ae0ccb8825f7718028991d1635d60323f9dc
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"sparse warnings: (new ones prefixed by >>)"
>> drivers/gpu/drm/bridge/sii902x.c:426:35: sparse: sparse: incorrect type in argument 3 (different modifiers) @@ expected struct drm_connector_funcs *funcs @@ got struct drm_connector_funcs const * @@
drivers/gpu/drm/bridge/sii902x.c:426:35: sparse: expected struct drm_connector_funcs *funcs
drivers/gpu/drm/bridge/sii902x.c:426:35: sparse: got struct drm_connector_funcs const *
--
>> drivers/gpu/drm/exynos/exynos_drm_vidi.c:346:26: sparse: sparse: incorrect type in argument 3 (different modifiers) @@ expected struct drm_connector_funcs *funcs @@ got struct drm_connector_funcs const * @@
drivers/gpu/drm/exynos/exynos_drm_vidi.c:346:26: sparse: expected struct drm_connector_funcs *funcs
drivers/gpu/drm/exynos/exynos_drm_vidi.c:346:26: sparse: got struct drm_connector_funcs const *
--
>> drivers/gpu/drm/vc4/vc4_vec.c:364:45: sparse: sparse: incorrect type in argument 3 (different modifiers) @@ expected struct drm_connector_funcs *funcs @@ got struct drm_connector_funcs const * @@
drivers/gpu/drm/vc4/vc4_vec.c:364:45: sparse: expected struct drm_connector_funcs *funcs
drivers/gpu/drm/vc4/vc4_vec.c:364:45: sparse: got struct drm_connector_funcs const *
vim +426 drivers/gpu/drm/bridge/sii902x.c
675605c1c8e6748 Boris Brezillon 2015-12-31 403
a25b988ff83f3ca Laurent Pinchart 2020-02-26 404 static int sii902x_bridge_attach(struct drm_bridge *bridge,
a25b988ff83f3ca Laurent Pinchart 2020-02-26 405 enum drm_bridge_attach_flags flags)
675605c1c8e6748 Boris Brezillon 2015-12-31 406 {
675605c1c8e6748 Boris Brezillon 2015-12-31 407 struct sii902x *sii902x = bridge_to_sii902x(bridge);
675605c1c8e6748 Boris Brezillon 2015-12-31 408 struct drm_device *drm = bridge->dev;
675605c1c8e6748 Boris Brezillon 2015-12-31 409 int ret;
675605c1c8e6748 Boris Brezillon 2015-12-31 410
a25b988ff83f3ca Laurent Pinchart 2020-02-26 411 if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) {
a25b988ff83f3ca Laurent Pinchart 2020-02-26 412 DRM_ERROR("Fix bridge driver to make connector optional!");
a25b988ff83f3ca Laurent Pinchart 2020-02-26 413 return -EINVAL;
a25b988ff83f3ca Laurent Pinchart 2020-02-26 414 }
a25b988ff83f3ca Laurent Pinchart 2020-02-26 415
675605c1c8e6748 Boris Brezillon 2015-12-31 416 drm_connector_helper_add(&sii902x->connector,
675605c1c8e6748 Boris Brezillon 2015-12-31 417 &sii902x_connector_helper_funcs);
675605c1c8e6748 Boris Brezillon 2015-12-31 418
675605c1c8e6748 Boris Brezillon 2015-12-31 419 if (!drm_core_check_feature(drm, DRIVER_ATOMIC)) {
675605c1c8e6748 Boris Brezillon 2015-12-31 420 dev_err(&sii902x->i2c->dev,
ce9971ded5692fa Liu Ying 2017-04-11 421 "sii902x driver is only compatible with DRM devices supporting atomic updates\n");
675605c1c8e6748 Boris Brezillon 2015-12-31 422 return -ENOTSUPP;
675605c1c8e6748 Boris Brezillon 2015-12-31 423 }
675605c1c8e6748 Boris Brezillon 2015-12-31 424
675605c1c8e6748 Boris Brezillon 2015-12-31 425 ret = drm_connector_init(drm, &sii902x->connector,
675605c1c8e6748 Boris Brezillon 2015-12-31 @426 &sii902x_connector_funcs,
675605c1c8e6748 Boris Brezillon 2015-12-31 427 DRM_MODE_CONNECTOR_HDMIA);
675605c1c8e6748 Boris Brezillon 2015-12-31 428 if (ret)
675605c1c8e6748 Boris Brezillon 2015-12-31 429 return ret;
675605c1c8e6748 Boris Brezillon 2015-12-31 430
675605c1c8e6748 Boris Brezillon 2015-12-31 431 if (sii902x->i2c->irq > 0)
675605c1c8e6748 Boris Brezillon 2015-12-31 432 sii902x->connector.polled = DRM_CONNECTOR_POLL_HPD;
675605c1c8e6748 Boris Brezillon 2015-12-31 433 else
675605c1c8e6748 Boris Brezillon 2015-12-31 434 sii902x->connector.polled = DRM_CONNECTOR_POLL_CONNECT;
675605c1c8e6748 Boris Brezillon 2015-12-31 435
cde4c44d8769c1b Daniel Vetter 2018-07-09 436 drm_connector_attach_encoder(&sii902x->connector, bridge->encoder);
675605c1c8e6748 Boris Brezillon 2015-12-31 437
675605c1c8e6748 Boris Brezillon 2015-12-31 438 return 0;
675605c1c8e6748 Boris Brezillon 2015-12-31 439 }
675605c1c8e6748 Boris Brezillon 2015-12-31 440
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38302 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread