From: kernel test robot <lkp@intel.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Matti Vaittinen <mazziesaccount@gmail.com>
Cc: kbuild-all@lists.01.org, Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
linux-kernel@vger.kernel.org, linux-power@fi.rohmeurope.com
Subject: Re: [PATCH 12/15] regulator: Support ROHM BD71815 regulators
Date: Sat, 9 Jan 2021 06:30:04 +0800 [thread overview]
Message-ID: <202101090606.bKDgYGze-lkp@intel.com> (raw)
In-Reply-To: <8eb1ea2fb52e97cdacab6b5944bb43c34e1449c1.1610110144.git.matti.vaittinen@fi.rohmeurope.com>
[-- Attachment #1: Type: text/plain, Size: 3762 bytes --]
Hi Matti,
I love your patch! Perhaps something to improve:
[auto build test WARNING on lee-mfd/for-mfd-next]
[also build test WARNING on regulator/for-next abelloni/rtc-next v5.11-rc2 next-20210108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Matti-Vaittinen/Support-ROHM-BD71815-PMIC/20210108-215230
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: powerpc64-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c84f932f4232b680eb9cc134cf94999bfda0a948
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Matti-Vaittinen/Support-ROHM-BD71815-PMIC/20210108-215230
git checkout c84f932f4232b680eb9cc134cf94999bfda0a948
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/regulator/bd71815-regulator.c:592:5: warning: no previous prototype for 'bd7181x_probe' [-Wmissing-prototypes]
592 | int bd7181x_probe(struct platform_device *pdev)
| ^~~~~~~~~~~~~
vim +/bd7181x_probe +592 drivers/regulator/bd71815-regulator.c
591
> 592 int bd7181x_probe(struct platform_device *pdev)
593 {
594 struct bd71815_pmic *pmic;
595 struct regulator_config config = {};
596 int i, ret;
597 struct gpio_desc *ldo4_en;
598
599 pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL);
600 if (!pmic)
601 return -ENOMEM;
602
603 memcpy(pmic->descs, bd71815_regulators, sizeof(pmic->descs));
604
605 pmic->dev = &pdev->dev;
606 pmic->regmap = dev_get_regmap(pdev->dev.parent, NULL);
607 if (!pmic->regmap) {
608 dev_err(pmic->dev, "No parent regmap\n");
609 return -ENODEV;
610 }
611 platform_set_drvdata(pdev, pmic);
612 ldo4_en = devm_gpiod_get_from_of_node(&pdev->dev,
613 pdev->dev.parent->of_node,
614 "rohm,vsel-gpios", 0,
615 GPIOD_ASIS, "ldo4-en");
616
617 if (IS_ERR(ldo4_en)) {
618 ret = PTR_ERR(ldo4_en);
619 if (ret != -ENOENT)
620 return ret;
621 ldo4_en = NULL;
622 }
623
624 /* Disable to go to ship-mode */
625 ret = regmap_update_bits(pmic->regmap, BD71815_REG_PWRCTRL, RESTARTEN, 0);
626 if (ret)
627 return ret;
628
629 config.dev = pdev->dev.parent;
630 config.regmap = pmic->regmap;
631
632 for (i = 0; i < BD71815_REGULATOR_CNT; i++) {
633 struct regulator_desc *desc;
634 struct regulator_dev *rdev;
635
636 desc = &pmic->descs[i].desc;
637 if (i == BD71815_LDO4)
638 config.ena_gpiod = ldo4_en;
639
640 config.driver_data = pmic;
641
642 rdev = devm_regulator_register(&pdev->dev, desc, &config);
643 if (IS_ERR(rdev)) {
644 dev_err(&pdev->dev,
645 "failed to register %s regulator\n",
646 desc->name);
647 return PTR_ERR(rdev);
648 }
649 config.ena_gpiod = NULL;
650 pmic->rdev[i] = rdev;
651 }
652 return 0;
653 }
654
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 71634 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 12/15] regulator: Support ROHM BD71815 regulators
Date: Sat, 09 Jan 2021 06:30:04 +0800 [thread overview]
Message-ID: <202101090606.bKDgYGze-lkp@intel.com> (raw)
In-Reply-To: <8eb1ea2fb52e97cdacab6b5944bb43c34e1449c1.1610110144.git.matti.vaittinen@fi.rohmeurope.com>
[-- Attachment #1: Type: text/plain, Size: 3868 bytes --]
Hi Matti,
I love your patch! Perhaps something to improve:
[auto build test WARNING on lee-mfd/for-mfd-next]
[also build test WARNING on regulator/for-next abelloni/rtc-next v5.11-rc2 next-20210108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Matti-Vaittinen/Support-ROHM-BD71815-PMIC/20210108-215230
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: powerpc64-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c84f932f4232b680eb9cc134cf94999bfda0a948
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Matti-Vaittinen/Support-ROHM-BD71815-PMIC/20210108-215230
git checkout c84f932f4232b680eb9cc134cf94999bfda0a948
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/regulator/bd71815-regulator.c:592:5: warning: no previous prototype for 'bd7181x_probe' [-Wmissing-prototypes]
592 | int bd7181x_probe(struct platform_device *pdev)
| ^~~~~~~~~~~~~
vim +/bd7181x_probe +592 drivers/regulator/bd71815-regulator.c
591
> 592 int bd7181x_probe(struct platform_device *pdev)
593 {
594 struct bd71815_pmic *pmic;
595 struct regulator_config config = {};
596 int i, ret;
597 struct gpio_desc *ldo4_en;
598
599 pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL);
600 if (!pmic)
601 return -ENOMEM;
602
603 memcpy(pmic->descs, bd71815_regulators, sizeof(pmic->descs));
604
605 pmic->dev = &pdev->dev;
606 pmic->regmap = dev_get_regmap(pdev->dev.parent, NULL);
607 if (!pmic->regmap) {
608 dev_err(pmic->dev, "No parent regmap\n");
609 return -ENODEV;
610 }
611 platform_set_drvdata(pdev, pmic);
612 ldo4_en = devm_gpiod_get_from_of_node(&pdev->dev,
613 pdev->dev.parent->of_node,
614 "rohm,vsel-gpios", 0,
615 GPIOD_ASIS, "ldo4-en");
616
617 if (IS_ERR(ldo4_en)) {
618 ret = PTR_ERR(ldo4_en);
619 if (ret != -ENOENT)
620 return ret;
621 ldo4_en = NULL;
622 }
623
624 /* Disable to go to ship-mode */
625 ret = regmap_update_bits(pmic->regmap, BD71815_REG_PWRCTRL, RESTARTEN, 0);
626 if (ret)
627 return ret;
628
629 config.dev = pdev->dev.parent;
630 config.regmap = pmic->regmap;
631
632 for (i = 0; i < BD71815_REGULATOR_CNT; i++) {
633 struct regulator_desc *desc;
634 struct regulator_dev *rdev;
635
636 desc = &pmic->descs[i].desc;
637 if (i == BD71815_LDO4)
638 config.ena_gpiod = ldo4_en;
639
640 config.driver_data = pmic;
641
642 rdev = devm_regulator_register(&pdev->dev, desc, &config);
643 if (IS_ERR(rdev)) {
644 dev_err(&pdev->dev,
645 "failed to register %s regulator\n",
646 desc->name);
647 return PTR_ERR(rdev);
648 }
649 config.ena_gpiod = NULL;
650 pmic->rdev[i] = rdev;
651 }
652 return 0;
653 }
654
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 71634 bytes --]
next prev parent reply other threads:[~2021-01-08 22:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 13:27 [PATCH 00/15] Support ROHM BD71815 PMIC Matti Vaittinen
2021-01-08 13:29 ` [PATCH 01/15] rtc: bd70528: Do not require parent data Matti Vaittinen
2021-01-08 13:31 ` [PATCH 02/15] clk: BD718x7: Do not depend on parent driver data Matti Vaittinen
2021-01-08 13:32 ` [PATCH 03/15] mfd: bd718x7: simplify by cleaning unnecessary device data Matti Vaittinen
2021-01-08 13:34 ` [PATCH 04/15] dt_bindings: bd71828: Add clock output mode Matti Vaittinen
2021-01-13 13:52 ` Rob Herring
2021-01-13 14:52 ` Matti Vaittinen
2021-01-13 15:52 ` Rob Herring
2021-01-08 13:34 ` [PATCH 05/15] dt_bindings: mfd: Add ROHM BD71815 PMIC Matti Vaittinen
2021-01-11 19:06 ` Rob Herring
2021-01-12 6:14 ` Vaittinen, Matti
2021-01-08 13:36 ` [PATCH 06/15] dt_bindings: regulator: Add ROHM BD71815 PMIC regulators Matti Vaittinen
2021-01-11 19:09 ` Rob Herring
2021-01-12 6:10 ` Matti Vaittinen
2021-01-13 13:53 ` Rob Herring
2021-01-13 14:23 ` Vaittinen, Matti
2021-01-13 15:47 ` Rob Herring
2021-01-08 13:37 ` [PATCH 07/15] mfd: Add ROHM BD71815 ID Matti Vaittinen
2021-01-08 13:37 ` [PATCH 08/15] mfd: Support for ROHM BD71815 PMIC core Matti Vaittinen
2021-01-08 13:39 ` [PATCH 09/15] gpio: support ROHM BD71815 GPOs Matti Vaittinen
2021-01-08 19:28 ` kernel test robot
2021-01-08 19:28 ` kernel test robot
2021-01-09 0:45 ` Linus Walleij
2021-01-11 6:15 ` Vaittinen, Matti
2021-01-11 7:26 ` Vaittinen, Matti
2021-01-08 13:41 ` [PATCH 10/15] regulator: helpers: Export helper voltage listing Matti Vaittinen
2021-01-08 13:42 ` [PATCH 11/15] regulator: rohm-regulator: SNVS dvs and linear voltage support Matti Vaittinen
2021-01-15 8:26 ` Lee Jones
2021-01-15 9:10 ` Vaittinen, Matti
2021-01-15 9:48 ` Matti Vaittinen
2021-01-08 13:43 ` [PATCH 12/15] regulator: Support ROHM BD71815 regulators Matti Vaittinen
2021-01-08 22:30 ` kernel test robot [this message]
2021-01-08 22:30 ` kernel test robot
2021-01-08 13:45 ` [PATCH 13/15] clk: bd718x7: Add support for clk gate on ROHM BD71815 PMIC Matti Vaittinen
2021-01-08 13:46 ` [PATCH 14/15] rtc: bd70528: Support RTC on ROHM BD71815 Matti Vaittinen
2021-01-08 13:46 ` [PATCH 15/15] MAINTAINERS: Add ROHM BD71815AGW Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101090606.bKDgYGze-lkp@intel.com \
--to=lkp@intel.com \
--cc=broonie@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.