* [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset
@ 2021-01-11 15:15 Bruno Thomsen
2021-01-12 17:29 ` Alexandre Belloni
2021-01-18 6:32 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Bruno Thomsen @ 2021-01-11 15:15 UTC (permalink / raw)
To: linux-kernel, devicetree
Cc: Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Bruno Thomsen, Bruno Thomsen,
Uwe Kleine-König, Rasmus Villemoes, Alexandre Belloni
RTC pcf2127 device driver has changed default behaviour of the watchdog
feature in v5.11-rc1. Now you need to explicitly enable it with a
device tree property, "reset-source", when used in the board design.
Fixes: 71ac13457d9d ("rtc: pcf2127: only use watchdog when explicitly available")
Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
Cc: Bruno Thomsen <bth@kamstrup.com>
Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
arch/arm/boot/dts/imx7d-flex-concentrator.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx7d-flex-concentrator.dts b/arch/arm/boot/dts/imx7d-flex-concentrator.dts
index 84b095279e65..bd6b5285aa8d 100644
--- a/arch/arm/boot/dts/imx7d-flex-concentrator.dts
+++ b/arch/arm/boot/dts/imx7d-flex-concentrator.dts
@@ -115,6 +115,7 @@ pcf2127: rtc@0 {
compatible = "nxp,pcf2127";
reg = <0>;
spi-max-frequency = <2000000>;
+ reset-source;
};
};
base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset
2021-01-11 15:15 [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset Bruno Thomsen
@ 2021-01-12 17:29 ` Alexandre Belloni
2021-01-18 6:32 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2021-01-12 17:29 UTC (permalink / raw)
To: Bruno Thomsen
Cc: linux-kernel, devicetree, Shawn Guo, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Bruno Thomsen,
Uwe Kleine-König, Rasmus Villemoes
On 11/01/2021 16:15:37+0100, Bruno Thomsen wrote:
> RTC pcf2127 device driver has changed default behaviour of the watchdog
> feature in v5.11-rc1. Now you need to explicitly enable it with a
> device tree property, "reset-source", when used in the board design.
>
> Fixes: 71ac13457d9d ("rtc: pcf2127: only use watchdog when explicitly available")
>
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> Cc: Bruno Thomsen <bth@kamstrup.com>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> arch/arm/boot/dts/imx7d-flex-concentrator.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx7d-flex-concentrator.dts b/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> index 84b095279e65..bd6b5285aa8d 100644
> --- a/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> +++ b/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> @@ -115,6 +115,7 @@ pcf2127: rtc@0 {
> compatible = "nxp,pcf2127";
> reg = <0>;
> spi-max-frequency = <2000000>;
> + reset-source;
> };
> };
>
>
> base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837
> --
> 2.29.2
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset
2021-01-11 15:15 [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset Bruno Thomsen
2021-01-12 17:29 ` Alexandre Belloni
@ 2021-01-18 6:32 ` Shawn Guo
2021-01-18 8:12 ` Uwe Kleine-König
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2021-01-18 6:32 UTC (permalink / raw)
To: Bruno Thomsen
Cc: linux-kernel, devicetree, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Bruno Thomsen, Uwe Kleine-König,
Rasmus Villemoes, Alexandre Belloni
On Mon, Jan 11, 2021 at 04:15:37PM +0100, Bruno Thomsen wrote:
> RTC pcf2127 device driver has changed default behaviour of the watchdog
> feature in v5.11-rc1. Now you need to explicitly enable it with a
> device tree property, "reset-source", when used in the board design.
It sound that the existing DTBs are broken by this default behaviour
change?
>
> Fixes: 71ac13457d9d ("rtc: pcf2127: only use watchdog when explicitly available")
>
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> Cc: Bruno Thomsen <bth@kamstrup.com>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Applied, thanks.
Shawn
> ---
> arch/arm/boot/dts/imx7d-flex-concentrator.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx7d-flex-concentrator.dts b/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> index 84b095279e65..bd6b5285aa8d 100644
> --- a/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> +++ b/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> @@ -115,6 +115,7 @@ pcf2127: rtc@0 {
> compatible = "nxp,pcf2127";
> reg = <0>;
> spi-max-frequency = <2000000>;
> + reset-source;
> };
> };
>
>
> base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset
2021-01-18 6:32 ` Shawn Guo
@ 2021-01-18 8:12 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2021-01-18 8:12 UTC (permalink / raw)
To: Shawn Guo
Cc: Bruno Thomsen, devicetree, Alexandre Belloni, Rasmus Villemoes,
linux-kernel, Bruno Thomsen, NXP Linux Team,
Pengutronix Kernel Team, Fabio Estevam
[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]
On Mon, Jan 18, 2021 at 02:32:53PM +0800, Shawn Guo wrote:
> On Mon, Jan 11, 2021 at 04:15:37PM +0100, Bruno Thomsen wrote:
> > RTC pcf2127 device driver has changed default behaviour of the watchdog
> > feature in v5.11-rc1. Now you need to explicitly enable it with a
> > device tree property, "reset-source", when used in the board design.
>
> It sound that the existing DTBs are broken by this default behaviour
> change?
I didn't do a representative research, but I expect that there are only
very few machines that have a working watchdog setup using the pcf2127.
All other machines were surprised by commit
0e735eaae165 ("rtc: pcf2127: add watchdog feature support")
because they suddenly had a non-functional watchdog device. The
alternative would be to "fix" the device trees of all these machines to
restore pre-v5.4-rc1 behaviour. This is IMHO worse.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-18 8:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 15:15 [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset Bruno Thomsen
2021-01-12 17:29 ` Alexandre Belloni
2021-01-18 6:32 ` Shawn Guo
2021-01-18 8:12 ` Uwe Kleine-König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.