From: Maxime Ripard <maxime@cerno.tech> To: Andre Przywara <andre.przywara@arm.com> Cc: "Chen-Yu Tsai" <wens@csie.org>, "Jernej Skrabec" <jernej.skrabec@siol.net>, "Icenowy Zheng" <icenowy@aosc.xyz>, "Linus Walleij" <linus.walleij@linaro.org>, "Rob Herring" <robh@kernel.org>, "Clément Péron" <peron.clem@gmail.com>, "Shuosheng Huang" <huangshuosheng@allwinnertech.com>, "Yangtao Li" <tiny.windzz@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 02/21] dt-bindings: pinctrl: Add Allwinner H616 compatible strings Date: Thu, 14 Jan 2021 12:57:45 +0100 [thread overview] Message-ID: <20210114115745.x5cuxmxqllu7b6zl@gilmour> (raw) In-Reply-To: <20210114004512.6cc7bd10@slackpad.fritz.box> [-- Attachment #1: Type: text/plain, Size: 3827 bytes --] On Thu, Jan 14, 2021 at 12:45:12AM +0000, Andre Przywara wrote: > On Mon, 14 Dec 2020 10:37:28 +0100 > Maxime Ripard <maxime@cerno.tech> wrote: > > > On Fri, Dec 11, 2020 at 01:19:15AM +0000, Andre Przywara wrote: > > > A new SoC, a new compatible string. > > > Also we were too miserly with just allowing seven interrupt banks. > > > > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > > --- > > > .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 18 > > > ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > > b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > > index 5240487dfe50..292b05d9ed08 100644 --- > > > a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > > +++ > > > b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > > @@ -53,6 +53,8 @@ properties: > > > - allwinner,sun50i-h5-pinctrl > > > - allwinner,sun50i-h6-pinctrl > > > - allwinner,sun50i-h6-r-pinctrl > > > + - allwinner,sun50i-h616-pinctrl > > > + - allwinner,sun50i-h616-r-pinctrl > > > - allwinner,suniv-f1c100s-pinctrl > > > - nextthing,gr8-pinctrl > > > > > > @@ -61,7 +63,7 @@ properties: > > > > > > interrupts: > > > minItems: 1 > > > - maxItems: 7 > > > + maxItems: 8 > > > description: > > > One interrupt per external interrupt bank supported on the > > > controller, sorted by bank number ascending order. > > > @@ -91,7 +93,7 @@ properties: > > > bank found in the controller > > > $ref: /schemas/types.yaml#/definitions/uint32-array > > > minItems: 1 > > > - maxItems: 5 > > > + maxItems: 8 > > > > > > patternProperties: > > > # It's pretty scary, but the basic idea is that: > > > @@ -145,6 +147,18 @@ allOf: > > > # boards are defining it at the moment so it would generate a > > > lot of # warnings. > > > > > > + - if: > > > + properties: > > > + compatible: > > > + enum: > > > + - allwinner,sun50i-h616-pinctrl > > > + > > > + then: > > > + properties: > > > + interrupts: > > > + minItems: 8 > > > + maxItems: 8 > > > + > > > > You don't need to have both if they are equals, and in this particular > > Mmh, but all the other compatibles have both equal, so what would be > the recommended way to describe this? Just minItems? I don't find a > good explanation at the moment how to handle an explicit number, other > than by enumerating the items explicitly. This is where the magic happens: https://github.com/devicetree-org/dt-schema/blob/master/dtschema/lib.py#L258 So, if there's an items property, it will expand minItems and maxItems according to the length of the list. Else, it will see if there's either minItems and maxItems and set the other one if it's missing. In this case, minItems and maxItems are equals, so you could just fill one of them > > case we already check that the maximum is 8 so there's no need to > > repeat that check here. > > Are you referring to the overall "maxItems: 8" above, in the 2nd hunk? > While this will become redundant, this is apparently prone to changes > (as only "7" would be redundant at the moment), so I would rather not > rely on a global limit. Yeah, my point was that since the upper schema checks for the interrupts array length to be between 1 and 8, there's no need to specify a max of 8, the upper schema has it covered. You're right that the max is increased regularly, however we can still rely on the above logic to fill maxItems to 8 anyway Maxime [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech> To: Andre Przywara <andre.przywara@arm.com> Cc: "Jernej Skrabec" <jernej.skrabec@siol.net>, devicetree@vger.kernel.org, "Yangtao Li" <tiny.windzz@gmail.com>, "Linus Walleij" <linus.walleij@linaro.org>, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, "Chen-Yu Tsai" <wens@csie.org>, "Clément Péron" <peron.clem@gmail.com>, "Icenowy Zheng" <icenowy@aosc.xyz>, "Shuosheng Huang" <huangshuosheng@allwinnertech.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 02/21] dt-bindings: pinctrl: Add Allwinner H616 compatible strings Date: Thu, 14 Jan 2021 12:57:45 +0100 [thread overview] Message-ID: <20210114115745.x5cuxmxqllu7b6zl@gilmour> (raw) In-Reply-To: <20210114004512.6cc7bd10@slackpad.fritz.box> [-- Attachment #1.1: Type: text/plain, Size: 3827 bytes --] On Thu, Jan 14, 2021 at 12:45:12AM +0000, Andre Przywara wrote: > On Mon, 14 Dec 2020 10:37:28 +0100 > Maxime Ripard <maxime@cerno.tech> wrote: > > > On Fri, Dec 11, 2020 at 01:19:15AM +0000, Andre Przywara wrote: > > > A new SoC, a new compatible string. > > > Also we were too miserly with just allowing seven interrupt banks. > > > > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > > --- > > > .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 18 > > > ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > > b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > > index 5240487dfe50..292b05d9ed08 100644 --- > > > a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > > +++ > > > b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > > @@ -53,6 +53,8 @@ properties: > > > - allwinner,sun50i-h5-pinctrl > > > - allwinner,sun50i-h6-pinctrl > > > - allwinner,sun50i-h6-r-pinctrl > > > + - allwinner,sun50i-h616-pinctrl > > > + - allwinner,sun50i-h616-r-pinctrl > > > - allwinner,suniv-f1c100s-pinctrl > > > - nextthing,gr8-pinctrl > > > > > > @@ -61,7 +63,7 @@ properties: > > > > > > interrupts: > > > minItems: 1 > > > - maxItems: 7 > > > + maxItems: 8 > > > description: > > > One interrupt per external interrupt bank supported on the > > > controller, sorted by bank number ascending order. > > > @@ -91,7 +93,7 @@ properties: > > > bank found in the controller > > > $ref: /schemas/types.yaml#/definitions/uint32-array > > > minItems: 1 > > > - maxItems: 5 > > > + maxItems: 8 > > > > > > patternProperties: > > > # It's pretty scary, but the basic idea is that: > > > @@ -145,6 +147,18 @@ allOf: > > > # boards are defining it at the moment so it would generate a > > > lot of # warnings. > > > > > > + - if: > > > + properties: > > > + compatible: > > > + enum: > > > + - allwinner,sun50i-h616-pinctrl > > > + > > > + then: > > > + properties: > > > + interrupts: > > > + minItems: 8 > > > + maxItems: 8 > > > + > > > > You don't need to have both if they are equals, and in this particular > > Mmh, but all the other compatibles have both equal, so what would be > the recommended way to describe this? Just minItems? I don't find a > good explanation at the moment how to handle an explicit number, other > than by enumerating the items explicitly. This is where the magic happens: https://github.com/devicetree-org/dt-schema/blob/master/dtschema/lib.py#L258 So, if there's an items property, it will expand minItems and maxItems according to the length of the list. Else, it will see if there's either minItems and maxItems and set the other one if it's missing. In this case, minItems and maxItems are equals, so you could just fill one of them > > case we already check that the maximum is 8 so there's no need to > > repeat that check here. > > Are you referring to the overall "maxItems: 8" above, in the 2nd hunk? > While this will become redundant, this is apparently prone to changes > (as only "7" would be redundant at the moment), so I would rather not > rely on a global limit. Yeah, my point was that since the upper schema checks for the interrupts array length to be between 1 and 8, there's no need to specify a max of 8, the upper schema has it covered. You're right that the max is increased regularly, however we can still rely on the above logic to fill maxItems to 8 anyway Maxime [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-14 11:58 UTC|newest] Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-11 1:19 [PATCH v2 00/21] arm64: sunxi: Initial Allwinner H616 SoC support Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-11 1:19 ` [PATCH v2 01/21] clk: sunxi-ng: h6: Fix clock divider range on some clocks Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-11 1:19 ` [PATCH v2 02/21] dt-bindings: pinctrl: Add Allwinner H616 compatible strings Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-14 9:37 ` Maxime Ripard 2020-12-14 9:37 ` Maxime Ripard 2021-01-14 0:45 ` Andre Przywara 2021-01-14 0:45 ` Andre Przywara 2021-01-14 11:57 ` Maxime Ripard [this message] 2021-01-14 11:57 ` Maxime Ripard 2020-12-11 1:19 ` [PATCH v2 03/21] pinctrl: sunxi: Add support for the Allwinner H616 pin controller Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-14 9:44 ` Maxime Ripard 2020-12-14 9:44 ` Maxime Ripard 2020-12-11 1:19 ` [PATCH v2 04/21] pinctrl: sunxi: Add support for the Allwinner H616-R " Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-11 1:19 ` [PATCH v2 05/21] dt-bindings: clk: sunxi-ccu: Add compatible string for Allwinner H616 Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-14 22:53 ` Rob Herring 2020-12-14 22:53 ` Rob Herring 2020-12-11 1:19 ` [PATCH v2 06/21] clk: sunxi-ng: Add support for the Allwinner H616 R-CCU Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-11 1:19 ` [PATCH v2 07/21] clk: sunxi-ng: Add support for the Allwinner H616 CCU Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-11 1:19 ` [PATCH v2 08/21] dt-bindings: mmc: sunxi: Add Allwinner A100 and H616 compatibles Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-14 22:54 ` Rob Herring 2020-12-14 22:54 ` Rob Herring 2021-01-11 18:06 ` Ulf Hansson 2021-01-11 18:06 ` Ulf Hansson 2020-12-11 1:19 ` [PATCH v2 09/21] mmc: sunxi: add support for A100 mmc controller Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2021-01-11 18:06 ` Ulf Hansson 2021-01-11 18:06 ` Ulf Hansson 2020-12-11 1:19 ` [PATCH v2 10/21] mfd: axp20x: Allow AXP chips without interrupt lines Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-11 1:19 ` [PATCH v2 11/21] dt-bindings: sram: sunxi-sram: Add H616 compatible string Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-14 22:54 ` Rob Herring 2020-12-14 22:54 ` Rob Herring 2020-12-11 1:19 ` [PATCH v2 12/21] soc: sunxi: sram: Add support for more than one EMAC clock Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-11 1:19 ` [PATCH v2 13/21] net: stmmac: dwmac-sun8i: Prepare for second EMAC clock register Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-11 1:19 ` [PATCH v2 14/21] phy: sun4i-usb: Rework "pmu_unk1" handling Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-13 18:24 ` Icenowy Zheng 2020-12-13 18:24 ` Icenowy Zheng 2020-12-14 1:35 ` André Przywara 2020-12-14 1:35 ` André Przywara 2020-12-14 4:45 ` Icenowy Zheng 2020-12-14 4:45 ` Icenowy Zheng 2020-12-11 1:19 ` [PATCH v2 15/21] phy: sun4i-usb: Add support for the H616 USB PHY Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-14 9:52 ` Maxime Ripard 2020-12-14 9:52 ` Maxime Ripard 2020-12-11 1:19 ` [PATCH v2 16/21] dt-bindings: watchdog: sun4i: Add A100 compatible Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-13 16:12 ` Guenter Roeck 2020-12-13 16:12 ` Guenter Roeck 2020-12-11 1:19 ` [PATCH v2 17/21] dt-bindings: watchdog: sun4i: Add H616 compatible string Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-14 22:55 ` Rob Herring 2020-12-14 22:55 ` Rob Herring 2021-01-23 17:29 ` Guenter Roeck 2021-01-23 17:29 ` Guenter Roeck 2020-12-11 1:19 ` [PATCH v2 18/21] dt-bindings: allwinner: Add H616 compatible strings Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-14 22:56 ` Rob Herring 2020-12-14 22:56 ` Rob Herring 2021-01-05 16:29 ` Wolfram Sang 2021-01-05 16:29 ` Wolfram Sang 2020-12-11 1:19 ` [PATCH v2 19/21] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-14 9:58 ` Maxime Ripard 2020-12-14 9:58 ` Maxime Ripard 2020-12-14 12:53 ` Andre Przywara 2020-12-14 12:53 ` Andre Przywara 2020-12-14 13:28 ` [linux-sunxi] " Chen-Yu Tsai 2020-12-14 13:28 ` Chen-Yu Tsai 2020-12-14 14:14 ` Maxime Ripard 2020-12-14 14:14 ` Maxime Ripard 2020-12-14 14:12 ` Maxime Ripard 2020-12-14 14:12 ` Maxime Ripard 2020-12-11 1:19 ` [PATCH v2 20/21] dt-bindings: arm: sunxi: Add OrangePi Zero 2 binding Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-14 22:56 ` Rob Herring 2020-12-14 22:56 ` Rob Herring 2020-12-11 1:19 ` [PATCH v2 21/21] arm64: dts: allwinner: Add OrangePi Zero 2 .dts Andre Przywara 2020-12-11 1:19 ` Andre Przywara 2020-12-14 9:59 ` Maxime Ripard 2020-12-14 9:59 ` Maxime Ripard 2020-12-13 17:47 ` [PATCH v2 00/21] arm64: sunxi: Initial Allwinner H616 SoC support Icenowy Zheng 2020-12-13 17:47 ` Icenowy Zheng 2020-12-14 1:18 ` André Przywara 2020-12-14 1:18 ` André Przywara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210114115745.x5cuxmxqllu7b6zl@gilmour \ --to=maxime@cerno.tech \ --cc=andre.przywara@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=huangshuosheng@allwinnertech.com \ --cc=icenowy@aosc.xyz \ --cc=jernej.skrabec@siol.net \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=peron.clem@gmail.com \ --cc=robh@kernel.org \ --cc=tiny.windzz@gmail.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.