From: kernel test robot <lkp@intel.com> To: Huaixin Chang <changhuaixin@linux.alibaba.com> Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, bsegall@google.com, dietmar.eggemann@arm.com, juri.lelli@redhat.com, khlebnikov@yandex-team.ru, linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com, pauld@redhead.com, peterz@infradead.org Subject: Re: [PATCH 2/4] sched/fair: Make CFS bandwidth controller burstable Date: Thu, 21 Jan 2021 01:06:15 +0800 [thread overview] Message-ID: <202101210019.rui4gkaD-lkp@intel.com> (raw) In-Reply-To: <20210120122715.29493-3-changhuaixin@linux.alibaba.com> [-- Attachment #1: Type: text/plain, Size: 3957 bytes --] Hi Huaixin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/sched/core] [also build test WARNING on tip/master linux/master linus/master v5.11-rc4 next-20210120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Huaixin-Chang/sched-fair-Introduce-primitives-for-CFS-bandwidth-burst/20210120-212731 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 65bcf072e20ed7597caa902f170f293662b0af3c config: x86_64-randconfig-a001-20210120 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 22b68440e1647e16b5ee24b924986207173c02d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/a62cc8421988be29990ad86e33e877fb8776f8bd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Huaixin-Chang/sched-fair-Introduce-primitives-for-CFS-bandwidth-burst/20210120-212731 git checkout a62cc8421988be29990ad86e33e877fb8776f8bd # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> kernel/sched/fair.c:4623:6: warning: no previous prototype for function '__refill_cfs_bandwidth_runtime' [-Wmissing-prototypes] void __refill_cfs_bandwidth_runtime(struct cfs_bandwidth *cfs_b, u64 overrun) ^ kernel/sched/fair.c:4623:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __refill_cfs_bandwidth_runtime(struct cfs_bandwidth *cfs_b, u64 overrun) ^ static kernel/sched/fair.c:2985:20: warning: unused function 'account_numa_enqueue' [-Wunused-function] static inline void account_numa_enqueue(struct rq *rq, struct task_struct *p) ^ kernel/sched/fair.c:2989:20: warning: unused function 'account_numa_dequeue' [-Wunused-function] static inline void account_numa_dequeue(struct rq *rq, struct task_struct *p) ^ kernel/sched/fair.c:2993:20: warning: unused function 'update_scan_period' [-Wunused-function] static inline void update_scan_period(struct task_struct *p, int new_cpu) ^ kernel/sched/fair.c:4730:19: warning: unused function 'throttled_lb_pair' [-Wunused-function] static inline int throttled_lb_pair(struct task_group *tg, ^ 5 warnings generated. vim +/__refill_cfs_bandwidth_runtime +4623 kernel/sched/fair.c 4615 4616 /* 4617 * Replenish runtime according to assigned quota. We use sched_clock_cpu 4618 * directly instead of rq->clock to avoid adding additional synchronization 4619 * around rq->lock. 4620 * 4621 * requires cfs_b->lock 4622 */ > 4623 void __refill_cfs_bandwidth_runtime(struct cfs_bandwidth *cfs_b, u64 overrun) 4624 { 4625 u64 refill; 4626 4627 if (cfs_b->quota != RUNTIME_INF) { 4628 4629 if (!sysctl_sched_cfs_bw_burst_enabled) { 4630 cfs_b->runtime = cfs_b->quota; 4631 return; 4632 } 4633 4634 overrun = min(overrun, cfs_b->max_overrun); 4635 refill = cfs_b->quota * overrun; 4636 cfs_b->runtime += refill; 4637 cfs_b->runtime = min(cfs_b->runtime, cfs_b->buffer); 4638 } 4639 } 4640 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 43369 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH 2/4] sched/fair: Make CFS bandwidth controller burstable Date: Thu, 21 Jan 2021 01:06:15 +0800 [thread overview] Message-ID: <202101210019.rui4gkaD-lkp@intel.com> (raw) In-Reply-To: <20210120122715.29493-3-changhuaixin@linux.alibaba.com> [-- Attachment #1: Type: text/plain, Size: 4044 bytes --] Hi Huaixin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/sched/core] [also build test WARNING on tip/master linux/master linus/master v5.11-rc4 next-20210120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Huaixin-Chang/sched-fair-Introduce-primitives-for-CFS-bandwidth-burst/20210120-212731 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 65bcf072e20ed7597caa902f170f293662b0af3c config: x86_64-randconfig-a001-20210120 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 22b68440e1647e16b5ee24b924986207173c02d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/a62cc8421988be29990ad86e33e877fb8776f8bd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Huaixin-Chang/sched-fair-Introduce-primitives-for-CFS-bandwidth-burst/20210120-212731 git checkout a62cc8421988be29990ad86e33e877fb8776f8bd # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> kernel/sched/fair.c:4623:6: warning: no previous prototype for function '__refill_cfs_bandwidth_runtime' [-Wmissing-prototypes] void __refill_cfs_bandwidth_runtime(struct cfs_bandwidth *cfs_b, u64 overrun) ^ kernel/sched/fair.c:4623:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void __refill_cfs_bandwidth_runtime(struct cfs_bandwidth *cfs_b, u64 overrun) ^ static kernel/sched/fair.c:2985:20: warning: unused function 'account_numa_enqueue' [-Wunused-function] static inline void account_numa_enqueue(struct rq *rq, struct task_struct *p) ^ kernel/sched/fair.c:2989:20: warning: unused function 'account_numa_dequeue' [-Wunused-function] static inline void account_numa_dequeue(struct rq *rq, struct task_struct *p) ^ kernel/sched/fair.c:2993:20: warning: unused function 'update_scan_period' [-Wunused-function] static inline void update_scan_period(struct task_struct *p, int new_cpu) ^ kernel/sched/fair.c:4730:19: warning: unused function 'throttled_lb_pair' [-Wunused-function] static inline int throttled_lb_pair(struct task_group *tg, ^ 5 warnings generated. vim +/__refill_cfs_bandwidth_runtime +4623 kernel/sched/fair.c 4615 4616 /* 4617 * Replenish runtime according to assigned quota. We use sched_clock_cpu 4618 * directly instead of rq->clock to avoid adding additional synchronization 4619 * around rq->lock. 4620 * 4621 * requires cfs_b->lock 4622 */ > 4623 void __refill_cfs_bandwidth_runtime(struct cfs_bandwidth *cfs_b, u64 overrun) 4624 { 4625 u64 refill; 4626 4627 if (cfs_b->quota != RUNTIME_INF) { 4628 4629 if (!sysctl_sched_cfs_bw_burst_enabled) { 4630 cfs_b->runtime = cfs_b->quota; 4631 return; 4632 } 4633 4634 overrun = min(overrun, cfs_b->max_overrun); 4635 refill = cfs_b->quota * overrun; 4636 cfs_b->runtime += refill; 4637 cfs_b->runtime = min(cfs_b->runtime, cfs_b->buffer); 4638 } 4639 } 4640 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 43369 bytes --]
next prev parent reply other threads:[~2021-01-20 17:16 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-17 7:46 [PATCH 0/4] sched/fair: Burstable CFS bandwidth controller Huaixin Chang 2020-12-17 7:46 ` [PATCH 1/4] sched/fair: Introduce primitives for CFS bandwidth burst Huaixin Chang 2020-12-17 13:36 ` Peter Zijlstra 2020-12-21 13:53 ` changhuaixin 2021-01-12 9:21 ` changhuaixin 2020-12-17 7:46 ` [PATCH 2/4] sched/fair: Make CFS bandwidth controller burstable Huaixin Chang 2020-12-18 9:53 ` kernel test robot 2020-12-18 9:53 ` kernel test robot 2020-12-17 7:46 ` [PATCH 3/4] sched/fair: Add cfs bandwidth burst statistics Huaixin Chang 2020-12-17 7:46 ` [PATCH 4/4] sched/fair: Add document for burstable CFS bandwidth control Huaixin Chang 2020-12-17 21:25 ` [PATCH 0/4] sched/fair: Burstable CFS bandwidth controller Benjamin Segall 2021-01-20 12:27 ` [PATCH v2 " Huaixin Chang 2021-01-20 12:27 ` [PATCH 1/4] sched/fair: Introduce primitives for CFS bandwidth burst Huaixin Chang 2021-01-20 12:27 ` [PATCH 2/4] sched/fair: Make CFS bandwidth controller burstable Huaixin Chang 2021-01-20 17:06 ` kernel test robot [this message] 2021-01-20 17:06 ` kernel test robot 2021-01-20 18:33 ` kernel test robot 2021-01-20 18:33 ` kernel test robot 2021-01-20 22:01 ` kernel test robot 2021-01-20 22:01 ` kernel test robot 2021-01-20 22:01 ` [RFC PATCH] sched/fair: __refill_cfs_bandwidth_runtime() can be static kernel test robot 2021-01-20 22:01 ` kernel test robot 2021-01-20 12:27 ` [PATCH 3/4] sched/fair: Add cfs bandwidth burst statistics Huaixin Chang 2021-01-20 12:27 ` [PATCH 4/4] sched/fair: Add document for burstable CFS bandwidth control Huaixin Chang 2021-01-20 19:48 ` Randy Dunlap 2021-01-21 11:04 ` [PATCH v3 0/4] sched/fair: Burstable CFS bandwidth controller Huaixin Chang 2021-01-21 11:04 ` [PATCH v3 1/4] sched/fair: Introduce primitives for CFS bandwidth burst Huaixin Chang 2021-03-10 12:39 ` Peter Zijlstra 2021-01-21 11:04 ` [PATCH v3 2/4] sched/fair: Make CFS bandwidth controller burstable Huaixin Chang 2021-03-10 13:04 ` Peter Zijlstra 2021-03-12 13:54 ` changhuaixin 2021-03-16 10:55 ` Peter Zijlstra 2021-01-21 11:04 ` [PATCH v3 3/4] sched/fair: Add cfs bandwidth burst statistics Huaixin Chang 2021-03-10 13:10 ` Peter Zijlstra 2021-01-21 11:04 ` [PATCH v3 4/4] sched/fair: Add document for burstable CFS bandwidth control Huaixin Chang 2021-03-10 13:17 ` Peter Zijlstra 2021-01-26 10:18 ` [PATCH v3 0/4] sched/fair: Burstable CFS bandwidth controller changhuaixin 2021-03-10 12:26 ` Peter Zijlstra 2021-02-09 13:17 ` Odin Ugedal 2021-02-09 10:28 ` Tejun Heo 2021-02-27 13:48 ` changhuaixin 2021-03-10 11:11 ` Odin Ugedal 2021-03-12 13:26 ` changhuaixin 2021-02-02 11:40 [PATCH " Huaixin Chang 2021-02-02 11:40 ` [PATCH 2/4] sched/fair: Make CFS bandwidth controller burstable Huaixin Chang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202101210019.rui4gkaD-lkp@intel.com \ --to=lkp@intel.com \ --cc=bsegall@google.com \ --cc=changhuaixin@linux.alibaba.com \ --cc=clang-built-linux@googlegroups.com \ --cc=dietmar.eggemann@arm.com \ --cc=juri.lelli@redhat.com \ --cc=kbuild-all@lists.01.org \ --cc=khlebnikov@yandex-team.ru \ --cc=linux-kernel@vger.kernel.org \ --cc=mgorman@suse.de \ --cc=mingo@redhat.com \ --cc=pauld@redhead.com \ --cc=peterz@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.