From: Leif Lindholm <leif@nuviainc.com>
To: qemu-arm@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Shashi Mallela <shashi.mallela@linaro.org>,
qemu-devel@nongnu.org
Subject: [RFC PATCH 1/4] hw/intc: don't bail out gicv3 model init for revision 4
Date: Sun, 24 Jan 2021 02:53:03 +0000 [thread overview]
Message-ID: <20210124025306.3949-2-leif@nuviainc.com> (raw)
In-Reply-To: <20210124025306.3949-1-leif@nuviainc.com>
As a first step towards GICv4 compatibility, add support for gic revision 4
to GICv3 driver (i.e. don't bail out if revision 4 is encountered).
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
---
hw/intc/arm_gicv3_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/arm_gicv3_common.c b/hw/intc/arm_gicv3_common.c
index 58ef65f589..7365d24873 100644
--- a/hw/intc/arm_gicv3_common.c
+++ b/hw/intc/arm_gicv3_common.c
@@ -315,7 +315,7 @@ static void arm_gicv3_common_realize(DeviceState *dev, Error **errp)
* conditions. However, in future it could be used, for example, if we
* implement GICv4.
*/
- if (s->revision != 3) {
+ if (s->revision != 3 && s->revision != 4) {
error_setg(errp, "unsupported GIC revision %d", s->revision);
return;
}
--
2.20.1
next prev parent reply other threads:[~2021-01-24 2:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 2:53 [RFC PATCH 0/4] hw/intc: enable GICv4 memory layout for GICv3 driver Leif Lindholm
2021-01-24 2:53 ` Leif Lindholm [this message]
2021-02-02 10:34 ` [RFC PATCH 1/4] hw/intc: don't bail out gicv3 model init for revision 4 Peter Maydell
2021-01-24 2:53 ` [RFC PATCH 2/4] hw/intc: add helper function to determine gicv3 redistributor size Leif Lindholm
2021-02-02 10:27 ` Peter Maydell
2021-01-24 2:53 ` [RFC PATCH 3/4] hw/intc: set GICD_TYPER.DVIS for GICv4 Leif Lindholm
2021-02-02 10:34 ` Peter Maydell
2021-01-24 2:53 ` [RFC PATCH 4/4] hw/intc: make gicv3_idreg() distinguish between gicv3/gicv4 Leif Lindholm
2021-02-02 10:31 ` Peter Maydell
2021-02-03 11:36 ` Leif Lindholm
2021-01-24 3:00 ` [RFC PATCH 0/4] hw/intc: enable GICv4 memory layout for GICv3 driver no-reply
2021-02-02 10:39 ` Peter Maydell
2021-02-03 12:26 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124025306.3949-2-leif@nuviainc.com \
--to=leif@nuviainc.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shashi.mallela@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.