* [PATCH 2/5] elfutils: add PACKAGECONFIG for debuginfod
2021-01-24 13:55 [PATCH 1/5] elfutils: split libdebuginfod into its own package Dorinda
@ 2021-01-24 13:55 ` Dorinda
2021-01-24 13:55 ` [PATCH 3/5] elfutils: add support for ipkg Dorinda
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Dorinda @ 2021-01-24 13:55 UTC (permalink / raw)
To: openembedded-core; +Cc: dorindabassey
removed the config option that disabled debuginfod and enabled it with PACKAGECONFIG
Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
---
meta/recipes-devtools/elfutils/elfutils_0.182.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/elfutils/elfutils_0.182.bb b/meta/recipes-devtools/elfutils/elfutils_0.182.bb
index 2666032d24..7b829cc7d5 100644
--- a/meta/recipes-devtools/elfutils/elfutils_0.182.bb
+++ b/meta/recipes-devtools/elfutils/elfutils_0.182.bb
@@ -32,7 +32,7 @@ SRC_URI[sha256sum] = "ecc406914edf335f0b7fc084ebe6c460c4d6d5175bfdd6688c1c78d914
inherit autotools gettext ptest pkgconfig
-EXTRA_OECONF = "--program-prefix=eu- --disable-debuginfod"
+EXTRA_OECONF = "--program-prefix=eu-"
DEPENDS_BZIP2 = "bzip2-replacement-native"
DEPENDS_BZIP2_class-target = "bzip2"
@@ -41,6 +41,7 @@ PACKAGECONFIG ??= ""
PACKAGECONFIG[bzip2] = "--with-bzlib,--without-bzlib,${DEPENDS_BZIP2}"
PACKAGECONFIG[xz] = "--with-lzma,--without-lzma,xz"
PACKAGECONFIG[libdebuginfod] = "--enable-libdebuginfod,--disable-libdebuginfod,curl"
+PACKAGECONFIG[debuginfod] = "--enable-debuginfod,--disable-debuginfod,libarchive sqlite3 libmicrohttpd"
RDEPENDS_${PN}-ptest += "libasm libelf bash make coreutils ${PN}-binutils"
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/5] elfutils: add support for ipkg
2021-01-24 13:55 [PATCH 1/5] elfutils: split libdebuginfod into its own package Dorinda
2021-01-24 13:55 ` [PATCH 2/5] elfutils: add PACKAGECONFIG for debuginfod Dorinda
@ 2021-01-24 13:55 ` Dorinda
2021-01-25 9:01 ` [OE-core] " Quentin Schulz
2021-01-24 13:55 ` [PATCH 4/5] sanity.bbclass: sanity check for bitbake in PATH Dorinda
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Dorinda @ 2021-01-24 13:55 UTC (permalink / raw)
To: openembedded-core; +Cc: dorindabassey
debuginfod scanner 0.181 could only support RPM and scan .debs, it can now scan .ipk
Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
---
.../elfutils/elfutils_0.182.bb | 1 +
...d-support-for-ipkg-to-debuginfod.cxx.patch | 32 +++++++++++++++++++
2 files changed, 33 insertions(+)
create mode 100644 meta/recipes-devtools/elfutils/files/0001-add-support-for-ipkg-to-debuginfod.cxx.patch
diff --git a/meta/recipes-devtools/elfutils/elfutils_0.182.bb b/meta/recipes-devtools/elfutils/elfutils_0.182.bb
index 7b829cc7d5..b3d8c8f8ac 100644
--- a/meta/recipes-devtools/elfutils/elfutils_0.182.bb
+++ b/meta/recipes-devtools/elfutils/elfutils_0.182.bb
@@ -20,6 +20,7 @@ SRC_URI = "https://sourceware.org/elfutils/ftp/${PV}/${BP}.tar.bz2 \
file://run-ptest \
file://ptest.patch \
file://0001-tests-Makefile.am-compile-test_nlist-with-standard-C.patch \
+ file://0001-add-support-for-ipkg-to-debuginfod.cxx.patch \
"
SRC_URI_append_libc-musl = " \
file://0001-musl-obstack-fts.patch \
diff --git a/meta/recipes-devtools/elfutils/files/0001-add-support-for-ipkg-to-debuginfod.cxx.patch b/meta/recipes-devtools/elfutils/files/0001-add-support-for-ipkg-to-debuginfod.cxx.patch
new file mode 100644
index 0000000000..4bb39c91e8
--- /dev/null
+++ b/meta/recipes-devtools/elfutils/files/0001-add-support-for-ipkg-to-debuginfod.cxx.patch
@@ -0,0 +1,32 @@
+From b647d1df55c20772a9cc7ce96fcf323c500481bf Mon Sep 17 00:00:00 2001
+From: dorindabassey <dorindabassey@gmail.com>
+Date: Sat, 19 Dec 2020 01:11:46 +0100
+Subject: [PATCH] add support for ipkg to debuginfod.cxx
+
+added support for ipkg to the debuginfod scanner. 0.181 only supports RPM and scan .debs, with this patch, debuginfod scanner would be able to scan .ipk
+
+Upstream-status: Pending
+
+Signed-off-by: dorindabassey <dorindabassey@gmail.com>
+---
+ debuginfod/debuginfod.cxx | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
+index 5621030..cc78c93 100644
+--- a/debuginfod/debuginfod.cxx
++++ b/debuginfod/debuginfod.cxx
+@@ -442,11 +442,13 @@ parse_opt (int key, char *arg,
+ {
+ scan_archives[".deb"]="dpkg-deb --fsys-tarfile";
+ scan_archives[".ddeb"]="dpkg-deb --fsys-tarfile";
++ scan_archives[".ipk"]="dpkg-deb --fsys-tarfile";
+ }
+ else
+ {
+ scan_archives[".deb"]="(bsdtar -O -x -f - data.tar.xz)<";
+ scan_archives[".ddeb"]="(bsdtar -O -x -f - data.tar.xz)<";
++ scan_archives[".ipk"]="(bsdtar -O -x -f - data.tar.xz)<";
+ }
+ // .udeb too?
+ break;
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [OE-core] [PATCH 3/5] elfutils: add support for ipkg
2021-01-24 13:55 ` [PATCH 3/5] elfutils: add support for ipkg Dorinda
@ 2021-01-25 9:01 ` Quentin Schulz
0 siblings, 0 replies; 11+ messages in thread
From: Quentin Schulz @ 2021-01-25 9:01 UTC (permalink / raw)
To: Dorinda; +Cc: openembedded-core
Hi Dorinda,
On Sun, Jan 24, 2021 at 02:55:57PM +0100, Dorinda wrote:
> debuginfod scanner 0.181 could only support RPM and scan .debs, it can now scan .ipk
>
Typo here? The recipe version is 0.182 not 0.181.
> Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
> ---
> .../elfutils/elfutils_0.182.bb | 1 +
> ...d-support-for-ipkg-to-debuginfod.cxx.patch | 32 +++++++++++++++++++
> 2 files changed, 33 insertions(+)
> create mode 100644 meta/recipes-devtools/elfutils/files/0001-add-support-for-ipkg-to-debuginfod.cxx.patch
>
> diff --git a/meta/recipes-devtools/elfutils/elfutils_0.182.bb b/meta/recipes-devtools/elfutils/elfutils_0.182.bb
> index 7b829cc7d5..b3d8c8f8ac 100644
> --- a/meta/recipes-devtools/elfutils/elfutils_0.182.bb
> +++ b/meta/recipes-devtools/elfutils/elfutils_0.182.bb
> @@ -20,6 +20,7 @@ SRC_URI = "https://sourceware.org/elfutils/ftp/${PV}/${BP}.tar.bz2 \
> file://run-ptest \
> file://ptest.patch \
> file://0001-tests-Makefile.am-compile-test_nlist-with-standard-C.patch \
> + file://0001-add-support-for-ipkg-to-debuginfod.cxx.patch \
> "
> SRC_URI_append_libc-musl = " \
> file://0001-musl-obstack-fts.patch \
> diff --git a/meta/recipes-devtools/elfutils/files/0001-add-support-for-ipkg-to-debuginfod.cxx.patch b/meta/recipes-devtools/elfutils/files/0001-add-support-for-ipkg-to-debuginfod.cxx.patch
> new file mode 100644
> index 0000000000..4bb39c91e8
> --- /dev/null
> +++ b/meta/recipes-devtools/elfutils/files/0001-add-support-for-ipkg-to-debuginfod.cxx.patch
> @@ -0,0 +1,32 @@
> +From b647d1df55c20772a9cc7ce96fcf323c500481bf Mon Sep 17 00:00:00 2001
> +From: dorindabassey <dorindabassey@gmail.com>
> +Date: Sat, 19 Dec 2020 01:11:46 +0100
> +Subject: [PATCH] add support for ipkg to debuginfod.cxx
> +
> +added support for ipkg to the debuginfod scanner. 0.181 only supports RPM and scan .debs, with this patch, debuginfod scanner would be able to scan .ipk
> +
Same here.
> +Upstream-status: Pending
> +
> +Signed-off-by: dorindabassey <dorindabassey@gmail.com>
> +---
> + debuginfod/debuginfod.cxx | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
> +index 5621030..cc78c93 100644
> +--- a/debuginfod/debuginfod.cxx
> ++++ b/debuginfod/debuginfod.cxx
> +@@ -442,11 +442,13 @@ parse_opt (int key, char *arg,
> + {
> + scan_archives[".deb"]="dpkg-deb --fsys-tarfile";
> + scan_archives[".ddeb"]="dpkg-deb --fsys-tarfile";
> ++ scan_archives[".ipk"]="dpkg-deb --fsys-tarfile";
> + }
> + else
> + {
> + scan_archives[".deb"]="(bsdtar -O -x -f - data.tar.xz)<";
> + scan_archives[".ddeb"]="(bsdtar -O -x -f - data.tar.xz)<";
> ++ scan_archives[".ipk"]="(bsdtar -O -x -f - data.tar.xz)<";
> + }
> + // .udeb too?
> + break;
> --
> 2.17.1
>
This looks like a trivial patch, have you sent it to elfutils mailing
list already? Didn't find any mail from you in their archives.
This way you could update the Upstream-status to Submitted and give the
link, that'll make it easier for maintainers of Yocto/this recipe to fix
a failed recipe upgrade (upstream project might decide this patch is not
enough or they want a different implementation, having the whole
discussion easily reachable is usually very helpful).
Thanks,
Quentin
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 4/5] sanity.bbclass: sanity check for bitbake in PATH
2021-01-24 13:55 [PATCH 1/5] elfutils: split libdebuginfod into its own package Dorinda
2021-01-24 13:55 ` [PATCH 2/5] elfutils: add PACKAGECONFIG for debuginfod Dorinda
2021-01-24 13:55 ` [PATCH 3/5] elfutils: add support for ipkg Dorinda
@ 2021-01-24 13:55 ` Dorinda
2021-01-25 9:12 ` [OE-core] " Quentin Schulz
2021-01-24 13:55 ` [PATCH 5/5] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS Dorinda
2021-01-25 8:54 ` [OE-core] [PATCH 1/5] elfutils: split libdebuginfod into its own package Quentin Schulz
4 siblings, 1 reply; 11+ messages in thread
From: Dorinda @ 2021-01-24 13:55 UTC (permalink / raw)
To: openembedded-core; +Cc: dorindabassey
added a sanity check to verify if bitbake is present in PATH
Fixes: https://bugzilla.yoctoproject.org/show_bug.cgi?id=13822#
Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
---
meta/classes/sanity.bbclass | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index d134b40a87..2040b48595 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -787,6 +787,11 @@ def check_sanity_everybuild(status, d):
if "." in paths or "./" in paths or "" in paths:
status.addresult("PATH contains '.', './' or '' (empty element), which will break the build, please remove this.\nParsed PATH is " + str(paths) + "\n")
+ #Check if bitbake is present in path
+ bb_check = bb.utils.which(d.getVar('PATH'), 'bitbake')
+ if not bb_check:
+ bb.warn("bitbake binary is not found in path, did you source the script?")
+
# Check whether 'inherit' directive is found (used for a class to inherit)
# in conf file it's supposed to be uppercase INHERIT
inherit = d.getVar('inherit')
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [OE-core] [PATCH 4/5] sanity.bbclass: sanity check for bitbake in PATH
2021-01-24 13:55 ` [PATCH 4/5] sanity.bbclass: sanity check for bitbake in PATH Dorinda
@ 2021-01-25 9:12 ` Quentin Schulz
0 siblings, 0 replies; 11+ messages in thread
From: Quentin Schulz @ 2021-01-25 9:12 UTC (permalink / raw)
To: Dorinda; +Cc: openembedded-core
Hi Dorinda,
On Sun, Jan 24, 2021 at 02:55:58PM +0100, Dorinda wrote:
> added a sanity check to verify if bitbake is present in PATH
>
> Fixes: https://bugzilla.yoctoproject.org/show_bug.cgi?id=13822#
>
I think the convention is:
[YOCTO #13822]
c.f.: https://wiki.yoctoproject.org/wiki/Bugzilla_Configuration_and_Bug_Tracking
A little word in the commit log and/or comment in the class to explain
how this could happen would be great so one does not have to read the
bugzilla entry to understand why this fix is needed.
> Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
> ---
> meta/classes/sanity.bbclass | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index d134b40a87..2040b48595 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -787,6 +787,11 @@ def check_sanity_everybuild(status, d):
> if "." in paths or "./" in paths or "" in paths:
> status.addresult("PATH contains '.', './' or '' (empty element), which will break the build, please remove this.\nParsed PATH is " + str(paths) + "\n")
>
> + #Check if bitbake is present in path
> + bb_check = bb.utils.which(d.getVar('PATH'), 'bitbake')
> + if not bb_check:
> + bb.warn("bitbake binary is not found in path, did you source the script?")
> +
I'd personally put PATH all uppercase, it is then obvious we're talking
about the PATH environment variable used to locate executables.
That's just me nitpicking however.
Otherwise, I don't think this patch is needed by the rest of the patch
series? If I'm correct, then ideally you should have sent it as part of
a second patch series or just sent it directly to the mailing list.
Usually a patch series is for a bug fix or a new feature, or follows a
specific theme (e.g. backports from one release to another, or
straightforward recipe upgrades). If the feature requires a bug fix,
then you add the bug fix to the feature patch series.
If you have multiple themes, unrelated bug fixes or features, it's
usually better to have separate patch series so that if there's a
discussion about one particular patch, the other patches can still be
merged fast by maintainers (easier to keep track which patches are
merged by just not merging any patch of a series which is under
discussion).
Thanks,
Quentin
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 5/5] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS
2021-01-24 13:55 [PATCH 1/5] elfutils: split libdebuginfod into its own package Dorinda
` (2 preceding siblings ...)
2021-01-24 13:55 ` [PATCH 4/5] sanity.bbclass: sanity check for bitbake in PATH Dorinda
@ 2021-01-24 13:55 ` Dorinda
2021-01-25 9:21 ` [OE-core] " Quentin Schulz
2021-01-25 8:54 ` [OE-core] [PATCH 1/5] elfutils: split libdebuginfod into its own package Quentin Schulz
4 siblings, 1 reply; 11+ messages in thread
From: Dorinda @ 2021-01-24 13:55 UTC (permalink / raw)
To: openembedded-core; +Cc: dorindabassey
added a check to ensure that a user isn't building in PSEUDO_IGNORE_PATHS
Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
---
meta/classes/sanity.bbclass | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 2040b48595..78c0343f0d 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -703,6 +703,13 @@ def check_sanity_version_change(status, d):
if (tmpdirmode & stat.S_ISUID):
status.addresult("TMPDIR is setuid, please don't build in a setuid directory")
+ # Check that user isn't building in PSEUDO_IGNORE_PATHS
+ pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS', expand=True).split(",")
+ workdir = d.getVar('WORKDIR', expand=True)
+ for i in pseudoignorepaths:
+ if workdir.startswith(i):
+ status.addresult("you are building in a path under PSEUDO_IGNORE_PATHS, please remove this" + str(i) + "directory in \nParsed WORKDIR: " + str(workdir) + "\n")
+
# Some third-party software apparently relies on chmod etc. being suid root (!!)
import stat
suid_check_bins = "chown chmod mknod".split()
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [OE-core] [PATCH 5/5] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS
2021-01-24 13:55 ` [PATCH 5/5] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS Dorinda
@ 2021-01-25 9:21 ` Quentin Schulz
2021-01-25 14:58 ` Peter Kjellerstedt
0 siblings, 1 reply; 11+ messages in thread
From: Quentin Schulz @ 2021-01-25 9:21 UTC (permalink / raw)
To: Dorinda; +Cc: openembedded-core
Hi Dorinda,
On Sun, Jan 24, 2021 at 02:55:59PM +0100, Dorinda wrote:
> added a check to ensure that a user isn't building in PSEUDO_IGNORE_PATHS
>
Missing [YOCTO #14179] tag I think :)
> Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
> ---
> meta/classes/sanity.bbclass | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 2040b48595..78c0343f0d 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -703,6 +703,13 @@ def check_sanity_version_change(status, d):
> if (tmpdirmode & stat.S_ISUID):
> status.addresult("TMPDIR is setuid, please don't build in a setuid directory")
>
> + # Check that user isn't building in PSEUDO_IGNORE_PATHS
> + pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS', expand=True).split(",")
> + workdir = d.getVar('WORKDIR', expand=True)
> + for i in pseudoignorepaths:
> + if workdir.startswith(i):
> + status.addresult("you are building in a path under PSEUDO_IGNORE_PATHS, please remove this" + str(i) + "directory in \nParsed WORKDIR: " + str(workdir) + "\n")
Capital Y for the beginning of the sentence?
Missing space before and after str(i).
I'm not familiar with this part of the code, so forgive me if this is
wrong but... is your sentence finished?
You are building in a path under PSEUDO_IGNORE_PATHS, please remove this <dir> directory in
Parsed WORKDIR: <workdir>
That is to me not very telling about what I should do to fix this issue.
I honestly might be missing a lot of context on the issue so wouldn't be
surprised if the issue is with me not understanding the sentence more
than the sentence being "unfinished".
Thanks,
Quentin
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [OE-core] [PATCH 5/5] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS
2021-01-25 9:21 ` [OE-core] " Quentin Schulz
@ 2021-01-25 14:58 ` Peter Kjellerstedt
2021-01-25 22:53 ` Dorinda
0 siblings, 1 reply; 11+ messages in thread
From: Peter Kjellerstedt @ 2021-01-25 14:58 UTC (permalink / raw)
To: Quentin Schulz, Dorinda; +Cc: openembedded-core
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Quentin Schulz
> Sent: den 25 januari 2021 10:22
> To: Dorinda <dorindabassey@gmail.com>
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 5/5] sanity.bbclass: verify that user isn't
> building in PSEUDO_IGNORE_PATHS
>
> Hi Dorinda,
>
> On Sun, Jan 24, 2021 at 02:55:59PM +0100, Dorinda wrote:
> > added a check to ensure that a user isn't building in
> PSEUDO_IGNORE_PATHS
> >
>
> Missing [YOCTO #14179] tag I think :)
>
> > Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
> > ---
> > meta/classes/sanity.bbclass | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> > index 2040b48595..78c0343f0d 100644
> > --- a/meta/classes/sanity.bbclass
> > +++ b/meta/classes/sanity.bbclass
> > @@ -703,6 +703,13 @@ def check_sanity_version_change(status, d):
> > if (tmpdirmode & stat.S_ISUID):
> > status.addresult("TMPDIR is setuid, please don't build in a setuid directory")
> >
> > + # Check that user isn't building in PSEUDO_IGNORE_PATHS
> > + pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS', expand=True).split(",")
> > + workdir = d.getVar('WORKDIR', expand=True)
> > + for i in pseudoignorepaths:
> > + if workdir.startswith(i):
PSEUDO_IGNORE_PATHS may contain empty paths (i.e., from multiple
consecutive commas, or a trailing commas). Pseudo will ignore these
paths, so this code should ignore them too:
if i and workdir.startswith(i):
> > + status.addresult("you are building in a path under PSEUDO_IGNORE_PATHS, please remove this" + str(i) + "directory in \nParsed WORKDIR: " + str(workdir) + "\n")
>
> Capital Y for the beginning of the sentence?
>
> Missing space before and after str(i).
>
> I'm not familiar with this part of the code, so forgive me if this is
> wrong but... is your sentence finished?
>
> You are building in a path under PSEUDO_IGNORE_PATHS, please remove this <dir> directory in
> Parsed WORKDIR: <workdir>
>
> That is to me not very telling about what I should do to fix this issue.
>
> I honestly might be missing a lot of context on the issue so wouldn't be
> surprised if the issue is with me not understanding the sentence more
> than the sentence being "unfinished".
No, I don't think you are wrong. I do not understand it either.
> Thanks,
> Quentin
//Peter
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [OE-core] [PATCH 5/5] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS
2021-01-25 14:58 ` Peter Kjellerstedt
@ 2021-01-25 22:53 ` Dorinda
0 siblings, 0 replies; 11+ messages in thread
From: Dorinda @ 2021-01-25 22:53 UTC (permalink / raw)
To: Peter Kjellerstedt; +Cc: quentin.schulz, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2873 bytes --]
Thanks for the feedbacks, will update the patch.
Dorinda
On Jan 25, 2021 3:58 PM, "Peter Kjellerstedt" <peter.kjellerstedt@axis.com>
wrote:
> > -----Original Message-----
> > From: openembedded-core@lists.openembedded.org <openembedded-
> > core@lists.openembedded.org> On Behalf Of Quentin Schulz
> > Sent: den 25 januari 2021 10:22
> > To: Dorinda <dorindabassey@gmail.com>
> > Cc: openembedded-core@lists.openembedded.org
> > Subject: Re: [OE-core] [PATCH 5/5] sanity.bbclass: verify that user isn't
> > building in PSEUDO_IGNORE_PATHS
> >
> > Hi Dorinda,
> >
> > On Sun, Jan 24, 2021 at 02:55:59PM +0100, Dorinda wrote:
> > > added a check to ensure that a user isn't building in
> > PSEUDO_IGNORE_PATHS
> > >
> >
> > Missing [YOCTO #14179] tag I think :)
> >
> > > Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
> > > ---
> > > meta/classes/sanity.bbclass | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> > > index 2040b48595..78c0343f0d 100644
> > > --- a/meta/classes/sanity.bbclass
> > > +++ b/meta/classes/sanity.bbclass
> > > @@ -703,6 +703,13 @@ def check_sanity_version_change(status, d):
> > > if (tmpdirmode & stat.S_ISUID):
> > > status.addresult("TMPDIR is setuid, please don't build in a
> setuid directory")
> > >
> > > + # Check that user isn't building in PSEUDO_IGNORE_PATHS
> > > + pseudoignorepaths = d.getVar('PSEUDO_IGNORE_PATHS',
> expand=True).split(",")
> > > + workdir = d.getVar('WORKDIR', expand=True)
> > > + for i in pseudoignorepaths:
> > > + if workdir.startswith(i):
>
> PSEUDO_IGNORE_PATHS may contain empty paths (i.e., from multiple
> consecutive commas, or a trailing commas). Pseudo will ignore these
> paths, so this code should ignore them too:
>
> if i and workdir.startswith(i):
>
> > > + status.addresult("you are building in a path under
> PSEUDO_IGNORE_PATHS, please remove this" + str(i) + "directory in \nParsed
> WORKDIR: " + str(workdir) + "\n")
> >
> > Capital Y for the beginning of the sentence?
> >
> > Missing space before and after str(i).
> >
> > I'm not familiar with this part of the code, so forgive me if this is
> > wrong but... is your sentence finished?
> >
> > You are building in a path under PSEUDO_IGNORE_PATHS, please remove this
> <dir> directory in
> > Parsed WORKDIR: <workdir>
> >
> > That is to me not very telling about what I should do to fix this issue.
> >
> > I honestly might be missing a lot of context on the issue so wouldn't be
> > surprised if the issue is with me not understanding the sentence more
> > than the sentence being "unfinished".
>
> No, I don't think you are wrong. I do not understand it either.
>
> > Thanks,
> > Quentin
>
> //Peter
>
>
[-- Attachment #2: Type: text/html, Size: 4019 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [OE-core] [PATCH 1/5] elfutils: split libdebuginfod into its own package
2021-01-24 13:55 [PATCH 1/5] elfutils: split libdebuginfod into its own package Dorinda
` (3 preceding siblings ...)
2021-01-24 13:55 ` [PATCH 5/5] sanity.bbclass: verify that user isn't building in PSEUDO_IGNORE_PATHS Dorinda
@ 2021-01-25 8:54 ` Quentin Schulz
4 siblings, 0 replies; 11+ messages in thread
From: Quentin Schulz @ 2021-01-25 8:54 UTC (permalink / raw)
To: Dorinda; +Cc: openembedded-core
Hi Dorinda,
On Sun, Jan 24, 2021 at 02:55:55PM +0100, Dorinda wrote:
> add package options for libdebuginfod
>
> Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
> ---
> meta/recipes-devtools/elfutils/elfutils_0.182.bb | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/elfutils/elfutils_0.182.bb b/meta/recipes-devtools/elfutils/elfutils_0.182.bb
> index f63208d72b..2666032d24 100644
> --- a/meta/recipes-devtools/elfutils/elfutils_0.182.bb
> +++ b/meta/recipes-devtools/elfutils/elfutils_0.182.bb
> @@ -1,7 +1,7 @@
> SUMMARY = "Utilities and libraries for handling compiled object files"
> HOMEPAGE = "https://sourceware.org/elfutils"
> SECTION = "base"
> -LICENSE = "GPLv2 & LGPLv3+ & GPLv3+"
> +LICENSE = "GPLv2 & GPLv2+ & LGPLv3+ & GPLv3+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
A change in LICENSE but not in LIC_FILES_CHKSUM is very unusual and
usually tells us that something was missed.
Having quickly checked in the git repo, indeed,
https://sourceware.org/git/?p=elfutils.git;a=blob;f=debuginfod/debuginfod-client.c
and the header are GPLv2+ | LGPLv3+.
What I recommend is adding either the c file or the header to
LIC_FILES_CHKSUM (only the commented part which contains the licenses;
check for the begin/end arguments in LIC_FILES_CHKSUM).
That way, if there's any change to this file's license, Yocto will
refuse to build the package until the license is fixed, which is what we
want.
Please explain also in the commit log why the recipe license has changed
with a short sentence.
Thanks,
Quentin
^ permalink raw reply [flat|nested] 11+ messages in thread