From: Jason Gunthorpe <jgg@nvidia.com>
To: "Saleem, Shiraz" <shiraz.saleem@intel.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Ertman, David M" <david.m.ertman@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Ismail, Mustafa" <mustafa.ismail@intel.com>
Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs
Date: Mon, 25 Jan 2021 20:59:28 -0400 [thread overview]
Message-ID: <20210126005928.GF4147@nvidia.com> (raw)
In-Reply-To: <99895f7c10a2473c84a105f46c7ef498@intel.com>
On Tue, Jan 26, 2021 at 12:42:16AM +0000, Saleem, Shiraz wrote:
> I think this essentially means doing away with .open/.close piece.
Yes, that too, and probably the FSM as well.
> Or are you saying that is ok? Yes we had a discussion in the past
> and I thought we concluded. But maybe I misunderstood.
>
> https://lore.kernel.org/linux-rdma/9DD61F30A802C4429A01CA4200E302A7DCD4FD03@fmsmsx124.amr.corp.intel.com/
Well, having now seen how aux bus ended up and the way it effected the
mlx5 driver, I am more firmly of the opinion this needs to be
fixed. It is extremly hard to get everything right with two different
registration schemes running around.
You never answered my question:
> Still, you need to be able to cope with the user unbinding your
> drivers in any order via sysfs. What happens to the VFs when the PF is
> unbound and releases whatever resources? This is where the broadcom
> driver ran into troubles..
?
> PF due to underlying config changes which require a
> de-reg/re-registration of the ibdevice. Today such config changes
> are handled with the netdev PCI driver using the .close() private
> callback into rdma driver which unregister ibdevice in PF while
> allowing the RDMA VF to survive.
Putting resources the device needs to function in the aux driver is no
good, managing shared resources is the role of the PCI function owning
core driver.
If you put the open/close on the aux device_driver struct and got rid
of the redundant life cycle stuff, it might be OK enough, assuming
there is a good answer to the question above.
Jason
next prev parent reply other threads:[~2021-01-26 5:39 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 23:48 [PATCH 00/22] Add Intel Ethernet Protocol Driver for RDMA (irdma) Shiraz Saleem
2021-01-22 23:48 ` [PATCH 01/22] iidc: Introduce iidc.h Shiraz Saleem
2021-01-22 23:48 ` [PATCH 02/22] ice: Initialize RDMA support Shiraz Saleem
2021-01-22 23:48 ` [PATCH 03/22] ice: Implement iidc operations Shiraz Saleem
2021-01-22 23:48 ` [PATCH 04/22] ice: Register auxiliary device to provide RDMA Shiraz Saleem
2021-01-25 19:09 ` Jason Gunthorpe
2021-02-05 15:23 ` Saleem, Shiraz
2021-02-05 15:27 ` Jason Gunthorpe
2021-01-22 23:48 ` [PATCH 05/22] i40e: Prep i40e header for aux bus conversion Shiraz Saleem
2021-01-22 23:48 ` [PATCH 06/22] i40e: Register auxiliary devices to provide RDMA Shiraz Saleem
2021-01-22 23:48 ` [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs Shiraz Saleem
2021-01-24 13:45 ` Leon Romanovsky
2021-01-25 13:28 ` Jason Gunthorpe
2021-01-25 20:52 ` Jakub Kicinski
2021-01-26 0:39 ` Saleem, Shiraz
2021-01-26 0:47 ` Jason Gunthorpe
2021-01-26 0:57 ` Keller, Jacob E
2021-01-26 1:01 ` Jacob Keller
2021-01-26 1:10 ` Jason Gunthorpe
2021-01-27 0:42 ` Saleem, Shiraz
2021-01-27 2:44 ` Jason Gunthorpe
2021-01-30 1:19 ` Saleem, Shiraz
2021-01-26 5:29 ` Leon Romanovsky
2021-01-26 22:07 ` Jacob Keller
2021-01-27 1:02 ` Saleem, Shiraz
2021-01-26 0:39 ` Saleem, Shiraz
2021-01-25 18:42 ` Jason Gunthorpe
2021-01-26 0:42 ` Saleem, Shiraz
2021-01-26 0:59 ` Jason Gunthorpe [this message]
2021-01-27 0:41 ` Saleem, Shiraz
2021-01-27 12:18 ` Leon Romanovsky
2021-01-27 22:17 ` Saleem, Shiraz
2021-01-27 23:16 ` Jason Gunthorpe
2021-01-28 5:41 ` Leon Romanovsky
2021-01-30 1:19 ` Saleem, Shiraz
2021-02-01 6:09 ` Leon Romanovsky
2021-02-01 19:18 ` Jason Gunthorpe
2021-02-02 0:40 ` Saleem, Shiraz
2021-02-02 1:06 ` Dan Williams
2021-02-02 17:14 ` Jason Gunthorpe
2021-02-02 19:42 ` Saleem, Shiraz
2021-02-02 23:17 ` Jason Gunthorpe
2021-02-01 19:21 ` Jason Gunthorpe
2021-01-26 5:37 ` Leon Romanovsky
2021-01-30 1:19 ` Saleem, Shiraz
2021-02-01 19:19 ` Jason Gunthorpe
2021-01-25 19:16 ` Jason Gunthorpe
2021-01-30 1:19 ` Saleem, Shiraz
2021-01-22 23:48 ` [PATCH 08/22] RDMA/irdma: Implement device initialization definitions Shiraz Saleem
2021-01-22 23:48 ` [PATCH 09/22] RDMA/irdma: Implement HW Admin Queue OPs Shiraz Saleem
2021-01-25 19:23 ` Jason Gunthorpe
2021-01-27 0:41 ` Saleem, Shiraz
2021-01-27 2:41 ` Jason Gunthorpe
2021-01-30 1:18 ` Saleem, Shiraz
2021-01-22 23:48 ` [PATCH 10/22] RDMA/irdma: Add HMC backing store setup functions Shiraz Saleem
2021-01-22 23:48 ` [PATCH 11/22] RDMA/irdma: Add privileged UDA queue implementation Shiraz Saleem
2021-01-22 23:48 ` [PATCH 12/22] RDMA/irdma: Add QoS definitions Shiraz Saleem
2021-01-22 23:48 ` [PATCH 13/22] RDMA/irdma: Add connection manager Shiraz Saleem
2021-01-22 23:48 ` [PATCH 14/22] RDMA/irdma: Add PBLE resource manager Shiraz Saleem
2021-01-22 23:48 ` [PATCH 15/22] RDMA/irdma: Implement device supported verb APIs Shiraz Saleem
2021-01-24 14:18 ` Leon Romanovsky
2021-01-27 1:04 ` Saleem, Shiraz
2021-01-22 23:48 ` [PATCH 16/22] RDMA/irdma: Add RoCEv2 UD OP support Shiraz Saleem
2021-01-22 23:48 ` [PATCH 17/22] RDMA/irdma: Add user/kernel shared libraries Shiraz Saleem
2021-01-22 23:48 ` [PATCH 18/22] RDMA/irdma: Add miscellaneous utility definitions Shiraz Saleem
2021-01-25 19:37 ` Jason Gunthorpe
2021-01-22 23:48 ` [PATCH 19/22] RDMA/irdma: Add dynamic tracing for CM Shiraz Saleem
2021-01-22 23:48 ` [PATCH 20/22] RDMA/irdma: Add ABI definitions Shiraz Saleem
2021-01-25 19:45 ` Jason Gunthorpe
2021-01-30 1:18 ` Saleem, Shiraz
2021-02-01 19:21 ` Jason Gunthorpe
2021-02-05 20:12 ` Saleem, Shiraz
2021-01-22 23:48 ` [PATCH 21/22] RDMA/irdma: Add irdma Kconfig/Makefile and remove i40iw Shiraz Saleem
2021-01-25 18:50 ` Jason Gunthorpe
2021-01-26 0:39 ` Saleem, Shiraz
2021-01-26 5:47 ` Leon Romanovsky
2021-01-22 23:48 ` [PATCH 22/22] RDMA/irdma: Update MAINTAINERS file Shiraz Saleem
2021-01-25 13:29 ` [PATCH 00/22] Add Intel Ethernet Protocol Driver for RDMA (irdma) Jason Gunthorpe
2021-01-25 18:44 ` Jason Gunthorpe
2021-01-26 0:39 ` Saleem, Shiraz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126005928.GF4147@nvidia.com \
--to=jgg@nvidia.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.