From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Ertman, David M" <david.m.ertman@intel.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Ismail, Mustafa" <mustafa.ismail@intel.com>
Subject: RE: [PATCH 20/22] RDMA/irdma: Add ABI definitions
Date: Fri, 5 Feb 2021 20:12:28 +0000 [thread overview]
Message-ID: <95c86ea5f5e94d068e6e0467ccba33a0@intel.com> (raw)
In-Reply-To: <20210201192121.GQ4247@nvidia.com>
> Subject: Re: [PATCH 20/22] RDMA/irdma: Add ABI definitions
>
> On Sat, Jan 30, 2021 at 01:18:36AM +0000, Saleem, Shiraz wrote:
> > > Subject: Re: [PATCH 20/22] RDMA/irdma: Add ABI definitions
> > >
> > > On Fri, Jan 22, 2021 at 05:48:25PM -0600, Shiraz Saleem wrote:
> > > > From: Mustafa Ismail <mustafa.ismail@intel.com>
> > > >
> > > > Add ABI definitions for irdma.
> > > >
> > > > Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
> > > > Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
> > > > include/uapi/rdma/irdma-abi.h | 140
> > > > ++++++++++++++++++++++++++++++++++++++++++
> > > > 1 file changed, 140 insertions(+) create mode 100644
> > > > include/uapi/rdma/irdma-abi.h
> > > >
> > > > diff --git a/include/uapi/rdma/irdma-abi.h
> > > > b/include/uapi/rdma/irdma-abi.h new file mode 100644 index
> > > > 0000000..d9c8ce1
> > > > +++ b/include/uapi/rdma/irdma-abi.h
> > > > @@ -0,0 +1,140 @@
> > > > +/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR
> > > > +Linux-OpenIB) */
> > > > +/*
> > > > + * Copyright (c) 2006 - 2021 Intel Corporation. All rights reserved.
> > > > + * Copyright (c) 2005 Topspin Communications. All rights reserved.
> > > > + * Copyright (c) 2005 Cisco Systems. All rights reserved.
> > > > + * Copyright (c) 2005 Open Grid Computing, Inc. All rights reserved.
> > > > + */
> > > > +
> > > > +#ifndef IRDMA_ABI_H
> > > > +#define IRDMA_ABI_H
> > > > +
> > > > +#include <linux/types.h>
> > > > +
> > > > +/* irdma must support legacy GEN_1 i40iw kernel
> > > > + * and user-space whose last ABI ver is 5 */ #define
> > > > +IRDMA_ABI_VER 6
> > >
> > > I don't want to see this value increase, either this is ABI
> > > compatible with i40iw or it is not and should be a new driver_id.
> >
> > I am not sure I understand how it's possible without a ver. bump.
> > We support user-space libirdma with this driver as well as libi40iw.
>
> Well, start by not making gratuitous changes to the structure layouts and then ask
> how to handle what you have left over.
>
Took a while but following now. We ll PoC and see how this shapes out. Thanks!
next prev parent reply other threads:[~2021-02-05 20:15 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 23:48 [PATCH 00/22] Add Intel Ethernet Protocol Driver for RDMA (irdma) Shiraz Saleem
2021-01-22 23:48 ` [PATCH 01/22] iidc: Introduce iidc.h Shiraz Saleem
2021-01-22 23:48 ` [PATCH 02/22] ice: Initialize RDMA support Shiraz Saleem
2021-01-22 23:48 ` [PATCH 03/22] ice: Implement iidc operations Shiraz Saleem
2021-01-22 23:48 ` [PATCH 04/22] ice: Register auxiliary device to provide RDMA Shiraz Saleem
2021-01-25 19:09 ` Jason Gunthorpe
2021-02-05 15:23 ` Saleem, Shiraz
2021-02-05 15:27 ` Jason Gunthorpe
2021-01-22 23:48 ` [PATCH 05/22] i40e: Prep i40e header for aux bus conversion Shiraz Saleem
2021-01-22 23:48 ` [PATCH 06/22] i40e: Register auxiliary devices to provide RDMA Shiraz Saleem
2021-01-22 23:48 ` [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs Shiraz Saleem
2021-01-24 13:45 ` Leon Romanovsky
2021-01-25 13:28 ` Jason Gunthorpe
2021-01-25 20:52 ` Jakub Kicinski
2021-01-26 0:39 ` Saleem, Shiraz
2021-01-26 0:47 ` Jason Gunthorpe
2021-01-26 0:57 ` Keller, Jacob E
2021-01-26 1:01 ` Jacob Keller
2021-01-26 1:10 ` Jason Gunthorpe
2021-01-27 0:42 ` Saleem, Shiraz
2021-01-27 2:44 ` Jason Gunthorpe
2021-01-30 1:19 ` Saleem, Shiraz
2021-01-26 5:29 ` Leon Romanovsky
2021-01-26 22:07 ` Jacob Keller
2021-01-27 1:02 ` Saleem, Shiraz
2021-01-26 0:39 ` Saleem, Shiraz
2021-01-25 18:42 ` Jason Gunthorpe
2021-01-26 0:42 ` Saleem, Shiraz
2021-01-26 0:59 ` Jason Gunthorpe
2021-01-27 0:41 ` Saleem, Shiraz
2021-01-27 12:18 ` Leon Romanovsky
2021-01-27 22:17 ` Saleem, Shiraz
2021-01-27 23:16 ` Jason Gunthorpe
2021-01-28 5:41 ` Leon Romanovsky
2021-01-30 1:19 ` Saleem, Shiraz
2021-02-01 6:09 ` Leon Romanovsky
2021-02-01 19:18 ` Jason Gunthorpe
2021-02-02 0:40 ` Saleem, Shiraz
2021-02-02 1:06 ` Dan Williams
2021-02-02 17:14 ` Jason Gunthorpe
2021-02-02 19:42 ` Saleem, Shiraz
2021-02-02 23:17 ` Jason Gunthorpe
2021-02-01 19:21 ` Jason Gunthorpe
2021-01-26 5:37 ` Leon Romanovsky
2021-01-30 1:19 ` Saleem, Shiraz
2021-02-01 19:19 ` Jason Gunthorpe
2021-01-25 19:16 ` Jason Gunthorpe
2021-01-30 1:19 ` Saleem, Shiraz
2021-01-22 23:48 ` [PATCH 08/22] RDMA/irdma: Implement device initialization definitions Shiraz Saleem
2021-01-22 23:48 ` [PATCH 09/22] RDMA/irdma: Implement HW Admin Queue OPs Shiraz Saleem
2021-01-25 19:23 ` Jason Gunthorpe
2021-01-27 0:41 ` Saleem, Shiraz
2021-01-27 2:41 ` Jason Gunthorpe
2021-01-30 1:18 ` Saleem, Shiraz
2021-01-22 23:48 ` [PATCH 10/22] RDMA/irdma: Add HMC backing store setup functions Shiraz Saleem
2021-01-22 23:48 ` [PATCH 11/22] RDMA/irdma: Add privileged UDA queue implementation Shiraz Saleem
2021-01-22 23:48 ` [PATCH 12/22] RDMA/irdma: Add QoS definitions Shiraz Saleem
2021-01-22 23:48 ` [PATCH 13/22] RDMA/irdma: Add connection manager Shiraz Saleem
2021-01-22 23:48 ` [PATCH 14/22] RDMA/irdma: Add PBLE resource manager Shiraz Saleem
2021-01-22 23:48 ` [PATCH 15/22] RDMA/irdma: Implement device supported verb APIs Shiraz Saleem
2021-01-24 14:18 ` Leon Romanovsky
2021-01-27 1:04 ` Saleem, Shiraz
2021-01-22 23:48 ` [PATCH 16/22] RDMA/irdma: Add RoCEv2 UD OP support Shiraz Saleem
2021-01-22 23:48 ` [PATCH 17/22] RDMA/irdma: Add user/kernel shared libraries Shiraz Saleem
2021-01-22 23:48 ` [PATCH 18/22] RDMA/irdma: Add miscellaneous utility definitions Shiraz Saleem
2021-01-25 19:37 ` Jason Gunthorpe
2021-01-22 23:48 ` [PATCH 19/22] RDMA/irdma: Add dynamic tracing for CM Shiraz Saleem
2021-01-22 23:48 ` [PATCH 20/22] RDMA/irdma: Add ABI definitions Shiraz Saleem
2021-01-25 19:45 ` Jason Gunthorpe
2021-01-30 1:18 ` Saleem, Shiraz
2021-02-01 19:21 ` Jason Gunthorpe
2021-02-05 20:12 ` Saleem, Shiraz [this message]
2021-01-22 23:48 ` [PATCH 21/22] RDMA/irdma: Add irdma Kconfig/Makefile and remove i40iw Shiraz Saleem
2021-01-25 18:50 ` Jason Gunthorpe
2021-01-26 0:39 ` Saleem, Shiraz
2021-01-26 5:47 ` Leon Romanovsky
2021-01-22 23:48 ` [PATCH 22/22] RDMA/irdma: Update MAINTAINERS file Shiraz Saleem
2021-01-25 13:29 ` [PATCH 00/22] Add Intel Ethernet Protocol Driver for RDMA (irdma) Jason Gunthorpe
2021-01-25 18:44 ` Jason Gunthorpe
2021-01-26 0:39 ` Saleem, Shiraz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95c86ea5f5e94d068e6e0467ccba33a0@intel.com \
--to=shiraz.saleem@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.