* [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:
@ 2021-01-26 16:39 Geert Uytterhoeven
2021-01-27 14:00 ` Rob Herring
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-01-26 16:39 UTC (permalink / raw)
To: Luca Ceresoli, Michael Turquette, Stephen Boyd, Rob Herring, Adam Ford
Cc: linux-clk, devicetree, linux-renesas-soc, Geert Uytterhoeven
- Remove unneeded reference for "idt,slew-percent", as vendor specific
properties having a standard unit suffix don't need a type,
- Add missing "additionalProperties: false" for subnodes, to catch
typos in properties,
- Fix property names in example.
Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This depends on "[PATCH dt-schema 0/2] dt-schema: Add percentage"
https://lore.kernel.org/r/20210126162756.1932692-1-geert+renesas@glider.be
v3:
- Drop references for "idt,voltage-microvolt" and "idt,slew-percent",
v2:
- Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
('clk: vc5: Use "idt,voltage-microvolt" instead of
"idt,voltage-microvolts"'),
- Drop reference to clock.yaml, which is already applied
unconditionally,
- Drop removal of allOf around if condition, as it is unnecessary
churn.
---
.../devicetree/bindings/clock/idt,versaclock5.yaml | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
index 2ac1131fd9222a86..116ecce758bc22cf 100644
--- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
+++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
@@ -78,9 +78,10 @@ patternProperties:
enum: [ 1800000, 2500000, 3300000 ]
idt,slew-percent:
description: The Slew rate control for CMOS single-ended.
- $ref: /schemas/types.yaml#/definitions/uint32
enum: [ 80, 85, 90, 100 ]
+ additionalProperties: false
+
required:
- compatible
- reg
@@ -135,13 +136,13 @@ examples:
clock-names = "xin";
OUT1 {
- idt,drive-mode = <VC5_CMOSD>;
- idt,voltage-microvolts = <1800000>;
+ idt,mode = <VC5_CMOSD>;
+ idt,voltage-microvolt = <1800000>;
idt,slew-percent = <80>;
};
OUT4 {
- idt,drive-mode = <VC5_LVDS>;
+ idt,mode = <VC5_LVDS>;
};
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:
2021-01-26 16:39 [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: Geert Uytterhoeven
@ 2021-01-27 14:00 ` Rob Herring
2021-01-27 14:23 ` Geert Uytterhoeven
2021-01-27 14:36 ` Luca Ceresoli
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2021-01-27 14:00 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Stephen Boyd, Luca Ceresoli, devicetree, Rob Herring,
Michael Turquette, linux-renesas-soc, Adam Ford, linux-clk
On Tue, 26 Jan 2021 17:39:55 +0100, Geert Uytterhoeven wrote:
> - Remove unneeded reference for "idt,slew-percent", as vendor specific
> properties having a standard unit suffix don't need a type,
> - Add missing "additionalProperties: false" for subnodes, to catch
> typos in properties,
> - Fix property names in example.
>
> Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This depends on "[PATCH dt-schema 0/2] dt-schema: Add percentage"
> https://lore.kernel.org/r/20210126162756.1932692-1-geert+renesas@glider.be
>
> v3:
> - Drop references for "idt,voltage-microvolt" and "idt,slew-percent",
>
> v2:
> - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
> ('clk: vc5: Use "idt,voltage-microvolt" instead of
> "idt,voltage-microvolts"'),
> - Drop reference to clock.yaml, which is already applied
> unconditionally,
> - Drop removal of allOf around if condition, as it is unnecessary
> churn.
> ---
> .../devicetree/bindings/clock/idt,versaclock5.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml: patternProperties:^OUT[1-4]$:properties:idt,slew-percent: 'oneOf' conditional failed, one must be fixed:
'type' is a required property
Additional properties are not allowed ('enum' was unexpected)
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml: patternProperties:^OUT[1-4]$:properties:idt,slew-percent: 'oneOf' conditional failed, one must be fixed:
'$ref' is a required property
'allOf' is a required property
80 is not of type 'string'
85 is not of type 'string'
90 is not of type 'string'
100 is not of type 'string'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml: ignoring, error in schema: patternProperties: ^OUT[1-4]$: properties: idt,slew-percent
warning: no schema found in file: ./Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
See https://patchwork.ozlabs.org/patch/1432164
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:
2021-01-27 14:00 ` Rob Herring
@ 2021-01-27 14:23 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-01-27 14:23 UTC (permalink / raw)
To: Rob Herring
Cc: Geert Uytterhoeven, Stephen Boyd, Luca Ceresoli,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring, Michael Turquette, Linux-Renesas, Adam Ford,
linux-clk
Hi Rob,
On Wed, Jan 27, 2021 at 3:00 PM Rob Herring <robh@kernel.org> wrote:
> On Tue, 26 Jan 2021 17:39:55 +0100, Geert Uytterhoeven wrote:
> > - Remove unneeded reference for "idt,slew-percent", as vendor specific
> > properties having a standard unit suffix don't need a type,
> > - Add missing "additionalProperties: false" for subnodes, to catch
> > typos in properties,
> > - Fix property names in example.
> >
> > Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > This depends on "[PATCH dt-schema 0/2] dt-schema: Add percentage"
> > https://lore.kernel.org/r/20210126162756.1932692-1-geert+renesas@glider.be
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml: patternProperties:^OUT[1-4]$:properties:idt,slew-percent: 'oneOf' conditional failed, one must be fixed:
> 'type' is a required property
> Additional properties are not allowed ('enum' was unexpected)
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml: patternProperties:^OUT[1-4]$:properties:idt,slew-percent: 'oneOf' conditional failed, one must be fixed:
> '$ref' is a required property
> 'allOf' is a required property
> 80 is not of type 'string'
> 85 is not of type 'string'
> 90 is not of type 'string'
> 100 is not of type 'string'
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml: ignoring, error in schema: patternProperties: ^OUT[1-4]$: properties: idt,slew-percent
> warning: no schema found in file: ./Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
Yep, your bot didn't take into account the dependencies mentioned above ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:
2021-01-26 16:39 [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: Geert Uytterhoeven
2021-01-27 14:00 ` Rob Herring
@ 2021-01-27 14:36 ` Luca Ceresoli
2021-02-04 15:57 ` Rob Herring
2021-02-05 3:25 ` Stephen Boyd
3 siblings, 0 replies; 6+ messages in thread
From: Luca Ceresoli @ 2021-01-27 14:36 UTC (permalink / raw)
To: Geert Uytterhoeven, Michael Turquette, Stephen Boyd, Rob Herring,
Adam Ford
Cc: linux-clk, devicetree, linux-renesas-soc
Hi Geert,
On 26/01/21 17:39, Geert Uytterhoeven wrote:
> - Remove unneeded reference for "idt,slew-percent", as vendor specific
> properties having a standard unit suffix don't need a type,
> - Add missing "additionalProperties: false" for subnodes, to catch
> typos in properties,
> - Fix property names in example.
>
> Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This depends on "[PATCH dt-schema 0/2] dt-schema: Add percentage"
> https://lore.kernel.org/r/20210126162756.1932692-1-geert+renesas@glider.be
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
--
Luca
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:
2021-01-26 16:39 [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: Geert Uytterhoeven
2021-01-27 14:00 ` Rob Herring
2021-01-27 14:36 ` Luca Ceresoli
@ 2021-02-04 15:57 ` Rob Herring
2021-02-05 3:25 ` Stephen Boyd
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-02-04 15:57 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Luca Ceresoli, Adam Ford, Stephen Boyd, Rob Herring, devicetree,
linux-renesas-soc, Michael Turquette, linux-clk
On Tue, 26 Jan 2021 17:39:55 +0100, Geert Uytterhoeven wrote:
> - Remove unneeded reference for "idt,slew-percent", as vendor specific
> properties having a standard unit suffix don't need a type,
> - Add missing "additionalProperties: false" for subnodes, to catch
> typos in properties,
> - Fix property names in example.
>
> Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This depends on "[PATCH dt-schema 0/2] dt-schema: Add percentage"
> https://lore.kernel.org/r/20210126162756.1932692-1-geert+renesas@glider.be
>
> v3:
> - Drop references for "idt,voltage-microvolt" and "idt,slew-percent",
>
> v2:
> - Settle on "idt,voltage-microvolt", cfr. commit 4b003f5fcadfa2d0
> ('clk: vc5: Use "idt,voltage-microvolt" instead of
> "idt,voltage-microvolts"'),
> - Drop reference to clock.yaml, which is already applied
> unconditionally,
> - Drop removal of allOf around if condition, as it is unnecessary
> churn.
> ---
> .../devicetree/bindings/clock/idt,versaclock5.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements:
2021-01-26 16:39 [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: Geert Uytterhoeven
` (2 preceding siblings ...)
2021-02-04 15:57 ` Rob Herring
@ 2021-02-05 3:25 ` Stephen Boyd
3 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2021-02-05 3:25 UTC (permalink / raw)
To: Adam Ford, Geert Uytterhoeven, Luca Ceresoli, Michael Turquette,
Rob Herring
Cc: linux-clk, devicetree, linux-renesas-soc, Geert Uytterhoeven
Quoting Geert Uytterhoeven (2021-01-26 08:39:55)
> - Remove unneeded reference for "idt,slew-percent", as vendor specific
> properties having a standard unit suffix don't need a type,
> - Add missing "additionalProperties: false" for subnodes, to catch
> typos in properties,
> - Fix property names in example.
>
> Fixes: 45c940184b501fc6 ("dt-bindings: clk: versaclock5: convert to yaml")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Acked-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-05 3:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 16:39 [PATCH v3] dt-bindings: clk: versaclock5: Miscellaneous fixes and improvements: Geert Uytterhoeven
2021-01-27 14:00 ` Rob Herring
2021-01-27 14:23 ` Geert Uytterhoeven
2021-01-27 14:36 ` Luca Ceresoli
2021-02-04 15:57 ` Rob Herring
2021-02-05 3:25 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.