* [PATCH] Documentation/x86/boot.rst: Correct the example of SETUP_INDIRECT
@ 2021-01-27 8:49 Cao jin
2021-01-27 12:54 ` Daniel Kiper
0 siblings, 1 reply; 3+ messages in thread
From: Cao jin @ 2021-01-27 8:49 UTC (permalink / raw)
To: x86, linux-kernel, linux-doc
Cc: tglx, mingo, bp, hpa, corbet, daniel.kiper, Cao jin
struct setup_data.len is the length of data field. In case of
SETUP_INDIRECT, it should be sizeof(setup_indirect).
Signed-off-by: Cao jin <jojing64@gmail.com>
---
Documentation/x86/boot.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/x86/boot.rst b/Documentation/x86/boot.rst
index abb9fc164657..fc844913dece 100644
--- a/Documentation/x86/boot.rst
+++ b/Documentation/x86/boot.rst
@@ -851,7 +851,7 @@ Protocol: 2.09+
struct setup_data {
__u64 next = 0 or <addr_of_next_setup_data_struct>;
__u32 type = SETUP_INDIRECT;
- __u32 len = sizeof(setup_data);
+ __u32 len = sizeof(setup_indirect);
__u8 data[sizeof(setup_indirect)] = struct setup_indirect {
__u32 type = SETUP_INDIRECT | SETUP_E820_EXT;
__u32 reserved = 0;
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation/x86/boot.rst: Correct the example of SETUP_INDIRECT
2021-01-27 8:49 [PATCH] Documentation/x86/boot.rst: Correct the example of SETUP_INDIRECT Cao jin
@ 2021-01-27 12:54 ` Daniel Kiper
2021-01-28 22:25 ` Jonathan Corbet
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Kiper @ 2021-01-27 12:54 UTC (permalink / raw)
To: Cao jin; +Cc: x86, linux-kernel, linux-doc, tglx, mingo, bp, hpa, corbet
On Wed, Jan 27, 2021 at 04:49:11PM +0800, Cao jin wrote:
> struct setup_data.len is the length of data field. In case of
> SETUP_INDIRECT, it should be sizeof(setup_indirect).
>
> Signed-off-by: Cao jin <jojing64@gmail.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation/x86/boot.rst: Correct the example of SETUP_INDIRECT
2021-01-27 12:54 ` Daniel Kiper
@ 2021-01-28 22:25 ` Jonathan Corbet
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2021-01-28 22:25 UTC (permalink / raw)
To: Daniel Kiper; +Cc: Cao jin, x86, linux-kernel, linux-doc, tglx, mingo, bp, hpa
On Wed, 27 Jan 2021 13:54:40 +0100
Daniel Kiper <daniel.kiper@oracle.com> wrote:
> On Wed, Jan 27, 2021 at 04:49:11PM +0800, Cao jin wrote:
> > struct setup_data.len is the length of data field. In case of
> > SETUP_INDIRECT, it should be sizeof(setup_indirect).
> >
> > Signed-off-by: Cao jin <jojing64@gmail.com>
>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-28 22:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 8:49 [PATCH] Documentation/x86/boot.rst: Correct the example of SETUP_INDIRECT Cao jin
2021-01-27 12:54 ` Daniel Kiper
2021-01-28 22:25 ` Jonathan Corbet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.