All of lore.kernel.org
 help / color / mirror / Atom feed
From: Venu Busireddy <venu.busireddy@oracle.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Connor Kuehl <ckuehl@redhat.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Jiri Slaby <jslaby@suse.cz>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Sean Christopherson <seanjc@google.com>,
	Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH v6 5/6] kvm/i386: Use a per-VM check for SMM capability
Date: Fri, 29 Jan 2021 11:46:01 -0600	[thread overview]
Message-ID: <20210129174601.GE231819@dt> (raw)
In-Reply-To: <f851903809e9d4e6a22d5dfd738dac8da991e28d.1611682609.git.thomas.lendacky@amd.com>

On 2021-01-26 11:36:48 -0600, Tom Lendacky wrote:
> From: Tom Lendacky <thomas.lendacky@amd.com>
> 
> SMM is not currently supported for an SEV-ES guest by KVM. Change the SMM
> capability check from a KVM-wide check to a per-VM check in order to have
> a finer-grained SMM capability check.
> 
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Suggested-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>

Reviewed-by: Venu Busireddy <venu.busireddy@oracle.com>

> ---
>  target/i386/kvm/kvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
> index bb6bfc19de..37fca43cd9 100644
> --- a/target/i386/kvm/kvm.c
> +++ b/target/i386/kvm/kvm.c
> @@ -135,7 +135,7 @@ int kvm_has_pit_state2(void)
>  
>  bool kvm_has_smm(void)
>  {
> -    return kvm_check_extension(kvm_state, KVM_CAP_X86_SMM);
> +    return kvm_vm_check_extension(kvm_state, KVM_CAP_X86_SMM);
>  }
>  
>  bool kvm_has_adjust_clock_stable(void)
> -- 
> 2.30.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Venu Busireddy <venu.busireddy@oracle.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Connor Kuehl <ckuehl@redhat.com>,
	Sean Christopherson <seanjc@google.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	Jiri Slaby <jslaby@suse.cz>, Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v6 5/6] kvm/i386: Use a per-VM check for SMM capability
Date: Fri, 29 Jan 2021 11:46:01 -0600	[thread overview]
Message-ID: <20210129174601.GE231819@dt> (raw)
In-Reply-To: <f851903809e9d4e6a22d5dfd738dac8da991e28d.1611682609.git.thomas.lendacky@amd.com>

On 2021-01-26 11:36:48 -0600, Tom Lendacky wrote:
> From: Tom Lendacky <thomas.lendacky@amd.com>
> 
> SMM is not currently supported for an SEV-ES guest by KVM. Change the SMM
> capability check from a KVM-wide check to a per-VM check in order to have
> a finer-grained SMM capability check.
> 
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Suggested-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>

Reviewed-by: Venu Busireddy <venu.busireddy@oracle.com>

> ---
>  target/i386/kvm/kvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
> index bb6bfc19de..37fca43cd9 100644
> --- a/target/i386/kvm/kvm.c
> +++ b/target/i386/kvm/kvm.c
> @@ -135,7 +135,7 @@ int kvm_has_pit_state2(void)
>  
>  bool kvm_has_smm(void)
>  {
> -    return kvm_check_extension(kvm_state, KVM_CAP_X86_SMM);
> +    return kvm_vm_check_extension(kvm_state, KVM_CAP_X86_SMM);
>  }
>  
>  bool kvm_has_adjust_clock_stable(void)
> -- 
> 2.30.0
> 


  reply	other threads:[~2021-01-29 17:49 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 17:36 [PATCH v6 0/6] Qemu SEV-ES guest support Tom Lendacky
2021-01-26 17:36 ` Tom Lendacky
2021-01-26 17:36 ` [PATCH v6 1/6] sev/i386: Add initial support for SEV-ES Tom Lendacky
2021-01-26 17:36   ` Tom Lendacky
2021-01-29 17:39   ` Venu Busireddy
2021-01-29 17:39     ` Venu Busireddy
2021-01-26 17:36 ` [PATCH v6 2/6] sev/i386: Require in-kernel irqchip support for SEV-ES guests Tom Lendacky
2021-01-26 17:36   ` Tom Lendacky
2021-01-29 17:41   ` Venu Busireddy
2021-01-29 17:41     ` Venu Busireddy
2021-01-26 17:36 ` [PATCH v6 3/6] sev/i386: Allow AP booting under SEV-ES Tom Lendacky
2021-01-26 17:36   ` Tom Lendacky
2021-01-29 17:44   ` Venu Busireddy
2021-01-29 17:44     ` Venu Busireddy
2021-02-01 18:48     ` Tom Lendacky
2021-02-01 18:48       ` Tom Lendacky
2021-01-26 17:36 ` [PATCH v6 4/6] sev/i386: Don't allow a system reset under an SEV-ES guest Tom Lendacky
2021-01-26 17:36   ` Tom Lendacky
2021-01-29 17:44   ` Venu Busireddy
2021-01-29 17:44     ` Venu Busireddy
2021-01-26 17:36 ` [PATCH v6 5/6] kvm/i386: Use a per-VM check for SMM capability Tom Lendacky
2021-01-26 17:36   ` Tom Lendacky
2021-01-29 17:46   ` Venu Busireddy [this message]
2021-01-29 17:46     ` Venu Busireddy
2021-01-26 17:36 ` [PATCH v6 6/6] sev/i386: Enable an SEV-ES guest based on SEV policy Tom Lendacky
2021-01-26 17:36   ` Tom Lendacky
2021-01-29 17:46   ` Venu Busireddy
2021-01-29 17:46     ` Venu Busireddy
2021-02-05 10:59 ` [PATCH v6 0/6] Qemu SEV-ES guest support Paolo Bonzini
2021-02-05 10:59   ` Paolo Bonzini
2021-02-08 15:48   ` Tom Lendacky
2021-02-08 15:48     ` Tom Lendacky
2021-02-08 16:31     ` Paolo Bonzini
2021-02-08 16:31       ` Paolo Bonzini
2021-02-08 17:35       ` Tom Lendacky
2021-02-08 17:35         ` Tom Lendacky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210129174601.GE231819@dt \
    --to=venu.busireddy@oracle.com \
    --cc=brijesh.singh@amd.com \
    --cc=ckuehl@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jslaby@suse.cz \
    --cc=kvm@vger.kernel.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=rth@twiddle.net \
    --cc=seanjc@google.com \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.