All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"jhs@mojatatu.com" <jhs@mojatatu.com>,
	"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
	"jiri@resnulli.us" <jiri@resnulli.us>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"Jose.Abreu@synopsys.com" <Jose.Abreu@synopsys.com>,
	Po Liu <po.liu@nxp.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"anthony.l.nguyen@intel.com" <anthony.l.nguyen@intel.com>,
	"mkubecek@suse.cz" <mkubecek@suse.cz>
Subject: Re: [PATCH net-next v3 0/8] ethtool: Add support for frame preemption
Date: Fri, 29 Jan 2021 23:37:29 +0000	[thread overview]
Message-ID: <20210129233729.bjckcxcx45hueb2z@skbuf> (raw)
In-Reply-To: <20210122224453.4161729-1-vinicius.gomes@intel.com>

On Fri, Jan 22, 2021 at 02:44:45PM -0800, Vinicius Costa Gomes wrote:
> This is still an RFC because two main reasons, I want to confirm that
> this approach (per-queue settings via qdiscs, device settings via
> ethtool) looks good, even though there aren't much more options left ;-)

I don't want to bother you too much, but a consequence of putting the
per-priority settings into tc-taprio is that those will spill over into
other qdiscs too that have nothing to do with TSN, for whomever will
need frame preemption without time-aware scheduling (and there are
reasons to want that).
So could we see in the next version the frame preemption bits added to
tc-mqprio as well? I just want to make sure that we run this by the tc
maintainers and that the idea gets their informed consent before we end
up in a position where frame preemption with time-aware scheduling is
done in one way, but frame preemption without time-aware scheduling is
done another way.
You should not need to change anything related to TC_SETUP_PREEMPT in
the igc driver, so it should be just code addition.

WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v3 0/8] ethtool: Add support for frame preemption
Date: Fri, 29 Jan 2021 23:37:29 +0000	[thread overview]
Message-ID: <20210129233729.bjckcxcx45hueb2z@skbuf> (raw)
In-Reply-To: <20210122224453.4161729-1-vinicius.gomes@intel.com>

On Fri, Jan 22, 2021 at 02:44:45PM -0800, Vinicius Costa Gomes wrote:
> This is still an RFC because two main reasons, I want to confirm that
> this approach (per-queue settings via qdiscs, device settings via
> ethtool) looks good, even though there aren't much more options left ;-)

I don't want to bother you too much, but a consequence of putting the
per-priority settings into tc-taprio is that those will spill over into
other qdiscs too that have nothing to do with TSN, for whomever will
need frame preemption without time-aware scheduling (and there are
reasons to want that).
So could we see in the next version the frame preemption bits added to
tc-mqprio as well? I just want to make sure that we run this by the tc
maintainers and that the idea gets their informed consent before we end
up in a position where frame preemption with time-aware scheduling is
done in one way, but frame preemption without time-aware scheduling is
done another way.
You should not need to change anything related to TC_SETUP_PREEMPT in
the igc driver, so it should be just code addition.

  parent reply	other threads:[~2021-01-29 23:38 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 22:44 [PATCH net-next v3 0/8] ethtool: Add support for frame preemption Vinicius Costa Gomes
2021-01-22 22:44 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-22 22:44 ` [PATCH net-next v3 1/8] ethtool: Add support for configuring " Vinicius Costa Gomes
2021-01-22 22:44   ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-03-02 14:23   ` Vladimir Oltean
2021-03-02 14:23     ` [Intel-wired-lan] " Vladimir Oltean
2021-03-03  0:40     ` Vinicius Costa Gomes
2021-03-03  0:40       ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-03-03  0:51       ` Vladimir Oltean
2021-03-03  0:51         ` [Intel-wired-lan] " Vladimir Oltean
2021-03-05 22:38         ` Vinicius Costa Gomes
2021-03-05 22:38           ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-22 22:44 ` [PATCH net-next v3 2/8] taprio: Add support for frame preemption offload Vinicius Costa Gomes
2021-01-22 22:44   ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-26  0:09   ` Vladimir Oltean
2021-01-26  0:09     ` [Intel-wired-lan] " Vladimir Oltean
2021-01-29 21:13     ` Vinicius Costa Gomes
2021-01-29 21:13       ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-29 21:57       ` Jakub Kicinski
2021-01-29 21:57         ` [Intel-wired-lan] " Jakub Kicinski
2021-01-29 23:12         ` Vinicius Costa Gomes
2021-01-29 23:12           ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-30  0:27           ` Jakub Kicinski
2021-01-30  0:27             ` [Intel-wired-lan] " Jakub Kicinski
2021-01-29 23:20       ` Vladimir Oltean
2021-01-29 23:20         ` [Intel-wired-lan] " Vladimir Oltean
2021-01-29 23:42         ` Vinicius Costa Gomes
2021-01-29 23:42           ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-30  0:25           ` Vladimir Oltean
2021-01-30  0:25             ` [Intel-wired-lan] " Vladimir Oltean
2021-01-22 22:44 ` [PATCH net-next v3 3/8] igc: Set the RX packet buffer size for TSN mode Vinicius Costa Gomes
2021-01-22 22:44   ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-22 22:44 ` [PATCH net-next v3 4/8] igc: Only dump registers if configured to dump HW information Vinicius Costa Gomes
2021-01-22 22:44   ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-22 22:44 ` [PATCH net-next v3 5/8] igc: Avoid TX Hangs because long cycles Vinicius Costa Gomes
2021-01-22 22:44   ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-26  0:02   ` Vladimir Oltean
2021-01-26  0:02     ` [Intel-wired-lan] " Vladimir Oltean
2021-01-27  9:03     ` Kurt Kanzenbach
2021-01-27  9:03       ` [Intel-wired-lan] " Kurt Kanzenbach
2021-01-29 21:01     ` Vinicius Costa Gomes
2021-01-29 21:01       ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-22 22:44 ` [PATCH net-next v3 6/8] igc: Add support for tuning frame preemption via ethtool Vinicius Costa Gomes
2021-01-22 22:44   ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-26  0:32   ` Vladimir Oltean
2021-01-26  0:32     ` [Intel-wired-lan] " Vladimir Oltean
2021-01-29 21:27     ` Vinicius Costa Gomes
2021-01-29 21:27       ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-29 23:16       ` Vladimir Oltean
2021-01-29 23:16         ` [Intel-wired-lan] " Vladimir Oltean
2021-03-03  1:07   ` Vladimir Oltean
2021-03-03  1:07     ` [Intel-wired-lan] " Vladimir Oltean
2021-01-22 22:44 ` [PATCH net-next v3 7/8] igc: Add support for Frame Preemption offload Vinicius Costa Gomes
2021-01-22 22:44   ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-22 22:44 ` [PATCH net-next v3 8/8] igc: Separate TSN configurations that can be updated Vinicius Costa Gomes
2021-01-22 22:44   ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-29 23:37 ` Vladimir Oltean [this message]
2021-01-29 23:37   ` [Intel-wired-lan] [PATCH net-next v3 0/8] ethtool: Add support for frame preemption Vladimir Oltean
2021-01-30  0:11   ` Vinicius Costa Gomes
2021-01-30  0:11     ` [Intel-wired-lan] " Vinicius Costa Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210129233729.bjckcxcx45hueb2z@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=Jose.Abreu@synopsys.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=po.liu@nxp.com \
    --cc=vinicius.gomes@intel.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.