From: Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>
To: Vladimir Oltean <vladimir.oltean@nxp.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: "netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"jhs\@mojatatu.com" <jhs@mojatatu.com>,
"xiyou.wangcong\@gmail.com" <xiyou.wangcong@gmail.com>,
"jiri\@resnulli.us" <jiri@resnulli.us>,
"kuba\@kernel.org" <kuba@kernel.org>,
"Jose.Abreu\@synopsys.com" <Jose.Abreu@synopsys.com>,
Po Liu <po.liu@nxp.com>,
"intel-wired-lan\@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"anthony.l.nguyen\@intel.com" <anthony.l.nguyen@intel.com>,
"mkubecek\@suse.cz" <mkubecek@suse.cz>
Subject: Re: [PATCH net-next v3 5/8] igc: Avoid TX Hangs because long cycles
Date: Wed, 27 Jan 2021 10:03:53 +0100 [thread overview]
Message-ID: <87czxqda4m.fsf@kurt> (raw)
In-Reply-To: <20210126000228.gpyh3rrp662wysit@skbuf>
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
On Tue Jan 26 2021, Vladimir Oltean wrote:
> On Fri, Jan 22, 2021 at 02:44:50PM -0800, Vinicius Costa Gomes wrote:
>> Avoid possible TX Hangs caused by using long Qbv cycles. In some
>> cases, using long cycles (more than 1 second) can cause transmissions
>> to be blocked for that time. As the TX Hang timeout is close to 1
>> second, we may need to reduce the cycle time to something more
>> reasonable: the value chosen is 1ms.
>>
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>> ---
>
> Don't you want this patch to go to 'net' and be backported?
I'm wondering about this patch as well. Is this fix related to frame
preemption? If I understand the code correctly the 1sec is a dummy cycle
and all queues are open. How should Tx hang then?
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v3 5/8] igc: Avoid TX Hangs because long cycles
Date: Wed, 27 Jan 2021 10:03:53 +0100 [thread overview]
Message-ID: <87czxqda4m.fsf@kurt> (raw)
In-Reply-To: <20210126000228.gpyh3rrp662wysit@skbuf>
On Tue Jan 26 2021, Vladimir Oltean wrote:
> On Fri, Jan 22, 2021 at 02:44:50PM -0800, Vinicius Costa Gomes wrote:
>> Avoid possible TX Hangs caused by using long Qbv cycles. In some
>> cases, using long cycles (more than 1 second) can cause transmissions
>> to be blocked for that time. As the TX Hang timeout is close to 1
>> second, we may need to reduce the cycle time to something more
>> reasonable: the value chosen is 1ms.
>>
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>> ---
>
> Don't you want this patch to go to 'net' and be backported?
I'm wondering about this patch as well. Is this fix related to frame
preemption? If I understand the code correctly the 1sec is a dummy cycle
and all queues are open. How should Tx hang then?
Thanks,
Kurt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20210127/0faf3bba/attachment.asc>
next prev parent reply other threads:[~2021-01-27 9:07 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 22:44 [PATCH net-next v3 0/8] ethtool: Add support for frame preemption Vinicius Costa Gomes
2021-01-22 22:44 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-22 22:44 ` [PATCH net-next v3 1/8] ethtool: Add support for configuring " Vinicius Costa Gomes
2021-01-22 22:44 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-03-02 14:23 ` Vladimir Oltean
2021-03-02 14:23 ` [Intel-wired-lan] " Vladimir Oltean
2021-03-03 0:40 ` Vinicius Costa Gomes
2021-03-03 0:40 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-03-03 0:51 ` Vladimir Oltean
2021-03-03 0:51 ` [Intel-wired-lan] " Vladimir Oltean
2021-03-05 22:38 ` Vinicius Costa Gomes
2021-03-05 22:38 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-22 22:44 ` [PATCH net-next v3 2/8] taprio: Add support for frame preemption offload Vinicius Costa Gomes
2021-01-22 22:44 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-26 0:09 ` Vladimir Oltean
2021-01-26 0:09 ` [Intel-wired-lan] " Vladimir Oltean
2021-01-29 21:13 ` Vinicius Costa Gomes
2021-01-29 21:13 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-29 21:57 ` Jakub Kicinski
2021-01-29 21:57 ` [Intel-wired-lan] " Jakub Kicinski
2021-01-29 23:12 ` Vinicius Costa Gomes
2021-01-29 23:12 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-30 0:27 ` Jakub Kicinski
2021-01-30 0:27 ` [Intel-wired-lan] " Jakub Kicinski
2021-01-29 23:20 ` Vladimir Oltean
2021-01-29 23:20 ` [Intel-wired-lan] " Vladimir Oltean
2021-01-29 23:42 ` Vinicius Costa Gomes
2021-01-29 23:42 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-30 0:25 ` Vladimir Oltean
2021-01-30 0:25 ` [Intel-wired-lan] " Vladimir Oltean
2021-01-22 22:44 ` [PATCH net-next v3 3/8] igc: Set the RX packet buffer size for TSN mode Vinicius Costa Gomes
2021-01-22 22:44 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-22 22:44 ` [PATCH net-next v3 4/8] igc: Only dump registers if configured to dump HW information Vinicius Costa Gomes
2021-01-22 22:44 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-22 22:44 ` [PATCH net-next v3 5/8] igc: Avoid TX Hangs because long cycles Vinicius Costa Gomes
2021-01-22 22:44 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-26 0:02 ` Vladimir Oltean
2021-01-26 0:02 ` [Intel-wired-lan] " Vladimir Oltean
2021-01-27 9:03 ` Kurt Kanzenbach [this message]
2021-01-27 9:03 ` Kurt Kanzenbach
2021-01-29 21:01 ` Vinicius Costa Gomes
2021-01-29 21:01 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-22 22:44 ` [PATCH net-next v3 6/8] igc: Add support for tuning frame preemption via ethtool Vinicius Costa Gomes
2021-01-22 22:44 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-26 0:32 ` Vladimir Oltean
2021-01-26 0:32 ` [Intel-wired-lan] " Vladimir Oltean
2021-01-29 21:27 ` Vinicius Costa Gomes
2021-01-29 21:27 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-29 23:16 ` Vladimir Oltean
2021-01-29 23:16 ` [Intel-wired-lan] " Vladimir Oltean
2021-03-03 1:07 ` Vladimir Oltean
2021-03-03 1:07 ` [Intel-wired-lan] " Vladimir Oltean
2021-01-22 22:44 ` [PATCH net-next v3 7/8] igc: Add support for Frame Preemption offload Vinicius Costa Gomes
2021-01-22 22:44 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-22 22:44 ` [PATCH net-next v3 8/8] igc: Separate TSN configurations that can be updated Vinicius Costa Gomes
2021-01-22 22:44 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-01-29 23:37 ` [PATCH net-next v3 0/8] ethtool: Add support for frame preemption Vladimir Oltean
2021-01-29 23:37 ` [Intel-wired-lan] " Vladimir Oltean
2021-01-30 0:11 ` Vinicius Costa Gomes
2021-01-30 0:11 ` [Intel-wired-lan] " Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czxqda4m.fsf@kurt \
--to=kurt.kanzenbach@linutronix.de \
--cc=Jose.Abreu@synopsys.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.