* [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Hide unused clients @ 2021-01-31 3:11 ` Chris Wilson 0 siblings, 0 replies; 21+ messages in thread From: Chris Wilson @ 2021-01-31 3:11 UTC (permalink / raw) To: intel-gfx; +Cc: igt-dev, Chris Wilson Keep new clients hidden until they utilise the GPU. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> --- tools/intel_gpu_top.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index 60ff62d28..66a8effa6 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -828,8 +828,11 @@ static void update_client(struct client *c, unsigned int pid, char *name) c->last[i] = val[i]; } - c->samples++; + if (!c->total_runtime) + return; + c->status = ALIVE; + c->samples++; } static void -- 2.30.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [igt-dev] [PATCH i-g-t] intel_gpu_top: Hide unused clients @ 2021-01-31 3:11 ` Chris Wilson 0 siblings, 0 replies; 21+ messages in thread From: Chris Wilson @ 2021-01-31 3:11 UTC (permalink / raw) To: intel-gfx; +Cc: igt-dev, Chris Wilson Keep new clients hidden until they utilise the GPU. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> --- tools/intel_gpu_top.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index 60ff62d28..66a8effa6 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -828,8 +828,11 @@ static void update_client(struct client *c, unsigned int pid, char *name) c->last[i] = val[i]; } - c->samples++; + if (!c->total_runtime) + return; + c->status = ALIVE; + c->samples++; } static void -- 2.30.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for intel_gpu_top: Hide unused clients 2021-01-31 3:11 ` [igt-dev] " Chris Wilson (?) @ 2021-01-31 3:46 ` Patchwork -1 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2021-01-31 3:46 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 2634 bytes --] == Series Details == Series: intel_gpu_top: Hide unused clients URL : https://patchwork.freedesktop.org/series/86486/ State : success == Summary == CI Bug Log - changes from CI_DRM_9706 -> IGTPW_5452 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/index.html Known issues ------------ Here are the changes found in IGTPW_5452 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_huc_copy@huc-copy: - fi-byt-j1900: NOTRUN -> [SKIP][1] ([fdo#109271]) +27 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/fi-byt-j1900/igt@gem_huc_copy@huc-copy.html * igt@kms_chamelium@hdmi-crc-fast: - fi-byt-j1900: NOTRUN -> [SKIP][2] ([fdo#109271] / [fdo#111827]) +8 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/fi-byt-j1900/igt@kms_chamelium@hdmi-crc-fast.html * igt@prime_vgem@basic-userptr: - fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/fi-tgl-y/igt@prime_vgem@basic-userptr.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/fi-tgl-y/igt@prime_vgem@basic-userptr.html #### Possible fixes #### * igt@prime_self_import@basic-with_one_bo_two_files: - fi-tgl-y: [DMESG-WARN][5] ([i915#402]) -> [PASS][6] +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 Participating hosts (43 -> 38) ------------------------------ Additional (1): fi-byt-j1900 Missing (6): fi-jsl-1 fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-dg1-1 fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5980 -> IGTPW_5452 CI-20190529: 20190529 CI_DRM_9706: f9173d6435c6a9bb0b0076ebf9122d876da208ae @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_5452: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/index.html IGT_5980: e02612921a4e95aef3a368e7468f4337c9dcee7d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/index.html [-- Attachment #1.2: Type: text/html, Size: 3445 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 21+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for intel_gpu_top: Hide unused clients 2021-01-31 3:11 ` [igt-dev] " Chris Wilson (?) (?) @ 2021-01-31 4:48 ` Patchwork -1 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2021-01-31 4:48 UTC (permalink / raw) To: Chris Wilson; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 30252 bytes --] == Series Details == Series: intel_gpu_top: Hide unused clients URL : https://patchwork.freedesktop.org/series/86486/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9706_full -> IGTPW_5452_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_5452_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_5452_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_5452_full: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_balancer@hang: - shard-iclb: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-iclb7/igt@gem_exec_balancer@hang.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb1/igt@gem_exec_balancer@hang.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-snb: [PASS][3] -> [FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-snb6/igt@kms_async_flips@alternate-sync-async-flip.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-snb4/igt@kms_async_flips@alternate-sync-async-flip.html #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * {igt@sysfs_clients@recycle}: - shard-apl: [PASS][5] -> [FAIL][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-apl3/igt@sysfs_clients@recycle.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl4/igt@sysfs_clients@recycle.html - shard-tglb: [PASS][7] -> [FAIL][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-tglb1/igt@sysfs_clients@recycle.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb5/igt@sysfs_clients@recycle.html Known issues ------------ Here are the changes found in IGTPW_5452_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@feature_discovery@psr2: - shard-iclb: NOTRUN -> [SKIP][9] ([i915#658]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb3/igt@feature_discovery@psr2.html * igt@gem_ctx_persistence@legacy-engines-queued: - shard-snb: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#1099]) +1 similar issue [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-snb4/igt@gem_ctx_persistence@legacy-engines-queued.html - shard-hsw: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#1099]) +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-hsw6/igt@gem_ctx_persistence@legacy-engines-queued.html * igt@gem_eio@in-flight-suspend: - shard-apl: NOTRUN -> [DMESG-WARN][12] ([i915#1037] / [i915#180]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl8/igt@gem_eio@in-flight-suspend.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2842]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-glk: [PASS][15] -> [FAIL][16] ([i915#2842]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-glk6/igt@gem_exec_fair@basic-none-share@rcs0.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-glk2/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none@vcs1: - shard-kbl: [PASS][17] -> [FAIL][18] ([i915#2842]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-kbl1/igt@gem_exec_fair@basic-none@vcs1.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-kbl4/igt@gem_exec_fair@basic-none@vcs1.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-iclb: NOTRUN -> [FAIL][19] ([i915#2842]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_reloc@basic-wide-active@bcs0: - shard-apl: NOTRUN -> [FAIL][20] ([i915#2389]) +3 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl1/igt@gem_exec_reloc@basic-wide-active@bcs0.html - shard-glk: NOTRUN -> [FAIL][21] ([i915#2389]) +3 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-glk7/igt@gem_exec_reloc@basic-wide-active@bcs0.html - shard-tglb: NOTRUN -> [FAIL][22] ([i915#2389]) +4 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb7/igt@gem_exec_reloc@basic-wide-active@bcs0.html * igt@gem_exec_reloc@basic-wide-active@rcs0: - shard-iclb: NOTRUN -> [FAIL][23] ([i915#2389]) +4 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb2/igt@gem_exec_reloc@basic-wide-active@rcs0.html - shard-kbl: NOTRUN -> [FAIL][24] ([i915#2389]) +4 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-kbl4/igt@gem_exec_reloc@basic-wide-active@rcs0.html * igt@gem_huc_copy@huc-copy: - shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#2190]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl8/igt@gem_huc_copy@huc-copy.html * igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs: - shard-iclb: NOTRUN -> [SKIP][26] ([i915#768]) +2 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb7/igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs.html * igt@gem_softpin@evict-snoop-interruptible: - shard-tglb: NOTRUN -> [SKIP][27] ([fdo#109312]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb7/igt@gem_softpin@evict-snoop-interruptible.html * igt@gem_userptr_blits@coherency-sync: - shard-tglb: NOTRUN -> [SKIP][28] ([fdo#110542]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb7/igt@gem_userptr_blits@coherency-sync.html - shard-iclb: NOTRUN -> [SKIP][29] ([fdo#109290]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb8/igt@gem_userptr_blits@coherency-sync.html * igt@gem_userptr_blits@mmap-offset-invalidate-idle@gtt: - shard-tglb: NOTRUN -> [SKIP][30] ([i915#1317]) +3 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb2/igt@gem_userptr_blits@mmap-offset-invalidate-idle@gtt.html * igt@gem_userptr_blits@readonly-pwrite-unsync: - shard-tglb: NOTRUN -> [SKIP][31] ([fdo#110426] / [i915#1704]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb6/igt@gem_userptr_blits@readonly-pwrite-unsync.html - shard-iclb: NOTRUN -> [SKIP][32] ([fdo#110426] / [i915#1704]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb6/igt@gem_userptr_blits@readonly-pwrite-unsync.html * igt@gen9_exec_parse@allowed-all: - shard-glk: [PASS][33] -> [DMESG-WARN][34] ([i915#1436] / [i915#716]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-glk4/igt@gen9_exec_parse@allowed-all.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-glk3/igt@gen9_exec_parse@allowed-all.html * igt@gen9_exec_parse@basic-rejected: - shard-iclb: NOTRUN -> [SKIP][35] ([fdo#112306]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb8/igt@gen9_exec_parse@basic-rejected.html - shard-tglb: NOTRUN -> [SKIP][36] ([fdo#112306]) +1 similar issue [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb7/igt@gen9_exec_parse@basic-rejected.html * igt@gen9_exec_parse@bb-large: - shard-tglb: NOTRUN -> [SKIP][37] ([i915#2527]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb1/igt@gen9_exec_parse@bb-large.html - shard-iclb: NOTRUN -> [SKIP][38] ([i915#2527]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb5/igt@gen9_exec_parse@bb-large.html * igt@gen9_exec_parse@shadow-peek: - shard-tglb: NOTRUN -> [SKIP][39] ([i915#2856]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb6/igt@gen9_exec_parse@shadow-peek.html * igt@i915_module_load@reload-with-fault-injection: - shard-hsw: [PASS][40] -> [INCOMPLETE][41] ([i915#2880]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-hsw6/igt@i915_module_load@reload-with-fault-injection.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-hsw2/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pm_dc@dc6-dpms: - shard-tglb: NOTRUN -> [FAIL][42] ([i915#454]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb1/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp: - shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#1937]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl4/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html * igt@i915_pm_rpm@modeset-pc8-residency-stress: - shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271]) +153 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl2/igt@i915_pm_rpm@modeset-pc8-residency-stress.html * igt@i915_suspend@forcewake: - shard-apl: NOTRUN -> [DMESG-WARN][45] ([i915#180]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl3/igt@i915_suspend@forcewake.html * igt@kms_atomic_transition@plane-all-modeset-transition: - shard-tglb: NOTRUN -> [SKIP][46] ([i915#1769]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb7/igt@kms_atomic_transition@plane-all-modeset-transition.html * igt@kms_big_fb@x-tiled-16bpp-rotate-270: - shard-iclb: NOTRUN -> [SKIP][47] ([fdo#110725] / [fdo#111614]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb4/igt@kms_big_fb@x-tiled-16bpp-rotate-270.html - shard-tglb: NOTRUN -> [SKIP][48] ([fdo#111614]) +1 similar issue [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb5/igt@kms_big_fb@x-tiled-16bpp-rotate-270.html * igt@kms_big_fb@yf-tiled-8bpp-rotate-90: - shard-tglb: NOTRUN -> [SKIP][49] ([fdo#111615]) +3 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb8/igt@kms_big_fb@yf-tiled-8bpp-rotate-90.html * igt@kms_chamelium@hdmi-edid-change-during-suspend: - shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +13 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl8/igt@kms_chamelium@hdmi-edid-change-during-suspend.html * igt@kms_chamelium@hdmi-hpd-after-suspend: - shard-snb: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +4 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-snb5/igt@kms_chamelium@hdmi-hpd-after-suspend.html * igt@kms_chamelium@vga-hpd-enable-disable-mode: - shard-glk: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +7 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-glk1/igt@kms_chamelium@vga-hpd-enable-disable-mode.html * igt@kms_color@pipe-a-ctm-0-25: - shard-tglb: NOTRUN -> [FAIL][53] ([i915#1149] / [i915#315]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb3/igt@kms_color@pipe-a-ctm-0-25.html * igt@kms_color@pipe-d-ctm-green-to-red: - shard-hsw: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#533]) +5 similar issues [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-hsw2/igt@kms_color@pipe-d-ctm-green-to-red.html - shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109278] / [i915#1149]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb3/igt@kms_color@pipe-d-ctm-green-to-red.html * igt@kms_color_chamelium@pipe-b-ctm-red-to-blue: - shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109284] / [fdo#111827]) +5 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb5/igt@kms_color_chamelium@pipe-b-ctm-red-to-blue.html * igt@kms_color_chamelium@pipe-d-ctm-max: - shard-hsw: NOTRUN -> [SKIP][57] ([fdo#109271] / [fdo#111827]) +4 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-hsw6/igt@kms_color_chamelium@pipe-d-ctm-max.html - shard-tglb: NOTRUN -> [SKIP][58] ([fdo#109284] / [fdo#111827]) +8 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb8/igt@kms_color_chamelium@pipe-d-ctm-max.html - shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +7 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-kbl1/igt@kms_color_chamelium@pipe-d-ctm-max.html - shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109278] / [fdo#109284] / [fdo#111827]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb8/igt@kms_color_chamelium@pipe-d-ctm-max.html * igt@kms_content_protection@srm: - shard-kbl: NOTRUN -> [TIMEOUT][61] ([i915#1319]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-kbl7/igt@kms_content_protection@srm.html - shard-apl: NOTRUN -> [TIMEOUT][62] ([i915#1319]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl2/igt@kms_content_protection@srm.html * igt@kms_content_protection@uevent: - shard-kbl: NOTRUN -> [FAIL][63] ([i915#2105]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-kbl1/igt@kms_content_protection@uevent.html - shard-tglb: NOTRUN -> [SKIP][64] ([fdo#111828]) +1 similar issue [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb6/igt@kms_content_protection@uevent.html - shard-apl: NOTRUN -> [FAIL][65] ([i915#2105]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl4/igt@kms_content_protection@uevent.html - shard-iclb: NOTRUN -> [SKIP][66] ([fdo#109300] / [fdo#111066]) +1 similar issue [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb6/igt@kms_content_protection@uevent.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-apl: [PASS][67] -> [DMESG-WARN][68] ([i915#180]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_crc@pipe-d-cursor-dpms: - shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109278]) +5 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb7/igt@kms_cursor_crc@pipe-d-cursor-dpms.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic: - shard-tglb: [PASS][70] -> [FAIL][71] ([i915#2346]) +1 similar issue [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-tglb6/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html * igt@kms_flip@2x-flip-vs-expired-vblank: - shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109274]) +1 similar issue [72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb5/igt@kms_flip@2x-flip-vs-expired-vblank.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs: - shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#2672]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-kbl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html - shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#2672]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html - shard-glk: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#2672]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-glk2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html - shard-iclb: NOTRUN -> [SKIP][76] ([i915#2587]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile: - shard-apl: NOTRUN -> [FAIL][77] ([i915#2641]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt: - shard-snb: NOTRUN -> [FAIL][78] ([i915#2546]) +2 similar issues [78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-snb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc: - shard-tglb: NOTRUN -> [SKIP][79] ([fdo#111825]) +41 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt: - shard-snb: NOTRUN -> [SKIP][80] ([fdo#109271]) +75 similar issues [80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-snb6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack: - shard-glk: NOTRUN -> [SKIP][81] ([fdo#109271]) +49 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-glk1/igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack: - shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109280]) +23 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc: - shard-kbl: NOTRUN -> [SKIP][83] ([fdo#109271]) +63 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-kbl6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc.html * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb: - shard-apl: NOTRUN -> [FAIL][84] ([fdo#108145] / [i915#265]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-glk: NOTRUN -> [FAIL][85] ([i915#265]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-glk1/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html - shard-apl: NOTRUN -> [FAIL][86] ([i915#265]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl2/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html - shard-kbl: NOTRUN -> [FAIL][87] ([i915#265]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-kbl7/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@kms_plane_lowres@pipe-b-tiling-yf: - shard-hsw: NOTRUN -> [SKIP][88] ([fdo#109271]) +60 similar issues [88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-hsw7/igt@kms_plane_lowres@pipe-b-tiling-yf.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-apl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#658]) +3 similar issues [89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3: - shard-kbl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#658]) +1 similar issue [90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-kbl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html - shard-iclb: NOTRUN -> [SKIP][91] ([i915#2920]) [91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-2: - shard-glk: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#658]) +1 similar issue [92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-glk1/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html - shard-tglb: NOTRUN -> [SKIP][93] ([i915#2920]) +1 similar issue [93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb5/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html * igt@kms_psr@cursor_render: - shard-hsw: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#1072]) +2 similar issues [94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-hsw8/igt@kms_psr@cursor_render.html * igt@kms_psr@psr2_primary_mmap_gtt: - shard-iclb: [PASS][95] -> [SKIP][96] ([fdo#109441]) +2 similar issues [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb1/igt@kms_psr@psr2_primary_mmap_gtt.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: NOTRUN -> [SKIP][97] ([fdo#109441]) +2 similar issues [97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html * igt@kms_tv_load_detect@load-detect: - shard-tglb: NOTRUN -> [SKIP][98] ([fdo#109309]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb2/igt@kms_tv_load_detect@load-detect.html * igt@kms_vblank@pipe-d-wait-idle: - shard-apl: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#533]) +2 similar issues [99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl7/igt@kms_vblank@pipe-d-wait-idle.html * igt@kms_vrr@flip-basic: - shard-tglb: NOTRUN -> [SKIP][100] ([fdo#109502]) [100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb5/igt@kms_vrr@flip-basic.html * igt@nouveau_crc@pipe-b-source-rg: - shard-tglb: NOTRUN -> [SKIP][101] ([i915#2530]) +1 similar issue [101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb3/igt@nouveau_crc@pipe-b-source-rg.html * igt@nouveau_crc@pipe-d-ctx-flip-skip-current-frame: - shard-iclb: NOTRUN -> [SKIP][102] ([fdo#109278] / [i915#2530]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb2/igt@nouveau_crc@pipe-d-ctx-flip-skip-current-frame.html * igt@perf@per-context-mode-unprivileged: - shard-iclb: NOTRUN -> [SKIP][103] ([fdo#109289]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb5/igt@perf@per-context-mode-unprivileged.html - shard-tglb: NOTRUN -> [SKIP][104] ([fdo#109289]) [104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb1/igt@perf@per-context-mode-unprivileged.html * igt@prime_nv_api@nv_i915_import_twice_check_flink_name: - shard-iclb: NOTRUN -> [SKIP][105] ([fdo#109291]) +2 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb4/igt@prime_nv_api@nv_i915_import_twice_check_flink_name.html * igt@prime_nv_api@nv_self_import: - shard-tglb: NOTRUN -> [SKIP][106] ([fdo#109291]) +3 similar issues [106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb2/igt@prime_nv_api@nv_self_import.html * igt@prime_vgem@fence-flip-hang: - shard-iclb: NOTRUN -> [SKIP][107] ([fdo#109295]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb7/igt@prime_vgem@fence-flip-hang.html - shard-tglb: NOTRUN -> [SKIP][108] ([fdo#109295]) +1 similar issue [108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb6/igt@prime_vgem@fence-flip-hang.html #### Possible fixes #### * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [FAIL][109] ([i915#2842]) -> [PASS][110] [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-kbl: [FAIL][111] ([i915#2842]) -> [PASS][112] +1 similar issue [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-kbl6/igt@gem_exec_fair@basic-pace@rcs0.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-tglb: [FAIL][113] ([i915#2842]) -> [PASS][114] [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-tglb5/igt@gem_exec_fair@basic-pace@vecs0.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb2/igt@gem_exec_fair@basic-pace@vecs0.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-tglb: [DMESG-WARN][115] ([i915#1436] / [i915#1602] / [i915#1887] / [i915#2411]) -> [PASS][116] [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen: - shard-kbl: [FAIL][117] ([i915#54]) -> [PASS][118] [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-kbl6/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-kbl1/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html - shard-apl: [FAIL][119] ([i915#54]) -> [PASS][120] [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl7/igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-apl: [DMESG-WARN][121] ([i915#180]) -> [PASS][122] +4 similar issues [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [SKIP][123] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][124] +1 similar issue [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-iclb6/igt@kms_psr2_su@frontbuffer.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb2/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_cursor_mmap_gtt: - shard-iclb: [SKIP][125] ([fdo#109441]) -> [PASS][126] [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-iclb1/igt@kms_psr@psr2_cursor_mmap_gtt.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html * {igt@sysfs_clients@busy@vcs0}: - shard-glk: [FAIL][127] -> [PASS][128] [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-glk8/igt@sysfs_clients@busy@vcs0.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-glk7/igt@sysfs_clients@busy@vcs0.html * {igt@sysfs_clients@recycle}: - shard-iclb: [FAIL][129] -> [PASS][130] [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-iclb7/igt@sysfs_clients@recycle.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb3/igt@sysfs_clients@recycle.html - shard-kbl: [FAIL][131] -> [PASS][132] [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-kbl2/igt@sysfs_clients@recycle.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-kbl7/igt@sysfs_clients@recycle.html * {igt@sysfs_clients@split-10@bcs0}: - shard-glk: [SKIP][133] ([fdo#109271]) -> [PASS][134] [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-glk2/igt@sysfs_clients@split-10@bcs0.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-glk6/igt@sysfs_clients@split-10@bcs0.html #### Warnings #### * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][135] ([i915#2681] / [i915#2684]) -> [WARN][136] ([i915#1804] / [i915#2684]) [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5: - shard-iclb: [SKIP][137] ([i915#658]) -> [SKIP][138] ([i915#2920]) +1 similar issue [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-iclb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html * igt@runner@aborted: - shard-hsw: ([FAIL][139], [FAIL][140]) ([i915#2295] / [i915#2505]) -> ([FAIL][141], [FAIL][142], [FAIL][143]) ([i915#142] / [i915#2292] / [i915#2295] / [i915#2505] / [i915#2722] / [i915#54]) [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-hsw8/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9706/shard-hsw4/igt@runne == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5452/index.html [-- Attachment #1.2: Type: text/html, Size: 33752 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Hide unused clients 2021-01-31 3:11 ` [igt-dev] " Chris Wilson @ 2021-02-01 8:14 ` Tvrtko Ursulin -1 siblings, 0 replies; 21+ messages in thread From: Tvrtko Ursulin @ 2021-02-01 8:14 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: igt-dev On 31/01/2021 03:11, Chris Wilson wrote: > Keep new clients hidden until they utilise the GPU. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > --- > tools/intel_gpu_top.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > index 60ff62d28..66a8effa6 100644 > --- a/tools/intel_gpu_top.c > +++ b/tools/intel_gpu_top.c > @@ -828,8 +828,11 @@ static void update_client(struct client *c, unsigned int pid, char *name) > c->last[i] = val[i]; > } > > - c->samples++; > + if (!c->total_runtime) > + return; > + > c->status = ALIVE; > + c->samples++; > } > > static void > Not sure we need to do it at this level and not instead at presentation time. Plus, in default sort mode they would be at the end of the list, so behind the more active clients. Or you go into sort by id and they annoy you there? Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] intel_gpu_top: Hide unused clients @ 2021-02-01 8:14 ` Tvrtko Ursulin 0 siblings, 0 replies; 21+ messages in thread From: Tvrtko Ursulin @ 2021-02-01 8:14 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: igt-dev On 31/01/2021 03:11, Chris Wilson wrote: > Keep new clients hidden until they utilise the GPU. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > --- > tools/intel_gpu_top.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > index 60ff62d28..66a8effa6 100644 > --- a/tools/intel_gpu_top.c > +++ b/tools/intel_gpu_top.c > @@ -828,8 +828,11 @@ static void update_client(struct client *c, unsigned int pid, char *name) > c->last[i] = val[i]; > } > > - c->samples++; > + if (!c->total_runtime) > + return; > + > c->status = ALIVE; > + c->samples++; > } > > static void > Not sure we need to do it at this level and not instead at presentation time. Plus, in default sort mode they would be at the end of the list, so behind the more active clients. Or you go into sort by id and they annoy you there? Regards, Tvrtko _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Hide unused clients 2021-02-01 8:14 ` [igt-dev] " Tvrtko Ursulin @ 2021-02-01 8:21 ` Chris Wilson -1 siblings, 0 replies; 21+ messages in thread From: Chris Wilson @ 2021-02-01 8:21 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx; +Cc: igt-dev Quoting Tvrtko Ursulin (2021-02-01 08:14:45) > > On 31/01/2021 03:11, Chris Wilson wrote: > > Keep new clients hidden until they utilise the GPU. > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > > --- > > tools/intel_gpu_top.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > > index 60ff62d28..66a8effa6 100644 > > --- a/tools/intel_gpu_top.c > > +++ b/tools/intel_gpu_top.c > > @@ -828,8 +828,11 @@ static void update_client(struct client *c, unsigned int pid, char *name) > > c->last[i] = val[i]; > > } > > > > - c->samples++; > > + if (!c->total_runtime) > > + return; > > + > > c->status = ALIVE; > > + c->samples++; > > } > > > > static void > > > > Not sure we need to do it at this level and not instead at presentation > time. My goal was just presentation :( > Plus, in default sort mode they would be at the end of the list, > so behind the more active clients. Or you go into sort by id and they > annoy you there? No. I had a bunch of "Xorg" when launching steam which never became anything. So I guess just a bunch of dlopen("libgl") spawing a bunch of clients that we never used for anything more than gl[X]GetString, but leaked the fd. [Why does steam need 10% of the gpu to update an icon on the toolbar which is hidden while minimised? Why do games sit in static menus at 100% gpu? Why?] -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] intel_gpu_top: Hide unused clients @ 2021-02-01 8:21 ` Chris Wilson 0 siblings, 0 replies; 21+ messages in thread From: Chris Wilson @ 2021-02-01 8:21 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx; +Cc: igt-dev Quoting Tvrtko Ursulin (2021-02-01 08:14:45) > > On 31/01/2021 03:11, Chris Wilson wrote: > > Keep new clients hidden until they utilise the GPU. > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > > --- > > tools/intel_gpu_top.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > > index 60ff62d28..66a8effa6 100644 > > --- a/tools/intel_gpu_top.c > > +++ b/tools/intel_gpu_top.c > > @@ -828,8 +828,11 @@ static void update_client(struct client *c, unsigned int pid, char *name) > > c->last[i] = val[i]; > > } > > > > - c->samples++; > > + if (!c->total_runtime) > > + return; > > + > > c->status = ALIVE; > > + c->samples++; > > } > > > > static void > > > > Not sure we need to do it at this level and not instead at presentation > time. My goal was just presentation :( > Plus, in default sort mode they would be at the end of the list, > so behind the more active clients. Or you go into sort by id and they > annoy you there? No. I had a bunch of "Xorg" when launching steam which never became anything. So I guess just a bunch of dlopen("libgl") spawing a bunch of clients that we never used for anything more than gl[X]GetString, but leaked the fd. [Why does steam need 10% of the gpu to update an icon on the toolbar which is hidden while minimised? Why do games sit in static menus at 100% gpu? Why?] -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Hide unused clients 2021-02-01 8:21 ` [igt-dev] " Chris Wilson @ 2021-02-01 8:36 ` Tvrtko Ursulin -1 siblings, 0 replies; 21+ messages in thread From: Tvrtko Ursulin @ 2021-02-01 8:36 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: igt-dev On 01/02/2021 08:21, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2021-02-01 08:14:45) >> >> On 31/01/2021 03:11, Chris Wilson wrote: >>> Keep new clients hidden until they utilise the GPU. >>> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> >>> --- >>> tools/intel_gpu_top.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c >>> index 60ff62d28..66a8effa6 100644 >>> --- a/tools/intel_gpu_top.c >>> +++ b/tools/intel_gpu_top.c >>> @@ -828,8 +828,11 @@ static void update_client(struct client *c, unsigned int pid, char *name) >>> c->last[i] = val[i]; >>> } >>> >>> - c->samples++; >>> + if (!c->total_runtime) >>> + return; >>> + >>> c->status = ALIVE; >>> + c->samples++; >>> } >>> >>> static void >>> >> >> Not sure we need to do it at this level and not instead at presentation >> time. > > My goal was just presentation :( Something like this would be presentation time: diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index 60ff62d28e5d..f7c5cc3bf19f 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -1942,6 +1942,9 @@ print_client(struct client *c, struct engines *engines, double t, int lines, unsigned int i; if (output_mode == INTERACTIVE) { + if (!c->total_runtime) /* make a key toggle? */ + return; + lines++; printf("%6u %17s ", c->pid, c->print_name); But it worries me a bit to do it by default. > >> Plus, in default sort mode they would be at the end of the list, >> so behind the more active clients. Or you go into sort by id and they >> annoy you there? > > No. I had a bunch of "Xorg" when launching steam which never became > anything. So I guess just a bunch of dlopen("libgl") spawing a bunch of > clients that we never used for anything more than gl[X]GetString, but > leaked the fd. But they were at the end, so potentially even cut of if enough interesting clients? Or you actually sorted by id? Or something else is broken? > > [Why does steam need 10% of the gpu to update an icon on the toolbar > which is hidden while minimised? Why do games sit in static menus at > 100% gpu? Why?] Yep, I have this issue with animated KDE tray icons. :I Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] intel_gpu_top: Hide unused clients @ 2021-02-01 8:36 ` Tvrtko Ursulin 0 siblings, 0 replies; 21+ messages in thread From: Tvrtko Ursulin @ 2021-02-01 8:36 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: igt-dev On 01/02/2021 08:21, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2021-02-01 08:14:45) >> >> On 31/01/2021 03:11, Chris Wilson wrote: >>> Keep new clients hidden until they utilise the GPU. >>> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> >>> --- >>> tools/intel_gpu_top.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c >>> index 60ff62d28..66a8effa6 100644 >>> --- a/tools/intel_gpu_top.c >>> +++ b/tools/intel_gpu_top.c >>> @@ -828,8 +828,11 @@ static void update_client(struct client *c, unsigned int pid, char *name) >>> c->last[i] = val[i]; >>> } >>> >>> - c->samples++; >>> + if (!c->total_runtime) >>> + return; >>> + >>> c->status = ALIVE; >>> + c->samples++; >>> } >>> >>> static void >>> >> >> Not sure we need to do it at this level and not instead at presentation >> time. > > My goal was just presentation :( Something like this would be presentation time: diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index 60ff62d28e5d..f7c5cc3bf19f 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -1942,6 +1942,9 @@ print_client(struct client *c, struct engines *engines, double t, int lines, unsigned int i; if (output_mode == INTERACTIVE) { + if (!c->total_runtime) /* make a key toggle? */ + return; + lines++; printf("%6u %17s ", c->pid, c->print_name); But it worries me a bit to do it by default. > >> Plus, in default sort mode they would be at the end of the list, >> so behind the more active clients. Or you go into sort by id and they >> annoy you there? > > No. I had a bunch of "Xorg" when launching steam which never became > anything. So I guess just a bunch of dlopen("libgl") spawing a bunch of > clients that we never used for anything more than gl[X]GetString, but > leaked the fd. But they were at the end, so potentially even cut of if enough interesting clients? Or you actually sorted by id? Or something else is broken? > > [Why does steam need 10% of the gpu to update an icon on the toolbar > which is hidden while minimised? Why do games sit in static menus at > 100% gpu? Why?] Yep, I have this issue with animated KDE tray icons. :I Regards, Tvrtko _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Hide unused clients 2021-02-01 8:36 ` [igt-dev] " Tvrtko Ursulin @ 2021-02-01 8:49 ` Chris Wilson -1 siblings, 0 replies; 21+ messages in thread From: Chris Wilson @ 2021-02-01 8:49 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx; +Cc: igt-dev Quoting Tvrtko Ursulin (2021-02-01 08:36:04) > > On 01/02/2021 08:21, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2021-02-01 08:14:45) > >> > >> On 31/01/2021 03:11, Chris Wilson wrote: > >>> Keep new clients hidden until they utilise the GPU. > >>> > >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > >>> --- > >>> tools/intel_gpu_top.c | 5 ++++- > >>> 1 file changed, 4 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > >>> index 60ff62d28..66a8effa6 100644 > >>> --- a/tools/intel_gpu_top.c > >>> +++ b/tools/intel_gpu_top.c > >>> @@ -828,8 +828,11 @@ static void update_client(struct client *c, unsigned int pid, char *name) > >>> c->last[i] = val[i]; > >>> } > >>> > >>> - c->samples++; > >>> + if (!c->total_runtime) > >>> + return; > >>> + > >>> c->status = ALIVE; > >>> + c->samples++; > >>> } > >>> > >>> static void > >>> > >> > >> Not sure we need to do it at this level and not instead at presentation > >> time. > > > > My goal was just presentation :( > > Something like this would be presentation time: > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > index 60ff62d28e5d..f7c5cc3bf19f 100644 > --- a/tools/intel_gpu_top.c > +++ b/tools/intel_gpu_top.c > @@ -1942,6 +1942,9 @@ print_client(struct client *c, struct engines > *engines, double t, int lines, > unsigned int i; > > if (output_mode == INTERACTIVE) { > + if (!c->total_runtime) /* make a key toggle? */ > + return; > + > lines++; > > printf("%6u %17s ", c->pid, c->print_name); > > But it worries me a bit to do it by default. I was about to argue then remembered top behaves the same (although a process cannot exist without consuming at least some CPU resources, whereas a client can never touch the GPU or allocate GPU memory). But if we are borrow ideas for filtering the view from top... :) For top, it's 'i' and there's o%CPU>x > >> Plus, in default sort mode they would be at the end of the list, > >> so behind the more active clients. Or you go into sort by id and they > >> annoy you there? > > > > No. I had a bunch of "Xorg" when launching steam which never became > > anything. So I guess just a bunch of dlopen("libgl") spawing a bunch of > > clients that we never used for anything more than gl[X]GetString, but > > leaked the fd. > > But they were at the end, so potentially even cut of if enough > interesting clients? Or you actually sorted by id? Or something else is > broken? But they were there! Unwanted DRI3 fd, abandoned, left homeless before being used. Even if they are used, there's still a window where we would see "Xorg" become "realname" (granted there's still a window as we sample pidname before totalruntime), it irks me. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] intel_gpu_top: Hide unused clients @ 2021-02-01 8:49 ` Chris Wilson 0 siblings, 0 replies; 21+ messages in thread From: Chris Wilson @ 2021-02-01 8:49 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx; +Cc: igt-dev Quoting Tvrtko Ursulin (2021-02-01 08:36:04) > > On 01/02/2021 08:21, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2021-02-01 08:14:45) > >> > >> On 31/01/2021 03:11, Chris Wilson wrote: > >>> Keep new clients hidden until they utilise the GPU. > >>> > >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > >>> --- > >>> tools/intel_gpu_top.c | 5 ++++- > >>> 1 file changed, 4 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > >>> index 60ff62d28..66a8effa6 100644 > >>> --- a/tools/intel_gpu_top.c > >>> +++ b/tools/intel_gpu_top.c > >>> @@ -828,8 +828,11 @@ static void update_client(struct client *c, unsigned int pid, char *name) > >>> c->last[i] = val[i]; > >>> } > >>> > >>> - c->samples++; > >>> + if (!c->total_runtime) > >>> + return; > >>> + > >>> c->status = ALIVE; > >>> + c->samples++; > >>> } > >>> > >>> static void > >>> > >> > >> Not sure we need to do it at this level and not instead at presentation > >> time. > > > > My goal was just presentation :( > > Something like this would be presentation time: > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > index 60ff62d28e5d..f7c5cc3bf19f 100644 > --- a/tools/intel_gpu_top.c > +++ b/tools/intel_gpu_top.c > @@ -1942,6 +1942,9 @@ print_client(struct client *c, struct engines > *engines, double t, int lines, > unsigned int i; > > if (output_mode == INTERACTIVE) { > + if (!c->total_runtime) /* make a key toggle? */ > + return; > + > lines++; > > printf("%6u %17s ", c->pid, c->print_name); > > But it worries me a bit to do it by default. I was about to argue then remembered top behaves the same (although a process cannot exist without consuming at least some CPU resources, whereas a client can never touch the GPU or allocate GPU memory). But if we are borrow ideas for filtering the view from top... :) For top, it's 'i' and there's o%CPU>x > >> Plus, in default sort mode they would be at the end of the list, > >> so behind the more active clients. Or you go into sort by id and they > >> annoy you there? > > > > No. I had a bunch of "Xorg" when launching steam which never became > > anything. So I guess just a bunch of dlopen("libgl") spawing a bunch of > > clients that we never used for anything more than gl[X]GetString, but > > leaked the fd. > > But they were at the end, so potentially even cut of if enough > interesting clients? Or you actually sorted by id? Or something else is > broken? But they were there! Unwanted DRI3 fd, abandoned, left homeless before being used. Even if they are used, there's still a window where we would see "Xorg" become "realname" (granted there's still a window as we sample pidname before totalruntime), it irks me. -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Hide unused clients 2021-01-31 3:11 ` [igt-dev] " Chris Wilson ` (3 preceding siblings ...) (?) @ 2021-02-01 8:53 ` Chris Wilson 2021-02-01 9:12 ` Tvrtko Ursulin ` (2 more replies) -1 siblings, 3 replies; 21+ messages in thread From: Chris Wilson @ 2021-02-01 8:53 UTC (permalink / raw) To: intel-gfx; +Cc: Chris Wilson Hide inactive clients by pressing 'i' (toggle in interactive mode). Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> --- tools/intel_gpu_top.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index 60ff62d28..edf0dedac 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -1595,6 +1595,7 @@ print_imc(struct engines *engines, double t, int lines, int con_w, int con_h) } static bool class_view; +static bool filter_idle; static int print_engines_header(struct engines *engines, double t, @@ -1689,6 +1690,9 @@ print_engines_footer(struct engines *engines, double t, pops->close_struct(); if (output_mode == INTERACTIVE) { + if (filter_idle && !c->total_runtime) + return; + if (lines++ < con_h) printf("\n"); } @@ -2115,6 +2119,9 @@ static void process_stdin(unsigned int timeout_us) case 'q': stop_top = true; break; + case 'i': + filter_idle ^= true; + break; case '1': class_view ^= true; break; -- 2.30.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Hide unused clients 2021-02-01 8:53 ` [Intel-gfx] " Chris Wilson @ 2021-02-01 9:12 ` Tvrtko Ursulin 2021-02-01 9:31 ` [Intel-gfx] [PATCH i-g-t v2] " Chris Wilson 2021-02-01 13:02 ` [igt-dev] ✗ Fi.CI.BUILD: failure for intel_gpu_top: Hide unused clients (rev3) Patchwork 2 siblings, 0 replies; 21+ messages in thread From: Tvrtko Ursulin @ 2021-02-01 9:12 UTC (permalink / raw) To: Chris Wilson, intel-gfx On 01/02/2021 08:53, Chris Wilson wrote: > Hide inactive clients by pressing 'i' (toggle in interactive mode). > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > --- > tools/intel_gpu_top.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > index 60ff62d28..edf0dedac 100644 > --- a/tools/intel_gpu_top.c > +++ b/tools/intel_gpu_top.c > @@ -1595,6 +1595,7 @@ print_imc(struct engines *engines, double t, int lines, int con_w, int con_h) > } > > static bool class_view; > +static bool filter_idle; > > static int > print_engines_header(struct engines *engines, double t, > @@ -1689,6 +1690,9 @@ print_engines_footer(struct engines *engines, double t, > pops->close_struct(); > > if (output_mode == INTERACTIVE) { > + if (filter_idle && !c->total_runtime) > + return; > + > if (lines++ < con_h) > printf("\n"); > } > @@ -2115,6 +2119,9 @@ static void process_stdin(unsigned int timeout_us) > case 'q': > stop_top = true; > break; > + case 'i': > + filter_idle ^= true; > + break; > case '1': > class_view ^= true; > break; > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH i-g-t v2] intel_gpu_top: Hide unused clients 2021-02-01 8:53 ` [Intel-gfx] " Chris Wilson 2021-02-01 9:12 ` Tvrtko Ursulin @ 2021-02-01 9:31 ` Chris Wilson 2021-02-01 9:53 ` [igt-dev] " Tvrtko Ursulin 2021-02-01 13:02 ` [igt-dev] ✗ Fi.CI.BUILD: failure for intel_gpu_top: Hide unused clients (rev3) Patchwork 2 siblings, 1 reply; 21+ messages in thread From: Chris Wilson @ 2021-02-01 9:31 UTC (permalink / raw) To: intel-gfx; +Cc: igt-dev, Chris Wilson Hide inactive clients by pressing 'i' (toggle in interactive mode). v2: Fix location of filter_idle. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> --- tools/intel_gpu_top.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index 60ff62d28..d88b6cc61 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -1595,6 +1595,7 @@ print_imc(struct engines *engines, double t, int lines, int con_w, int con_h) } static bool class_view; +static bool filter_idle; static int print_engines_header(struct engines *engines, double t, @@ -2115,6 +2116,9 @@ static void process_stdin(unsigned int timeout_us) case 'q': stop_top = true; break; + case 'i': + filter_idle ^= true; + break; case '1': class_view ^= true; break; @@ -2323,9 +2327,14 @@ int main(int argc, char **argv) for_each_client(clients, c, j) { assert(c->status != PROBE); + if (c->status != ALIVE) break; /* Active clients are first in the array. */ + /* Active clients before idle */ + if (filter_idle && !c->total_runtime) + break; + if (lines >= con_h) break; -- 2.30.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t v2] intel_gpu_top: Hide unused clients 2021-02-01 9:31 ` [Intel-gfx] [PATCH i-g-t v2] " Chris Wilson @ 2021-02-01 9:53 ` Tvrtko Ursulin 0 siblings, 0 replies; 21+ messages in thread From: Tvrtko Ursulin @ 2021-02-01 9:53 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: igt-dev On 01/02/2021 09:31, Chris Wilson wrote: > Hide inactive clients by pressing 'i' (toggle in interactive mode). > > v2: Fix location of filter_idle. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > --- > tools/intel_gpu_top.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > index 60ff62d28..d88b6cc61 100644 > --- a/tools/intel_gpu_top.c > +++ b/tools/intel_gpu_top.c > @@ -1595,6 +1595,7 @@ print_imc(struct engines *engines, double t, int lines, int con_w, int con_h) > } > > static bool class_view; > +static bool filter_idle; > > static int > print_engines_header(struct engines *engines, double t, > @@ -2115,6 +2116,9 @@ static void process_stdin(unsigned int timeout_us) > case 'q': > stop_top = true; > break; > + case 'i': > + filter_idle ^= true; > + break; > case '1': > class_view ^= true; > break; > @@ -2323,9 +2327,14 @@ int main(int argc, char **argv) > > for_each_client(clients, c, j) { > assert(c->status != PROBE); > + > if (c->status != ALIVE) > break; /* Active clients are first in the array. */ > > + /* Active clients before idle */ > + if (filter_idle && !c->total_runtime) > + break; > + Break won't be correct for id sort. I don't see what did not work with v1? It should be effectively the same apart from the break. Regards, Tvrtko > if (lines >= con_h) > break; > > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] intel_gpu_top: Hide unused clients @ 2021-02-01 9:53 ` Tvrtko Ursulin 0 siblings, 0 replies; 21+ messages in thread From: Tvrtko Ursulin @ 2021-02-01 9:53 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: igt-dev On 01/02/2021 09:31, Chris Wilson wrote: > Hide inactive clients by pressing 'i' (toggle in interactive mode). > > v2: Fix location of filter_idle. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > --- > tools/intel_gpu_top.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > index 60ff62d28..d88b6cc61 100644 > --- a/tools/intel_gpu_top.c > +++ b/tools/intel_gpu_top.c > @@ -1595,6 +1595,7 @@ print_imc(struct engines *engines, double t, int lines, int con_w, int con_h) > } > > static bool class_view; > +static bool filter_idle; > > static int > print_engines_header(struct engines *engines, double t, > @@ -2115,6 +2116,9 @@ static void process_stdin(unsigned int timeout_us) > case 'q': > stop_top = true; > break; > + case 'i': > + filter_idle ^= true; > + break; > case '1': > class_view ^= true; > break; > @@ -2323,9 +2327,14 @@ int main(int argc, char **argv) > > for_each_client(clients, c, j) { > assert(c->status != PROBE); > + > if (c->status != ALIVE) > break; /* Active clients are first in the array. */ > > + /* Active clients before idle */ > + if (filter_idle && !c->total_runtime) > + break; > + Break won't be correct for id sort. I don't see what did not work with v1? It should be effectively the same apart from the break. Regards, Tvrtko > if (lines >= con_h) > break; > > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2] intel_gpu_top: Hide unused clients 2021-02-01 9:53 ` [igt-dev] " Tvrtko Ursulin (?) @ 2021-02-01 9:57 ` Chris Wilson 2021-02-01 10:05 ` Tvrtko Ursulin -1 siblings, 1 reply; 21+ messages in thread From: Chris Wilson @ 2021-02-01 9:57 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx; +Cc: igt-dev Quoting Tvrtko Ursulin (2021-02-01 09:53:20) > > On 01/02/2021 09:31, Chris Wilson wrote: > > Hide inactive clients by pressing 'i' (toggle in interactive mode). > > > > v2: Fix location of filter_idle. > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > > --- > > tools/intel_gpu_top.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c > > index 60ff62d28..d88b6cc61 100644 > > --- a/tools/intel_gpu_top.c > > +++ b/tools/intel_gpu_top.c > > @@ -1595,6 +1595,7 @@ print_imc(struct engines *engines, double t, int lines, int con_w, int con_h) > > } > > > > static bool class_view; > > +static bool filter_idle; > > > > static int > > print_engines_header(struct engines *engines, double t, > > @@ -2115,6 +2116,9 @@ static void process_stdin(unsigned int timeout_us) > > case 'q': > > stop_top = true; > > break; > > + case 'i': > > + filter_idle ^= true; > > + break; > > case '1': > > class_view ^= true; > > break; > > @@ -2323,9 +2327,14 @@ int main(int argc, char **argv) > > > > for_each_client(clients, c, j) { > > assert(c->status != PROBE); > > + > > if (c->status != ALIVE) > > break; /* Active clients are first in the array. */ > > > > + /* Active clients before idle */ > > + if (filter_idle && !c->total_runtime) > > + break; > > + > > Break won't be correct for id sort. I don't see what did not work with > v1? It should be effectively the same apart from the break. We didn't the client to peek into. Maybe you want to do v3 :) -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2] intel_gpu_top: Hide unused clients 2021-02-01 9:57 ` [Intel-gfx] " Chris Wilson @ 2021-02-01 10:05 ` Tvrtko Ursulin 0 siblings, 0 replies; 21+ messages in thread From: Tvrtko Ursulin @ 2021-02-01 10:05 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: igt-dev On 01/02/2021 09:57, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2021-02-01 09:53:20) >> >> On 01/02/2021 09:31, Chris Wilson wrote: >>> Hide inactive clients by pressing 'i' (toggle in interactive mode). >>> >>> v2: Fix location of filter_idle. >>> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> >>> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> >>> --- >>> tools/intel_gpu_top.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c >>> index 60ff62d28..d88b6cc61 100644 >>> --- a/tools/intel_gpu_top.c >>> +++ b/tools/intel_gpu_top.c >>> @@ -1595,6 +1595,7 @@ print_imc(struct engines *engines, double t, int lines, int con_w, int con_h) >>> } >>> >>> static bool class_view; >>> +static bool filter_idle; >>> >>> static int >>> print_engines_header(struct engines *engines, double t, >>> @@ -2115,6 +2116,9 @@ static void process_stdin(unsigned int timeout_us) >>> case 'q': >>> stop_top = true; >>> break; >>> + case 'i': >>> + filter_idle ^= true; >>> + break; >>> case '1': >>> class_view ^= true; >>> break; >>> @@ -2323,9 +2327,14 @@ int main(int argc, char **argv) >>> >>> for_each_client(clients, c, j) { >>> assert(c->status != PROBE); >>> + >>> if (c->status != ALIVE) >>> break; /* Active clients are first in the array. */ >>> >>> + /* Active clients before idle */ >>> + if (filter_idle && !c->total_runtime) >>> + break; >>> + >> >> Break won't be correct for id sort. I don't see what did not work with >> v1? It should be effectively the same apart from the break. > > We didn't the client to peek into. Ahaha did not spot you put the diff in wrong function. :) > Maybe you want to do v3 :) Sure. Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] intel_gpu_top: Hide unused clients @ 2021-02-01 10:05 ` Tvrtko Ursulin 0 siblings, 0 replies; 21+ messages in thread From: Tvrtko Ursulin @ 2021-02-01 10:05 UTC (permalink / raw) To: Chris Wilson, intel-gfx; +Cc: igt-dev On 01/02/2021 09:57, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2021-02-01 09:53:20) >> >> On 01/02/2021 09:31, Chris Wilson wrote: >>> Hide inactive clients by pressing 'i' (toggle in interactive mode). >>> >>> v2: Fix location of filter_idle. >>> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> >>> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> >>> --- >>> tools/intel_gpu_top.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c >>> index 60ff62d28..d88b6cc61 100644 >>> --- a/tools/intel_gpu_top.c >>> +++ b/tools/intel_gpu_top.c >>> @@ -1595,6 +1595,7 @@ print_imc(struct engines *engines, double t, int lines, int con_w, int con_h) >>> } >>> >>> static bool class_view; >>> +static bool filter_idle; >>> >>> static int >>> print_engines_header(struct engines *engines, double t, >>> @@ -2115,6 +2116,9 @@ static void process_stdin(unsigned int timeout_us) >>> case 'q': >>> stop_top = true; >>> break; >>> + case 'i': >>> + filter_idle ^= true; >>> + break; >>> case '1': >>> class_view ^= true; >>> break; >>> @@ -2323,9 +2327,14 @@ int main(int argc, char **argv) >>> >>> for_each_client(clients, c, j) { >>> assert(c->status != PROBE); >>> + >>> if (c->status != ALIVE) >>> break; /* Active clients are first in the array. */ >>> >>> + /* Active clients before idle */ >>> + if (filter_idle && !c->total_runtime) >>> + break; >>> + >> >> Break won't be correct for id sort. I don't see what did not work with >> v1? It should be effectively the same apart from the break. > > We didn't the client to peek into. Ahaha did not spot you put the diff in wrong function. :) > Maybe you want to do v3 :) Sure. Regards, Tvrtko _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 21+ messages in thread
* [igt-dev] ✗ Fi.CI.BUILD: failure for intel_gpu_top: Hide unused clients (rev3) 2021-02-01 8:53 ` [Intel-gfx] " Chris Wilson 2021-02-01 9:12 ` Tvrtko Ursulin 2021-02-01 9:31 ` [Intel-gfx] [PATCH i-g-t v2] " Chris Wilson @ 2021-02-01 13:02 ` Patchwork 2 siblings, 0 replies; 21+ messages in thread From: Patchwork @ 2021-02-01 13:02 UTC (permalink / raw) To: Tvrtko Ursulin; +Cc: igt-dev == Series Details == Series: intel_gpu_top: Hide unused clients (rev3) URL : https://patchwork.freedesktop.org/series/86486/ State : failure == Summary == IGT patchset build failed on latest successful build 536e0c2e9a63721596cdf93e996e7469cadfaaae intel_gpu_top: Add option to hide inactive clients [399/454] Linking target tools/hsw_compute_wrpll. [400/454] Linking target tools/skl_compute_wrpll. [401/454] Linking target tools/skl_ddb_allocation. [402/454] Linking target tools/intel_audio_dump. [403/454] Linking target tools/intel_backlight. [404/454] Linking target tools/intel_bios_dumper. [405/454] Linking target tools/intel_display_crc. [406/454] Linking target tools/intel_display_poller. [407/454] Linking target tools/intel_forcewaked. [408/454] Linking target tools/intel_gpu_frequency. [409/454] Linking target tools/intel_gtt. [410/454] Linking target tools/intel_firmware_decode. [411/454] Linking target tools/intel_gpu_time. [412/454] Linking target tools/intel_guc_logger. [413/454] Linking target tools/intel_infoframes. [414/454] Linking target tools/intel_lid. [415/454] Linking target tools/intel_opregion_decode. [416/454] Linking target tools/intel_panel_fitter. [417/454] Linking target tools/intel_reg_checker. [418/454] Linking target tools/intel_residency. [419/454] Linking target tools/intel_stepping. [420/454] Linking target tools/intel_vbt_decode. [421/454] Linking target tools/intel_watermark. [422/454] Linking target tools/dpcd_reg. [423/454] Linking target tools/intel_gem_info. [424/454] Linking target tools/intel_gvtg_test. [425/454] Linking target tools/intel_dump_decode. [426/454] Linking target tools/lsgpu. [427/454] Linking target tools/intel_framebuffer_dump. [428/454] Linking target tools/intel_error_decode. [429/454] Linking target tools/intel_perf_counters. [430/454] Linking target tools/intel_dp_compliance. [431/454] Linking target tools/intel_l3_parity. [432/454] Compiling C object 'tools/tools@@intel_gpu_top@exe/intel_gpu_top.c.o'. FAILED: tools/tools@@intel_gpu_top@exe/intel_gpu_top.c.o ccache cc -Itools/tools@@intel_gpu_top@exe -Itools -I../tools -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I/home/cidrm/kernel_headers/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wimplicit-fallthrough=0 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -fcommon -MD -MQ 'tools/tools@@intel_gpu_top@exe/intel_gpu_top.c.o' -MF 'tools/tools@@intel_gpu_top@exe/intel_gpu_top.c.o.d' -o 'tools/tools@@intel_gpu_top@exe/intel_gpu_top.c.o' -c ../tools/intel_gpu_top.c ../tools/intel_gpu_top.c:1937:13: warning: redundant redeclaration of ‘filter_idle’ [-Wredundant-decls] static bool filter_idle; ^~~~~~~~~~~ ../tools/intel_gpu_top.c:1598:13: note: previous declaration of ‘filter_idle’ was here static bool filter_idle; ^~~~~~~~~~~ ../tools/intel_gpu_top.c: In function ‘process_stdin’: ../tools/intel_gpu_top.c:2129:3: error: duplicate case value case 'i': ^~~~ ../tools/intel_gpu_top.c:2123:3: note: previously used here case 'i': ^~~~ ninja: build stopped: subcommand failed. _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2021-02-01 13:02 UTC | newest] Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-01-31 3:11 [Intel-gfx] [PATCH i-g-t] intel_gpu_top: Hide unused clients Chris Wilson 2021-01-31 3:11 ` [igt-dev] " Chris Wilson 2021-01-31 3:46 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2021-01-31 4:48 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2021-02-01 8:14 ` [Intel-gfx] [PATCH i-g-t] " Tvrtko Ursulin 2021-02-01 8:14 ` [igt-dev] " Tvrtko Ursulin 2021-02-01 8:21 ` [Intel-gfx] " Chris Wilson 2021-02-01 8:21 ` [igt-dev] " Chris Wilson 2021-02-01 8:36 ` [Intel-gfx] " Tvrtko Ursulin 2021-02-01 8:36 ` [igt-dev] " Tvrtko Ursulin 2021-02-01 8:49 ` [Intel-gfx] " Chris Wilson 2021-02-01 8:49 ` [igt-dev] " Chris Wilson 2021-02-01 8:53 ` [Intel-gfx] " Chris Wilson 2021-02-01 9:12 ` Tvrtko Ursulin 2021-02-01 9:31 ` [Intel-gfx] [PATCH i-g-t v2] " Chris Wilson 2021-02-01 9:53 ` Tvrtko Ursulin 2021-02-01 9:53 ` [igt-dev] " Tvrtko Ursulin 2021-02-01 9:57 ` [Intel-gfx] " Chris Wilson 2021-02-01 10:05 ` Tvrtko Ursulin 2021-02-01 10:05 ` Tvrtko Ursulin 2021-02-01 13:02 ` [igt-dev] ✗ Fi.CI.BUILD: failure for intel_gpu_top: Hide unused clients (rev3) Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.