From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
yung-chuan.liao@linux.intel.com, gregkh@linuxfoundation.org,
sanyog.r.kale@intel.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] soundwire: add support for static port mapping
Date: Mon, 1 Feb 2021 15:57:09 +0530 [thread overview]
Message-ID: <20210201102709.GT2771@vkoul-mobl> (raw)
In-Reply-To: <31ff9d2b-760a-374e-5b37-45d8e8116f7b@linaro.org>
On 25-01-21, 16:23, Srinivas Kandagatla wrote:
>
>
> On 22/01/2021 16:42, Pierre-Louis Bossart wrote:
> > > >
> > > > if you completely remove the stream and re-add it with updated
> > > > configuration things should work.
> > >
> > > That's exactly what we do currently!
> > >
> > > The updated ports due to new configuration ex: for "mic capture"
> > > dailink needs to be communicated from slave(codec) to master so that
> > > it can allocate correct ports. That is what this patch is trying to
> > > do (share current port map information).
> >
> > .. we have a disconnect on how to do this configuration update.
> >
> > The 'stream' support was designed so that a stream can be split across
> > multiple devices (both masters and slaves). With this design we need to
> > have a central configuration and distribute the information to all
> > devices taking part of the stream.
That is correct, but in this case a stream consists of one master and
one or more slave devices. This is not a multi-master design. The adding
of multiple masters should not be done here... that does not seem
logically right in this situation
> > It seems you are in a different solution-space, where the codec driver
> > needs to notify the master of which ports it needs to use?
>
> Correct! As Codec is the place where we have mixer controls ant it can
> clearly tell which master ports should be used for that particular
> configuration.
And that should come from firmware (DT etc) and driver should pass on
this info
> > I also don't see where the mapping is actually set. Patch 2 uses a
> > mapping but there's no codec driver change that defines the mapping?
> >
> > Do you actually call sdw_stream_add_slave() with a new mapping?
> >
> Yes, currently am working on a codec driver for WCD938x Codec, which I will
> posting very soon!
>
> > It feels we are missing the codec part to really see what you are trying
> > to do?
> My WIP code is at https://git.linaro.org/people/srinivas.kandagatla/linux.git/tree/sound/soc/codecs/wcd938x.c?h=wcd938x/wip#n4526
>
> Currently the master ports are hardcoded in the driver for now, but these
> will come from DT.
>
> --srini
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, gregkh@linuxfoundation.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com,
yung-chuan.liao@linux.intel.com
Subject: Re: [RFC PATCH 1/2] soundwire: add support for static port mapping
Date: Mon, 1 Feb 2021 15:57:09 +0530 [thread overview]
Message-ID: <20210201102709.GT2771@vkoul-mobl> (raw)
In-Reply-To: <31ff9d2b-760a-374e-5b37-45d8e8116f7b@linaro.org>
On 25-01-21, 16:23, Srinivas Kandagatla wrote:
>
>
> On 22/01/2021 16:42, Pierre-Louis Bossart wrote:
> > > >
> > > > if you completely remove the stream and re-add it with updated
> > > > configuration things should work.
> > >
> > > That's exactly what we do currently!
> > >
> > > The updated ports due to new configuration ex: for "mic capture"
> > > dailink needs to be communicated from slave(codec) to master so that
> > > it can allocate correct ports. That is what this patch is trying to
> > > do (share current port map information).
> >
> > .. we have a disconnect on how to do this configuration update.
> >
> > The 'stream' support was designed so that a stream can be split across
> > multiple devices (both masters and slaves). With this design we need to
> > have a central configuration and distribute the information to all
> > devices taking part of the stream.
That is correct, but in this case a stream consists of one master and
one or more slave devices. This is not a multi-master design. The adding
of multiple masters should not be done here... that does not seem
logically right in this situation
> > It seems you are in a different solution-space, where the codec driver
> > needs to notify the master of which ports it needs to use?
>
> Correct! As Codec is the place where we have mixer controls ant it can
> clearly tell which master ports should be used for that particular
> configuration.
And that should come from firmware (DT etc) and driver should pass on
this info
> > I also don't see where the mapping is actually set. Patch 2 uses a
> > mapping but there's no codec driver change that defines the mapping?
> >
> > Do you actually call sdw_stream_add_slave() with a new mapping?
> >
> Yes, currently am working on a codec driver for WCD938x Codec, which I will
> posting very soon!
>
> > It feels we are missing the codec part to really see what you are trying
> > to do?
> My WIP code is at https://git.linaro.org/people/srinivas.kandagatla/linux.git/tree/sound/soc/codecs/wcd938x.c?h=wcd938x/wip#n4526
>
> Currently the master ports are hardcoded in the driver for now, but these
> will come from DT.
>
> --srini
--
~Vinod
next prev parent reply other threads:[~2021-02-01 10:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 18:01 [RFC PATCH 0/2] soundwire: add static port mapping support Srinivas Kandagatla
2021-01-20 18:01 ` Srinivas Kandagatla
2021-01-20 18:01 ` [RFC PATCH 1/2] soundwire: add support for static port mapping Srinivas Kandagatla
2021-01-20 18:01 ` Srinivas Kandagatla
2021-01-20 22:15 ` Pierre-Louis Bossart
2021-01-20 22:15 ` Pierre-Louis Bossart
2021-01-21 11:35 ` Srinivas Kandagatla
2021-01-21 11:35 ` Srinivas Kandagatla
2021-01-21 14:56 ` Pierre-Louis Bossart
2021-01-21 15:41 ` Srinivas Kandagatla
2021-01-21 18:00 ` Pierre-Louis Bossart
2021-01-21 18:41 ` Srinivas Kandagatla
2021-01-21 21:30 ` Pierre-Louis Bossart
2021-01-22 7:05 ` Srinivas Kandagatla
2021-01-22 15:32 ` Pierre-Louis Bossart
2021-01-22 15:46 ` Srinivas Kandagatla
2021-01-22 16:42 ` Pierre-Louis Bossart
2021-01-25 16:23 ` Srinivas Kandagatla
2021-02-01 10:27 ` Vinod Koul [this message]
2021-02-01 10:27 ` Vinod Koul
2021-02-19 10:35 ` Srinivas Kandagatla
2021-02-19 10:35 ` Srinivas Kandagatla
2021-02-19 19:52 ` Pierre-Louis Bossart
2021-02-19 19:52 ` Pierre-Louis Bossart
2021-02-22 13:40 ` Srinivas Kandagatla
2021-02-22 13:40 ` Srinivas Kandagatla
2021-01-20 18:01 ` [RFC PATCH 2/2] soundwire: qcom: " Srinivas Kandagatla
2021-01-20 18:01 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201102709.GT2771@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.