From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com,
yung-chuan.liao@linux.intel.com
Subject: Re: [RFC PATCH 1/2] soundwire: add support for static port mapping
Date: Fri, 19 Feb 2021 13:52:04 -0600 [thread overview]
Message-ID: <64d2537a-bd60-e0a3-c4aa-4f802c34102b@linux.intel.com> (raw)
In-Reply-To: <c8bb718d-c06d-2942-9c0b-2a6f97031e10@linaro.org>
>>>> It seems you are in a different solution-space, where the codec driver
>>>> needs to notify the master of which ports it needs to use?
>>> Correct! As Codec is the place where we have mixer controls ant it can
>>> clearly tell which master ports should be used for that particular
>>> configuration.
>> And that should come from firmware (DT etc) and driver should pass on
>> this info
>
> Are you okay with the patch as it is, provided this information is
> populated from DT?
I am fine with the direction at a high-level. The premise for SoundWire
is that the bus is simple enough that it can be used in different
contexts and architectures, so if Qualcomm need something that differs
from what is needed for Intel we are really not in a position to object.
That said, I could use more explanations on how the mapping is defined:
I don't think we have the same definition of 'static port mapping'. For
SDCA integration, we plan to have a static mapping in some sort of ACPI
table that will describe which port on the Manager side is connected to
which ports on Peripheral XYZ. That's static as in set in stone in
platform firmware. I understand the reference to DT settings as the same
idea.
But if the mapping depends on the value of mixer controls as you
describe it, then it's not static and defined by DT settings, but
run-time defined.
Also maybe we'd want to have a more opaque way of passing the
information, maybe with a stream private data or a callback, instead of
hard-coding fields that are only used by Qualcomm.
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Cc: gregkh@linuxfoundation.org, alsa-devel@alsa-project.org,
yung-chuan.liao@linux.intel.com, linux-kernel@vger.kernel.org,
sanyog.r.kale@intel.com
Subject: Re: [RFC PATCH 1/2] soundwire: add support for static port mapping
Date: Fri, 19 Feb 2021 13:52:04 -0600 [thread overview]
Message-ID: <64d2537a-bd60-e0a3-c4aa-4f802c34102b@linux.intel.com> (raw)
In-Reply-To: <c8bb718d-c06d-2942-9c0b-2a6f97031e10@linaro.org>
>>>> It seems you are in a different solution-space, where the codec driver
>>>> needs to notify the master of which ports it needs to use?
>>> Correct! As Codec is the place where we have mixer controls ant it can
>>> clearly tell which master ports should be used for that particular
>>> configuration.
>> And that should come from firmware (DT etc) and driver should pass on
>> this info
>
> Are you okay with the patch as it is, provided this information is
> populated from DT?
I am fine with the direction at a high-level. The premise for SoundWire
is that the bus is simple enough that it can be used in different
contexts and architectures, so if Qualcomm need something that differs
from what is needed for Intel we are really not in a position to object.
That said, I could use more explanations on how the mapping is defined:
I don't think we have the same definition of 'static port mapping'. For
SDCA integration, we plan to have a static mapping in some sort of ACPI
table that will describe which port on the Manager side is connected to
which ports on Peripheral XYZ. That's static as in set in stone in
platform firmware. I understand the reference to DT settings as the same
idea.
But if the mapping depends on the value of mixer controls as you
describe it, then it's not static and defined by DT settings, but
run-time defined.
Also maybe we'd want to have a more opaque way of passing the
information, maybe with a stream private data or a callback, instead of
hard-coding fields that are only used by Qualcomm.
next prev parent reply other threads:[~2021-02-19 21:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 18:01 [RFC PATCH 0/2] soundwire: add static port mapping support Srinivas Kandagatla
2021-01-20 18:01 ` Srinivas Kandagatla
2021-01-20 18:01 ` [RFC PATCH 1/2] soundwire: add support for static port mapping Srinivas Kandagatla
2021-01-20 18:01 ` Srinivas Kandagatla
2021-01-20 22:15 ` Pierre-Louis Bossart
2021-01-20 22:15 ` Pierre-Louis Bossart
2021-01-21 11:35 ` Srinivas Kandagatla
2021-01-21 11:35 ` Srinivas Kandagatla
2021-01-21 14:56 ` Pierre-Louis Bossart
2021-01-21 15:41 ` Srinivas Kandagatla
2021-01-21 18:00 ` Pierre-Louis Bossart
2021-01-21 18:41 ` Srinivas Kandagatla
2021-01-21 21:30 ` Pierre-Louis Bossart
2021-01-22 7:05 ` Srinivas Kandagatla
2021-01-22 15:32 ` Pierre-Louis Bossart
2021-01-22 15:46 ` Srinivas Kandagatla
2021-01-22 16:42 ` Pierre-Louis Bossart
2021-01-25 16:23 ` Srinivas Kandagatla
2021-02-01 10:27 ` Vinod Koul
2021-02-01 10:27 ` Vinod Koul
2021-02-19 10:35 ` Srinivas Kandagatla
2021-02-19 10:35 ` Srinivas Kandagatla
2021-02-19 19:52 ` Pierre-Louis Bossart [this message]
2021-02-19 19:52 ` Pierre-Louis Bossart
2021-02-22 13:40 ` Srinivas Kandagatla
2021-02-22 13:40 ` Srinivas Kandagatla
2021-01-20 18:01 ` [RFC PATCH 2/2] soundwire: qcom: " Srinivas Kandagatla
2021-01-20 18:01 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64d2537a-bd60-e0a3-c4aa-4f802c34102b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.