From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Giancarlo Ferrari <giancarlo.ferrari89@gmail.com>,
linux-kernel@vger.kernel.org, penberg@kernel.org,
geert@linux-m68k.org, linux-arm-kernel@lists.infradead.org,
akpm@linux-foundation.org, rppt@kernel.org,
giancarlo.ferrari@nokia.com
Subject: Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated
Date: Mon, 1 Feb 2021 16:37:50 +0000 [thread overview]
Message-ID: <20210201163750.GI1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210201163240.GE66060@C02TD0UTHF1T.local>
On Mon, Feb 01, 2021 at 04:32:40PM +0000, Mark Rutland wrote:
> I reckon here we need:
>
> __cpuc_flush_dcache_area(reboot_code_buffer,
> relocate_new_kernel_size + sizeof(*data));
>
> ... to make sure both the instructions and data are visible with the MMU
> off (since fncpy() only cleans to the PoU, not the PoC).
We don't. When soft_restart() turns the MMU off, and it calls
flush_cache_all() before and afterwards to ensure that all dirty lines
are pushed out.
The flushing to PoU in fncpy() is to cover other cases.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, penberg@kernel.org,
geert@linux-m68k.org, rppt@kernel.org,
Giancarlo Ferrari <giancarlo.ferrari89@gmail.com>,
akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
giancarlo.ferrari@nokia.com
Subject: Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated
Date: Mon, 1 Feb 2021 16:37:50 +0000 [thread overview]
Message-ID: <20210201163750.GI1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210201163240.GE66060@C02TD0UTHF1T.local>
On Mon, Feb 01, 2021 at 04:32:40PM +0000, Mark Rutland wrote:
> I reckon here we need:
>
> __cpuc_flush_dcache_area(reboot_code_buffer,
> relocate_new_kernel_size + sizeof(*data));
>
> ... to make sure both the instructions and data are visible with the MMU
> off (since fncpy() only cleans to the PoU, not the PoC).
We don't. When soft_restart() turns the MMU off, and it calls
flush_cache_all() before and afterwards to ensure that all dirty lines
are pushed out.
The flushing to PoU in fncpy() is to cover other cases.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-01 16:38 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 0:44 [PATCH] ARM: kexec: Fix panic after TLB are invalidated Giancarlo Ferrari
2021-02-01 0:44 ` Giancarlo Ferrari
2021-02-01 11:34 ` Russell King - ARM Linux admin
2021-02-01 11:34 ` Russell King - ARM Linux admin
2021-02-01 12:47 ` Mark Rutland
2021-02-01 12:47 ` Mark Rutland
2021-02-01 13:03 ` Russell King - ARM Linux admin
2021-02-01 13:03 ` Russell King - ARM Linux admin
2021-02-01 13:57 ` Mark Rutland
2021-02-01 13:57 ` Mark Rutland
2021-02-01 16:08 ` Russell King - ARM Linux admin
2021-02-01 16:08 ` Russell King - ARM Linux admin
2021-02-01 16:32 ` Mark Rutland
2021-02-01 16:32 ` Mark Rutland
2021-02-01 16:37 ` Russell King - ARM Linux admin [this message]
2021-02-01 16:37 ` Russell King - ARM Linux admin
2021-02-01 20:07 ` Giancarlo Ferrari
2021-02-01 20:07 ` Giancarlo Ferrari
2021-02-01 20:16 ` Russell King - ARM Linux admin
2021-02-01 20:16 ` Russell King - ARM Linux admin
2021-02-01 22:18 ` Giancarlo Ferrari
2021-02-01 22:18 ` Giancarlo Ferrari
2021-02-04 23:48 ` Giancarlo Ferrari
2021-02-04 23:48 ` Giancarlo Ferrari
2021-02-05 0:18 ` Russell King - ARM Linux admin
2021-02-05 0:18 ` Russell King - ARM Linux admin
2021-02-05 0:40 ` Giancarlo Ferrari
2021-02-05 0:40 ` Giancarlo Ferrari
2021-02-05 0:45 ` Giancarlo Ferrari
2021-02-05 0:45 ` Giancarlo Ferrari
2021-02-05 9:44 ` Russell King - ARM Linux admin
2021-02-05 9:44 ` Russell King - ARM Linux admin
2021-02-05 14:36 ` Giancarlo Ferrari
2021-02-05 14:36 ` Giancarlo Ferrari
2021-02-01 14:39 ` Giancarlo Ferrari
2021-02-01 14:39 ` Giancarlo Ferrari
2021-02-01 15:30 ` Mark Rutland
2021-02-01 15:30 ` Mark Rutland
2021-02-01 19:09 ` Giancarlo Ferrari
2021-02-01 19:09 ` Giancarlo Ferrari
-- strict thread matches above, loose matches on Subject: below --
2021-01-12 16:49 Giancarlo Ferrari
2021-01-12 16:49 ` Giancarlo Ferrari
2021-02-01 10:10 ` Giancarlo Ferrari
2021-02-01 10:10 ` Giancarlo Ferrari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201163750.GI1463@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=giancarlo.ferrari89@gmail.com \
--cc=giancarlo.ferrari@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=penberg@kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.