* [PATCH] selftests/vm: rename file run_vmtests to run_vmtests.sh
@ 2021-02-05 8:55 Rong Chen
2021-02-05 20:06 ` John Hubbard
0 siblings, 1 reply; 2+ messages in thread
From: Rong Chen @ 2021-02-05 8:55 UTC (permalink / raw)
To: Shuah Khan, John Hubbard, Andrew Morton
Cc: Rong Chen, kernel test robot, linux-kselftest, linux-kernel
Commit c2aa8afc36fa has renamed run_vmtests in Makefile,
but the file still uses the old name.
The kernel test robot reported the following issue:
# selftests: vm: run_vmtests.sh
# Warning: file run_vmtests.sh is missing!
not ok 1 selftests: vm: run_vmtests.sh
Reported-by: kernel test robot <lkp@intel.com>
Fixes: c2aa8afc36fa (selftests/vm: rename run_vmtests --> run_vmtests.sh)
Signed-off-by: Rong Chen <rong.a.chen@intel.com>
---
tools/testing/selftests/vm/{run_vmtests => run_vmtests.sh} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename tools/testing/selftests/vm/{run_vmtests => run_vmtests.sh} (100%)
diff --git a/tools/testing/selftests/vm/run_vmtests b/tools/testing/selftests/vm/run_vmtests.sh
similarity index 100%
rename from tools/testing/selftests/vm/run_vmtests
rename to tools/testing/selftests/vm/run_vmtests.sh
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/vm: rename file run_vmtests to run_vmtests.sh
2021-02-05 8:55 [PATCH] selftests/vm: rename file run_vmtests to run_vmtests.sh Rong Chen
@ 2021-02-05 20:06 ` John Hubbard
0 siblings, 0 replies; 2+ messages in thread
From: John Hubbard @ 2021-02-05 20:06 UTC (permalink / raw)
To: Rong Chen, Shuah Khan, Andrew Morton
Cc: kernel test robot, linux-kselftest, linux-kernel
On 2/5/21 12:55 AM, Rong Chen wrote:
> Commit c2aa8afc36fa has renamed run_vmtests in Makefile,
> but the file still uses the old name.
>
> The kernel test robot reported the following issue:
>
> # selftests: vm: run_vmtests.sh
> # Warning: file run_vmtests.sh is missing!
> not ok 1 selftests: vm: run_vmtests.sh
>
I don't know exactly what is going on here, but there was originally a mistake
on my part in renaming run_vmtests to run_vmtests.sh (I was trying to set
the executable bit, which is not always supported by the patch flow), and that
caused some churn in Andrews's tree. And so maybe that rename got lost/dropped
along the way.
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: c2aa8afc36fa (selftests/vm: rename run_vmtests --> run_vmtests.sh)
> Signed-off-by: Rong Chen <rong.a.chen@intel.com>
> ---
> tools/testing/selftests/vm/{run_vmtests => run_vmtests.sh} | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename tools/testing/selftests/vm/{run_vmtests => run_vmtests.sh} (100%)
>
> diff --git a/tools/testing/selftests/vm/run_vmtests b/tools/testing/selftests/vm/run_vmtests.sh
> similarity index 100%
> rename from tools/testing/selftests/vm/run_vmtests
> rename to tools/testing/selftests/vm/run_vmtests.sh
>
So I guess this is OK, given that I see "run_vmtests" in both -next
and main.
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
thanks,
--
John Hubbard
NVIDIA
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-05 20:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 8:55 [PATCH] selftests/vm: rename file run_vmtests to run_vmtests.sh Rong Chen
2021-02-05 20:06 ` John Hubbard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.