* [PATCH 2/2] board: toradex: move RGMII delays to PHY side
2021-02-09 8:38 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Oleksandr Suvorov
@ 2021-02-09 8:38 ` Oleksandr Suvorov
2021-02-10 19:20 ` Fabio Estevam
2021-03-01 11:55 ` sbabic at denx.de
2021-02-09 8:41 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Marek Vasut
` (3 subsequent siblings)
4 siblings, 2 replies; 10+ messages in thread
From: Oleksandr Suvorov @ 2021-02-09 8:38 UTC (permalink / raw)
To: u-boot
The RGMII link delays can be set on either MAC or PHY side. Set the
rgmii-id PHY mode for FEC and remove FEC_ENET_ENABLE_.XC_DELAY
setting, so that these definitions aren't used anymore throughout
the U-Boot.
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
---
arch/arm/dts/fsl-imx8qm-apalis.dts | 2 +-
arch/arm/dts/fsl-imx8qxp-apalis.dts | 2 +-
include/configs/apalis-imx8.h | 2 --
include/configs/apalis-imx8x.h | 3 ---
4 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/arch/arm/dts/fsl-imx8qm-apalis.dts b/arch/arm/dts/fsl-imx8qm-apalis.dts
index 5187b79452..0d8d3b3e8e 100644
--- a/arch/arm/dts/fsl-imx8qm-apalis.dts
+++ b/arch/arm/dts/fsl-imx8qm-apalis.dts
@@ -503,7 +503,7 @@
pinctrl-0 = <&pinctrl_fec1>;
fsl,magic-packet;
phy-handle = <ðphy0>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-reset-duration = <10>;
phy-reset-gpios = <&gpio1 11 1>;
status = "okay";
diff --git a/arch/arm/dts/fsl-imx8qxp-apalis.dts b/arch/arm/dts/fsl-imx8qxp-apalis.dts
index 6bd231b283..9cb3d3a809 100644
--- a/arch/arm/dts/fsl-imx8qxp-apalis.dts
+++ b/arch/arm/dts/fsl-imx8qxp-apalis.dts
@@ -229,7 +229,7 @@
pinctrl-0 = <&pinctrl_fec1>;
fsl,magic-packet;
phy-handle = <ðphy0>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-reset-duration = <10>;
phy-reset-post-delay = <150>;
phy-reset-gpios = <&gpio3 4 GPIO_ACTIVE_LOW>;
diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h
index 0260eb4019..8fe3226cf9 100644
--- a/include/configs/apalis-imx8.h
+++ b/include/configs/apalis-imx8.h
@@ -21,8 +21,6 @@
#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
/* Networking */
-#define FEC_ENET_ENABLE_TXC_DELAY
-
#define CONFIG_TFTP_TSIZE
#define CONFIG_IPADDR 192.168.10.2
diff --git a/include/configs/apalis-imx8x.h b/include/configs/apalis-imx8x.h
index a84b8e684b..fdb0da34ec 100644
--- a/include/configs/apalis-imx8x.h
+++ b/include/configs/apalis-imx8x.h
@@ -25,9 +25,6 @@
#define CONFIG_NETMASK 255.255.255.0
#define CONFIG_SERVERIP 192.168.10.1
-#define FEC_ENET_ENABLE_TXC_DELAY
-#define FEC_ENET_ENABLE_RXC_DELAY
-
#define MEM_LAYOUT_ENV_SETTINGS \
"kernel_addr_r=0x80280000\0" \
"fdt_addr_r=0x83100000\0" \
--
2.29.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/2] board: toradex: move RGMII delays to PHY side
2021-02-09 8:38 ` [PATCH 2/2] board: toradex: move RGMII delays to PHY side Oleksandr Suvorov
@ 2021-02-10 19:20 ` Fabio Estevam
2021-03-01 11:55 ` sbabic at denx.de
1 sibling, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2021-02-10 19:20 UTC (permalink / raw)
To: u-boot
Hi Oleksandr,
On Tue, Feb 9, 2021 at 5:39 AM Oleksandr Suvorov
<oleksandr.suvorov@toradex.com> wrote:
>
> The RGMII link delays can be set on either MAC or PHY side. Set the
> rgmii-id PHY mode for FEC and remove FEC_ENET_ENABLE_.XC_DELAY
> setting, so that these definitions aren't used anymore throughout
> the U-Boot.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] board: toradex: move RGMII delays to PHY side
2021-02-09 8:38 ` [PATCH 2/2] board: toradex: move RGMII delays to PHY side Oleksandr Suvorov
2021-02-10 19:20 ` Fabio Estevam
@ 2021-03-01 11:55 ` sbabic at denx.de
1 sibling, 0 replies; 10+ messages in thread
From: sbabic at denx.de @ 2021-03-01 11:55 UTC (permalink / raw)
To: u-boot
> The RGMII link delays can be set on either MAC or PHY side. Set the
> rgmii-id PHY mode for FEC and remove FEC_ENET_ENABLE_.XC_DELAY
> setting, so that these definitions aren't used anymore throughout
> the U-Boot.
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X
2021-02-09 8:38 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Oleksandr Suvorov
2021-02-09 8:38 ` [PATCH 2/2] board: toradex: move RGMII delays to PHY side Oleksandr Suvorov
@ 2021-02-09 8:41 ` Marek Vasut
2021-02-09 8:54 ` Ramon Fried
2021-02-10 18:27 ` Oliver Graute
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2021-02-09 8:41 UTC (permalink / raw)
To: u-boot
On 2/9/21 9:38 AM, Oleksandr Suvorov wrote:
> Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC.
> Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this
> definition from configs of boards, based on MX8/MX8X.
Acked-by: Marek Vasut <marex@denx.de>
+CC Ramon
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X
2021-02-09 8:38 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Oleksandr Suvorov
2021-02-09 8:38 ` [PATCH 2/2] board: toradex: move RGMII delays to PHY side Oleksandr Suvorov
2021-02-09 8:41 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Marek Vasut
@ 2021-02-10 18:27 ` Oliver Graute
2021-02-10 19:19 ` Fabio Estevam
2021-03-01 11:55 ` sbabic at denx.de
4 siblings, 0 replies; 10+ messages in thread
From: Oliver Graute @ 2021-02-10 18:27 UTC (permalink / raw)
To: u-boot
On 09/02/21, Oleksandr Suvorov wrote:
> Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC.
> Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this
> definition from configs of boards, based on MX8/MX8X.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Acked-by: Oliver Graute <oliver.graute@kococonnector.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X
2021-02-09 8:38 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Oleksandr Suvorov
` (2 preceding siblings ...)
2021-02-10 18:27 ` Oliver Graute
@ 2021-02-10 19:19 ` Fabio Estevam
2021-03-01 11:55 ` sbabic at denx.de
4 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2021-02-10 19:19 UTC (permalink / raw)
To: u-boot
Hi Oleksandr,
On Tue, Feb 9, 2021 at 5:39 AM Oleksandr Suvorov
<oleksandr.suvorov@toradex.com> wrote:
>
> Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC.
> Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this
> definition from configs of boards, based on MX8/MX8X.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X
2021-02-09 8:38 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Oleksandr Suvorov
` (3 preceding siblings ...)
2021-02-10 19:19 ` Fabio Estevam
@ 2021-03-01 11:55 ` sbabic at denx.de
4 siblings, 0 replies; 10+ messages in thread
From: sbabic at denx.de @ 2021-03-01 11:55 UTC (permalink / raw)
To: u-boot
> Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC.
> Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this
> definition from configs of boards, based on MX8/MX8X.
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Acked-by: Marek Vasut <marex@denx.de>
> Reviewed-By: Ramon Fried <rfried.dev@gmail.com>
> Acked-by: Oliver Graute <oliver.graute@kococonnector.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 10+ messages in thread