All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Improve iMX8 FEC ENET MAC settings
@ 2021-02-09  8:38 Oleksandr Suvorov
  2021-02-09  8:38 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Oleksandr Suvorov
  0 siblings, 1 reply; 10+ messages in thread
From: Oleksandr Suvorov @ 2021-02-09  8:38 UTC (permalink / raw)
  To: u-boot


This series stops using FEC_ENET_ENABLE_.XC_DELAY settings throughout
the U-Boot, and adds the common quirk for FEC ENET MAC device,
simplifying configs of imx8-boards.


Oleksandr Suvorov (2):
  ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X
  board: toradex: move RGMII delays to PHY side

 arch/arm/dts/fsl-imx8qm-apalis.dts        | 2 +-
 arch/arm/dts/fsl-imx8qxp-apalis.dts       | 2 +-
 arch/arm/include/asm/arch-imx8/imx-regs.h | 2 ++
 include/configs/apalis-imx8.h             | 3 ---
 include/configs/apalis-imx8x.h            | 4 ----
 include/configs/capricorn-common.h        | 1 -
 include/configs/colibri-imx8x.h           | 2 --
 include/configs/imx8qm_mek.h              | 1 -
 include/configs/imx8qm_rom7720.h          | 1 -
 include/configs/imx8qxp_mek.h             | 1 -
 10 files changed, 4 insertions(+), 15 deletions(-)

-- 
2.29.2

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X
  2021-02-09  8:38 [PATCH 0/2] Improve iMX8 FEC ENET MAC settings Oleksandr Suvorov
@ 2021-02-09  8:38 ` Oleksandr Suvorov
  2021-02-09  8:38   ` [PATCH 2/2] board: toradex: move RGMII delays to PHY side Oleksandr Suvorov
                     ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Oleksandr Suvorov @ 2021-02-09  8:38 UTC (permalink / raw)
  To: u-boot

Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC.
Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this
definition from configs of boards, based on MX8/MX8X.

Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
---

 arch/arm/include/asm/arch-imx8/imx-regs.h | 2 ++
 include/configs/apalis-imx8.h             | 1 -
 include/configs/apalis-imx8x.h            | 1 -
 include/configs/capricorn-common.h        | 1 -
 include/configs/colibri-imx8x.h           | 2 --
 include/configs/imx8qm_mek.h              | 1 -
 include/configs/imx8qm_rom7720.h          | 1 -
 include/configs/imx8qxp_mek.h             | 1 -
 8 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/arch/arm/include/asm/arch-imx8/imx-regs.h b/arch/arm/include/asm/arch-imx8/imx-regs.h
index 6333ff4686..ed6e05e556 100644
--- a/arch/arm/include/asm/arch-imx8/imx-regs.h
+++ b/arch/arm/include/asm/arch-imx8/imx-regs.h
@@ -26,6 +26,8 @@
 #define LPI2C4_BASE_ADDR	0x5A830000
 #define LPI2C5_BASE_ADDR	0x5A840000
 
+#define FEC_QUIRK_ENET_MAC
+
 #ifdef CONFIG_IMX8QXP
 #define LVDS0_PHYCTRL_BASE	0x56221000
 #define LVDS1_PHYCTRL_BASE	0x56241000
diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h
index b474b2f522..0260eb4019 100644
--- a/include/configs/apalis-imx8.h
+++ b/include/configs/apalis-imx8.h
@@ -21,7 +21,6 @@
 #define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
 
 /* Networking */
-#define FEC_QUIRK_ENET_MAC
 #define FEC_ENET_ENABLE_TXC_DELAY
 
 #define CONFIG_TFTP_TSIZE
diff --git a/include/configs/apalis-imx8x.h b/include/configs/apalis-imx8x.h
index db31c210f5..a84b8e684b 100644
--- a/include/configs/apalis-imx8x.h
+++ b/include/configs/apalis-imx8x.h
@@ -143,7 +143,6 @@
 #define CONFIG_FEC_MXC_PHYADDR          0x4
 #define CONFIG_ETHPRIME                 "eth0"
 #define CONFIG_FEC_XCV_TYPE		RGMII
-#define FEC_QUIRK_ENET_MAC
 #define PHY_ANEG_TIMEOUT 20000
 
 #endif /* __APALIS_IMX8X_H */
diff --git a/include/configs/capricorn-common.h b/include/configs/capricorn-common.h
index 7c168f17d5..b310e6c9e5 100644
--- a/include/configs/capricorn-common.h
+++ b/include/configs/capricorn-common.h
@@ -43,7 +43,6 @@
 
 /* ENET Config */
 #define CONFIG_FEC_XCV_TYPE		RMII
-#define FEC_QUIRK_ENET_MAC
 
 /* ENET1 connects to base board and MUX with ESAI */
 #define CONFIG_FEC_ENET_DEV		1
diff --git a/include/configs/colibri-imx8x.h b/include/configs/colibri-imx8x.h
index fc2c191594..59593f6c00 100644
--- a/include/configs/colibri-imx8x.h
+++ b/include/configs/colibri-imx8x.h
@@ -22,8 +22,6 @@
 #define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
 
 /* Networking */
-#define FEC_QUIRK_ENET_MAC
-
 #define CONFIG_TFTP_TSIZE
 
 #define CONFIG_IPADDR			192.168.10.2
diff --git a/include/configs/imx8qm_mek.h b/include/configs/imx8qm_mek.h
index ff281d3800..99e73a9446 100644
--- a/include/configs/imx8qm_mek.h
+++ b/include/configs/imx8qm_mek.h
@@ -173,6 +173,5 @@
 
 /* Networking */
 #define CONFIG_FEC_XCV_TYPE		RGMII
-#define FEC_QUIRK_ENET_MAC
 
 #endif /* __IMX8QM_MEK_H */
diff --git a/include/configs/imx8qm_rom7720.h b/include/configs/imx8qm_rom7720.h
index e5989ebafb..fcbf8eeb34 100644
--- a/include/configs/imx8qm_rom7720.h
+++ b/include/configs/imx8qm_rom7720.h
@@ -161,7 +161,6 @@
 
 /* Networking */
 #define CONFIG_FEC_XCV_TYPE		RGMII
-#define FEC_QUIRK_ENET_MAC
 
 #include <linux/stringify.h>
 #endif /* __IMX8QM_ROM7720_H */
diff --git a/include/configs/imx8qxp_mek.h b/include/configs/imx8qxp_mek.h
index 51a8eb6760..a7d623a9b9 100644
--- a/include/configs/imx8qxp_mek.h
+++ b/include/configs/imx8qxp_mek.h
@@ -177,7 +177,6 @@
 
 /* Networking */
 #define CONFIG_FEC_XCV_TYPE		RGMII
-#define FEC_QUIRK_ENET_MAC
 
 /* Misc configuration */
 #define CONFIG_SYS_CBSIZE	2048
-- 
2.29.2

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 2/2] board: toradex: move RGMII delays to PHY side
  2021-02-09  8:38 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Oleksandr Suvorov
@ 2021-02-09  8:38   ` Oleksandr Suvorov
  2021-02-10 19:20     ` Fabio Estevam
  2021-03-01 11:55     ` sbabic at denx.de
  2021-02-09  8:41   ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Marek Vasut
                     ` (3 subsequent siblings)
  4 siblings, 2 replies; 10+ messages in thread
From: Oleksandr Suvorov @ 2021-02-09  8:38 UTC (permalink / raw)
  To: u-boot

The RGMII link delays can be set on either MAC or PHY side. Set the
rgmii-id PHY mode for FEC and remove FEC_ENET_ENABLE_.XC_DELAY
setting, so that these definitions aren't used anymore throughout
the U-Boot.

Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
---

 arch/arm/dts/fsl-imx8qm-apalis.dts  | 2 +-
 arch/arm/dts/fsl-imx8qxp-apalis.dts | 2 +-
 include/configs/apalis-imx8.h       | 2 --
 include/configs/apalis-imx8x.h      | 3 ---
 4 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/arch/arm/dts/fsl-imx8qm-apalis.dts b/arch/arm/dts/fsl-imx8qm-apalis.dts
index 5187b79452..0d8d3b3e8e 100644
--- a/arch/arm/dts/fsl-imx8qm-apalis.dts
+++ b/arch/arm/dts/fsl-imx8qm-apalis.dts
@@ -503,7 +503,7 @@
 	pinctrl-0 = <&pinctrl_fec1>;
 	fsl,magic-packet;
 	phy-handle = <&ethphy0>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-duration = <10>;
 	phy-reset-gpios = <&gpio1 11 1>;
 	status = "okay";
diff --git a/arch/arm/dts/fsl-imx8qxp-apalis.dts b/arch/arm/dts/fsl-imx8qxp-apalis.dts
index 6bd231b283..9cb3d3a809 100644
--- a/arch/arm/dts/fsl-imx8qxp-apalis.dts
+++ b/arch/arm/dts/fsl-imx8qxp-apalis.dts
@@ -229,7 +229,7 @@
 	pinctrl-0 = <&pinctrl_fec1>;
 	fsl,magic-packet;
 	phy-handle = <&ethphy0>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-duration = <10>;
 	phy-reset-post-delay = <150>;
 	phy-reset-gpios = <&gpio3 4 GPIO_ACTIVE_LOW>;
diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h
index 0260eb4019..8fe3226cf9 100644
--- a/include/configs/apalis-imx8.h
+++ b/include/configs/apalis-imx8.h
@@ -21,8 +21,6 @@
 #define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
 
 /* Networking */
-#define FEC_ENET_ENABLE_TXC_DELAY
-
 #define CONFIG_TFTP_TSIZE
 
 #define CONFIG_IPADDR			192.168.10.2
diff --git a/include/configs/apalis-imx8x.h b/include/configs/apalis-imx8x.h
index a84b8e684b..fdb0da34ec 100644
--- a/include/configs/apalis-imx8x.h
+++ b/include/configs/apalis-imx8x.h
@@ -25,9 +25,6 @@
 #define CONFIG_NETMASK			255.255.255.0
 #define CONFIG_SERVERIP			192.168.10.1
 
-#define FEC_ENET_ENABLE_TXC_DELAY
-#define FEC_ENET_ENABLE_RXC_DELAY
-
 #define MEM_LAYOUT_ENV_SETTINGS \
 	"kernel_addr_r=0x80280000\0" \
 	"fdt_addr_r=0x83100000\0" \
-- 
2.29.2

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X
  2021-02-09  8:38 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Oleksandr Suvorov
  2021-02-09  8:38   ` [PATCH 2/2] board: toradex: move RGMII delays to PHY side Oleksandr Suvorov
@ 2021-02-09  8:41   ` Marek Vasut
  2021-02-09  8:54     ` Ramon Fried
  2021-02-10 18:27   ` Oliver Graute
                     ` (2 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2021-02-09  8:41 UTC (permalink / raw)
  To: u-boot

On 2/9/21 9:38 AM, Oleksandr Suvorov wrote:
> Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC.
> Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this
> definition from configs of boards, based on MX8/MX8X.

Acked-by: Marek Vasut <marex@denx.de>

+CC Ramon

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X
  2021-02-09  8:41   ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Marek Vasut
@ 2021-02-09  8:54     ` Ramon Fried
  0 siblings, 0 replies; 10+ messages in thread
From: Ramon Fried @ 2021-02-09  8:54 UTC (permalink / raw)
  To: u-boot

On Tue, Feb 9, 2021 at 10:41 AM Marek Vasut <marex@denx.de> wrote:
>
> On 2/9/21 9:38 AM, Oleksandr Suvorov wrote:
> > Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC.
> > Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this
> > definition from configs of boards, based on MX8/MX8X.
>
> Acked-by: Marek Vasut <marex@denx.de>
>
> +CC Ramon
Reviewed-By: Ramon Fried <rfried.dev@gmail.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X
  2021-02-09  8:38 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Oleksandr Suvorov
  2021-02-09  8:38   ` [PATCH 2/2] board: toradex: move RGMII delays to PHY side Oleksandr Suvorov
  2021-02-09  8:41   ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Marek Vasut
@ 2021-02-10 18:27   ` Oliver Graute
  2021-02-10 19:19   ` Fabio Estevam
  2021-03-01 11:55   ` sbabic at denx.de
  4 siblings, 0 replies; 10+ messages in thread
From: Oliver Graute @ 2021-02-10 18:27 UTC (permalink / raw)
  To: u-boot

On 09/02/21, Oleksandr Suvorov wrote:
> Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC.
> Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this
> definition from configs of boards, based on MX8/MX8X.
> 
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

Acked-by: Oliver Graute <oliver.graute@kococonnector.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X
  2021-02-09  8:38 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Oleksandr Suvorov
                     ` (2 preceding siblings ...)
  2021-02-10 18:27   ` Oliver Graute
@ 2021-02-10 19:19   ` Fabio Estevam
  2021-03-01 11:55   ` sbabic at denx.de
  4 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2021-02-10 19:19 UTC (permalink / raw)
  To: u-boot

Hi Oleksandr,

On Tue, Feb 9, 2021 at 5:39 AM Oleksandr Suvorov
<oleksandr.suvorov@toradex.com> wrote:
>
> Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC.
> Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this
> definition from configs of boards, based on MX8/MX8X.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 2/2] board: toradex: move RGMII delays to PHY side
  2021-02-09  8:38   ` [PATCH 2/2] board: toradex: move RGMII delays to PHY side Oleksandr Suvorov
@ 2021-02-10 19:20     ` Fabio Estevam
  2021-03-01 11:55     ` sbabic at denx.de
  1 sibling, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2021-02-10 19:20 UTC (permalink / raw)
  To: u-boot

Hi Oleksandr,

On Tue, Feb 9, 2021 at 5:39 AM Oleksandr Suvorov
<oleksandr.suvorov@toradex.com> wrote:
>
> The RGMII link delays can be set on either MAC or PHY side. Set the
> rgmii-id PHY mode for FEC and remove FEC_ENET_ENABLE_.XC_DELAY
> setting, so that these definitions aren't used anymore throughout
> the U-Boot.
>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 2/2] board: toradex: move RGMII delays to PHY side
  2021-02-09  8:38   ` [PATCH 2/2] board: toradex: move RGMII delays to PHY side Oleksandr Suvorov
  2021-02-10 19:20     ` Fabio Estevam
@ 2021-03-01 11:55     ` sbabic at denx.de
  1 sibling, 0 replies; 10+ messages in thread
From: sbabic at denx.de @ 2021-03-01 11:55 UTC (permalink / raw)
  To: u-boot

> The RGMII link delays can be set on either MAC or PHY side. Set the
> rgmii-id PHY mode for FEC and remove FEC_ENET_ENABLE_.XC_DELAY
> setting, so that these definitions aren't used anymore throughout
> the U-Boot.
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X
  2021-02-09  8:38 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Oleksandr Suvorov
                     ` (3 preceding siblings ...)
  2021-02-10 19:19   ` Fabio Estevam
@ 2021-03-01 11:55   ` sbabic at denx.de
  4 siblings, 0 replies; 10+ messages in thread
From: sbabic at denx.de @ 2021-03-01 11:55 UTC (permalink / raw)
  To: u-boot

> Both NXP SoCs i.MX8 and i.MX8X have ENET gigabit MAC.
> Define FEC_QUIRK_ENET_MAC for the imx8 platform and remove this
> definition from configs of boards, based on MX8/MX8X.
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> Acked-by: Marek Vasut <marex@denx.de>
> Reviewed-By: Ramon Fried <rfried.dev@gmail.com>
> Acked-by: Oliver Graute <oliver.graute@kococonnector.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-03-01 11:55 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09  8:38 [PATCH 0/2] Improve iMX8 FEC ENET MAC settings Oleksandr Suvorov
2021-02-09  8:38 ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Oleksandr Suvorov
2021-02-09  8:38   ` [PATCH 2/2] board: toradex: move RGMII delays to PHY side Oleksandr Suvorov
2021-02-10 19:20     ` Fabio Estevam
2021-03-01 11:55     ` sbabic at denx.de
2021-02-09  8:41   ` [PATCH 1/2] ARM: imx8: Add missing FEC ENET quirk for i.MX8/i.MX8X Marek Vasut
2021-02-09  8:54     ` Ramon Fried
2021-02-10 18:27   ` Oliver Graute
2021-02-10 19:19   ` Fabio Estevam
2021-03-01 11:55   ` sbabic at denx.de

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.