Re: [PATCH v2 10/25] asm-generic/io.h: Add a non-posted variant of ioremap()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3045 bytes --]

Hi Hector,

I love your patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on robh/for-next tty/tty-testing linus/master v5.11 next-20210212]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hector-Martin/Apple-M1-SoC-platform-bring-up/20210215-202520
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: mips-randconfig-r002-20210215 (attached as .config)
compiler: mips64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9785be3c8ec6cb8530d72cff794f5c22414f5a3e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hector-Martin/Apple-M1-SoC-platform-bring-up/20210215-202520
        git checkout 9785be3c8ec6cb8530d72cff794f5c22414f5a3e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   lib/devres.c: In function '__devm_ioremap':
>> lib/devres.c:47:10: error: implicit declaration of function 'ioremap_np'; did you mean 'ioremap_uc'? [-Werror=implicit-function-declaration]
      47 |   addr = ioremap_np(offset, size);
         |          ^~~~~~~~~~
         |          ioremap_uc
   lib/devres.c:47:8: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      47 |   addr = ioremap_np(offset, size);
         |        ^
   cc1: some warnings being treated as errors


vim +47 lib/devres.c

    25	
    26	static void __iomem *__devm_ioremap(struct device *dev, resource_size_t offset,
    27					    resource_size_t size,
    28					    enum devm_ioremap_type type)
    29	{
    30		void __iomem **ptr, *addr = NULL;
    31	
    32		ptr = devres_alloc(devm_ioremap_release, sizeof(*ptr), GFP_KERNEL);
    33		if (!ptr)
    34			return NULL;
    35	
    36		switch (type) {
    37		case DEVM_IOREMAP:
    38			addr = ioremap(offset, size);
    39			break;
    40		case DEVM_IOREMAP_UC:
    41			addr = ioremap_uc(offset, size);
    42			break;
    43		case DEVM_IOREMAP_WC:
    44			addr = ioremap_wc(offset, size);
    45			break;
    46		case DEVM_IOREMAP_NP:
  > 47			addr = ioremap_np(offset, size);
    48			break;
    49		}
    50	
    51		if (addr) {
    52			*ptr = addr;
    53			devres_add(dev, ptr);
    54		} else
    55			devres_free(ptr);
    56	
    57		return addr;
    58	}
    59	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19829 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel