From: "Marek Behún" <kabel@kernel.org> To: Gregory CLEMENT <gregory.clement@bootlin.com> Cc: "Marek Behún" <kabel@kernel.org>, "Rui Salvaterra" <rsalvaterra@gmail.com>, "Uwe Kleine-König" <uwe@kleine-koenig.org>, linux-arm-kernel@lists.infradead.org, "Andrew Lunn" <andrew@lunn.ch>, stable@vger.kernel.org Subject: [PATCH mvebu-dt] ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin Date: Sun, 21 Feb 2021 00:11:44 +0100 [thread overview] Message-ID: <20210220231144.32325-1-kabel@kernel.org> (raw) Use the `marvell,reg-init` DT property to configure the LED[2]/INTn pin of the Marvell 88E1514 ethernet PHY on Turris Omnia into interrupt mode. Without this the pin is by default in LED[2] mode, and the Marvell PHY driver configures LED[2] into "On - Link, Blink - Activity" mode. This fixes the issue where the pca9538 GPIO/interrupt controller (which can't mask interrupts in HW) received too many interrupts and after a time started ignoring the interrupt with error message: IRQ 71: nobody cared There is a work in progress to have the Marvell PHY driver support parsing PHY LED nodes from OF and registering the LEDs as Linux LED class devices. Once this is done the PHY driver can also automatically set the pin into INTn mode if it does not find LED[2] in OF. Until then, though, we fix this via `marvell,reg-init` DT property. Signed-off-by: Marek Behún <kabel@kernel.org> Reported-by: Rui Salvaterra <rsalvaterra@gmail.com> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia") Cc: Uwe Kleine-König <uwe@kleine-koenig.org> Cc: linux-arm-kernel@lists.infradead.org Cc: Andrew Lunn <andrew@lunn.ch> Cc: Gregory CLEMENT <gregory.clement@bootlin.com> Cc: <stable@vger.kernel.org> --- This patch fixes bug introduced with the commit that added Turris Omnia's DTS (26ca8b52d6e1), but will not apply cleanly because there is commit 8ee4a5f4f40d which changed node name and node compatible property and this commit did not go into stable. So either commit 8ee4a5f4f40d has also to go into stable before this, or this patch has to be fixed a little in order to apply to 4.14+. Please let me know how should I handle this. --- arch/arm/boot/dts/armada-385-turris-omnia.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts index 646a06420c77..b0f3fd8e1429 100644 --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts @@ -389,6 +389,7 @@ &mdio { phy1: ethernet-phy@1 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <1>; + marvell,reg-init = <3 18 0 0x4985>; /* irq is connected to &pcawan pin 7 */ }; -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: "Marek Behún" <kabel@kernel.org> To: Gregory CLEMENT <gregory.clement@bootlin.com> Cc: "Marek Behún" <kabel@kernel.org>, "Andrew Lunn" <andrew@lunn.ch>, "Uwe Kleine-König" <uwe@kleine-koenig.org>, stable@vger.kernel.org, "Rui Salvaterra" <rsalvaterra@gmail.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH mvebu-dt] ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin Date: Sun, 21 Feb 2021 00:11:44 +0100 [thread overview] Message-ID: <20210220231144.32325-1-kabel@kernel.org> (raw) Use the `marvell,reg-init` DT property to configure the LED[2]/INTn pin of the Marvell 88E1514 ethernet PHY on Turris Omnia into interrupt mode. Without this the pin is by default in LED[2] mode, and the Marvell PHY driver configures LED[2] into "On - Link, Blink - Activity" mode. This fixes the issue where the pca9538 GPIO/interrupt controller (which can't mask interrupts in HW) received too many interrupts and after a time started ignoring the interrupt with error message: IRQ 71: nobody cared There is a work in progress to have the Marvell PHY driver support parsing PHY LED nodes from OF and registering the LEDs as Linux LED class devices. Once this is done the PHY driver can also automatically set the pin into INTn mode if it does not find LED[2] in OF. Until then, though, we fix this via `marvell,reg-init` DT property. Signed-off-by: Marek Behún <kabel@kernel.org> Reported-by: Rui Salvaterra <rsalvaterra@gmail.com> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia") Cc: Uwe Kleine-König <uwe@kleine-koenig.org> Cc: linux-arm-kernel@lists.infradead.org Cc: Andrew Lunn <andrew@lunn.ch> Cc: Gregory CLEMENT <gregory.clement@bootlin.com> Cc: <stable@vger.kernel.org> --- This patch fixes bug introduced with the commit that added Turris Omnia's DTS (26ca8b52d6e1), but will not apply cleanly because there is commit 8ee4a5f4f40d which changed node name and node compatible property and this commit did not go into stable. So either commit 8ee4a5f4f40d has also to go into stable before this, or this patch has to be fixed a little in order to apply to 4.14+. Please let me know how should I handle this. --- arch/arm/boot/dts/armada-385-turris-omnia.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts index 646a06420c77..b0f3fd8e1429 100644 --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts @@ -389,6 +389,7 @@ &mdio { phy1: ethernet-phy@1 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <1>; + marvell,reg-init = <3 18 0 0x4985>; /* irq is connected to &pcawan pin 7 */ }; -- 2.26.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-02-20 23:13 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-20 23:11 Marek Behún [this message] 2021-02-20 23:11 ` [PATCH mvebu-dt] ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin Marek Behún 2021-02-21 0:10 ` Andrew Lunn 2021-02-21 0:10 ` Andrew Lunn 2021-02-21 0:47 ` Marek Behún 2021-02-21 0:47 ` Marek Behún 2021-02-21 21:18 ` Andrew Lunn 2021-02-21 21:18 ` Andrew Lunn 2021-02-21 22:40 ` Marek Behún 2021-02-21 22:40 ` Marek Behún 2021-02-21 19:58 ` Rui Salvaterra 2021-02-21 19:58 ` Rui Salvaterra 2021-02-21 20:52 ` Andrew Lunn 2021-02-21 20:52 ` Andrew Lunn 2021-02-21 20:58 ` Marek Behún 2021-02-21 20:58 ` Marek Behún 2021-04-02 20:15 ` Gregory CLEMENT 2021-04-02 20:15 ` Gregory CLEMENT
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210220231144.32325-1-kabel@kernel.org \ --to=kabel@kernel.org \ --cc=andrew@lunn.ch \ --cc=gregory.clement@bootlin.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=rsalvaterra@gmail.com \ --cc=stable@vger.kernel.org \ --cc=uwe@kleine-koenig.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.