[meta-ti][PATCH] recipes-bsp: wl18xx-fw: update SRCREV to latest

[meta-ti][PATCH] recipes-bsp: wl18xx-fw: update SRCREV to latest

[Nikhil Devshatwar]

Update the wl18xx firmware recipe to latest version 8.9.0.0.86

Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
---
 recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
index a52ec898..50b6c297 100644
--- a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
+++ b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
@@ -7,8 +7,7 @@ SRC_URI = " \
 	file://0001-Add-Makefile-to-install-firmware-files.patch \
 "
 
-# Tag: R8.7-SP3 (8.7.3)
-SRCREV = "f659be25473e4bde8dc790bff703ecacde6e21da"
+SRCREV = "5ec05007f2662f460f881c5868311fd3ab7e6e71"
 BRANCH = "master"
 
 S = "${WORKDIR}/git"
-- 
2.17.1

Re: [meta-ti][PATCH] recipes-bsp: wl18xx-fw: update SRCREV to latest

[Denys Dmytriyenko]

On Wed, Mar 03, 2021 at 11:39:17PM +0530, Nikhil Devshatwar via lists.yoctoproject.org wrote:
> Update the wl18xx firmware recipe to latest version 8.9.0.0.86

Do you also need to update the version from 8.7.3 to 8.9.x?


> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> ---
>  recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> index a52ec898..50b6c297 100644
> --- a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> +++ b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> @@ -7,8 +7,7 @@ SRC_URI = " \
>  	file://0001-Add-Makefile-to-install-firmware-files.patch \
>  "
>  
> -# Tag: R8.7-SP3 (8.7.3)
> -SRCREV = "f659be25473e4bde8dc790bff703ecacde6e21da"
> +SRCREV = "5ec05007f2662f460f881c5868311fd3ab7e6e71"
>  BRANCH = "master"
>  
>  S = "${WORKDIR}/git"
> -- 
> 2.17.1

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

Re: [meta-ti][PATCH] recipes-bsp: wl18xx-fw: update SRCREV to latest

[Nikhil Devshatwar]

On 13:17-20210303, Denys Dmytriyenko wrote:
> On Wed, Mar 03, 2021 at 11:39:17PM +0530, Nikhil Devshatwar via lists.yoctoproject.org wrote:
> > Update the wl18xx firmware recipe to latest version 8.9.0.0.86
> 
> Do you also need to update the version from 8.7.3 to 8.9.x?

I am not sure how the recipe version is decided.
Old commit ID had the firmware version 8.9.0.0.76 which is now
changed to 8.9.0.0.86

I don't know how the recipe version is tied to the firmware version.
Hari, Do you know?

Regards,
Nikhil Devshatwar
> 
> 
> > Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> > ---
> >  recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > index a52ec898..50b6c297 100644
> > --- a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > +++ b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > @@ -7,8 +7,7 @@ SRC_URI = " \
> >  	file://0001-Add-Makefile-to-install-firmware-files.patch \
> >  "
> >  
> > -# Tag: R8.7-SP3 (8.7.3)
> > -SRCREV = "f659be25473e4bde8dc790bff703ecacde6e21da"
> > +SRCREV = "5ec05007f2662f460f881c5868311fd3ab7e6e71"
> >  BRANCH = "master"
> >  
> >  S = "${WORKDIR}/git"
> > -- 
> > 2.17.1
> 
> -- 
> Regards,
> Denys Dmytriyenko <denis@denix.org>
> PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
> Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

Re: [meta-ti][PATCH] recipes-bsp: wl18xx-fw: update SRCREV to latest

[Denys Dmytriyenko]

On Fri, Mar 05, 2021 at 03:29:49PM +0530, Nikhil Devshatwar wrote:
> On 13:17-20210303, Denys Dmytriyenko wrote:
> > On Wed, Mar 03, 2021 at 11:39:17PM +0530, Nikhil Devshatwar via lists.yoctoproject.org wrote:
> > > Update the wl18xx firmware recipe to latest version 8.9.0.0.86
> > 
> > Do you also need to update the version from 8.7.3 to 8.9.x?
> 
> I am not sure how the recipe version is decided.
> Old commit ID had the firmware version 8.9.0.0.76 which is now
> changed to 8.9.0.0.86
> 
> I don't know how the recipe version is tied to the firmware version.
> Hari, Do you know?

Nikhil,

Originally, the recipe version was tied into the release tag (see below)


> > > Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> > > ---
> > >  recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > diff --git a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > > index a52ec898..50b6c297 100644
> > > --- a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > > +++ b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb

The filename sets 8.7.3 as the version.


> > > @@ -7,8 +7,7 @@ SRC_URI = " \
> > >  	file://0001-Add-Makefile-to-install-firmware-files.patch \
> > >  "
> > >  
> > > -# Tag: R8.7-SP3 (8.7.3)

Which corresponds to this tag ^^^


> > > -SRCREV = "f659be25473e4bde8dc790bff703ecacde6e21da"
> > > +SRCREV = "5ec05007f2662f460f881c5868311fd3ab7e6e71"
> > >  BRANCH = "master"
> > >  
> > >  S = "${WORKDIR}/git"
> > > -- 
> > > 2.17.1

Re: [meta-ti][PATCH] recipes-bsp: wl18xx-fw: update SRCREV to latest

[Nikhil Devshatwar]

On 15:29-20210305, Nikhil Devshatwar via lists.yoctoproject.org wrote:
> On 13:17-20210303, Denys Dmytriyenko wrote:
> > On Wed, Mar 03, 2021 at 11:39:17PM +0530, Nikhil Devshatwar via lists.yoctoproject.org wrote:
> > > Update the wl18xx firmware recipe to latest version 8.9.0.0.86
> > 
> > Do you also need to update the version from 8.7.3 to 8.9.x?
> 
> I am not sure how the recipe version is decided.
> Old commit ID had the firmware version 8.9.0.0.76 which is now
> changed to 8.9.0.0.86
> 
> I don't know how the recipe version is tied to the firmware version.
> Hari, Do you know?

I looked at the git history of the firmware and the last commit was
tagged with R8.7_SP3 Maybe this is used to derive the firmware version
8.7.3

But since the last tag in 2017, there haven't been new tags but the
firmware has been updated 7 times.

In this case, the recipe is adding only a single file, so let's just use
the firmware version in the recipe rather than using tags from the repo.

While at it, maybe it does not make sense to keep renaming the file for
every version change, so we just make it _git.bb and set
PV += "8.9.0.0.86"

Regards,
Nikhil Devshatwar

> 
> Regards,
> Nikhil Devshatwar
> > 
> > 
> > > Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> > > ---
> > >  recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > diff --git a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > > index a52ec898..50b6c297 100644
> > > --- a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > > +++ b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > > @@ -7,8 +7,7 @@ SRC_URI = " \
> > >  	file://0001-Add-Makefile-to-install-firmware-files.patch \
> > >  "
> > >  
> > > -# Tag: R8.7-SP3 (8.7.3)
> > > -SRCREV = "f659be25473e4bde8dc790bff703ecacde6e21da"
> > > +SRCREV = "5ec05007f2662f460f881c5868311fd3ab7e6e71"
> > >  BRANCH = "master"
> > >  
> > >  S = "${WORKDIR}/git"
> > > -- 
> > > 2.17.1
> > 
> > -- 
> > Regards,
> > Denys Dmytriyenko <denis@denix.org>
> > PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
> > Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

> 
> 
> 

Re: [meta-ti][PATCH] recipes-bsp: wl18xx-fw: update SRCREV to latest

[Denys Dmytriyenko]

On Fri, Mar 05, 2021 at 04:00:55PM +0530, Nikhil Devshatwar wrote:
> On 15:29-20210305, Nikhil Devshatwar via lists.yoctoproject.org wrote:
> > On 13:17-20210303, Denys Dmytriyenko wrote:
> > > On Wed, Mar 03, 2021 at 11:39:17PM +0530, Nikhil Devshatwar via lists.yoctoproject.org wrote:
> > > > Update the wl18xx firmware recipe to latest version 8.9.0.0.86
> > > 
> > > Do you also need to update the version from 8.7.3 to 8.9.x?
> > 
> > I am not sure how the recipe version is decided.
> > Old commit ID had the firmware version 8.9.0.0.76 which is now
> > changed to 8.9.0.0.86
> > 
> > I don't know how the recipe version is tied to the firmware version.
> > Hari, Do you know?
> 
> I looked at the git history of the firmware and the last commit was
> tagged with R8.7_SP3 Maybe this is used to derive the firmware version
> 8.7.3

Correct.


> But since the last tag in 2017, there haven't been new tags but the
> firmware has been updated 7 times.
> 
> In this case, the recipe is adding only a single file, so let's just use
> the firmware version in the recipe rather than using tags from the repo.

If there's a version embedded in the firmware, that makes things easier and 
more reliable.


> While at it, maybe it does not make sense to keep renaming the file for
> every version change, so we just make it _git.bb and set
> PV += "8.9.0.0.86"

It's been 4 years since last release/update. With such infrequent updates it's 
better to keep the version in the filename.

You want to name the recipe with _git and set PV inside when you have frequent 
updates and also versions in-between releases.


> > > > Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> > > > ---
> > > >  recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb | 3 +--
> > > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > > 
> > > > diff --git a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > > > index a52ec898..50b6c297 100644
> > > > --- a/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > > > +++ b/recipes-bsp/wl18xx-fw/wl18xx-fw_8.7.3.bb
> > > > @@ -7,8 +7,7 @@ SRC_URI = " \
> > > >  	file://0001-Add-Makefile-to-install-firmware-files.patch \
> > > >  "
> > > >  
> > > > -# Tag: R8.7-SP3 (8.7.3)
> > > > -SRCREV = "f659be25473e4bde8dc790bff703ecacde6e21da"
> > > > +SRCREV = "5ec05007f2662f460f881c5868311fd3ab7e6e71"
> > > >  BRANCH = "master"
> > > >  
> > > >  S = "${WORKDIR}/git"
> > > > -- 
> > > > 2.17.1