From: Mark Brown <broonie@kernel.org>
To: Lucas Tanure <tanureal@opensource.cirrus.com>
Cc: James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 06/15] ASoC: cs42l42: Remove power if the driver is being removed
Date: Fri, 5 Mar 2021 18:49:44 +0000 [thread overview]
Message-ID: <20210305184944.GC4552@sirena.org.uk> (raw)
In-Reply-To: <20210305173442.195740-7-tanureal@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
On Fri, Mar 05, 2021 at 05:34:33PM +0000, Lucas Tanure wrote:
> - /* Hold down reset */
> - gpiod_set_value_cansleep(cs42l42->reset_gpio, 0);
> + disable_irq(i2c_client->irq);
> + pm_runtime_suspend(&i2c_client->dev);
> + pm_runtime_disable(&i2c_client->dev);
You should be unregistering the interrupt, not disabling it - this will
better support any shared IRQ usage that appears and is much, much more
idiomatic.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Lucas Tanure <tanureal@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
patches@opensource.cirrus.com, Takashi Iwai <tiwai@suse.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
James Schulman <james.schulman@cirrus.com>,
David Rhodes <david.rhodes@cirrus.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 06/15] ASoC: cs42l42: Remove power if the driver is being removed
Date: Fri, 5 Mar 2021 18:49:44 +0000 [thread overview]
Message-ID: <20210305184944.GC4552@sirena.org.uk> (raw)
In-Reply-To: <20210305173442.195740-7-tanureal@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
On Fri, Mar 05, 2021 at 05:34:33PM +0000, Lucas Tanure wrote:
> - /* Hold down reset */
> - gpiod_set_value_cansleep(cs42l42->reset_gpio, 0);
> + disable_irq(i2c_client->irq);
> + pm_runtime_suspend(&i2c_client->dev);
> + pm_runtime_disable(&i2c_client->dev);
You should be unregistering the interrupt, not disabling it - this will
better support any shared IRQ usage that appears and is much, much more
idiomatic.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-05 18:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 17:34 [PATCH v2 00/15] Report jack and button detection + Capture Support Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 01/15] ASoC: cs42l42: Fix Bitclock polarity inversion Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 02/15] ASoC: cs42l42: Fix channel width support Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 03/15] ASoC: cs42l42: Fix mixer volume control Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 04/15] ASoC: cs42l42: Don't enable/disable regulator at Bias Level Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 05/15] ASoC: cs42l42: Always wait at least 3ms after reset Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 06/15] ASoC: cs42l42: Remove power if the driver is being removed Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 18:49 ` Mark Brown [this message]
2021-03-05 18:49 ` Mark Brown
2021-03-05 17:34 ` [PATCH v2 07/15] ASoC: cs42l42: Disable regulators if probe fails Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 08/15] ASoC: cs42l42: Provide finer control on playback path Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 09/15] ASoC: cs42l42: Set clock source for both ways of stream Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 10/15] ASoC: cs42l42: Add Capture Support Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 11/15] ASoC: cs42l42: Report jack and button detection Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 12/15] ASoC: cs42l42: Use bclk from hw_params if set_sysclk was not called Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 13/15] ASoC: cs42l42: Wait at least 150us after writing SCLK_PRESENT Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 14/15] ASoC: cs42l42: Only start PLL if it is needed Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-05 17:34 ` [PATCH v2 15/15] ASoC: cs42l42: Wait for PLL to lock before switching to it Lucas Tanure
2021-03-05 17:34 ` Lucas Tanure
2021-03-08 16:06 ` (subset) [PATCH v2 00/15] Report jack and button detection + Capture Support Mark Brown
2021-03-08 16:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305184944.GC4552@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.