[PATCH] build: require glib >= 2.60

[PATCH] build: require glib >= 2.60

[JongSeok Won]

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

Build failure in the latest version has occurred with glib 2.56.4.

src/simutil.c: In function ‘validate_utf8_tlv’:
src/simutil.c:779:9: error: implicit declaration of function
‘g_utf8_validate_len’; did you mean ‘g_utf8_validate’?
[-Werror=implicit-function-declaration]
  return g_utf8_validate_len((const char *)tlv + 2, len, NULL);
         ^~~~~~~~~~~~~~~~~~~
         g_utf8_validate


According to glib documentation, "g_utf8_validate_len" is supported since
2.60
So, I sent this patch.

Regards,
JongSeok Won

---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index d4efc8a8..f195c862 100644
--- a/configure.ac
+++ b/configure.ac
@@ -63,8 +63,8 @@ AC_CHECK_FUNC(signalfd, dummy=yes,
 AC_CHECK_LIB(dl, dlopen, dummy=yes,
  AC_MSG_ERROR(dynamic linking loader is required))

-PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.32, dummy=yes,
- AC_MSG_ERROR(GLib >= 2.32 is required))
+PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.60, dummy=yes,
+ AC_MSG_ERROR(GLib >= 2.60 is required))
 AC_SUBST(GLIB_CFLAGS)
 AC_SUBST(GLIB_LIBS)
 --

Re: [PATCH] build: require glib >= 2.60

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

Hi,

> -PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.32, dummy=yes,
> - AC_MSG_ERROR(GLib >= 2.32 is required))
> +PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.60, dummy=yes,
> + AC_MSG_ERROR(GLib >= 2.60 is required))

This patch doesn't apply:
denkenz(a)localhost ~/ofono-master $ git am ~/merge/\[PATCH\]\ build\:\ require\ 
glib\ \>\=\ 2.60.eml
Applying: build: require glib >= 2.60
error: corrupt patch at line 12
Patch failed at 0001 build: require glib >= 2.60
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Looks like it is whitespace-mangled or otherwise damaged for some reason.

Regards,
-Denis

Re: [PATCH] build: require glib >= 2.60

[JongSeok Won]

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

Hi, Denis

I had a mistake while making patch. So, I'll re-send the patch of V2.

Best regards
JongSeok Won

2021년 3월 5일 (금) 오후 11:49, Denis Kenzior <denkenz@gmail.com>님이 작성:

> Hi,
>
> > -PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.32, dummy=yes,
> > - AC_MSG_ERROR(GLib >= 2.32 is required))
> > +PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.60, dummy=yes,
> > + AC_MSG_ERROR(GLib >= 2.60 is required))
>
> This patch doesn't apply:
> denkenz(a)localhost ~/ofono-master $ git am ~/merge/\[PATCH\]\ build\:\
> require\
> glib\ \>\=\ 2.60.eml
> Applying: build: require glib >= 2.60
> error: corrupt patch at line 12
> Patch failed at 0001 build: require glib >= 2.60
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
>
> Looks like it is whitespace-mangled or otherwise damaged for some reason.
>
> Regards,
> -Denis
>

[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 1510 bytes --]

[PATCH] build: require glib >= 2.60

[JongSeok Won]

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

g_utf8_validate_len() is support after glib 2.60
---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index d4efc8a8..f195c862 100644
--- a/configure.ac
+++ b/configure.ac
@@ -63,8 +63,8 @@ AC_CHECK_FUNC(signalfd, dummy=yes,
 AC_CHECK_LIB(dl, dlopen, dummy=yes,
 			AC_MSG_ERROR(dynamic linking loader is required))
 
-PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.32, dummy=yes,
-				AC_MSG_ERROR(GLib >= 2.32 is required))
+PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.60, dummy=yes,
+				AC_MSG_ERROR(GLib >= 2.60 is required))
 AC_SUBST(GLIB_CFLAGS)
 AC_SUBST(GLIB_LIBS)
 
-- 
2.17.1

Re: [PATCH] build: require glib >= 2.60

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

On 3/8/21 3:33 AM, JongSeok Won wrote:
> g_utf8_validate_len() is support after glib 2.60
> ---
>   configure.ac | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied, thanks.

Regards,
-Denis

[PATCH] build: require glib >= 2.60

[JongSeok Won]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

Build failure in the latest version has occurred with glib 2.56.4.

src/simutil.c: In function ‘validate_utf8_tlv’:
> src/simutil.c:779:9: error: implicit declaration of function
> ‘g_utf8_validate_len’; did you mean ‘g_utf8_validate’?
> [-Werror=implicit-function-declaration]
>   return g_utf8_validate_len((const char *)tlv + 2, len, NULL);
>          ^~~~~~~~~~~~~~~~~~~
>          g_utf8_validate
>

According to glib documentation, "g_utf8_validate_len" is supported since
2.60
So, I sent this patch.

Regards,
JongSeok Won

---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index d4efc8a8..f195c862 100644
--- a/configure.ac
+++ b/configure.ac
@@ -63,8 +63,8 @@ AC_CHECK_FUNC(signalfd, dummy=yes,
 AC_CHECK_LIB(dl, dlopen, dummy=yes,
  AC_MSG_ERROR(dynamic linking loader is required))

-PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.32, dummy=yes,
- AC_MSG_ERROR(GLib >= 2.32 is required))
+PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.60, dummy=yes,
+ AC_MSG_ERROR(GLib >= 2.60 is required))
 AC_SUBST(GLIB_CFLAGS)
 AC_SUBST(GLIB_LIBS)
 --

[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 1790 bytes --]