All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jens Axboe <axboe@kernel.dk>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-ide@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 02/10] ARM: disable CONFIG_IDE in footbridge_defconfig
Date: Mon, 22 Mar 2021 16:59:56 +0000	[thread overview]
Message-ID: <20210322165956.GY1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210322151823.GA2764@lst.de>

On Mon, Mar 22, 2021 at 04:18:23PM +0100, Christoph Hellwig wrote:
> On Mon, Mar 22, 2021 at 03:15:03PM +0000, Russell King - ARM Linux admin wrote:
> > It gets worse than that though - due to a change to remove
> > pcibios_min_io from the generic code, moving it into the ARM
> > architecture code, this has caused a regression that prevents the
> > legacy resources being registered against the bus resource. So even
> > if they are there, they cause probe failures. I haven't found a
> > reasonable way to solve this yet, but until there is, there is no
> > way that the PATA driver can be used as the "legacy mode" support
> > is effectively done via the PCI code assigning virtual IO port
> > resources.
> > 
> > I'm quite surprised that the CY82C693 even works on Alpha - I've
> > asked for a lspci for that last week but nothing has yet been
> > forthcoming from whoever responded to your patch for Alpha - so I
> > can't compare what I'm seeing with what's happening with Alpha.
> 
> That sounds like something we could fix with a quirk for function 2
> in the PCI resource assignment code.  Can you show what vendor and
> device ID function 2 has so that I could try to come up with one?

I already have a quirk in arch/arm/kernel/bios32.c for this - but it
is no longer sufficient due to changes in the PCI layer, where much
of this is documented.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-ide@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	linux-alpha@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Matt Turner <mattst88@gmail.com>,
	linuxppc-dev@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 02/10] ARM: disable CONFIG_IDE in footbridge_defconfig
Date: Mon, 22 Mar 2021 16:59:56 +0000	[thread overview]
Message-ID: <20210322165956.GY1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210322151823.GA2764@lst.de>

On Mon, Mar 22, 2021 at 04:18:23PM +0100, Christoph Hellwig wrote:
> On Mon, Mar 22, 2021 at 03:15:03PM +0000, Russell King - ARM Linux admin wrote:
> > It gets worse than that though - due to a change to remove
> > pcibios_min_io from the generic code, moving it into the ARM
> > architecture code, this has caused a regression that prevents the
> > legacy resources being registered against the bus resource. So even
> > if they are there, they cause probe failures. I haven't found a
> > reasonable way to solve this yet, but until there is, there is no
> > way that the PATA driver can be used as the "legacy mode" support
> > is effectively done via the PCI code assigning virtual IO port
> > resources.
> > 
> > I'm quite surprised that the CY82C693 even works on Alpha - I've
> > asked for a lspci for that last week but nothing has yet been
> > forthcoming from whoever responded to your patch for Alpha - so I
> > can't compare what I'm seeing with what's happening with Alpha.
> 
> That sounds like something we could fix with a quirk for function 2
> in the PCI resource assignment code.  Can you show what vendor and
> device ID function 2 has so that I could try to come up with one?

I already have a quirk in arch/arm/kernel/bios32.c for this - but it
is no longer sufficient due to changes in the PCI layer, where much
of this is documented.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jens Axboe <axboe@kernel.dk>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linux-ide@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 02/10] ARM: disable CONFIG_IDE in footbridge_defconfig
Date: Mon, 22 Mar 2021 16:59:56 +0000	[thread overview]
Message-ID: <20210322165956.GY1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210322151823.GA2764@lst.de>

On Mon, Mar 22, 2021 at 04:18:23PM +0100, Christoph Hellwig wrote:
> On Mon, Mar 22, 2021 at 03:15:03PM +0000, Russell King - ARM Linux admin wrote:
> > It gets worse than that though - due to a change to remove
> > pcibios_min_io from the generic code, moving it into the ARM
> > architecture code, this has caused a regression that prevents the
> > legacy resources being registered against the bus resource. So even
> > if they are there, they cause probe failures. I haven't found a
> > reasonable way to solve this yet, but until there is, there is no
> > way that the PATA driver can be used as the "legacy mode" support
> > is effectively done via the PCI code assigning virtual IO port
> > resources.
> > 
> > I'm quite surprised that the CY82C693 even works on Alpha - I've
> > asked for a lspci for that last week but nothing has yet been
> > forthcoming from whoever responded to your patch for Alpha - so I
> > can't compare what I'm seeing with what's happening with Alpha.
> 
> That sounds like something we could fix with a quirk for function 2
> in the PCI resource assignment code.  Can you show what vendor and
> device ID function 2 has so that I could try to come up with one?

I already have a quirk in arch/arm/kernel/bios32.c for this - but it
is no longer sufficient due to changes in the PCI layer, where much
of this is documented.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-03-22 17:00 UTC|newest]

Thread overview: 142+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18  4:56 remove the legacy ide driver Christoph Hellwig
2021-03-18  4:56 ` Christoph Hellwig
2021-03-18  4:56 ` Christoph Hellwig
2021-03-18  4:56 ` [PATCH 01/10] alpha: use libata instead of " Christoph Hellwig
2021-03-18  4:56   ` Christoph Hellwig
2021-03-18  4:56   ` Christoph Hellwig
2021-03-18  5:54   ` Al Viro
2021-03-18  5:54     ` Al Viro
2021-03-18  5:54     ` Al Viro
2021-03-18  6:07     ` Christoph Hellwig
2021-03-18  6:07       ` Christoph Hellwig
2021-03-18  6:07       ` Christoph Hellwig
2021-03-18 17:09       ` Måns Rullgård
2021-03-18 17:09         ` Måns Rullgård
2021-03-18 17:09         ` Måns Rullgård
2021-03-18 18:03         ` Måns Rullgård
2021-03-18 18:03           ` Måns Rullgård
2021-03-18 18:03           ` Måns Rullgård
2021-03-18  7:54     ` John Paul Adrian Glaubitz
2021-03-18  7:54       ` John Paul Adrian Glaubitz
2021-03-18  7:54       ` John Paul Adrian Glaubitz
2021-03-19 16:23     ` Serge Belyshev
2021-03-19 16:23       ` Serge Belyshev
2021-03-19 16:23       ` Serge Belyshev
2021-03-18  4:56 ` [PATCH 02/10] ARM: disable CONFIG_IDE in footbridge_defconfig Christoph Hellwig
2021-03-18  4:56   ` Christoph Hellwig
2021-03-18  4:56   ` Christoph Hellwig
2021-03-19 17:07   ` Russell King - ARM Linux admin
2021-03-19 17:07     ` Russell King - ARM Linux admin
2021-03-19 17:07     ` Russell King - ARM Linux admin
2021-03-19 17:53     ` Russell King - ARM Linux admin
2021-03-19 17:53       ` Russell King - ARM Linux admin
2021-03-19 17:53       ` Russell King - ARM Linux admin
2021-03-22 14:54       ` Christoph Hellwig
2021-03-22 14:54         ` Christoph Hellwig
2021-03-22 14:54         ` Christoph Hellwig
2021-03-22 15:15         ` Russell King - ARM Linux admin
2021-03-22 15:15           ` Russell King - ARM Linux admin
2021-03-22 15:15           ` Russell King - ARM Linux admin
2021-03-22 15:18           ` Christoph Hellwig
2021-03-22 15:18             ` Christoph Hellwig
2021-03-22 15:18             ` Christoph Hellwig
2021-03-22 15:33             ` Christoph Hellwig
2021-03-22 15:33               ` Christoph Hellwig
2021-03-22 15:33               ` Christoph Hellwig
2021-03-23 14:03               ` Russell King - ARM Linux admin
2021-03-23 14:03                 ` Russell King - ARM Linux admin
2021-03-23 14:03                 ` Russell King - ARM Linux admin
2021-03-22 15:44             ` Cye Borg
2021-03-22 16:59             ` Russell King - ARM Linux admin [this message]
2021-03-22 16:59               ` Russell King - ARM Linux admin
2021-03-22 16:59               ` Russell King - ARM Linux admin
2021-03-22 16:09           ` John Paul Adrian Glaubitz
2021-03-22 16:09             ` John Paul Adrian Glaubitz
2021-03-22 16:09             ` John Paul Adrian Glaubitz
2021-03-22 16:43             ` Cye Borg
2021-03-22 16:47             ` Cye Borg
2021-03-22 16:47               ` Cye Borg
2021-03-22 16:47               ` Cye Borg
2021-03-22 17:03             ` Russell King - ARM Linux admin
2021-03-22 17:03               ` Russell King - ARM Linux admin
2021-03-22 17:03               ` Russell King - ARM Linux admin
2021-03-22 17:10               ` Cye Borg
2021-03-22 17:10                 ` Cye Borg
2021-03-22 17:10                 ` Cye Borg
2021-03-23 18:43                 ` Russell King - ARM Linux admin
2021-03-23 18:43                   ` Russell King - ARM Linux admin
2021-03-23 18:43                   ` Russell King - ARM Linux admin
2021-03-24  5:47                   ` Cye Borg
2021-03-24  5:47                     ` Cye Borg
2021-03-24  5:47                     ` Cye Borg
2021-03-18  4:56 ` [PATCH 03/10] ARM: disable CONFIG_IDE in pxa_defconfig Christoph Hellwig
2021-03-18  4:56   ` Christoph Hellwig
2021-03-18  4:56   ` Christoph Hellwig
2021-03-18  4:57 ` [PATCH 04/10] MIPS: disable CONFIG_IDE in sb1250_swarm_defconfig Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-19  0:12   ` Maciej W. Rozycki
2021-03-19  0:12     ` Maciej W. Rozycki
2021-03-19  0:12     ` Maciej W. Rozycki
2021-03-24  9:59   ` Thomas Bogendoerfer
2021-03-24  9:59     ` Thomas Bogendoerfer
2021-03-24  9:59     ` Thomas Bogendoerfer
2021-03-18  4:57 ` [PATCH 05/10] MIPS: switch workpad_defconfig from legacy IDE to libata Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-24 10:00   ` Thomas Bogendoerfer
2021-03-24 10:00     ` Thomas Bogendoerfer
2021-03-24 10:00     ` Thomas Bogendoerfer
2021-03-18  4:57 ` [PATCH 06/10] MIPS: disable CONFIG_IDE in rbtx49xx_defconfig Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-24 10:00   ` Thomas Bogendoerfer
2021-03-24 10:00     ` Thomas Bogendoerfer
2021-03-24 10:00     ` Thomas Bogendoerfer
2021-03-18  4:57 ` [PATCH 07/10] MIPS: disable CONFIG_IDE in bigsur_defconfig Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-18 10:08   ` Sergei Shtylyov
2021-03-18 10:08     ` Sergei Shtylyov
2021-03-18 10:08     ` Sergei Shtylyov
2021-03-24 10:00   ` Thomas Bogendoerfer
2021-03-24 10:00     ` Thomas Bogendoerfer
2021-03-24 10:00     ` Thomas Bogendoerfer
2021-03-18  4:57 ` [PATCH 08/10] MIPS: disable CONFIG_IDE in malta*_defconfig Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-18 10:12   ` Sergei Shtylyov
2021-03-18 10:12     ` Sergei Shtylyov
2021-03-18 10:12     ` Sergei Shtylyov
2021-03-18 14:19   ` Thomas Bogendoerfer
2021-03-18 14:19     ` Thomas Bogendoerfer
2021-03-18 14:19     ` Thomas Bogendoerfer
2021-03-19 13:03     ` Christoph Hellwig
2021-03-19 13:03       ` Christoph Hellwig
2021-03-19 13:03       ` Christoph Hellwig
2021-03-24 10:01   ` Thomas Bogendoerfer
2021-03-24 10:01     ` Thomas Bogendoerfer
2021-03-24 10:01     ` Thomas Bogendoerfer
2021-03-18  4:57 ` [PATCH 09/10] m68k: use libata instead of the legacy ide driver Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-18  4:57 ` [PATCH 10/10] ide: remove " Christoph Hellwig
2021-03-18  4:57   ` Christoph Hellwig
2021-03-20  3:44   ` Maciej W. Rozycki
2021-03-20  3:44     ` Maciej W. Rozycki
2021-03-20  3:44     ` Maciej W. Rozycki
2021-03-20  4:04     ` Maciej W. Rozycki
2021-03-20  4:04       ` Maciej W. Rozycki
2021-03-20  4:04       ` Maciej W. Rozycki
2021-03-19  1:43 ` Finn Thain
2021-03-19  1:43   ` Finn Thain
2021-03-19  1:43   ` Finn Thain
2021-03-19  5:43   ` Christoph Hellwig
2021-03-19  5:43     ` Christoph Hellwig
2021-03-19  5:43     ` Christoph Hellwig
2021-03-19 16:48 ` Maciej W. Rozycki
2021-03-19 16:48   ` Maciej W. Rozycki
2021-03-19 16:48   ` Maciej W. Rozycki
2021-03-21  9:20 ` John Paul Adrian Glaubitz
2021-03-21  9:20   ` John Paul Adrian Glaubitz
2021-03-21  9:20   ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210322165956.GY1463@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=hch@lst.de \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mattst88@gmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=rth@twiddle.net \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.