From: Pavel Machek <pavel@ucw.cz>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, vgupta@synopsys.com,
linux-snps-arc@lists.infradead.org, jiri@nvidia.com,
idosch@nvidia.com, netdev@vger.kernel.org, Jason@zx2c4.com,
mchehab@kernel.org
Subject: Re: [PATCH 10/11] pragma once: delete few backslashes
Date: Tue, 23 Mar 2021 11:09:16 +0100 [thread overview]
Message-ID: <20210323100916.GB20449@amd> (raw)
In-Reply-To: <91f4ba8b-38a0-dfcf-1fec-31410a802f5f@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
Hi!
> > index e201b4b1655a..46704c341b17 100644
> > --- a/arch/arc/include/asm/cacheflush.h
> > +++ b/arch/arc/include/asm/cacheflush.h
> > @@ -112,6 +112,6 @@ do { \
> > } while (0)
> >
> > #define copy_from_user_page(vma, page, vaddr, dst, src, len) \
> > - memcpy(dst, src, len); \
> > + memcpy(dst, src, len)
> > This changebar also removes a semicolon.
> It looks plausibly correct, but the commit message ought to mention it.
Probably should use do{}while(0) trick.
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, vgupta@synopsys.com,
linux-snps-arc@lists.infradead.org, jiri@nvidia.com,
idosch@nvidia.com, netdev@vger.kernel.org, Jason@zx2c4.com,
mchehab@kernel.org
Subject: Re: [PATCH 10/11] pragma once: delete few backslashes
Date: Tue, 23 Mar 2021 11:09:16 +0100 [thread overview]
Message-ID: <20210323100916.GB20449@amd> (raw)
In-Reply-To: <91f4ba8b-38a0-dfcf-1fec-31410a802f5f@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 569 bytes --]
Hi!
> > index e201b4b1655a..46704c341b17 100644
> > --- a/arch/arc/include/asm/cacheflush.h
> > +++ b/arch/arc/include/asm/cacheflush.h
> > @@ -112,6 +112,6 @@ do { \
> > } while (0)
> >
> > #define copy_from_user_page(vma, page, vaddr, dst, src, len) \
> > - memcpy(dst, src, len); \
> > + memcpy(dst, src, len)
> > This changebar also removes a semicolon.
> It looks plausibly correct, but the commit message ought to mention it.
Probably should use do{}while(0) trick.
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2021-03-23 10:10 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-28 16:57 [PATCH 00/11] pragma once: treewide conversion Alexey Dobriyan
2021-02-28 16:58 ` [PATCH 01/11] pragma once: delete include/linux/atm_suni.h Alexey Dobriyan
2021-02-28 19:05 ` Jakub Kicinski
2021-02-28 16:59 ` [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types Alexey Dobriyan
2021-02-28 16:59 ` Alexey Dobriyan
2021-03-01 10:19 ` Russell King - ARM Linux admin
2021-03-01 10:19 ` Russell King - ARM Linux admin
2021-03-02 15:15 ` Alexey Dobriyan
2021-03-02 15:15 ` Alexey Dobriyan
2021-02-28 16:59 ` [PATCH 03/11] pragma once: convert arch/s390/tools/gen_facilities.c Alexey Dobriyan
2021-02-28 17:00 ` [PATCH 04/11] pragma once: convert drivers/gpu/drm/pl111/pl111_nomadik.h Alexey Dobriyan
2021-03-01 14:41 ` Linus Walleij
2021-02-28 17:01 ` [PATCH 05/11] pragma once: convert drivers/scsi/qla2xxx/qla_target.h Alexey Dobriyan
2021-02-28 22:07 ` Bart Van Assche
2021-02-28 17:02 ` [PATCH 06/11] pragma once: convert include/linux/cb710.h Alexey Dobriyan
2021-03-03 23:13 ` Michał Mirosław
2021-02-28 17:02 ` [PATCH 07/11] pragma once: convert kernel/time/timeconst.bc Alexey Dobriyan
2021-02-28 17:03 ` [PATCH 08/11] pragma once: convert scripts/atomic/ Alexey Dobriyan
2021-03-01 7:55 ` Peter Zijlstra
2021-02-28 17:04 ` [PATCH 09/11] pragma once: convert scripts/selinux/genheaders/genheaders.c Alexey Dobriyan
2021-02-28 18:37 ` Paul Moore
2021-02-28 18:57 ` Alexey Dobriyan
2021-02-28 17:05 ` [PATCH 10/11] pragma once: delete few backslashes Alexey Dobriyan
2021-02-28 17:05 ` Alexey Dobriyan
2021-03-01 8:54 ` Ido Schimmel
2021-03-01 8:54 ` Ido Schimmel
2021-03-02 19:00 ` Vineet Gupta
2021-03-02 19:00 ` Vineet Gupta
2021-03-04 14:22 ` Edward Cree
2021-03-04 14:22 ` Edward Cree
2021-03-23 10:09 ` Pavel Machek [this message]
2021-03-23 10:09 ` Pavel Machek
2021-02-28 17:05 ` [PATCH 11/11] pragma once: conversion script (in Python 2) Alexey Dobriyan
2021-02-28 17:11 ` [PATCH 12/11] pragma once: scripted treewide conversion Alexey Dobriyan
2021-02-28 17:11 ` Alexey Dobriyan
2021-03-01 17:35 ` Darrick J. Wong
2021-02-28 17:46 ` [PATCH 00/11] pragma once: " Linus Torvalds
2021-02-28 19:34 ` Alexey Dobriyan
2021-02-28 20:00 ` Linus Torvalds
[not found] ` <877dmo10m3.fsf@tromey.com>
2021-03-03 20:17 ` Linus Torvalds
2021-03-04 13:55 ` David Laight
2021-03-04 20:16 ` Linus Torvalds
2021-03-05 9:19 ` David Laight
2021-03-05 21:23 ` Linus Torvalds
2021-03-06 13:07 ` Miguel Ojeda
2021-03-06 21:33 ` Linus Torvalds
2021-03-23 10:03 ` Pavel Machek
2021-03-01 0:29 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323100916.GB20449@amd \
--to=pavel@ucw.cz \
--cc=Jason@zx2c4.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ecree.xilinx@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.