From: Vineet Gupta <vgupta@synopsys.com> To: Alexey Dobriyan <adobriyan@gmail.com>, torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-snps-arc@lists.infradead.org, jiri@nvidia.com, idosch@nvidia.com, netdev@vger.kernel.org, Jason@zx2c4.com, mchehab@kernel.org Subject: Re: [PATCH 10/11] pragma once: delete few backslashes Date: Tue, 2 Mar 2021 11:00:10 -0800 [thread overview] Message-ID: <5783abae-c7af-0e82-8f28-09f30ff67904@synopsys.com> (raw) In-Reply-To: <YDvNSg9OPv7JqfRS@localhost.localdomain> On 2/28/21 9:05 AM, Alexey Dobriyan wrote: > From 251ca5673886b5bb0a42004944290b9d2b267a4a Mon Sep 17 00:00:00 2001 > From: Alexey Dobriyan <adobriyan@gmail.com> > Date: Fri, 19 Feb 2021 13:37:24 +0300 > Subject: [PATCH 10/11] pragma once: delete few backslashes > > Some macros contain one backslash too many and end up being the last > macro in a header file. When #pragma once conversion script truncates > the last #endif and whitespace before it, such backslash triggers > a warning about "OMG file ends up in a backslash-newline". > > Needless to say I don't want to handle another case in my script, > so delete useless backslashes instead. > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Acked-by: Vineet Gupta <vgupta@synopsys.com> #arch/arc bits Thx, -Vineet > --- > arch/arc/include/asm/cacheflush.h | 2 +- > drivers/net/ethernet/mellanox/mlxsw/item.h | 2 +- > include/linux/once.h | 2 +- > include/media/drv-intf/exynos-fimc.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arc/include/asm/cacheflush.h b/arch/arc/include/asm/cacheflush.h > index e201b4b1655a..46704c341b17 100644 > --- a/arch/arc/include/asm/cacheflush.h > +++ b/arch/arc/include/asm/cacheflush.h > @@ -112,6 +112,6 @@ do { \ > } while (0) > > #define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > - memcpy(dst, src, len); \ > + memcpy(dst, src, len) > > #endif > diff --git a/drivers/net/ethernet/mellanox/mlxsw/item.h b/drivers/net/ethernet/mellanox/mlxsw/item.h > index e92cadc98128..cc0133401dd1 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/item.h > +++ b/drivers/net/ethernet/mellanox/mlxsw/item.h > @@ -504,6 +504,6 @@ mlxsw_##_type##_##_cname##_##_iname##_set(char *buf, u16 index, u8 val) \ > return __mlxsw_item_bit_array_set(buf, \ > &__ITEM_NAME(_type, _cname, _iname), \ > index, val); \ > -} \ > +} > > #endif > diff --git a/include/linux/once.h b/include/linux/once.h > index 9225ee6d96c7..0af450ff94a5 100644 > --- a/include/linux/once.h > +++ b/include/linux/once.h > @@ -55,6 +55,6 @@ void __do_once_done(bool *done, struct static_key_true *once_key, > #define get_random_once(buf, nbytes) \ > DO_ONCE(get_random_bytes, (buf), (nbytes)) > #define get_random_once_wait(buf, nbytes) \ > - DO_ONCE(get_random_bytes_wait, (buf), (nbytes)) \ > + DO_ONCE(get_random_bytes_wait, (buf), (nbytes)) > > #endif /* _LINUX_ONCE_H */ > diff --git a/include/media/drv-intf/exynos-fimc.h b/include/media/drv-intf/exynos-fimc.h > index 6b9ef631d6bb..6c5fbdacf4b5 100644 > --- a/include/media/drv-intf/exynos-fimc.h > +++ b/include/media/drv-intf/exynos-fimc.h > @@ -152,6 +152,6 @@ static inline struct exynos_video_entity *vdev_to_exynos_video_entity( > #define fimc_pipeline_call(ent, op, args...) \ > ((!(ent) || !(ent)->pipe) ? -ENOENT : \ > (((ent)->pipe->ops && (ent)->pipe->ops->op) ? \ > - (ent)->pipe->ops->op(((ent)->pipe), ##args) : -ENOIOCTLCMD)) \ > + (ent)->pipe->ops->op(((ent)->pipe), ##args) : -ENOIOCTLCMD)) > > #endif /* S5P_FIMC_H_ */ >
WARNING: multiple messages have this Message-ID (diff)
From: Vineet Gupta <vgupta@synopsys.com> To: Alexey Dobriyan <adobriyan@gmail.com>, torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-snps-arc@lists.infradead.org, jiri@nvidia.com, idosch@nvidia.com, netdev@vger.kernel.org, Jason@zx2c4.com, mchehab@kernel.org Subject: Re: [PATCH 10/11] pragma once: delete few backslashes Date: Tue, 2 Mar 2021 11:00:10 -0800 [thread overview] Message-ID: <5783abae-c7af-0e82-8f28-09f30ff67904@synopsys.com> (raw) In-Reply-To: <YDvNSg9OPv7JqfRS@localhost.localdomain> On 2/28/21 9:05 AM, Alexey Dobriyan wrote: > From 251ca5673886b5bb0a42004944290b9d2b267a4a Mon Sep 17 00:00:00 2001 > From: Alexey Dobriyan <adobriyan@gmail.com> > Date: Fri, 19 Feb 2021 13:37:24 +0300 > Subject: [PATCH 10/11] pragma once: delete few backslashes > > Some macros contain one backslash too many and end up being the last > macro in a header file. When #pragma once conversion script truncates > the last #endif and whitespace before it, such backslash triggers > a warning about "OMG file ends up in a backslash-newline". > > Needless to say I don't want to handle another case in my script, > so delete useless backslashes instead. > > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Acked-by: Vineet Gupta <vgupta@synopsys.com> #arch/arc bits Thx, -Vineet > --- > arch/arc/include/asm/cacheflush.h | 2 +- > drivers/net/ethernet/mellanox/mlxsw/item.h | 2 +- > include/linux/once.h | 2 +- > include/media/drv-intf/exynos-fimc.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arc/include/asm/cacheflush.h b/arch/arc/include/asm/cacheflush.h > index e201b4b1655a..46704c341b17 100644 > --- a/arch/arc/include/asm/cacheflush.h > +++ b/arch/arc/include/asm/cacheflush.h > @@ -112,6 +112,6 @@ do { \ > } while (0) > > #define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > - memcpy(dst, src, len); \ > + memcpy(dst, src, len) > > #endif > diff --git a/drivers/net/ethernet/mellanox/mlxsw/item.h b/drivers/net/ethernet/mellanox/mlxsw/item.h > index e92cadc98128..cc0133401dd1 100644 > --- a/drivers/net/ethernet/mellanox/mlxsw/item.h > +++ b/drivers/net/ethernet/mellanox/mlxsw/item.h > @@ -504,6 +504,6 @@ mlxsw_##_type##_##_cname##_##_iname##_set(char *buf, u16 index, u8 val) \ > return __mlxsw_item_bit_array_set(buf, \ > &__ITEM_NAME(_type, _cname, _iname), \ > index, val); \ > -} \ > +} > > #endif > diff --git a/include/linux/once.h b/include/linux/once.h > index 9225ee6d96c7..0af450ff94a5 100644 > --- a/include/linux/once.h > +++ b/include/linux/once.h > @@ -55,6 +55,6 @@ void __do_once_done(bool *done, struct static_key_true *once_key, > #define get_random_once(buf, nbytes) \ > DO_ONCE(get_random_bytes, (buf), (nbytes)) > #define get_random_once_wait(buf, nbytes) \ > - DO_ONCE(get_random_bytes_wait, (buf), (nbytes)) \ > + DO_ONCE(get_random_bytes_wait, (buf), (nbytes)) > > #endif /* _LINUX_ONCE_H */ > diff --git a/include/media/drv-intf/exynos-fimc.h b/include/media/drv-intf/exynos-fimc.h > index 6b9ef631d6bb..6c5fbdacf4b5 100644 > --- a/include/media/drv-intf/exynos-fimc.h > +++ b/include/media/drv-intf/exynos-fimc.h > @@ -152,6 +152,6 @@ static inline struct exynos_video_entity *vdev_to_exynos_video_entity( > #define fimc_pipeline_call(ent, op, args...) \ > ((!(ent) || !(ent)->pipe) ? -ENOENT : \ > (((ent)->pipe->ops && (ent)->pipe->ops->op) ? \ > - (ent)->pipe->ops->op(((ent)->pipe), ##args) : -ENOIOCTLCMD)) \ > + (ent)->pipe->ops->op(((ent)->pipe), ##args) : -ENOIOCTLCMD)) > > #endif /* S5P_FIMC_H_ */ > _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2021-03-02 22:08 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-28 16:57 [PATCH 00/11] pragma once: treewide conversion Alexey Dobriyan 2021-02-28 16:58 ` [PATCH 01/11] pragma once: delete include/linux/atm_suni.h Alexey Dobriyan 2021-02-28 19:05 ` Jakub Kicinski 2021-02-28 16:59 ` [PATCH 02/11] pragma once: convert arch/arm/tools/gen-mach-types Alexey Dobriyan 2021-02-28 16:59 ` Alexey Dobriyan 2021-03-01 10:19 ` Russell King - ARM Linux admin 2021-03-01 10:19 ` Russell King - ARM Linux admin 2021-03-02 15:15 ` Alexey Dobriyan 2021-03-02 15:15 ` Alexey Dobriyan 2021-02-28 16:59 ` [PATCH 03/11] pragma once: convert arch/s390/tools/gen_facilities.c Alexey Dobriyan 2021-02-28 17:00 ` [PATCH 04/11] pragma once: convert drivers/gpu/drm/pl111/pl111_nomadik.h Alexey Dobriyan 2021-03-01 14:41 ` Linus Walleij 2021-02-28 17:01 ` [PATCH 05/11] pragma once: convert drivers/scsi/qla2xxx/qla_target.h Alexey Dobriyan 2021-02-28 22:07 ` Bart Van Assche 2021-02-28 17:02 ` [PATCH 06/11] pragma once: convert include/linux/cb710.h Alexey Dobriyan 2021-03-03 23:13 ` Michał Mirosław 2021-02-28 17:02 ` [PATCH 07/11] pragma once: convert kernel/time/timeconst.bc Alexey Dobriyan 2021-02-28 17:03 ` [PATCH 08/11] pragma once: convert scripts/atomic/ Alexey Dobriyan 2021-03-01 7:55 ` Peter Zijlstra 2021-02-28 17:04 ` [PATCH 09/11] pragma once: convert scripts/selinux/genheaders/genheaders.c Alexey Dobriyan 2021-02-28 18:37 ` Paul Moore 2021-02-28 18:57 ` Alexey Dobriyan 2021-02-28 17:05 ` [PATCH 10/11] pragma once: delete few backslashes Alexey Dobriyan 2021-02-28 17:05 ` Alexey Dobriyan 2021-03-01 8:54 ` Ido Schimmel 2021-03-01 8:54 ` Ido Schimmel 2021-03-02 19:00 ` Vineet Gupta [this message] 2021-03-02 19:00 ` Vineet Gupta 2021-03-04 14:22 ` Edward Cree 2021-03-04 14:22 ` Edward Cree 2021-03-23 10:09 ` Pavel Machek 2021-03-23 10:09 ` Pavel Machek 2021-02-28 17:05 ` [PATCH 11/11] pragma once: conversion script (in Python 2) Alexey Dobriyan 2021-02-28 17:11 ` [PATCH 12/11] pragma once: scripted treewide conversion Alexey Dobriyan 2021-02-28 17:11 ` Alexey Dobriyan 2021-03-01 17:35 ` Darrick J. Wong 2021-02-28 17:46 ` [PATCH 00/11] pragma once: " Linus Torvalds 2021-02-28 19:34 ` Alexey Dobriyan 2021-02-28 20:00 ` Linus Torvalds [not found] ` <877dmo10m3.fsf@tromey.com> 2021-03-03 20:17 ` Linus Torvalds 2021-03-04 13:55 ` David Laight 2021-03-04 20:16 ` Linus Torvalds 2021-03-05 9:19 ` David Laight 2021-03-05 21:23 ` Linus Torvalds 2021-03-06 13:07 ` Miguel Ojeda 2021-03-06 21:33 ` Linus Torvalds 2021-03-23 10:03 ` Pavel Machek 2021-03-01 0:29 ` Luc Van Oostenryck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5783abae-c7af-0e82-8f28-09f30ff67904@synopsys.com \ --to=vgupta@synopsys.com \ --cc=Jason@zx2c4.com \ --cc=adobriyan@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=idosch@nvidia.com \ --cc=jiri@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-snps-arc@lists.infradead.org \ --cc=mchehab@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.