* [PATCH] drm/amd/display: Removing unsued code from dmub_cmd.h
@ 2021-03-23 21:01 Anson Jacob
2021-03-24 4:12 ` Rodrigo Siqueira
0 siblings, 1 reply; 2+ messages in thread
From: Anson Jacob @ 2021-03-23 21:01 UTC (permalink / raw)
To: amd-gfx
Cc: Anson Jacob, Rodrigo.Siqueira, solomon.chiu, Harry.Wentland,
felipe.clark
Removing code that is not used at the moment.
Signed-off-by: Anson Jacob <Anson.Jacob@amd.com>
---
.../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 37 -------------------
1 file changed, 37 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
index 09c62485a1f1..2d23462f4980 100644
--- a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
+++ b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
@@ -202,12 +202,7 @@ struct dmub_feature_caps {
* Max PSR version supported by FW.
*/
uint8_t psr;
-#ifndef TRIM_FAMS
- uint8_t fw_assisted_mclk_switch;
- uint8_t reserved[6];
-#else
uint8_t reserved[7];
-#endif
};
#if defined(__cplusplus)
@@ -532,10 +527,6 @@ enum dmub_cmd_type {
* Command type used for OUTBOX1 notification enable
*/
DMUB_CMD__OUTBOX1_ENABLE = 71,
-#ifndef TRIM_FAMS
- DMUB_CMD__FW_ASSISTED_MCLK_SWITCH = 76,
-#endif
-
/**
* Command type used for all VBIOS interface commands.
*/
@@ -1115,13 +1106,6 @@ enum dmub_cmd_psr_type {
DMUB_CMD__PSR_FORCE_STATIC = 5,
};
-#ifndef TRIM_FAMS
-enum dmub_cmd_fams_type {
- DMUB_CMD__FAMS_SETUP_FW_CTRL = 0,
- DMUB_CMD__FAMS_DRR_UPDATE = 1,
-};
-#endif
-
/**
* PSR versions.
*/
@@ -1791,24 +1775,6 @@ struct dmub_rb_cmd_drr_update {
struct dmub_optc_state dmub_optc_state_req;
};
-#ifndef TRIM_FAMS
-struct dmub_cmd_fw_assisted_mclk_switch_pipe_data {
- uint32_t pix_clk_100hz;
- uint32_t min_refresh_in_uhz;
- uint32_t max_ramp_step;
-};
-
-struct dmub_cmd_fw_assisted_mclk_switch_config {
- uint32_t fams_enabled;
- struct dmub_cmd_fw_assisted_mclk_switch_pipe_data pipe_data[DMUB_MAX_STREAMS];
-};
-
-struct dmub_rb_cmd_fw_assisted_mclk_switch {
- struct dmub_cmd_header header;
- struct dmub_cmd_fw_assisted_mclk_switch_config config_data;
-};
-#endif
-
/**
* Data passed from driver to FW in a DMUB_CMD__VBIOS_LVTMA_CONTROL command.
*/
@@ -1951,9 +1917,6 @@ union dmub_rb_cmd {
*/
struct dmub_rb_cmd_query_feature_caps query_feature_caps;
struct dmub_rb_cmd_drr_update drr_update;
-#ifndef TRIM_FAMS
- struct dmub_rb_cmd_fw_assisted_mclk_switch fw_assisted_mclk_switch;
-#endif
/**
* Definition of a DMUB_CMD__VBIOS_LVTMA_CONTROL command.
*/
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Removing unsued code from dmub_cmd.h
2021-03-23 21:01 [PATCH] drm/amd/display: Removing unsued code from dmub_cmd.h Anson Jacob
@ 2021-03-24 4:12 ` Rodrigo Siqueira
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Siqueira @ 2021-03-24 4:12 UTC (permalink / raw)
To: Anson Jacob; +Cc: felipe.clark, Harry.Wentland, amd-gfx, solomon.chiu
[-- Attachment #1.1: Type: text/plain, Size: 2648 bytes --]
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
On 03/23, Anson Jacob wrote:
> Removing code that is not used at the moment.
>
> Signed-off-by: Anson Jacob <Anson.Jacob@amd.com>
> ---
> .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 37 -------------------
> 1 file changed, 37 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
> index 09c62485a1f1..2d23462f4980 100644
> --- a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
> +++ b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
> @@ -202,12 +202,7 @@ struct dmub_feature_caps {
> * Max PSR version supported by FW.
> */
> uint8_t psr;
> -#ifndef TRIM_FAMS
> - uint8_t fw_assisted_mclk_switch;
> - uint8_t reserved[6];
> -#else
> uint8_t reserved[7];
> -#endif
> };
>
> #if defined(__cplusplus)
> @@ -532,10 +527,6 @@ enum dmub_cmd_type {
> * Command type used for OUTBOX1 notification enable
> */
> DMUB_CMD__OUTBOX1_ENABLE = 71,
> -#ifndef TRIM_FAMS
> - DMUB_CMD__FW_ASSISTED_MCLK_SWITCH = 76,
> -#endif
> -
> /**
> * Command type used for all VBIOS interface commands.
> */
> @@ -1115,13 +1106,6 @@ enum dmub_cmd_psr_type {
> DMUB_CMD__PSR_FORCE_STATIC = 5,
> };
>
> -#ifndef TRIM_FAMS
> -enum dmub_cmd_fams_type {
> - DMUB_CMD__FAMS_SETUP_FW_CTRL = 0,
> - DMUB_CMD__FAMS_DRR_UPDATE = 1,
> -};
> -#endif
> -
> /**
> * PSR versions.
> */
> @@ -1791,24 +1775,6 @@ struct dmub_rb_cmd_drr_update {
> struct dmub_optc_state dmub_optc_state_req;
> };
>
> -#ifndef TRIM_FAMS
> -struct dmub_cmd_fw_assisted_mclk_switch_pipe_data {
> - uint32_t pix_clk_100hz;
> - uint32_t min_refresh_in_uhz;
> - uint32_t max_ramp_step;
> -};
> -
> -struct dmub_cmd_fw_assisted_mclk_switch_config {
> - uint32_t fams_enabled;
> - struct dmub_cmd_fw_assisted_mclk_switch_pipe_data pipe_data[DMUB_MAX_STREAMS];
> -};
> -
> -struct dmub_rb_cmd_fw_assisted_mclk_switch {
> - struct dmub_cmd_header header;
> - struct dmub_cmd_fw_assisted_mclk_switch_config config_data;
> -};
> -#endif
> -
> /**
> * Data passed from driver to FW in a DMUB_CMD__VBIOS_LVTMA_CONTROL command.
> */
> @@ -1951,9 +1917,6 @@ union dmub_rb_cmd {
> */
> struct dmub_rb_cmd_query_feature_caps query_feature_caps;
> struct dmub_rb_cmd_drr_update drr_update;
> -#ifndef TRIM_FAMS
> - struct dmub_rb_cmd_fw_assisted_mclk_switch fw_assisted_mclk_switch;
> -#endif
> /**
> * Definition of a DMUB_CMD__VBIOS_LVTMA_CONTROL command.
> */
> --
> 2.25.1
>
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-24 4:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 21:01 [PATCH] drm/amd/display: Removing unsued code from dmub_cmd.h Anson Jacob
2021-03-24 4:12 ` Rodrigo Siqueira
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.