From: Geert Uytterhoeven <geert+renesas@glider.be> To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>, Petr Mladek <pmladek@suse.com>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Cc: Linus Torvalds <torvalds@linux-foundation.org>, Andrew Morton <akpm@linux-foundation.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, John Ogness <john.ogness@linutronix.de>, Gary R Hook <gary.hook@amd.com>, Marco Elver <elver@google.com>, Randy Dunlap <rdunlap@infradead.org>, Vlastimil Babka <vbabka@suse.cz>, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be> Subject: [PATCH 0/3] Use pr_crit() instead of long fancy messages Date: Wed, 31 Mar 2021 11:31:01 +0200 [thread overview] Message-ID: <20210331093104.383705-1-geert+renesas@glider.be> (raw) Hi all, While long fancy messages have a higher probability of being seen than small messages, they may scroll of the screen fast, if visible at all, and may still be missed. In addition, they increase boot time and kernel size. The correct mechanism to increase importance of a kernel message is not to draw fancy boxes with more text, but to shout louder, i.e. increase the message's reporting level. Making sure the administrator of the system is aware of such a message is a system policy, and is the responsability of a user-space log daemon. This series increases the reporting level of such messages from KERN_WARNING to KERN_CRIT, and removes irrelevant text and graphics. It was made against linux-next, but applies to v5.12-rc5 with an offset for the last patch. Each of these patches reduces kernel size by ca. 0.5 KiB. Thanks for your comments! Geert Uytterhoeven (3): iommu: Use pr_crit() instead of long fancy messages tracing: Use pr_crit() instead of long fancy messages lib/vsprintf: Use pr_crit() instead of long fancy messages drivers/iommu/iommu-debugfs.c | 19 ++++--------------- kernel/trace/trace.c | 17 +++-------------- lib/vsprintf.c | 17 +++-------------- 3 files changed, 10 insertions(+), 43 deletions(-) -- 2.25.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas@glider.be> To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>, Petr Mladek <pmladek@suse.com>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Cc: Marco Elver <elver@google.com>, linux-embedded@vger.kernel.org, John Ogness <john.ogness@linutronix.de>, Gary R Hook <gary.hook@amd.com>, Randy Dunlap <rdunlap@infradead.org>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Geert Uytterhoeven <geert+renesas@glider.be>, Andrew Morton <akpm@linux-foundation.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Linus Torvalds <torvalds@linux-foundation.org>, Vlastimil Babka <vbabka@suse.cz> Subject: [PATCH 0/3] Use pr_crit() instead of long fancy messages Date: Wed, 31 Mar 2021 11:31:01 +0200 [thread overview] Message-ID: <20210331093104.383705-1-geert+renesas@glider.be> (raw) Hi all, While long fancy messages have a higher probability of being seen than small messages, they may scroll of the screen fast, if visible at all, and may still be missed. In addition, they increase boot time and kernel size. The correct mechanism to increase importance of a kernel message is not to draw fancy boxes with more text, but to shout louder, i.e. increase the message's reporting level. Making sure the administrator of the system is aware of such a message is a system policy, and is the responsability of a user-space log daemon. This series increases the reporting level of such messages from KERN_WARNING to KERN_CRIT, and removes irrelevant text and graphics. It was made against linux-next, but applies to v5.12-rc5 with an offset for the last patch. Each of these patches reduces kernel size by ca. 0.5 KiB. Thanks for your comments! Geert Uytterhoeven (3): iommu: Use pr_crit() instead of long fancy messages tracing: Use pr_crit() instead of long fancy messages lib/vsprintf: Use pr_crit() instead of long fancy messages drivers/iommu/iommu-debugfs.c | 19 ++++--------------- kernel/trace/trace.c | 17 +++-------------- lib/vsprintf.c | 17 +++-------------- 3 files changed, 10 insertions(+), 43 deletions(-) -- 2.25.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2021-03-31 10:00 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-31 9:31 Geert Uytterhoeven [this message] 2021-03-31 9:31 ` [PATCH 0/3] Use pr_crit() instead of long fancy messages Geert Uytterhoeven 2021-03-31 9:31 ` [PATCH 1/3] iommu: " Geert Uytterhoeven 2021-03-31 9:31 ` Geert Uytterhoeven 2021-03-31 9:31 ` [PATCH 2/3] tracing: " Geert Uytterhoeven 2021-03-31 9:31 ` Geert Uytterhoeven 2021-03-31 13:40 ` Steven Rostedt 2021-03-31 13:40 ` Steven Rostedt 2021-03-31 13:40 ` Steven Rostedt 2021-04-01 9:14 ` Petr Mladek 2021-04-01 9:14 ` Petr Mladek via iommu 2021-04-01 9:14 ` Petr Mladek via iommu 2021-04-01 9:39 ` Geert Uytterhoeven 2021-04-01 9:39 ` Geert Uytterhoeven 2021-04-01 9:39 ` Geert Uytterhoeven 2021-04-01 11:28 ` Robin Murphy 2021-04-01 11:28 ` Robin Murphy 2021-04-01 11:28 ` Robin Murphy 2021-03-31 9:31 ` [PATCH 3/3] lib/vsprintf: " Geert Uytterhoeven 2021-03-31 9:31 ` Geert Uytterhoeven 2021-05-17 6:21 ` Geert Uytterhoeven 2021-05-17 6:21 ` Geert Uytterhoeven 2021-05-17 6:21 ` Geert Uytterhoeven 2021-05-20 12:51 ` Petr Mladek 2021-05-20 12:51 ` Petr Mladek via iommu 2021-05-20 12:51 ` Petr Mladek via iommu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210331093104.383705-1-geert+renesas@glider.be \ --to=geert+renesas@glider.be \ --cc=akpm@linux-foundation.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=elver@google.com \ --cc=gary.hook@amd.com \ --cc=iommu@lists.linux-foundation.org \ --cc=john.ogness@linutronix.de \ --cc=joro@8bytes.org \ --cc=linux-embedded@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@rasmusvillemoes.dk \ --cc=mingo@redhat.com \ --cc=pmladek@suse.com \ --cc=rdunlap@infradead.org \ --cc=rostedt@goodmis.org \ --cc=sergey.senozhatsky@gmail.com \ --cc=torvalds@linux-foundation.org \ --cc=vbabka@suse.cz \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.