From: Steven Rostedt <rostedt@goodmis.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
John Ogness <john.ogness@linutronix.de>,
Gary R Hook <gary.hook@amd.com>, Marco Elver <elver@google.com>,
Randy Dunlap <rdunlap@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-embedded@vger.kernel.org
Subject: Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages
Date: Wed, 31 Mar 2021 09:40:07 -0400 [thread overview]
Message-ID: <20210331094007.77aa5194@gandalf.local.home> (raw)
In-Reply-To: <20210331093104.383705-3-geert+renesas@glider.be>
On Wed, 31 Mar 2021 11:31:03 +0200
Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> This reduces kernel size by ca. 0.5 KiB.
If you are worried about size, disable tracing and it will go away
entirely. 0.5KiB is a drop in the bucket compared to what tracing adds in
size overhead.
Sorry, but NAK.
This has been very successful in stopping people from adding trace_printk()
to the kernel, and I like to keep it that way.
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Petr Mladek <pmladek@suse.com>, Marco Elver <elver@google.com>,
linux-embedded@vger.kernel.org,
John Ogness <john.ogness@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
iommu@lists.linux-foundation.org, Ingo Molnar <mingo@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Will Deacon <will@kernel.org>, Gary R Hook <gary.hook@amd.com>
Subject: Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages
Date: Wed, 31 Mar 2021 09:40:07 -0400 [thread overview]
Message-ID: <20210331094007.77aa5194@gandalf.local.home> (raw)
In-Reply-To: <20210331093104.383705-3-geert+renesas@glider.be>
On Wed, 31 Mar 2021 11:31:03 +0200
Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> This reduces kernel size by ca. 0.5 KiB.
If you are worried about size, disable tracing and it will go away
entirely. 0.5KiB is a drop in the bucket compared to what tracing adds in
size overhead.
Sorry, but NAK.
This has been very successful in stopping people from adding trace_printk()
to the kernel, and I like to keep it that way.
-- Steve
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>
To: Geert Uytterhoeven
<geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
Cc: Petr Mladek <pmladek-IBi9RG/b67k@public.gmane.org>,
Marco Elver <elver-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
linux-embedded-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
John Ogness <john.ogness-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Rasmus Villemoes
<linux-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sergey Senozhatsky
<sergey.senozhatsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Vlastimil Babka <vbabka-AlSwsSmVLrQ@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Andy Shevchenko
<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Will Deacon <will-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Gary R Hook <gary.hook-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 2/3] tracing: Use pr_crit() instead of long fancy messages
Date: Wed, 31 Mar 2021 09:40:07 -0400 [thread overview]
Message-ID: <20210331094007.77aa5194@gandalf.local.home> (raw)
In-Reply-To: <20210331093104.383705-3-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
On Wed, 31 Mar 2021 11:31:03 +0200
Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org> wrote:
> This reduces kernel size by ca. 0.5 KiB.
If you are worried about size, disable tracing and it will go away
entirely. 0.5KiB is a drop in the bucket compared to what tracing adds in
size overhead.
Sorry, but NAK.
This has been very successful in stopping people from adding trace_printk()
to the kernel, and I like to keep it that way.
-- Steve
next prev parent reply other threads:[~2021-03-31 13:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 9:31 [PATCH 0/3] Use pr_crit() instead of long fancy messages Geert Uytterhoeven
2021-03-31 9:31 ` Geert Uytterhoeven
2021-03-31 9:31 ` [PATCH 1/3] iommu: " Geert Uytterhoeven
2021-03-31 9:31 ` Geert Uytterhoeven
2021-03-31 9:31 ` [PATCH 2/3] tracing: " Geert Uytterhoeven
2021-03-31 9:31 ` Geert Uytterhoeven
2021-03-31 13:40 ` Steven Rostedt [this message]
2021-03-31 13:40 ` Steven Rostedt
2021-03-31 13:40 ` Steven Rostedt
2021-04-01 9:14 ` Petr Mladek
2021-04-01 9:14 ` Petr Mladek via iommu
2021-04-01 9:14 ` Petr Mladek via iommu
2021-04-01 9:39 ` Geert Uytterhoeven
2021-04-01 9:39 ` Geert Uytterhoeven
2021-04-01 9:39 ` Geert Uytterhoeven
2021-04-01 11:28 ` Robin Murphy
2021-04-01 11:28 ` Robin Murphy
2021-04-01 11:28 ` Robin Murphy
2021-03-31 9:31 ` [PATCH 3/3] lib/vsprintf: " Geert Uytterhoeven
2021-03-31 9:31 ` Geert Uytterhoeven
2021-05-17 6:21 ` Geert Uytterhoeven
2021-05-17 6:21 ` Geert Uytterhoeven
2021-05-17 6:21 ` Geert Uytterhoeven
2021-05-20 12:51 ` Petr Mladek
2021-05-20 12:51 ` Petr Mladek via iommu
2021-05-20 12:51 ` Petr Mladek via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331094007.77aa5194@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=elver@google.com \
--cc=gary.hook@amd.com \
--cc=geert+renesas@glider.be \
--cc=iommu@lists.linux-foundation.org \
--cc=john.ogness@linutronix.de \
--cc=joro@8bytes.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.