* Re: [PATCH v4 1/3] clk: add support for the lmk04832
@ 2021-04-07 9:50 kernel test robot
2021-04-07 9:51 ` [PATCH] clk: fix for_each_child.cocci warnings kernel test robot
2021-04-07 9:51 ` [PATCH] clk: fix semicolon.cocci warnings kernel test robot
0 siblings, 2 replies; 9+ messages in thread
From: kernel test robot @ 2021-04-07 9:50 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210407005330.2890430-2-liambeguin@gmail.com>
References: <20210407005330.2890430-2-liambeguin@gmail.com>
TO: Liam Beguin <liambeguin@gmail.com>
TO: liambeguin(a)gmail.com
TO: mturquette(a)baylibre.com
TO: sboyd(a)kernel.org
CC: linux-clk(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
CC: devicetree(a)vger.kernel.org
CC: robh+dt(a)kernel.org
Hi Liam,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on f40ddce88593482919761f74910f42f4b84c004b]
url: https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
base: f40ddce88593482919761f74910f42f4b84c004b
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
config: i386-allmodconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/clk/clk-lmk04832.c:1155:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1162.
--
>> drivers/clk/clk-lmk04832.c:1175:2-3: Unneeded semicolon
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65172 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] clk: fix for_each_child.cocci warnings
2021-04-07 9:50 [PATCH v4 1/3] clk: add support for the lmk04832 kernel test robot
@ 2021-04-07 9:51 ` kernel test robot
2021-04-07 9:51 ` [PATCH] clk: fix semicolon.cocci warnings kernel test robot
1 sibling, 0 replies; 9+ messages in thread
From: kernel test robot @ 2021-04-07 9:51 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210407005330.2890430-2-liambeguin@gmail.com>
References: <20210407005330.2890430-2-liambeguin@gmail.com>
TO: Liam Beguin <liambeguin@gmail.com>
TO: liambeguin(a)gmail.com
TO: mturquette(a)baylibre.com
TO: sboyd(a)kernel.org
CC: linux-clk(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
CC: devicetree(a)vger.kernel.org
CC: robh+dt(a)kernel.org
From: kernel test robot <lkp@intel.com>
drivers/clk/clk-lmk04832.c:1155:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1162.
Semantic patch information:
False positives can be due to function calls within the for_each
loop that may encapsulate an of_node_put.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Liam Beguin <lvb@xiphos.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
base: f40ddce88593482919761f74910f42f4b84c004b
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
Please take the patch only if it's a positive warning. Thanks!
clk-lmk04832.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/clk/clk-lmk04832.c
+++ b/drivers/clk/clk-lmk04832.c
@@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
if (ret) {
dev_err(lmk->dev, "missing reg property in child: %s\n",
child->full_name);
+ of_node_put(child);
goto err_disable_oscin;
}
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] clk: fix semicolon.cocci warnings
2021-04-07 9:50 [PATCH v4 1/3] clk: add support for the lmk04832 kernel test robot
2021-04-07 9:51 ` [PATCH] clk: fix for_each_child.cocci warnings kernel test robot
@ 2021-04-07 9:51 ` kernel test robot
1 sibling, 0 replies; 9+ messages in thread
From: kernel test robot @ 2021-04-07 9:51 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210407005330.2890430-2-liambeguin@gmail.com>
References: <20210407005330.2890430-2-liambeguin@gmail.com>
TO: Liam Beguin <liambeguin@gmail.com>
TO: liambeguin(a)gmail.com
TO: mturquette(a)baylibre.com
TO: sboyd(a)kernel.org
CC: linux-clk(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
CC: devicetree(a)vger.kernel.org
CC: robh+dt(a)kernel.org
From: kernel test robot <lkp@intel.com>
drivers/clk/clk-lmk04832.c:1175:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Liam Beguin <lvb@xiphos.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
base: f40ddce88593482919761f74910f42f4b84c004b
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
clk-lmk04832.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/clk/clk-lmk04832.c
+++ b/drivers/clk/clk-lmk04832.c
@@ -1172,7 +1172,7 @@ static int lmk04832_probe(struct spi_dev
lmk->clkout[reg].sysref =
of_property_read_bool(child, "ti,clkout-sysref");
- };
+ }
lmk->regmap = devm_regmap_init_spi(spi, ®map_config);
if (IS_ERR(lmk->regmap)) {
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] clk: fix for_each_child.cocci warnings
@ 2021-04-07 19:02 ` Julia Lawall
0 siblings, 0 replies; 9+ messages in thread
From: Julia Lawall @ 2021-04-07 19:02 UTC (permalink / raw)
To: Liam Beguin, mturquette, sboyd
Cc: linux-clk, linux-kernel, devicetree, robh+dt, kbuild-all
From: kernel test robot <lkp@intel.com>
For_each_child_of_node should have of_node_put() before goto.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Liam Beguin <lvb@xiphos.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
url: https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
base: f40ddce88593482919761f74910f42f4b84c004b
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
clk-lmk04832.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/clk/clk-lmk04832.c
+++ b/drivers/clk/clk-lmk04832.c
@@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
if (ret) {
dev_err(lmk->dev, "missing reg property in child: %s\n",
child->full_name);
+ of_node_put(child);
goto err_disable_oscin;
}
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] clk: fix for_each_child.cocci warnings
@ 2021-04-07 19:02 ` Julia Lawall
0 siblings, 0 replies; 9+ messages in thread
From: Julia Lawall @ 2021-04-07 19:02 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
From: kernel test robot <lkp@intel.com>
For_each_child_of_node should have of_node_put() before goto.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Liam Beguin <lvb@xiphos.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
url: https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
base: f40ddce88593482919761f74910f42f4b84c004b
:::::: branch date: 9 hours ago
:::::: commit date: 9 hours ago
clk-lmk04832.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/clk/clk-lmk04832.c
+++ b/drivers/clk/clk-lmk04832.c
@@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
if (ret) {
dev_err(lmk->dev, "missing reg property in child: %s\n",
child->full_name);
+ of_node_put(child);
goto err_disable_oscin;
}
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] clk: fix for_each_child.cocci warnings
2021-04-07 19:02 ` Julia Lawall
@ 2021-04-08 0:31 ` Stephen Boyd
-1 siblings, 0 replies; 9+ messages in thread
From: Stephen Boyd @ 2021-04-08 0:31 UTC (permalink / raw)
To: Julia Lawall, Liam Beguin, mturquette
Cc: linux-clk, linux-kernel, devicetree, robh+dt, kbuild-all
Quoting Julia Lawall (2021-04-07 12:02:32)
> From: kernel test robot <lkp@intel.com>
>
> For_each_child_of_node should have of_node_put() before goto.
>
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>
> CC: Liam Beguin <lvb@xiphos.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
Is this a fix for a patch on the list?
>
> url: https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
> base: f40ddce88593482919761f74910f42f4b84c004b
> :::::: branch date: 9 hours ago
> :::::: commit date: 9 hours ago
>
> clk-lmk04832.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/clk/clk-lmk04832.c
> +++ b/drivers/clk/clk-lmk04832.c
> @@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
> if (ret) {
> dev_err(lmk->dev, "missing reg property in child: %s\n",
> child->full_name);
> + of_node_put(child);
> goto err_disable_oscin;
> }
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] clk: fix for_each_child.cocci warnings
@ 2021-04-08 0:31 ` Stephen Boyd
0 siblings, 0 replies; 9+ messages in thread
From: Stephen Boyd @ 2021-04-08 0:31 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]
Quoting Julia Lawall (2021-04-07 12:02:32)
> From: kernel test robot <lkp@intel.com>
>
> For_each_child_of_node should have of_node_put() before goto.
>
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>
> CC: Liam Beguin <lvb@xiphos.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
Is this a fix for a patch on the list?
>
> url: https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
> base: f40ddce88593482919761f74910f42f4b84c004b
> :::::: branch date: 9 hours ago
> :::::: commit date: 9 hours ago
>
> clk-lmk04832.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/clk/clk-lmk04832.c
> +++ b/drivers/clk/clk-lmk04832.c
> @@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
> if (ret) {
> dev_err(lmk->dev, "missing reg property in child: %s\n",
> child->full_name);
> + of_node_put(child);
> goto err_disable_oscin;
> }
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] clk: fix for_each_child.cocci warnings
2021-04-08 0:31 ` Stephen Boyd
@ 2021-04-08 1:50 ` Liam Beguin
-1 siblings, 0 replies; 9+ messages in thread
From: Liam Beguin @ 2021-04-08 1:50 UTC (permalink / raw)
To: Stephen Boyd, Julia Lawall, mturquette
Cc: linux-clk, linux-kernel, devicetree, robh+dt, kbuild-all
Hi Stephen,
On Wed Apr 7, 2021 at 8:31 PM EDT, Stephen Boyd wrote:
> Quoting Julia Lawall (2021-04-07 12:02:32)
> > From: kernel test robot <lkp@intel.com>
> >
> > For_each_child_of_node should have of_node_put() before goto.
> >
> > Generated by: scripts/coccinelle/iterators/for_each_child.cocci
> >
> > CC: Liam Beguin <lvb@xiphos.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> > ---
>
> Is this a fix for a patch on the list?
>
This is a fix for a patch[1] I sent yesterday.
I'll apply and resend.
Thanks,
Liam
[1] https://patchwork.kernel.org/project/linux-clk/patch/20210407005330.2890430-2-liambeguin@gmail.com/
> >
> > url: https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
> > base: f40ddce88593482919761f74910f42f4b84c004b
> > :::::: branch date: 9 hours ago
> > :::::: commit date: 9 hours ago
> >
> > clk-lmk04832.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- a/drivers/clk/clk-lmk04832.c
> > +++ b/drivers/clk/clk-lmk04832.c
> > @@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
> > if (ret) {
> > dev_err(lmk->dev, "missing reg property in child: %s\n",
> > child->full_name);
> > + of_node_put(child);
> > goto err_disable_oscin;
> > }
> >
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] clk: fix for_each_child.cocci warnings
@ 2021-04-08 1:50 ` Liam Beguin
0 siblings, 0 replies; 9+ messages in thread
From: Liam Beguin @ 2021-04-08 1:50 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]
Hi Stephen,
On Wed Apr 7, 2021 at 8:31 PM EDT, Stephen Boyd wrote:
> Quoting Julia Lawall (2021-04-07 12:02:32)
> > From: kernel test robot <lkp@intel.com>
> >
> > For_each_child_of_node should have of_node_put() before goto.
> >
> > Generated by: scripts/coccinelle/iterators/for_each_child.cocci
> >
> > CC: Liam Beguin <lvb@xiphos.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> > ---
>
> Is this a fix for a patch on the list?
>
This is a fix for a patch[1] I sent yesterday.
I'll apply and resend.
Thanks,
Liam
[1] https://patchwork.kernel.org/project/linux-clk/patch/20210407005330.2890430-2-liambeguin(a)gmail.com/
> >
> > url: https://github.com/0day-ci/linux/commits/Liam-Beguin/add-support-for-the-lmk04832/20210407-085408
> > base: f40ddce88593482919761f74910f42f4b84c004b
> > :::::: branch date: 9 hours ago
> > :::::: commit date: 9 hours ago
> >
> > clk-lmk04832.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- a/drivers/clk/clk-lmk04832.c
> > +++ b/drivers/clk/clk-lmk04832.c
> > @@ -1159,6 +1159,7 @@ static int lmk04832_probe(struct spi_dev
> > if (ret) {
> > dev_err(lmk->dev, "missing reg property in child: %s\n",
> > child->full_name);
> > + of_node_put(child);
> > goto err_disable_oscin;
> > }
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-04-08 1:50 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 9:50 [PATCH v4 1/3] clk: add support for the lmk04832 kernel test robot
2021-04-07 9:51 ` [PATCH] clk: fix for_each_child.cocci warnings kernel test robot
2021-04-07 9:51 ` [PATCH] clk: fix semicolon.cocci warnings kernel test robot
2021-04-07 19:02 [PATCH] clk: fix for_each_child.cocci warnings Julia Lawall
2021-04-07 19:02 ` Julia Lawall
2021-04-08 0:31 ` Stephen Boyd
2021-04-08 0:31 ` Stephen Boyd
2021-04-08 1:50 ` Liam Beguin
2021-04-08 1:50 ` Liam Beguin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.