* [PATCH -next] mmc: sdhci-st: Remove unnecessary error log
@ 2021-04-09 2:38 ` Laibin Qiu
0 siblings, 0 replies; 6+ messages in thread
From: Laibin Qiu @ 2021-04-09 2:38 UTC (permalink / raw)
To: adrian.hunter, patrice.chotard, ulf.hansson, yuehaibing
Cc: linux-mmc, linux-arm-kernel, linux-kernel
devm_ioremap_resource() has recorded error log, so it's
unnecessary to record log again.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
---
drivers/mmc/host/sdhci-st.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
index 78941ac3a1d6..d41582c21aa3 100644
--- a/drivers/mmc/host/sdhci-st.c
+++ b/drivers/mmc/host/sdhci-st.c
@@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"top-mmc-delay");
pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(pdata->top_ioaddr)) {
- dev_warn(&pdev->dev, "FlashSS Top Dly registers not available");
+ if (IS_ERR(pdata->top_ioaddr))
pdata->top_ioaddr = NULL;
- }
pltfm_host->clk = clk;
pdata->icnclk = icnclk;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH -next] mmc: sdhci-st: Remove unnecessary error log
@ 2021-04-09 2:38 ` Laibin Qiu
0 siblings, 0 replies; 6+ messages in thread
From: Laibin Qiu @ 2021-04-09 2:38 UTC (permalink / raw)
To: adrian.hunter, patrice.chotard, ulf.hansson, yuehaibing
Cc: linux-mmc, linux-arm-kernel, linux-kernel
devm_ioremap_resource() has recorded error log, so it's
unnecessary to record log again.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
---
drivers/mmc/host/sdhci-st.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
index 78941ac3a1d6..d41582c21aa3 100644
--- a/drivers/mmc/host/sdhci-st.c
+++ b/drivers/mmc/host/sdhci-st.c
@@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"top-mmc-delay");
pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(pdata->top_ioaddr)) {
- dev_warn(&pdev->dev, "FlashSS Top Dly registers not available");
+ if (IS_ERR(pdata->top_ioaddr))
pdata->top_ioaddr = NULL;
- }
pltfm_host->clk = clk;
pdata->icnclk = icnclk;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log
2021-04-09 2:38 ` Laibin Qiu
@ 2021-04-09 7:42 ` Patrice CHOTARD
-1 siblings, 0 replies; 6+ messages in thread
From: Patrice CHOTARD @ 2021-04-09 7:42 UTC (permalink / raw)
To: Laibin Qiu, adrian.hunter, ulf.hansson, yuehaibing
Cc: linux-mmc, linux-arm-kernel, linux-kernel
Hi Laibin
On 4/9/21 4:38 AM, Laibin Qiu wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
> ---
> drivers/mmc/host/sdhci-st.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 78941ac3a1d6..d41582c21aa3 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev)
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "top-mmc-delay");
> pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(pdata->top_ioaddr)) {
> - dev_warn(&pdev->dev, "FlashSS Top Dly registers not available");
> + if (IS_ERR(pdata->top_ioaddr))
> pdata->top_ioaddr = NULL;
> - }
>
> pltfm_host->clk = clk;
> pdata->icnclk = icnclk;
>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log
@ 2021-04-09 7:42 ` Patrice CHOTARD
0 siblings, 0 replies; 6+ messages in thread
From: Patrice CHOTARD @ 2021-04-09 7:42 UTC (permalink / raw)
To: Laibin Qiu, adrian.hunter, ulf.hansson, yuehaibing
Cc: linux-mmc, linux-arm-kernel, linux-kernel
Hi Laibin
On 4/9/21 4:38 AM, Laibin Qiu wrote:
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
> ---
> drivers/mmc/host/sdhci-st.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 78941ac3a1d6..d41582c21aa3 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev)
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "top-mmc-delay");
> pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(pdata->top_ioaddr)) {
> - dev_warn(&pdev->dev, "FlashSS Top Dly registers not available");
> + if (IS_ERR(pdata->top_ioaddr))
> pdata->top_ioaddr = NULL;
> - }
>
> pltfm_host->clk = clk;
> pdata->icnclk = icnclk;
>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log
2021-04-09 2:38 ` Laibin Qiu
@ 2021-04-12 7:52 ` Ulf Hansson
-1 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2021-04-12 7:52 UTC (permalink / raw)
To: Laibin Qiu
Cc: Adrian Hunter, patrice.chotard, YueHaibing, linux-mmc, Linux ARM,
Linux Kernel Mailing List
On Fri, 9 Apr 2021 at 04:28, Laibin Qiu <qiulaibin@huawei.com> wrote:
>
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-st.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 78941ac3a1d6..d41582c21aa3 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev)
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "top-mmc-delay");
> pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(pdata->top_ioaddr)) {
> - dev_warn(&pdev->dev, "FlashSS Top Dly registers not available");
> + if (IS_ERR(pdata->top_ioaddr))
> pdata->top_ioaddr = NULL;
> - }
>
> pltfm_host->clk = clk;
> pdata->icnclk = icnclk;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log
@ 2021-04-12 7:52 ` Ulf Hansson
0 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2021-04-12 7:52 UTC (permalink / raw)
To: Laibin Qiu
Cc: Adrian Hunter, patrice.chotard, YueHaibing, linux-mmc, Linux ARM,
Linux Kernel Mailing List
On Fri, 9 Apr 2021 at 04:28, Laibin Qiu <qiulaibin@huawei.com> wrote:
>
> devm_ioremap_resource() has recorded error log, so it's
> unnecessary to record log again.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Laibin Qiu <qiulaibin@huawei.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-st.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c
> index 78941ac3a1d6..d41582c21aa3 100644
> --- a/drivers/mmc/host/sdhci-st.c
> +++ b/drivers/mmc/host/sdhci-st.c
> @@ -400,10 +400,8 @@ static int sdhci_st_probe(struct platform_device *pdev)
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "top-mmc-delay");
> pdata->top_ioaddr = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(pdata->top_ioaddr)) {
> - dev_warn(&pdev->dev, "FlashSS Top Dly registers not available");
> + if (IS_ERR(pdata->top_ioaddr))
> pdata->top_ioaddr = NULL;
> - }
>
> pltfm_host->clk = clk;
> pdata->icnclk = icnclk;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-12 7:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 2:38 [PATCH -next] mmc: sdhci-st: Remove unnecessary error log Laibin Qiu
2021-04-09 2:38 ` Laibin Qiu
2021-04-09 7:42 ` Patrice CHOTARD
2021-04-09 7:42 ` Patrice CHOTARD
2021-04-12 7:52 ` Ulf Hansson
2021-04-12 7:52 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.