Re: [PATCH 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Oleg Nesterov <oleg@redhat.com>
To: He Zhe <zhe.he@windriver.com>
Cc: catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org, paul@paul-moore.com,
	eparis@redhat.com, linux-audit@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat
Date: Fri, 16 Apr 2021 11:43:25 +0200	[thread overview]
Message-ID: <20210416094324.GA1962@redhat.com> (raw)
In-Reply-To: <20210416075533.7720-2-zhe.he@windriver.com>

On 04/16, He Zhe wrote:
>
> --- a/arch/arm64/include/asm/syscall.h
> +++ b/arch/arm64/include/asm/syscall.h
> @@ -44,7 +44,12 @@ static inline long syscall_get_error(struct task_struct *task,
>  static inline long syscall_get_return_value(struct task_struct *task,
>  					    struct pt_regs *regs)
>  {
> -	return regs->regs[0];
> +	long val = regs->regs[0];
> +
> +	if (is_compat_thread(task_thread_info(task)))
> +		val = sign_extend64(val, 31);
> +
> +	return val;
>  }

I can't really review these arm-specific patches, but with this change both
syscall_get_error() and is_syscall_success() can use syscall_get_return_value()
to avoid the code duplication.

Oleg.

WARNING: multiple messages have this Message-ID (diff)

From: Oleg Nesterov <oleg@redhat.com>
To: He Zhe <zhe.he@windriver.com>
Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
	linux-audit@redhat.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat
Date: Fri, 16 Apr 2021 11:43:25 +0200	[thread overview]
Message-ID: <20210416094324.GA1962@redhat.com> (raw)
In-Reply-To: <20210416075533.7720-2-zhe.he@windriver.com>

On 04/16, He Zhe wrote:
>
> --- a/arch/arm64/include/asm/syscall.h
> +++ b/arch/arm64/include/asm/syscall.h
> @@ -44,7 +44,12 @@ static inline long syscall_get_error(struct task_struct *task,
>  static inline long syscall_get_return_value(struct task_struct *task,
>  					    struct pt_regs *regs)
>  {
> -	return regs->regs[0];
> +	long val = regs->regs[0];
> +
> +	if (is_compat_thread(task_thread_info(task)))
> +		val = sign_extend64(val, 31);
> +
> +	return val;
>  }

I can't really review these arm-specific patches, but with this change both
syscall_get_error() and is_syscall_success() can use syscall_get_return_value()
to avoid the code duplication.

Oleg.

--
Linux-audit mailing list
Linux-audit@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-audit

WARNING: multiple messages have this Message-ID (diff)

From: Oleg Nesterov <oleg@redhat.com>
To: He Zhe <zhe.he@windriver.com>
Cc: catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org, paul@paul-moore.com,
	eparis@redhat.com, linux-audit@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat
Date: Fri, 16 Apr 2021 11:43:25 +0200	[thread overview]
Message-ID: <20210416094324.GA1962@redhat.com> (raw)
In-Reply-To: <20210416075533.7720-2-zhe.he@windriver.com>

On 04/16, He Zhe wrote:
>
> --- a/arch/arm64/include/asm/syscall.h
> +++ b/arch/arm64/include/asm/syscall.h
> @@ -44,7 +44,12 @@ static inline long syscall_get_error(struct task_struct *task,
>  static inline long syscall_get_return_value(struct task_struct *task,
>  					    struct pt_regs *regs)
>  {
> -	return regs->regs[0];
> +	long val = regs->regs[0];
> +
> +	if (is_compat_thread(task_thread_info(task)))
> +		val = sign_extend64(val, 31);
> +
> +	return val;
>  }

I can't really review these arm-specific patches, but with this change both
syscall_get_error() and is_syscall_success() can use syscall_get_return_value()
to avoid the code duplication.

Oleg.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2021-04-16  9:43 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16  7:55 [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat He Zhe
2021-04-16  7:55 ` He Zhe
2021-04-16  7:55 ` He Zhe
2021-04-16  7:55 ` [PATCH 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat He Zhe
2021-04-16  7:55   ` He Zhe
2021-04-16  7:55   ` He Zhe
2021-04-16  9:43   ` Oleg Nesterov [this message]
2021-04-16  9:43     ` Oleg Nesterov
2021-04-16  9:43     ` Oleg Nesterov
2021-04-20  8:38     ` He Zhe
2021-04-20  8:38       ` He Zhe
2021-04-20  8:38       ` He Zhe
2021-04-21 17:41   ` Mark Rutland
2021-04-21 17:41     ` Mark Rutland
2021-04-21 17:41     ` Mark Rutland
2021-04-22 16:55     ` Mark Rutland
2021-04-22 16:55       ` Mark Rutland
2021-04-22 16:55       ` Mark Rutland
2021-04-16  7:55 ` [PATCH 3/3] audit: Use syscall_get_return_value to get syscall return code in audit_syscall_exit He Zhe
2021-04-16  7:55   ` He Zhe
2021-04-16  7:55   ` He Zhe
2021-04-16 12:33 ` [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat Catalin Marinas
2021-04-16 12:33   ` Catalin Marinas
2021-04-16 12:33   ` Catalin Marinas
2021-04-16 13:34   ` Mark Rutland
2021-04-16 13:34     ` Mark Rutland
2021-04-16 13:34     ` Mark Rutland
2021-04-17 13:19     ` David Laight
2021-04-17 13:19       ` David Laight
2021-04-17 13:19       ` David Laight
2021-04-19 12:19     ` Will Deacon
2021-04-19 12:19       ` Will Deacon
2021-04-19 12:19       ` Will Deacon
2021-04-20  8:54       ` He Zhe
2021-04-20  8:54         ` He Zhe
2021-04-20  8:54         ` He Zhe
2021-04-21 17:10       ` Mark Rutland
2021-04-21 17:10         ` Mark Rutland
2021-04-21 17:10         ` Mark Rutland
2021-04-22 16:07         ` Will Deacon
2021-04-22 16:07           ` Will Deacon
2021-04-22 16:07           ` Will Deacon
2021-04-22 16:42           ` Mark Rutland
2021-04-22 16:42             ` Mark Rutland
2021-04-22 16:42             ` Mark Rutland
2021-04-22 18:57             ` Dmitry V. Levin
2021-04-22 18:57               ` Dmitry V. Levin
2021-04-22 18:57               ` Dmitry V. Levin
2021-04-20  8:42   ` He Zhe
2021-04-20  8:42     ` He Zhe
2021-04-20  8:42     ` He Zhe
2021-04-21 17:17     ` Mark Rutland
2021-04-21 17:17       ` Mark Rutland
2021-04-21 17:17       ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210416094324.GA1962@redhat.com \
    --to=oleg@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=eparis@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=will@kernel.org \
    --cc=zhe.he@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.