* [PATCH] fs/reiserfs/journal.c: delete useless variables
@ 2021-04-13 1:43 Tian Tao
2021-04-21 14:31 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2021-04-13 1:43 UTC (permalink / raw)
To: jack, rdunlap; +Cc: reiserfs-devel, Tian Tao
The value of 'cn' is not used, so just delete it.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
fs/reiserfs/journal.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
index e98f993..9edc8e2 100644
--- a/fs/reiserfs/journal.c
+++ b/fs/reiserfs/journal.c
@@ -461,7 +461,6 @@ int reiserfs_in_journal(struct super_block *sb,
b_blocknr_t * next_zero_bit)
{
struct reiserfs_journal *journal = SB_JOURNAL(sb);
- struct reiserfs_journal_cnode *cn;
struct reiserfs_list_bitmap *jb;
int i;
unsigned long bl;
@@ -497,13 +496,12 @@ int reiserfs_in_journal(struct super_block *sb,
bl = bmap_nr * (sb->s_blocksize << 3) + bit_nr;
/* is it in any old transactions? */
if (search_all
- && (cn =
- get_journal_hash_dev(sb, journal->j_list_hash_table, bl))) {
+ && (get_journal_hash_dev(sb, journal->j_list_hash_table, bl))) {
return 1;
}
/* is it in the current transaction. This should never happen */
- if ((cn = get_journal_hash_dev(sb, journal->j_hash_table, bl))) {
+ if ((get_journal_hash_dev(sb, journal->j_hash_table, bl))) {
BUG();
return 1;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/reiserfs/journal.c: delete useless variables
2021-04-13 1:43 [PATCH] fs/reiserfs/journal.c: delete useless variables Tian Tao
@ 2021-04-21 14:31 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2021-04-21 14:31 UTC (permalink / raw)
To: Tian Tao; +Cc: jack, rdunlap, reiserfs-devel
On Tue 13-04-21 09:43:16, Tian Tao wrote:
> The value of 'cn' is not used, so just delete it.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Thanks. I've added the patch to my tree.
Honza
> ---
> fs/reiserfs/journal.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index e98f993..9edc8e2 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -461,7 +461,6 @@ int reiserfs_in_journal(struct super_block *sb,
> b_blocknr_t * next_zero_bit)
> {
> struct reiserfs_journal *journal = SB_JOURNAL(sb);
> - struct reiserfs_journal_cnode *cn;
> struct reiserfs_list_bitmap *jb;
> int i;
> unsigned long bl;
> @@ -497,13 +496,12 @@ int reiserfs_in_journal(struct super_block *sb,
> bl = bmap_nr * (sb->s_blocksize << 3) + bit_nr;
> /* is it in any old transactions? */
> if (search_all
> - && (cn =
> - get_journal_hash_dev(sb, journal->j_list_hash_table, bl))) {
> + && (get_journal_hash_dev(sb, journal->j_list_hash_table, bl))) {
> return 1;
> }
>
> /* is it in the current transaction. This should never happen */
> - if ((cn = get_journal_hash_dev(sb, journal->j_hash_table, bl))) {
> + if ((get_journal_hash_dev(sb, journal->j_hash_table, bl))) {
> BUG();
> return 1;
> }
> --
> 2.7.4
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-21 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 1:43 [PATCH] fs/reiserfs/journal.c: delete useless variables Tian Tao
2021-04-21 14:31 ` Jan Kara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.