[PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header

[PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header

[Philippe Mathieu-Daudé]

include/exec/gen-icount.h is listed as unmaintained.
Add it to Main Loop (or should it be TCG? softmmu/icount.c
is already there).

Add the missing "exec/exec-all.h" header.

Philippe Mathieu-Daudé (2):
  MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section
  exec/gen-icount.h: Add missing "exec/exec-all.h" include

 include/exec/gen-icount.h | 1 +
 MAINTAINERS               | 1 +
 2 files changed, 2 insertions(+)

-- 
2.26.3

[PATCH 1/2] MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section

[Philippe Mathieu-Daudé]

As the 'Main Loop' section covers softmmu/icount.c,
add "exec/gen-icount.h" there too.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 36055f14c59..b91419ef08d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2445,6 +2445,7 @@ F: ui/cocoa.m
 Main loop
 M: Paolo Bonzini <pbonzini@redhat.com>
 S: Maintained
+F: include/exec/gen-icount.h
 F: include/qemu/main-loop.h
 F: include/sysemu/runstate.h
 F: include/sysemu/runstate-action.h
-- 
2.26.3

[PATCH 2/2] exec/gen-icount.h: Add missing "exec/exec-all.h" include

[Philippe Mathieu-Daudé]

When including "exec/gen-icount.h" we get:

  include/exec/gen-icount.h: In function ‘gen_tb_start’:
  include/exec/gen-icount.h:40:9: error: implicit declaration of function ‘tb_cflags’ [-Werror=implicit-function-declaration]
     40 |     if (tb_cflags(tb) & CF_USE_ICOUNT) {
        |         ^~~~~~~~~
  include/exec/gen-icount.h:40:9: error: nested extern declaration of ‘tb_cflags’ [-Werror=nested-externs]
  include/exec/gen-icount.h:40:25: error: ‘CF_USE_ICOUNT’ undeclared (first use in this function); did you mean ‘CPU_COUNT’?
     40 |     if (tb_cflags(tb) & CF_USE_ICOUNT) {
        |                         ^~~~~~~~~~~~~
        |                         CPU_COUNT

Since tb_cflags() is declared in "exec/exec-all.h", include this
header in "exec/gen-icount.h".

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 include/exec/gen-icount.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/exec/gen-icount.h b/include/exec/gen-icount.h
index 298e01eef49..467529d84c5 100644
--- a/include/exec/gen-icount.h
+++ b/include/exec/gen-icount.h
@@ -1,6 +1,7 @@
 #ifndef GEN_ICOUNT_H
 #define GEN_ICOUNT_H
 
+#include "exec/exec-all.h"
 #include "qemu/timer.h"
 
 /* Helpers for instruction counting code generation.  */
-- 
2.26.3

Re: [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header

[Philippe Mathieu-Daudé]

ping?

On 4/22/21 8:41 AM, Philippe Mathieu-Daudé wrote:
> include/exec/gen-icount.h is listed as unmaintained.
> Add it to Main Loop (or should it be TCG? softmmu/icount.c
> is already there).
> 
> Add the missing "exec/exec-all.h" header.
> 
> Philippe Mathieu-Daudé (2):
>   MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section
>   exec/gen-icount.h: Add missing "exec/exec-all.h" include
> 
>  include/exec/gen-icount.h | 1 +
>  MAINTAINERS               | 1 +
>  2 files changed, 2 insertions(+)
> 

Re: [PATCH 0/2] exec: Cover gen-icount.h in MAINTAINERS, add missing exec-all.h header

[Richard Henderson]

On 4/21/21 11:41 PM, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (2):
>    MAINTAINERS: Add include/exec/gen-icount.h to 'Main Loop' section
>    exec/gen-icount.h: Add missing "exec/exec-all.h" include

Queued, thanks.

r~